gemiterm 2.0.0 → 2.1.0

package/tests/services/profile-auth-manager.test.ts

@@ -1,334 +0,0 @@
-import { describe, test, expect, beforeEach, afterEach, mock } from "bun:test";
-import { mkdirSync, rmSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { ProfileAuthManager } from "../../src/services/profile-auth-manager.ts";
-import { ProfileManager, CookieStorage } from "../../src/infrastructure/storage.ts";
-import { CookieStorageService } from "../../src/services/cookie-storage-service.ts";
-import { Logger } from "../../src/infrastructure/logger.ts";
-import type { Cookie } from "../../src/core/types.ts";
-import type { ProfileManager as ProfileManagerType } from "../../src/infrastructure/storage.ts";
-import type { IGeminiClientService } from "../../src/core/command-handlers.ts";
-
-/*
-The 8 tests in `describe('findProfileForConversation')` previously asserted the BUGGY
-'first active profile' behavior; they have been updated to assert the CORRECT
-per-profile-lookup behavior. See `openspec/changes/command-spec-conformance/proposal.md`
-for context.
-*/
-
-const TEST_DIR = join(tmpdir(), "gemiterm-test-profile-auth-manager");
-
-const logger = new Logger("test");
-
-function makeValidCookies(): Cookie[] {
-  const farFuture = Math.floor(Date.now() / 1000) + 365 * 24 * 60 * 60;
-  return [
-    {
-      name: "__Secure-1PSID",
-      value: "test-psid-value",
-      domain: ".google.com",
-      path: "/",
-      expires: farFuture,
-      httpOnly: true,
-      secure: true,
-      sameSite: "Lax",
-    },
-    {
-      name: "__Secure-1PSIDTS",
-      value: "test-psidts-value",
-      domain: ".google.com",
-      path: "/",
-      expires: farFuture,
-      httpOnly: true,
-      secure: true,
-      sameSite: "Lax",
-    },
-  ];
-}
-
-function makeExpiredCookies(): Cookie[] {
-  const past = Math.floor(Date.now() / 1000) - 30 * 24 * 60 * 60;
-  return [
-    {
-      name: "__Secure-1PSID",
-      value: "expired-psid-value",
-      domain: ".google.com",
-      path: "/",
-      expires: past,
-      httpOnly: true,
-      secure: true,
-      sameSite: "Lax",
-    },
-    {
-      name: "__Secure-1PSIDTS",
-      value: "expired-psidts-value",
-      domain: ".google.com",
-      path: "/",
-      expires: past,
-      httpOnly: true,
-      secure: true,
-      sameSite: "Lax",
-    },
-  ];
-}
-
-function createManager(
-  profileManager: ProfileManagerType,
-  geminiClient?: IGeminiClientService,
-): ProfileAuthManager {
-  const cookieStorage = new CookieStorageService({
-    cookieStorage: new CookieStorage(),
-    logger,
-  });
-  return new ProfileAuthManager({
-    profileManager,
-    cookieStorageService: cookieStorage,
-    logger,
-    geminiClient: geminiClient ?? {
-      async deleteChat() { return; },
-      async sendMessage() { return ""; },
-      async startNewChat() { return { response: "", conversationId: "" }; },
-      async profileHasConversation() { return false; },
-      forProfile() { return this as unknown as IGeminiClientService; },
-    },
-  });
-}
-
-beforeEach(() => {
-  process.env.GEMITERM_CONFIG_DIR = TEST_DIR;
-  mkdirSync(TEST_DIR, { recursive: true });
-});
-
-afterEach(() => {
-  rmSync(TEST_DIR, { recursive: true, force: true });
-  delete process.env.GEMITERM_CONFIG_DIR;
-});
-
-describe("ProfileAuthManager", () => {
-  describe("ensureAuthenticated", () => {
-    test("returns cookies for a profile with valid session", () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("default");
-      storage.save("default", makeValidCookies());
-
-      const mgr = createManager(manager);
-      const cookies = mgr.ensureAuthenticated("default");
-
-      expect(cookies.secure_1psid).toBe("test-psid-value");
-      expect(cookies.secure_1psidts).toBe("test-psidts-value");
-    });
-
-    test("throws AuthenticationError when no valid cookies", () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("default");
-
-      const mgr = createManager(manager);
-
-      expect(() => mgr.ensureAuthenticated("default")).toThrow("No valid session");
-    });
-
-    test("throws AuthenticationError with expired cookies", () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("default");
-      storage.save("default", makeExpiredCookies());
-
-      const mgr = createManager(manager);
-
-      expect(() => mgr.ensureAuthenticated("default")).toThrow("No valid session");
-    });
-
-    test("throws on invalid profile name", () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      const mgr = createManager(manager);
-
-      expect(() => mgr.ensureAuthenticated("bad name!")).toThrow("invalid characters");
-    });
-
-    test("uses default profile when none specified", () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("default");
-      storage.save("default", makeValidCookies());
-
-      const markerDir = join(TEST_DIR, "config");
-      mkdirSync(markerDir, { recursive: true });
-      writeFileSync(join(markerDir, "default-profile"), "default", "utf-8");
-
-      const mgr = createManager(manager);
-      const cookies = mgr.ensureAuthenticated();
-
-      expect(cookies.secure_1psid).toBe("test-psid-value");
-    });
-  });
-
-  describe("getActiveProfiles", () => {
-    test("returns profiles with valid cookies", () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("active");
-      manager.create("expired");
-      storage.save("active", makeValidCookies());
-      storage.save("expired", makeExpiredCookies());
-
-      const mgr = createManager(manager);
-      const active = mgr.getActiveProfiles();
-
-      expect(active).toContain("active");
-      expect(active).not.toContain("expired");
-    });
-
-    test("returns empty array when no profiles have valid cookies", () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("p1");
-      storage.save("p1", makeExpiredCookies());
-
-      const mgr = createManager(manager);
-      const active = mgr.getActiveProfiles();
-
-      expect(active).toEqual([]);
-    });
-
-    test("returns empty array when no profiles exist", () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      const mgr = createManager(manager);
-      const active = mgr.getActiveProfiles();
-
-      expect(active).toEqual([]);
-    });
-  });
-
-  describe("findProfileForConversation", () => {
-    test("returns the profile that owns the conversation", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("work");
-      manager.create("personal");
-      storage.save("work", makeValidCookies());
-      storage.save("personal", makeValidCookies());
-
-      const mockGeminiClient = {
-        async deleteChat() { return; },
-        async sendMessage() { return ""; },
-        async startNewChat() { return { response: "", conversationId: "" }; },
-        async profileHasConversation(profileName: string) {
-          return profileName === "work";
-        },
-        forProfile() { return this as unknown as IGeminiClientService; },
-      };
-
-      const mgr = createManager(manager, mockGeminiClient as unknown as IGeminiClientService);
-      const result = await mgr.findProfileForConversation("conv-123");
-
-      expect(result).toBe("work");
-    });
-
-    test("returns null when no profile owns the conversation", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("p1");
-      storage.save("p1", makeExpiredCookies());
-
-      const mockGeminiClient = {
-        async deleteChat() { return; },
-        async sendMessage() { return ""; },
-        async startNewChat() { return { response: "", conversationId: "" }; },
-        async profileHasConversation() { return false; },
-        forProfile() { return this as unknown as IGeminiClientService; },
-      };
-
-      const mgr = createManager(manager, mockGeminiClient as unknown as IGeminiClientService);
-      const result = await mgr.findProfileForConversation("conv-456");
-
-      expect(result).toBeNull();
-    });
-
-    test("returns null when no profiles exist", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      const mgr = createManager(manager);
-
-      const result = await mgr.findProfileForConversation("conv-789");
-
-      expect(result).toBeNull();
-    });
-
-    test("returns null when conversation is not in any profile", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("work");
-      manager.create("personal");
-      storage.save("work", makeValidCookies());
-      storage.save("personal", makeValidCookies());
-
-      const mockGeminiClient = {
-        async deleteChat() { return; },
-        async sendMessage() { return ""; },
-        async startNewChat() { return { response: "", conversationId: "" }; },
-        async profileHasConversation() { return false; },
-        forProfile() { return this as unknown as IGeminiClientService; },
-      };
-
-      const mgr = createManager(manager, mockGeminiClient as unknown as IGeminiClientService);
-      const result = await mgr.findProfileForConversation("conv-999");
-
-      expect(result).toBeNull();
-    });
-
-    test("returns first profile in list order when multiple profiles report ownership", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("profile1");
-      manager.create("profile2");
-      manager.create("profile3");
-      storage.save("profile1", makeValidCookies());
-      storage.save("profile2", makeValidCookies());
-      storage.save("profile3", makeValidCookies());
-
-      const mockGeminiClient = {
-        async deleteChat() { return; },
-        async sendMessage() { return ""; },
-        async startNewChat() { return { response: "", conversationId: "" }; },
-        async profileHasConversation(profileName: string) {
-          return profileName === "profile1" || profileName === "profile3";
-        },
-        forProfile() { return this as unknown as IGeminiClientService; },
-      };
-
-      const mgr = createManager(manager, mockGeminiClient as unknown as IGeminiClientService);
-      const result = await mgr.findProfileForConversation("conv-shared");
-
-      expect(result).toBe("profile1");
-    });
-
-    test("passes the conversationId argument to the lookup helper", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("work");
-      storage.save("work", makeValidCookies());
-
-      const calls: Array<[string, string]> = [];
-      const mockGeminiClient = {
-        async deleteChat() { return; },
-        async sendMessage() { return ""; },
-        async startNewChat() { return { response: "", conversationId: "" }; },
-        async profileHasConversation(profileName: string, conversationId: string) {
-          calls.push([profileName, conversationId]);
-          return false;
-        },
-        forProfile() { return this as unknown as IGeminiClientService; },
-      };
-
-      const mgr = createManager(manager, mockGeminiClient as unknown as IGeminiClientService);
-      await mgr.findProfileForConversation("abc-123");
-
-      expect(calls).toContainEqual(["work", "abc-123"]);
-    });
-  });
-});

package/tests/services/profile-service.test.ts

@@ -1,224 +0,0 @@
-import { describe, test, expect, beforeEach, afterEach } from "bun:test";
-import { mkdirSync, rmSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { ProfileService } from "../../src/services/profile-service.ts";
-import { ProfileManager, CookieStorage } from "../../src/infrastructure/storage.ts";
-import { Logger } from "../../src/infrastructure/logger.ts";
-import type { Cookie } from "../../src/core/types.ts";
-
-const TEST_DIR = join(tmpdir(), "gemiterm-test-profile-service");
-
-const logger = new Logger("test");
-
-beforeEach(() => {
-  process.env.GEMITERM_CONFIG_DIR = TEST_DIR;
-  mkdirSync(TEST_DIR, { recursive: true });
-});
-
-afterEach(() => {
-  rmSync(TEST_DIR, { recursive: true, force: true });
-  delete process.env.GEMITERM_CONFIG_DIR;
-});
-
-function makeValidCookies(): Cookie[] {
-  const farFuture = Math.floor(Date.now() / 1000) + 365 * 24 * 60 * 60;
-  return [
-    {
-      name: "__Secure-1PSID",
-      value: "test-psid-value",
-      domain: ".google.com",
-      path: "/",
-      expires: farFuture,
-      httpOnly: true,
-      secure: true,
-      sameSite: "Lax",
-    },
-    {
-      name: "__Secure-1PSIDTS",
-      value: "test-psidts-value",
-      domain: ".google.com",
-      path: "/",
-      expires: farFuture,
-      httpOnly: true,
-      secure: true,
-      sameSite: "Lax",
-    },
-  ];
-}
-
-function setupAuthenticatedProfile(profileName = "default"): ProfileService {
-  const storage = new CookieStorage();
-  const manager = new ProfileManager(storage);
-  storage.save(profileName, makeValidCookies());
-
-  const markerDir = join(TEST_DIR, "config");
-  mkdirSync(markerDir, { recursive: true });
-  writeFileSync(join(markerDir, "default-profile"), profileName, "utf-8");
-
-  return new ProfileService(manager, logger);
-}
-
-describe("ProfileService", () => {
-  describe("authenticate", () => {
-    test("authenticates with valid cookies", async () => {
-      const svc = setupAuthenticatedProfile();
-      const result = await svc.authenticate();
-
-      expect(result.cookies).toHaveLength(2);
-      expect(result.cookies[0].name).toBe("__Secure-1PSID");
-      expect(result.cookies[0].value).toBe("test-psid-value");
-      expect(result.expiresAt).not.toBeNull();
-    });
-
-    test("throws AuthenticationError when no valid cookies exist", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      const svc = new ProfileService(manager, logger);
-
-      await expect(svc.authenticate("default")).rejects.toThrow("No valid session");
-    });
-
-    test("creates profile if it does not exist and authenticates", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      storage.save("default", makeValidCookies());
-
-      const markerDir = join(TEST_DIR, "config");
-      mkdirSync(markerDir, { recursive: true });
-      writeFileSync(join(markerDir, "default-profile"), "default", "utf-8");
-
-      const svc = new ProfileService(manager, logger);
-      const result = await svc.authenticate("default");
-
-      expect(result.cookies).toHaveLength(2);
-      expect(result.cookies[0].name).toBe("__Secure-1PSID");
-    });
-
-    test("throws on invalid profile name", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      const svc = new ProfileService(manager, logger);
-
-      await expect(svc.authenticate("bad name!")).rejects.toThrow("invalid characters");
-    });
-  });
-
-  describe("getProfileStatuses", () => {
-    test("returns statuses for all profiles", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      storage.save("active", makeValidCookies());
-
-      const svc = new ProfileService(manager, logger);
-      const statuses = await svc.getProfileStatuses();
-
-      expect(statuses.length).toBeGreaterThan(0);
-      const active = statuses.find((s) => s.name === "active");
-      expect(active).toBeDefined();
-      expect(active!.isActive).toBe(true);
-    });
-
-    test("returns empty array when no profiles exist", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      const svc = new ProfileService(manager, logger);
-
-      const statuses = await svc.getProfileStatuses();
-      expect(statuses).toEqual([]);
-    });
-  });
-
-  describe("getAuthStatus", () => {
-    test("returns authenticated when default profile has valid cookies", async () => {
-      const svc = setupAuthenticatedProfile();
-      const status = await svc.getAuthStatus();
-
-      expect(status.authenticated).toBe(true);
-      expect(status.profileName).toBe("default");
-    });
-
-    test("returns not authenticated when default has no cookies", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      const svc = new ProfileService(manager, logger);
-
-      const status = await svc.getAuthStatus();
-      expect(status.authenticated).toBe(false);
-    });
-  });
-
-  describe("deleteProfile", () => {
-    test("deletes an existing profile", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("to-delete");
-      storage.save("to-delete", makeValidCookies());
-
-      const svc = new ProfileService(manager, logger);
-      await svc.deleteProfile("to-delete");
-
-      expect(manager.list()).not.toContain("to-delete");
-    });
-
-    test("throws on non-existent profile", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      const svc = new ProfileService(manager, logger);
-
-      await expect(svc.deleteProfile("ghost")).rejects.toThrow("does not exist");
-    });
-
-    test("throws on invalid profile name", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      const svc = new ProfileService(manager, logger);
-
-      await expect(svc.deleteProfile("bad name!")).rejects.toThrow("invalid characters");
-    });
-  });
-
-  describe("renameProfile", () => {
-    test("renames an existing profile", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("old-name");
-
-      const svc = new ProfileService(manager, logger);
-      await svc.renameProfile("old-name", "new-name");
-
-      expect(manager.list()).toContain("new-name");
-      expect(manager.list()).not.toContain("old-name");
-    });
-
-    test("throws on invalid names", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      const svc = new ProfileService(manager, logger);
-
-      await expect(svc.renameProfile("old", "new!")).rejects.toThrow("invalid characters");
-    });
-  });
-
-  describe("setDefaultProfile", () => {
-    test("sets the default profile", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      manager.create("p1");
-      manager.create("p2");
-
-      const svc = new ProfileService(manager, logger);
-      await svc.setDefaultProfile("p2");
-
-      expect(manager.getDefault()).toBe("p2");
-    });
-
-    test("throws on invalid profile name", async () => {
-      const storage = new CookieStorage();
-      const manager = new ProfileManager(storage);
-      const svc = new ProfileService(manager, logger);
-
-      await expect(svc.setDefaultProfile("bad!")).rejects.toThrow("invalid characters");
-    });
-  });
-});

package/tests/setup.ts

@@ -1,95 +0,0 @@
-import { mkdirSync, rmSync, writeFileSync, mkdir } from "node:fs";
-import { resolve, join } from "node:path";
-import { tmpdir } from "node:os";
-import { promisify } from "node:util";
-
-const mkdirAsync = promisify(mkdir);
-
-let testConfigDir: string | null = null;
-
-export function createTestConfigDir(prefix = "gemiterm-test"): string {
-  testConfigDir = resolve(
-    join(tmpdir(), `${prefix}-${Date.now()}-${Math.random().toString(36).slice(2)}`),
-  );
-  mkdirSync(testConfigDir, { recursive: true });
-  return testConfigDir;
-}
-
-export async function createTestConfigDirAsync(prefix = "gemiterm-test"): Promise<string> {
-  testConfigDir = resolve(
-    join(tmpdir(), `${prefix}-${Date.now()}-${Math.random().toString(36).slice(2)}`),
-  );
-  await mkdirAsync(testConfigDir, { recursive: true });
-  return testConfigDir;
-}
-
-export function cleanupTestConfigDir(): void {
-  if (testConfigDir) {
-    try {
-      rmSync(testConfigDir, { recursive: true, force: true });
-    } catch {
-      // temp dir cleanup is best-effort
-    }
-    testConfigDir = null;
-  }
-}
-
-export function getTestConfigDir(): string {
-  if (!testConfigDir) {
-    throw new Error("Test config dir not initialized. Call createTestConfigDir() first.");
-  }
-  return testConfigDir;
-}
-
-export function setupTestConfig(prefix?: string): string {
-  const dir = createTestConfigDir(prefix);
-  process.env.GEMITERM_CONFIG_DIR = dir;
-  return dir;
-}
-
-export function teardownTestConfig(originalEnv?: Record<string, string | undefined>): void {
-  cleanupTestConfigDir();
-  if (originalEnv) {
-    if (originalEnv.GEMITERM_CONFIG_DIR !== undefined) {
-      process.env.GEMITERM_CONFIG_DIR = originalEnv.GEMITERM_CONFIG_DIR;
-    } else {
-      delete process.env.GEMITERM_CONFIG_DIR;
-    }
-  } else {
-    delete process.env.GEMITERM_CONFIG_DIR;
-  }
-}
-
-export function createMockStorageStateFile(
-  profileName: string,
-  cookies: Array<{
-    name: string;
-    value: string;
-    domain?: string;
-    path?: string;
-    expires?: number;
-    httpOnly?: boolean;
-    secure?: boolean;
-    sameSite?: string;
-  }>,
-  configDir?: string,
-): string {
-  const dir = configDir || getTestConfigDir();
-  const profileDir = join(dir, "profiles", profileName);
-  mkdirSync(profileDir, { recursive: true });
-  const content = JSON.stringify({
-    cookies: cookies.map((c) => ({
-      name: c.name,
-      value: c.value,
-      domain: c.domain ?? ".google.com",
-      path: c.path ?? "/",
-      expires: c.expires ?? -1,
-      httpOnly: c.httpOnly ?? true,
-      secure: c.secure ?? true,
-      sameSite: c.sameSite ?? "None",
-    })),
-  });
-  const filePath = join(profileDir, "storage_state.json");
-  writeFileSync(filePath, content, "utf-8");
-  return filePath;
-}

package/tests/smoke/smoke.test.ts

@@ -1,52 +0,0 @@
-import { describe, test, expect, afterAll } from "bun:test";
-import { spawn, Subprocess } from "bun";
-import { resolve } from "node:path";
-
-const CLI_ENTRY = resolve(import.meta.dir, "..", "..", "src", "cli", "index.ts");
-
-interface SpawnResult {
-  exitCode: number;
-  stdout: string;
-  stderr: string;
-}
-
-async function runCli(args: string[]): Promise<SpawnResult> {
-  const proc: Subprocess = spawn({
-    cmd: ["bun", CLI_ENTRY, ...args],
-    stdout: "pipe",
-    stderr: "pipe",
-    env: { ...process.env, GEMITERM_CONFIG_DIR: "" },
-  });
-
-  const [stdout, stderr, exitCode] = await Promise.all([
-    new Response(proc.stdout).text(),
-    new Response(proc.stderr).text(),
-    proc.exited,
-  ]);
-
-  return { exitCode: exitCode ?? -1, stdout, stderr };
-}
-
-describe("Smoke Tests", () => {
-  test("--help displays usage information and exits 0", async () => {
-    const result = await runCli(["--help"]);
-
-    expect(result.exitCode).toBe(0);
-    expect(result.stdout.length).toBeGreaterThan(0);
-    expect(result.stdout.toLowerCase()).toContain("gemiterm");
-  });
-
-  test("--version prints version string and exits 0", async () => {
-    const result = await runCli(["--version"]);
-
-    expect(result.exitCode).toBe(0);
-    expect(result.stdout).toContain("gemiterm v");
-  });
-
-  test("status runs without crashing", async () => {
-    const result = await runCli(["status"]);
-
-    expect(result.exitCode).toBeGreaterThanOrEqual(0);
-    expect(result.stdout.length).toBeGreaterThan(0);
-  });
-});