gemcap-be-common 1.4.4 → 1.4.6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (6) hide show
  1. package/package.json +1 -1
  2. package/services/loan-transactions.service.d.ts +1 -1
  3. package/services/signs.service.d.ts +0 -3
  4. package/services/signs.service.js +0 -21
  5. package/services/signs.service.ts +0 -24
  6. package/tsconfig.tsbuildinfo +1 -1
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "gemcap-be-common",
3
- "version": "1.4.4",
3
+ "version": "1.4.6",
4
4
  "description": "",
5
5
  "main": "index.js",
6
6
  "scripts": {
package/services/loan-transactions.service.d.ts CHANGED
@@ -155,7 +155,7 @@ export declare class LoanTransactionsService {
155
155
  getTransactionReport(transactionIds: string[], borrowerId: string, effectiveDate: Date): Promise<{
156
156
  transactionIdsToMark: any[];
157
157
  transactions: {
158
- [x: string]: (string | number | string[] | Date)[];
158
+ [x: string]: (string | number | Date | string[])[];
159
159
  }[];
160
160
  }>;
161
161
  getBorrowerIdsForFile(transactionFileId: string): Promise<{
package/services/signs.service.d.ts CHANGED
@@ -48,9 +48,6 @@ export declare class SignsService {
48
48
  private readonly loanStatementService;
49
49
  private readonly usersService;
50
50
  constructor(lockService: LockService, loanTransactionsService: LoanTransactionsService, loanStatementService: LoanStatementService, usersService: UsersService);
51
- users: IUser[];
52
- fulfillUserList(): Promise<void>;
53
- clearUserList(): void;
54
51
  getAvailabilitiesSigns(bbcDateIds: string[]): Promise<IAvailabilitySignView[]>;
55
52
  getAvailabilitySigns(bbcDateId: string): Promise<IAvailabilitySignView>;
56
53
  revokeAvailability(bbcDateId: string, userId: string, userIdRevoked: string): Promise<void>;
package/services/signs.service.js CHANGED
@@ -32,13 +32,6 @@ class SignsService {
32
32
  this.loanStatementService = loanStatementService;
33
33
  this.usersService = usersService;
34
34
  }
35
- users = null;
36
- async fulfillUserList() {
37
- this.users = await this.usersService.getUserList();
38
- }
39
- clearUserList() {
40
- this.users = null;
41
- }
42
35
  async getAvailabilitiesSigns(bbcDateIds) {
43
36
  const availabilitySigns = await (0, availability_db_1.getAvailabilitySigns)(bbcDateIds);
44
37
  const users = await this.usersService.getUserList();
@@ -67,26 +60,12 @@ class SignsService {
67
60
  };
68
61
  }
69
62
  const availabilitySigns = availabilitiesSigns[0];
70
- let keyCloakUsers = this.users;
71
- if (!keyCloakUsers) {
72
- keyCloakUsers = await this.usersService.getUserList();
73
- }
74
63
  availabilitySigns.signs = availabilitySigns.signs.reduce((acc, userSign) => {
75
64
  if (!userSign.userSigned) {
76
65
  return acc;
77
66
  }
78
- const foundUserSigned = keyCloakUsers.find((user) => user.id === userSign.userSigned.id);
79
- if (foundUserSigned) {
80
- userSign.userSigned.firstName = foundUserSigned.firstName;
81
- userSign.userSigned.lastName = foundUserSigned.lastName;
82
- }
83
67
  userSign.userSigned = (lodash_1.default.pick(userSign.userSigned, ['_id', 'firstName', 'lastName']));
84
68
  if (userSign.userRevoked) {
85
- const foundUserRevoked = keyCloakUsers.find((user) => user.id === userSign.userRevoked.id);
86
- if (foundUserRevoked) {
87
- userSign.userRevoked.firstName = foundUserRevoked.firstName;
88
- userSign.userRevoked.lastName = foundUserRevoked.lastName;
89
- }
90
69
  userSign.userRevoked = (lodash_1.default.pick(userSign.userRevoked, ['_id', 'firstName', 'lastName']));
91
70
  }
92
71
  return [...acc, lodash_1.default.pick(userSign, ['userSigned', 'signedAt', 'userRevoked', 'revokedAt'])];
package/services/signs.service.ts CHANGED
@@ -50,16 +50,6 @@ export class SignsService {
50
50
  ) {
51
51
  }
52
52
 
53
- users: IUser[] = null;
54
-
55
- async fulfillUserList() {
56
- this.users = await this.usersService.getUserList();
57
- }
58
-
59
- clearUserList() {
60
- this.users = null;
61
- }
62
-
63
53
  async getAvailabilitiesSigns(bbcDateIds: string[]): Promise<IAvailabilitySignView[]> {
64
54
  const availabilitySigns = await getAvailabilitySigns(bbcDateIds);
65
55
  const users = await this.usersService.getUserList();
@@ -89,26 +79,12 @@ export class SignsService {
89
79
  };
90
80
  }
91
81
  const availabilitySigns = availabilitiesSigns[0];
92
- let keyCloakUsers = this.users;
93
- if (!keyCloakUsers) {
94
- keyCloakUsers = await this.usersService.getUserList();
95
- }
96
82
  availabilitySigns.signs = availabilitySigns.signs.reduce((acc, userSign) => {
97
83
  if (!userSign.userSigned) {
98
84
  return acc;
99
85
  }
100
- const foundUserSigned = keyCloakUsers.find((user) => user.id === userSign.userSigned.id);
101
- if (foundUserSigned) {
102
- userSign.userSigned.firstName = foundUserSigned.firstName;
103
- userSign.userSigned.lastName = foundUserSigned.lastName;
104
- }
105
86
  userSign.userSigned = (_.pick(userSign.userSigned, ['_id', 'firstName', 'lastName'])) as IUser;
106
87
  if (userSign.userRevoked) {
107
- const foundUserRevoked = keyCloakUsers.find((user) => user.id === userSign.userRevoked.id);
108
- if (foundUserRevoked) {
109
- userSign.userRevoked.firstName = foundUserRevoked.firstName;
110
- userSign.userRevoked.lastName = foundUserRevoked.lastName;
111
- }
112
88
  userSign.userRevoked = (_.pick(userSign.userRevoked, ['_id', 'firstName', 'lastName'])) as IUser;
113
89
  }
114
90
  return [...acc, _.pick(userSign, ['userSigned', 'signedAt', 'userRevoked', 'revokedAt'])];