gemcap-be-common 1.4.231 → 1.4.233

package/helpers/bank-reference.helper.js

@@ -14,15 +14,24 @@ const extractReferenceValue = (reference, key) => {
     let value = match[1].trim();
     // Remove trailing account markers like /AC- or /BC-
     value = value.split('/')[0].trim();
+    // Remove NOTPROVIDED if present
+    value = value.replace(/NOTPROVIDED/gi, '').trim();
+    // Collapse multiple spaces (incl. tabs) into a single space
+    value = value.replace(/\s{2,}/g, ' ');
     return value;
 };
 const convertBankReferenceToTransactionReference = (rawReference) => {
-    if (!rawReference) {
-        return ' :  : ';
+    // If reference is empty/null → return empty string
+    if (!rawReference || !rawReference.trim()) {
+        return '';
     }
     const org = extractReferenceValue(rawReference, 'ORG');
     const bnf = extractReferenceValue(rawReference, 'BNF');
     const obi = extractReferenceValue(rawReference, 'OBI');
+    // If none of the required keys were found → return original reference as-is
+    if (!org && !bnf && !obi) {
+        return rawReference;
+    }
     return `${org || ''} : ${bnf || ''} : ${obi || ''}`;
 };
 exports.convertBankReferenceToTransactionReference = convertBankReferenceToTransactionReference;

package/helpers/bank-reference.helper.ts

@@ -17,17 +17,29 @@ const extractReferenceValue = (reference: string, key: string): string => {
   // Remove trailing account markers like /AC- or /BC-
   value = value.split('/')[0].trim();
 
+  // Remove NOTPROVIDED if present
+  value = value.replace(/NOTPROVIDED/gi, '').trim();
+
+  // Collapse multiple spaces (incl. tabs) into a single space
+  value = value.replace(/\s{2,}/g, ' ');
+
   return value;
 };
 
 export const convertBankReferenceToTransactionReference = (rawReference: string) => {
-  if (!rawReference) {
-    return ' :  : ';
+  // If reference is empty/null → return empty string
+  if (!rawReference || !rawReference.trim()) {
+    return '';
   }
 
   const org = extractReferenceValue(rawReference, 'ORG');
   const bnf = extractReferenceValue(rawReference, 'BNF');
   const obi = extractReferenceValue(rawReference, 'OBI');
 
+  // If none of the required keys were found → return original reference as-is
+  if (!org && !bnf && !obi) {
+    return rawReference;
+  }
+
   return `${org || ''} : ${bnf || ''} : ${obi || ''}`;
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gemcap-be-common",
-  "version": "1.4.231",
+  "version": "1.4.233",
   "description": "",
   "main": "index.js",
   "scripts": {

package/services/bank-uploaded-transactions.service.js

@@ -322,7 +322,6 @@ class BankUploadedTransactionsService {
             });
             const loanTransactionsService = this.getLoanTransactionsService();
             const normalizedTransaction = await loanTransactionsService.normalizeLoanTransaction(getLoanTransaction(), userId);
-            console.log({ normalizedTransaction });
             const createdLoanTransaction = await loanTransactionsService.createLoanTransaction(normalizedTransaction);
             loanTransactionsMap[String(transaction._id)] = [...loanTransactionsMap[String(transaction._id)], new mongoose_1.default.Types.ObjectId(String(createdLoanTransaction._id))];
             productIds.add(String(foundCashAllocationProduct.productId));

package/services/bank-uploaded-transactions.service.ts

@@ -360,7 +360,6 @@ export class BankUploadedTransactionsService {
       });
       const loanTransactionsService = this.getLoanTransactionsService();
       const normalizedTransaction = await loanTransactionsService.normalizeLoanTransaction(getLoanTransaction() as ILoanTransactionDoc, userId);
-      console.log({ normalizedTransaction });
       const createdLoanTransaction = await loanTransactionsService.createLoanTransaction(normalizedTransaction as Partial<ILoanTransactionWithId>);
       loanTransactionsMap[String(transaction._id)] = [...loanTransactionsMap[String(transaction._id)], new mongoose.Types.ObjectId(String(createdLoanTransaction._id))];
       productIds.add(String(foundCashAllocationProduct.productId));