gdharness 1.3.59 → 1.3.61

package/build/godot/addons/gdharness_runtime/reading.gd

@@ -139,7 +139,7 @@ static func from_the_root(said: String, node_path: String, root_name: String) ->
 
 ## [param said], the refusal for a path a scene does not have, with where the path leaves it: the
 ## last node of the path it has, [param reached] from the root, called [param root_name], when that
-## is empty; the name below it that is missing; and [param children], the names that node has, as
+## is empty, the name below it that is missing, and [param children], the names that node has, as
 ## after a node was moved or renamed. Names up to [constant NAMED_CHILDREN] of them.
 static func missing_below(
 	said: String,
@@ -152,17 +152,21 @@ static func missing_below(
 	if children.size() > NAMED_CHILDREN:
 		shown += " and %d more" % (children.size() - NAMED_CHILDREN)
 	return (
-		"%s%s %s has no %s; %s."
+		"%s %s has no %s. %s."
 		% [
-			said,
-			"" if said.ends_with(".") else ".",
+			ended(said),
 			"The root, %s," % root_name if reached.is_empty() else "/".join(reached),
 			missing,
-			"its children are " + shown if not children.is_empty() else "it has no children",
+			"Its children are " + shown if not children.is_empty() else "It has no children",
 		]
 	)
 
 
+## [param said] with a full stop at its end, so another sentence can follow it.
+static func ended(said: String) -> String:
+	return said if said.ends_with(".") else said + "."
+
+
 ## [param said], the refusal for a [param kind] the scene does not have at [param node_path], with
 ## what is there when the scene has a node there, [param found] its class, and [param holders], the
 ## paths of the nodes in the scene that are one, so the caller has the path to pass. Names up to
@@ -180,7 +184,7 @@ static func not_of_kind(
 		return (
 			told
 			+ (
-				" The scene holds no %s; scene_node add with nodeType %s puts one in it."
+				" The scene holds no %s. scene_node add with nodeType %s puts one in it."
 				% [kind, kind]
 			)
 		)
@@ -222,17 +226,17 @@ static func offered(said: String, word: String, names: Array) -> String:
 	var every: PackedStringArray = PackedStringArray(names)
 	var close: PackedStringArray = nearest(word, every)
 	if close.is_empty():
-		return "%s; it has %s" % [said, ", ".join(every)]
+		return "%s It has %s" % [ended(said), ", ".join(every)]
 	return (
-		"%s; the nearest it has %s %s"
-		% [said, "is" if close.size() == 1 else "are", ", ".join(close)]
+		"%s The nearest it has %s %s"
+		% [ended(said), "is" if close.size() == 1 else "are", ", ".join(close)]
 	)
 
 
 ## [param said], the refusal for [param property], which [param target] does not declare, with the
 ## names it declares nearest it when any are, as a misspelt one is usually one of them, or else the
 ## variables its script declares. The engine's own are not listed when none is near, since an object
-## has a hundred, while a script's are the few a caller most likely meant; an object with no script
+## has a hundred, while a script's are the few a caller most likely meant. An object with no script
 ## is told where they are listed instead, since the refusal alone left nothing to try.
 static func near_property(said: String, target: Object, property: String) -> String:
 	var headings: int = PROPERTY_USAGE_CATEGORY | PROPERTY_USAGE_GROUP | PROPERTY_USAGE_SUBGROUP
@@ -243,7 +247,7 @@ static func near_property(said: String, target: Object, property: String) -> Str
 		if usage & PROPERTY_USAGE_ARRAY:
 			var listed: String = _list_called(target, declared, property)
 			if not listed.is_empty():
-				return "%s; %s" % [said, listed]
+				return "%s %s" % [ended(said), listed]
 		if not usage & headings:
 			names.append(str(declared.get("name", "")))
 		if usage & PROPERTY_USAGE_SCRIPT_VARIABLE and not usage & headings:
@@ -251,8 +255,8 @@ static func near_property(said: String, target: Object, property: String) -> Str
 	var close: PackedStringArray = nearest(property, PackedStringArray(names))
 	if not close.is_empty():
 		return (
-			"%s; the nearest it has %s %s"
-			% [said, "is" if close.size() == 1 else "are", ", ".join(close)]
+			"%s The nearest it has %s %s"
+			% [ended(said), "is" if close.size() == 1 else "are", ", ".join(close)]
 		)
 	# With a script that declares nothing readable, as one that does not compile, the name is
 	# likelier the script's than the class's, so the class's list would point the wrong way.
@@ -261,17 +265,17 @@ static func near_property(said: String, target: Object, property: String) -> Str
 	if scripted.is_empty():
 		return (
 			(
-				"%s; editor_classes info with className %s and includeInherited true lists the "
+				"%s editor_classes info with className %s and includeInherited true lists the "
 				+ "ones it has"
 			)
-			% [said, target.get_class()]
+			% [ended(said), target.get_class()]
 		)
 	scripted.sort()
-	return "%s; its script declares %s" % [said, ", ".join(PackedStringArray(scripted))]
+	return "%s Its script declares %s" % [ended(said), ", ".join(PackedStringArray(scripted))]
 
 
 ## How [param target] keeps the list [param property] names, when that is the label of one of the
-## engine's numbered lists, such as an OptionButton's Items; empty when it is not. The engine has no
+## engine's numbered lists, such as an OptionButton's Items. Empty when it is not. The engine has no
 ## property by that name, only a count and each entry's fields under a numbered prefix, so "items"
 ## was refused with nothing near it to offer.
 static func _list_called(target: Object, count: Dictionary, property: String) -> String:
@@ -292,7 +296,7 @@ static func _list_called(target: Object, count: Dictionary, property: String) ->
 	)
 	return (
 		(
-			"it keeps its %s as %s, how many there are, and %s under %s for the first, %s for the "
+			"It keeps its %s as %s, how many there are, and %s under %s for the first, %s for the "
 			+ "second and so on: give %s before the fields of the entries it makes"
 		)
 		% [parts[0].to_lower(), counted, each, first, parts[1] + "1/", counted]

package/build/godot/addons/gdharness_runtime/runtime_accessibility.gd

@@ -381,7 +381,7 @@ func get_accessibility(params: Dictionary) -> Dictionary:
 	if elements <= windows.size():
 		var setting: String = _setting()
 		# The command line's --accessibility is consumed by the engine and not handed on, so only
-		# the setting and a screen reader can say the tree is built; otherwise an empty window is
+		# the setting and a screen reader can say the tree is built. Otherwise an empty window is
 		# most likely a game that builds none.
 		# 1 is a screen reader running, 0 none and -1 a platform that cannot say.
 		var read_aloud: bool = (
@@ -606,7 +606,7 @@ static func _match(element: Dictionary, made_by: Dictionary, placing: GdhPlacing
 ## Control, a RichTextLabel and each of its lines are containers. A RichTextLabel's text in a
 ## column of plain containers came out straight under the window. So the node is found where it
 ## must be: below the shown element's node, itself left out of the tree (a node that is shown would
-## have the part under it), drawn around the part, and, for text, holding its words.
+## have the part under it), drawn around the part, and, for text, one that holds its words.
 static func _attribute(
 	element: Dictionary, holder: Node, placing: GdhPlacing, is_window: bool
 ) -> void:

package/build/godot/addons/gdharness_runtime/runtime_autoload.gd

@@ -1,7 +1,7 @@
 extends Node
 ## The runtime autoload: a TCP server inside the running game that the gdharness server asks
 ## about the scene tree, drives with input, and captures. This file is the server and the
-## command table; what each command does lives in a sibling module.
+## command table. What each command does lives in a sibling module.
 ##
 ## The port is whatever the operating system hands out, and the game announces it by writing
 ## one file named after its process id into a directory the server derives the same way. Two
@@ -14,10 +14,12 @@ const GdhFrames = preload("runtime_frames.gd")
 const GdhRead = preload("reading.gd")
 ## Where the modules are loaded from. Kept in step with the markers below.
 const ADDON_DIR: String = "res://addons/gdharness_runtime/"
-## The modules that answer commands, loaded at the first command one answers rather than preloaded.
+## The modules that answer commands, compiled on the engine's loading threads rather than preloaded.
 ## A preload compiles as this script parses, and the modules are twelve thousand lines: compiling
 ## them took most of a second of every debug start, in games nobody asks anything, a bench's quiet
-## workers and script runs among them.
+## workers and script runs among them. Compiled at a command instead, they held that frame for up
+## to 590 ms, which a game's frame bench read as its own stall. So a served game compiles them on a
+## loading thread from its first frame, where a game nobody serves compiles none.
 const QUERIES: String = "runtime_queries.gd"
 const CHANGES: String = "runtime_changes.gd"
 const INPUT: String = "runtime_input.gd"
@@ -28,6 +30,11 @@ const CAPTURE: String = "runtime_capture.gd"
 const WAITS: String = "runtime_waits.gd"
 const ACCESSIBILITY: String = "runtime_accessibility.gd"
 const VALUES: String = "runtime_values.gd"
+## Every module in the order a loading thread compiles them: the values one first, since most others
+## are built with it, then by how soon a caller tends to need one.
+const MODULES: PackedStringArray = [
+	VALUES, QUERIES, WAITS, INPUT, TYPING, CHANGES, CAPTURE, PAD, TOUCH, ACCESSIBILITY,
+]
 ## Every module command, by the name a request uses, as the module and the method that answers it.
 const MODULE_COMMANDS: Dictionary = {
 	"get_tree": [QUERIES, "get_tree"],
@@ -132,11 +139,16 @@ const DIGEST_MARKER: String = "res://addons/gdharness_runtime/.gdharness-digest"
 var values: RefCounted:
 	get:
 		if _values == null:
-			_values = _loaded(VALUES).new()
+			_values = _compiled(VALUES).new()
 		return _values
 
 var _values: RefCounted
 var _frames: GdhFrames = GdhFrames.new()
+var _modules_requested: bool = false
+## The module path a loading thread is compiling, or "" for none.
+var _in_flight: String = ""
+## The module paths waiting for a loading thread, the next first.
+var _queued: Array[String] = []
 ## Each module loaded so far, by its file. Held here because a Callable holds its object by id
 ## rather than by reference, and a module referenced only by the Callable answering one command
 ## would be freed once it answered.
@@ -216,6 +228,11 @@ func _process(_delta: float) -> void:
 		return
 	_frames.note_frame(Time.get_ticks_usec())
 	_calibrate_the_profiler()
+	if not _modules_requested:
+		_modules_requested = true
+		_request_modules()
+	elif not _in_flight.is_empty() or not _queued.is_empty():
+		_advance_modules()
 
 	# Every connection waiting rather than one a frame: the engine queues eight a game has not taken
 	# and refuses the rest, so calls sent together would be refused as if the game were not up.
@@ -233,7 +250,7 @@ func _process(_delta: float) -> void:
 	var gone: Array[StreamPeerTCP] = []
 	for client: StreamPeerTCP in _clients:
 		# A poll that fails is a client that has already gone, which the status check below is
-		# about to find; the answer is read so it is not dropped, not because it adds anything.
+		# about to find. The answer is read so it is not dropped, not because it adds anything.
 		var polled: Error = client.poll()
 		if polled != OK or client.get_status() != StreamPeerTCP.STATUS_CONNECTED:
 			gone.append(client)
@@ -276,17 +293,66 @@ func _notification(what: int) -> void:
 		_cleanup()
 
 
-## The script of the module in [param file], compiled at the first call that needs it.
+## The script of the module in [param file], compiled here if no thread has it.
 static func _loaded(file: String) -> GDScript:
 	return load(ADDON_DIR + file) as GDScript
 
 
+## Queues every module not yet compiled for a loading thread. Called at the first frame a served
+## game runs, after its main scene has loaded.
+func _request_modules() -> void:
+	for file: String in MODULES:
+		var path: String = ADDON_DIR + file
+		if path != _in_flight and not _queued.has(path) and not ResourceLoader.has_cached(path):
+			_queued.append(path)
+	_advance_modules()
+
+
+## Takes the module a loading thread has finished and asks for the next. One at a time, because
+## many threaded loads at once have deadlocked a game's boot in Godot's loader.
+func _advance_modules() -> void:
+	if not _in_flight.is_empty():
+		var status: ResourceLoader.ThreadLoadStatus = ResourceLoader.load_threaded_get_status(
+			_in_flight
+		)
+		if status == ResourceLoader.THREAD_LOAD_IN_PROGRESS:
+			return
+		# Taken so the loader lets go of the request. A failed one answers null, and the module's
+		# first command then compiles it and reports why.
+		var _taken: Resource = ResourceLoader.load_threaded_get(_in_flight)
+		_in_flight = ""
+	while not _queued.is_empty():
+		var path: String = _queued.pop_front()
+		if ResourceLoader.has_cached(path):
+			continue
+		# A request the loader refuses leaves the module to be compiled at its first command.
+		if ResourceLoader.load_threaded_request(path, "GDScript") == OK:
+			_in_flight = path
+			return
+
+
+## The script of the module in [param file], finished in this frame when its loading thread has not
+## finished it yet. A command acts in the frame it arrives, so it never waits frames for its module:
+## a frame wait let 38 frames pass for three, and a signal fired before the wait began. Such a frame
+## is the runtime's slowness, and is left out of the timing.
+func _compiled(file: String) -> GDScript:
+	var path: String = ADDON_DIR + file
+	if not ResourceLoader.has_cached(path):
+		_frames.skip_this_frame()
+	if path == _in_flight:
+		var _taken: Resource = ResourceLoader.load_threaded_get(path)
+		_in_flight = ""
+	else:
+		_queued.erase(path)
+	return _loaded(file)
+
+
 ## The module in [param file], built at its first command with what it is built with.
 func _module(file: String) -> Object:
 	var made: Object = _modules.get(file)
 	if made != null:
 		return made
-	var script: GDScript = _loaded(file)
+	var script: GDScript = _compiled(file)
 	match file:
 		QUERIES:
 			made = script.new(self, values, _frames)
@@ -295,7 +361,6 @@ func _module(file: String) -> Object:
 		_:
 			made = script.new(self, values)
 	_modules[file] = made
-	_frames.skip_this_frame()
 	return made
 
 
@@ -420,7 +485,7 @@ func _note_the_exit() -> void:
 ## The debugger reads in order, so its answer comes once it has read everything the game queued
 ## before the totals, and a debugger that has fallen behind answers late rather than not at all. A
 ## debugger gdharness gave this game, the keeper of a run the server started or an editor with the
-## gdharness addon, is waited for until it answers; a fixed three seconds lost the totals of a run
+## gdharness addon, is waited for until it answers. A fixed three seconds lost the totals of a run
 ## whose first frame named 1536 functions, on a loaded runner that read them slower than that. Any
 ## other debugger may never answer, and holds the exit for the short wait only.
 ##
@@ -455,7 +520,7 @@ func _send_the_profile() -> void:
 
 
 ## Sends the debugger the message it answers once it has read everything sent before it, and waits
-## up to [param waits] ms for the answer, polling for it since the game's loop is over.
+## up to [param waits] ms for the answer. It polls for it since the game's loop is over.
 func _debugger_answered(waits: int) -> bool:
 	_profile_received = false
 	EngineDebugger.send_message(PROFILE_SENT, [])
@@ -629,7 +694,7 @@ func _start_server() -> void:
 
 
 ## The scene [param given] names for the engine to run, as a `res://` path, when it lies under one
-## of [param prefixes]; otherwise empty. The engine takes any bare argument ending in a scene's
+## of [param prefixes], and otherwise empty. The engine takes any bare argument ending in a scene's
 ## extension for the scene, relative to the project or absolute, so each is read as it would.
 static func quiet_scene_in(given: PackedStringArray, prefixes: Variant) -> String:
 	# A PackedStringArray as project.godot writes one, or an Array of strings as a hand might.
@@ -689,7 +754,7 @@ func _announce(bind_address: String) -> void:
 	if made != OK and made != ERR_ALREADY_EXISTS:
 		push_warning(
 			(
-				"[gdharness] cannot create %s (%s); the server will not find this game"
+				"[gdharness] cannot create %s (%s), so the server will not find this game"
 				% [directory, made]
 			)
 		)
@@ -704,7 +769,7 @@ func _announce(bind_address: String) -> void:
 	if file == null:
 		push_warning(
 			(
-				"[gdharness] cannot write %s (%s); the server will not find this game"
+				"[gdharness] cannot write %s (%s), so the server will not find this game"
 				% [staged, FileAccess.get_open_error()]
 			)
 		)
@@ -712,14 +777,14 @@ func _announce(bind_address: String) -> void:
 	var written: bool = file.store_string(JSON.stringify(_identity(bind_address)))
 	file.close()
 	if not written:
-		push_warning("[gdharness] cannot write %s; the server will not find this game" % staged)
+		push_warning("[gdharness] cannot write %s, so the server will not find this game" % staged)
 		_unstage(staged)
 		return
 	var moved: Error = DirAccess.rename_absolute(staged, path)
 	if moved != OK:
 		push_warning(
 			(
-				"[gdharness] cannot move %s to %s (%s); the server will not find this game"
+				"[gdharness] cannot move %s to %s (%s), so the server will not find this game"
 				% [staged, path, moved]
 			)
 		)
@@ -729,7 +794,7 @@ func _announce(bind_address: String) -> void:
 
 
 ## Takes a staged announcement down after a write or a move that failed. The answer is taken
-## rather than dropped, since these scripts compile under the game's own warning levels; a
+## rather than dropped, since these scripts compile under the game's own warning levels. A
 ## staged file that will not go either is nothing any server reads.
 func _unstage(staged: String) -> void:
 	var _removed: Error = DirAccess.remove_absolute(staged)
@@ -834,7 +899,7 @@ func _ping(_params: Dictionary) -> Dictionary:
 
 
 ## The game asked to close, as a player's close asks it: answered at once and delivered once the
-## answer has gone out. `acceptsQuit` says whether the tree quits on the request by itself; a game
+## answer has gone out. `acceptsQuit` says whether the tree quits on the request by itself. A game
 ## that turned that off decides for itself, and may ask the player first.
 func _close_game(_params: Dictionary) -> Dictionary:
 	_close_asked = true
@@ -884,6 +949,12 @@ func _cleanup() -> void:
 	_clients.clear()
 	_pending.clear()
 	_outgoing.clear()
+	# A threaded request nobody takes leaves its load token behind, which the engine reports as a
+	# leaked instance at exit. Taken here, which waits for that one module to finish compiling.
+	_queued.clear()
+	if not _in_flight.is_empty():
+		var _taken: Resource = ResourceLoader.load_threaded_get(_in_flight)
+		_in_flight = ""
 
 	if _server:
 		_server.stop()
@@ -896,7 +967,7 @@ func _cleanup() -> void:
 		if removed != OK:
 			push_warning(
 				(
-					"[gdharness] cannot remove %s; the server will find a game that is gone"
+					"[gdharness] cannot remove %s, so the server will find a game that is gone"
 					% _announcement
 				)
 			)

package/build/godot/addons/gdharness_runtime/runtime_capture.gd

@@ -74,7 +74,7 @@ func capture_viewport(params: Dictionary) -> Dictionary:
 	# and the game's own mode put back after it.
 	var sub: SubViewport = viewport
 	var mode: SubViewport.UpdateMode = sub.render_target_update_mode
-	# Nothing is drawn without a window, so the frame waited for below may never come; the capture
+	# Nothing is drawn without a window, so the frame waited for below may never come. The capture
 	# refuses that state itself.
 	if mode == SubViewport.UPDATE_ALWAYS or not _host.get_tree().root.can_draw():
 		return await _capture(viewport, params)
@@ -144,7 +144,7 @@ func _cut_asked(params: Dictionary, in_window: bool) -> Dictionary:
 		GdhRead.as_int(params.get("width", 0)) > 0 or GdhRead.as_int(params.get("height", 0)) > 0
 	)
 	if region_given != null and not node_path.is_empty():
-		return _refused("region and nodePath each name the part to capture; give one of them")
+		return _refused("region and nodePath each name the part to capture. Give one of them")
 	if (region_given != null or not node_path.is_empty()) and not in_window:
 		return _refused(
 			(
@@ -160,7 +160,7 @@ func _cut_asked(params: Dictionary, in_window: bool) -> Dictionary:
 		return _refused(
 			(
 				"zoom enlarges by a whole factor and keeps every pixel square, and width and "
-				+ "height scale to a size; give one or the other"
+				+ "height scale to a size. Give one or the other"
 			)
 		)
 	var asked: Dictionary = { "zoom": zoom }
@@ -239,7 +239,7 @@ static func drawn_rect_of(node: Node) -> Variant:
 			item.get_viewport(), item.get_global_transform_with_canvas() * own
 		)
 	var no_extent: String = (
-		"%s is a %s, which has a position on screen and no extent; give region around the point "
+		"%s is a %s, which has a position on screen and no extent. Give region around the point "
 		+ "runtime_inspect rect answers for it"
 	)
 	return no_extent % [node.get_path(), node.get_class()]
@@ -286,7 +286,7 @@ static func cut(image: Image, picture: Rect2i, zoom: int) -> Image:
 	return part
 
 
-## The server names the file, so a game cannot point it at a path of its own choosing; a call
+## The server names the file, so a game cannot point it at a path of its own choosing. A call
 ## with no path is a call the server did not make.
 func _capture(viewport: Viewport, params: Dictionary, with_windows: bool = false) -> Dictionary:
 	var requested_path: String = str(params.get("output_path", ""))
@@ -324,7 +324,7 @@ func _capture(viewport: Viewport, params: Dictionary, with_windows: bool = false
 	# The game announces itself before its first frame, and until a frame has been drawn the texture
 	# holds nothing the game drew: blank on one machine, solid white on another, which a caller took
 	# for the game flashing white on boot. Measured on 4.7.2 with both renderers, only the first
-	# processed frame reads it so; the next one holds the scene.
+	# processed frame reads it so. The next one holds the scene.
 	while Engine.get_frames_drawn() == 0:
 		await _host.get_tree().process_frame
 

package/build/godot/addons/gdharness_runtime/runtime_changes.gd

@@ -81,7 +81,7 @@ func set_property(params: Dictionary) -> Dictionary:
 		return fitting
 	var given: Variant = fitting["value"]
 	# A component of a vector or a transform is written into a copy, which is put back where it was
-	# read from, setter and all; the read back is then taken off the game again, since the copy here
+	# read from, setter and all. The read back is then taken off the game again, since the copy here
 	# says only what was written into it.
 	var chain: Array[Dictionary] = reached["chain"]
 	var copied: bool = GdhPaths.composite(holder)
@@ -133,7 +133,7 @@ func set_property(params: Dictionary) -> Dictionary:
 			why += (
 				(
 					". %s is declared as %s, which is also how the engine names a script class "
-					+ "with no class_name; if it is one, the object given has the right class and "
+					+ "with no class_name. If it is one, the object given has the right class and "
 					+ "another script: it is %s"
 				)
 				% [named, str(slot["class"]), GdhValues.class_of(refused_object)]
@@ -165,7 +165,7 @@ func set_property(params: Dictionary) -> Dictionary:
 		answer["unchanged"] = true
 	_keep_reported(answer, "errors", caught.raised)
 	_keep_reported(answer, "warnings", caught.warned)
-	# The engine stores a number past an export range, or one no enum value has, as given; only the
+	# The engine stores a number past an export range, or one no enum value has, as given. Only the
 	# inspector holds a property to them, so the game now holds a value its own script never
 	# expected.
 	if holder is Object:
@@ -484,7 +484,7 @@ func call_method(params: Dictionary) -> Dictionary:
 			var close: PackedStringArray = GdhRead.nearest(node_path, PackedStringArray(classes))
 			standing["message"] = (
 				(
-					"%s. No global class is called %s either%s; a static function is called with "
+					"%s. No global class is called %s either%s. A static function is called with "
 					+ "its class's name or its script's res:// path as the path."
 				)
 				% [
@@ -631,7 +631,7 @@ func call_method(params: Dictionary) -> Dictionary:
 				var _noted: bool = outside.append(stray)
 
 	# Timed around the call alone, since the bridge's round trip is a second or more and swamps what
-	# one click's work costs; the frame metrics read whichever frame is last, which is not this one.
+	# one click's work costs. The frame metrics read whichever frame is last, which is not this one.
 	# Listened to as well, because a call the engine refused returns null like one that ran.
 	var caught: GdhCallErrors = GdhCallErrors.new()
 	OS.add_logger(caught)
@@ -639,7 +639,7 @@ func call_method(params: Dictionary) -> Dictionary:
 	var result: Variant = holder.callv(named, deserialized_args)
 	OS.remove_logger(caught)
 	# A method that awaits hands back its state at the first await and its value only when it ends,
-	# so the answer waits for the value; one that takes longer than the server waits is collected by
+	# so the answer waits for the value. One that takes longer than the server waits is collected by
 	# its requestId like any slow call.
 	var state: Object = result if result is Object else null
 	var awaited: bool = state != null and state.get_class() == "GDScriptFunctionState"
@@ -660,7 +660,7 @@ func call_method(params: Dictionary) -> Dictionary:
 			message += (
 				(
 					". The parameter is declared as %s, which is also how the engine names a "
-					+ "script class with no class_name; if it is one, the object given has the "
+					+ "script class with no class_name. If it is one, the object given has the "
 					+ "right class and another script: it is %s"
 				)
 				% checked
@@ -756,7 +756,7 @@ static func _reads_the_result(asked: Variant) -> bool:
 ##
 ## In the same answer because an object handed back is otherwise only its class and its instance
 ## id, and reading one field of it meant finding the same object again by a path into the game's
-## private state, which works only where the caller already knows a key; a catalogue of records
+## private state, which works only where the caller already knows a key. A catalogue of records
 ## handed back as a list took one call per record. A name that is not there is listed rather than
 ## refusing the answer, since the call has run by then and its result is what was asked.
 func _read_off_result(result: Variant, asked: Variant) -> Dictionary:
@@ -809,7 +809,7 @@ func _read_off_result(result: Variant, asked: Variant) -> Dictionary:
 
 
 ## What was read off one element of a list or a dictionary a call answered with, or null for one
-## that is no object; why a name was not there goes into [param missing], led by [param named].
+## that is no object. Why a name was not there goes into [param missing], led by [param named].
 func _read_off_element(
 	element: Variant, named: String, asked: Variant, missing: Array[String]
 ) -> Variant:
@@ -900,7 +900,7 @@ static func _walk_from(object: Object, path: String) -> Dictionary:
 ## up to all of them, or any number past that for one taking varargs.
 static func _argument_count_refused(holder: Object, method: String, given: int) -> String:
 	# A node's method list runs to hundreds of entries, and walking it costs a couple of
-	# milliseconds of the game's frame; a call giving exactly the arguments the method declares
+	# milliseconds of the game's frame. A call giving exactly the arguments the method declares
 	# needs no walk.
 	if given == holder.get_method_argument_count(method):
 		return ""

package/build/godot/addons/gdharness_runtime/runtime_frames.gd

@@ -1,6 +1,6 @@
 extends RefCounted
 ## How long the game's last frames took, timed from the runtime's first frame. Apart from the
-## queries that report it, because those are loaded at the first request and the frames before it
+## queries that report it, because those are compiled after that frame and the frames before them
 ## count too.
 
 ## How many frames the frame time is the mean of: two seconds at sixty frames a second.
@@ -39,8 +39,9 @@ func note_frame(now_usec: int) -> void:
 	_last_physics_frames = stepped
 
 
-## Leaves the frame in progress out of the timing, for one the runtime itself slowed: compiling a
-## module at its first command takes up to half a second, which is gdharness's and not the game's,
-## and would stand as the slowest frame for the next two seconds of readings.
+## Leaves the frame in progress out of the timing, for one the runtime itself slowed. A module a
+## command needs before its loading thread finished it is finished in the frame, which can take half
+## a second. That is gdharness's and not the game's, and would stand as the slowest frame for two
+## seconds of readings.
 func skip_this_frame() -> void:
 	_last_frame_usec = 0

package/build/godot/addons/gdharness_runtime/runtime_hover.gd

@@ -9,8 +9,7 @@ extends RefCounted
 ## it. An injected event never crosses anything, and on gdharness's own desktop no pointer ever
 ## enters a window, so nothing was hovered. A BaseButton takes a mouse press only while hovered, so
 ## every click on a button in such a window was dropped while the press itself was routed to it.
-## Reported from Game C, whose strip window holds its first-run question, and traced through Godot
-## 4.7.2's source.
+## Reported from Game C and traced through Godot 4.7.2's source.
 ##
 ## What is supplied is what the engine does once the window has been entered: the control its own
 ## search finds under the point, MOUSE_ENTER and mouse_entered on it and on each holder the pointer
@@ -45,7 +44,7 @@ func cannot_hover(window: Window) -> bool:
 
 
 ## Hovers what is under [param point], in [param viewport]'s own coordinates, when the engine could
-## not; answers whether it did. Where the engine hovers by itself, any hover supplied before is
+## not. Answers whether it did. Where the engine hovers by itself, any hover supplied before is
 ## taken down first, so a control is never entered twice.
 func follow(viewport: Viewport, point: Vector2) -> bool:
 	var window: Window = viewport as Window
@@ -246,7 +245,7 @@ func press_of(aim: Dictionary, viewport: Viewport, position: Vector2) -> Diction
 
 ## What a press at [param point], in [param viewport]'s own coordinates, goes to: the control the
 ## GUI picks, carried into a window embedded over the point and into what a SubViewportContainer
-## shows, as the engine carries it; null when nothing there takes the pointer.
+## shows, as the engine carries it. Null when nothing there takes the pointer.
 func _pressed_at(viewport: Viewport, point: Vector2) -> Node:
 	var windows: Array[Window] = viewport.get_embedded_subwindows()
 	for index: int in range(windows.size() - 1, -1, -1):

package/build/godot/addons/gdharness_runtime/runtime_input.gd

@@ -20,7 +20,7 @@ const GdhSays = preload("runtime_says.gd")
 ## everything that process starts. Kept in step with `DESKTOP_VARIABLE` in src/desktop.ts.
 const DESKTOP_VARIABLE: String = "GDHARNESS_DESKTOP"
 
-## Whether this run has had the pointer note in full; the game process is the run.
+## Whether this run has had the pointer note in full. The game process is the run.
 static var _pointer_explained: bool = false
 ## Whether this run has had the note on a supplied hover in full.
 static var _hover_explained: bool = false
@@ -76,7 +76,7 @@ static func _pointer_noted(answer: Dictionary) -> Dictionary:
 			+ "get_global_mouse_position() and get_local_mouse_position() on what is drawn there, "
 			+ "read a meaningless position rather than where this put it. What reads the event "
 			+ "itself gets this position: the control under the pointer, its hover and tooltip, "
-			+ "and the game's input handlers. Said once a run; pointer_on_hidden_desktop marks "
+			+ "and the game's input handlers. Said once a run. pointer_on_hidden_desktop marks "
 			+ "every answer it applies to."
 		)
 	return answer
@@ -97,7 +97,7 @@ static func _hover_noted(answer: Dictionary, supplied: bool) -> Dictionary:
 			+ "engine would have: their mouse_entered and mouse_exited, and the hover a Button "
 			+ "presses on, and told the window the pointer is in it, so a motion reaches the "
 			+ "control under it. Viewport.gui_get_hovered_control() still answers null in this "
-			+ "window. Said once a run; hover_supplied marks every answer it applies to."
+			+ "window. Said once a run. hover_supplied marks every answer it applies to."
 		)
 	return answer
 
@@ -539,7 +539,7 @@ func inject_mouse_drag(params: Dictionary) -> Dictionary:
 ## never pressed anything. The position is the control's centre carried into window pixels, so
 ## the caller never has to do that arithmetic.
 ##
-## A control out of sight inside a ScrollContainer is scrolled to first; the answer says so under
+## A control out of sight inside a ScrollContainer is scrolled to first. The answer says so under
 ## `scrolled_into_view`, because the view having moved is a thing that happened to the screen and
 ## the caller is the only one who can tell whether that matters.
 ##
@@ -635,7 +635,7 @@ func click(params: Dictionary) -> Dictionary:
 	#
 	# Out of sight against what it is clipped to rather than against the viewport: a row scrolled
 	# off the top of its container is inside the viewport, behind whatever is drawn up there, so
-	# the click went to that instead and said so. Measured on a hall whose staff panel had been
+	# the click went to that instead and said so. Measured on a screen whose list had been
 	# scrolled past: the button was at y 69 and its container started at y 166.
 	var scrolled: bool = item_scrolled
 	if not GdhScreen.in_sight(control, own, local):
@@ -745,7 +745,7 @@ func click(params: Dictionary) -> Dictionary:
 		var _hearing: int = toggle.pressed.connect(heard_press)
 	var press: InputEventMouseButton = await _click_button(viewport, position, button, double)
 	# The release is what a button acts on, and a queue_free it causes lands at the end of
-	# this frame; the frame passes so the answer describes the control as the click left it.
+	# this frame. The frame passes so the answer describes the control as the click left it.
 	await _host.get_tree().process_frame
 	if rich != null and is_instance_valid(rich) and rich.meta_clicked.is_connected(heard):
 		rich.meta_clicked.disconnect(heard)
@@ -795,8 +795,8 @@ func click(params: Dictionary) -> Dictionary:
 
 ## Why a click at [param control]'s centre, or at the point [param aimed] names, would reach
 ## nothing, or "" when it would reach it: the point outside the viewport it is drawn in, at
-## [param local]; outside the viewport showing that one on the screen, which [param reached] holds
-## with the point there; or clipped away by a ScrollContainer holding it. A refusal names the
+## [param local], outside the viewport showing that one on the screen, which [param reached] holds
+## with the point there, or clipped away by a ScrollContainer holding it. A refusal names the
 ## viewport or container at fault and the point in that one's own space, since naming another
 ## printed a point inside the rect it was said to be outside. The note on a game with no window goes
 ## only on the viewport that is the window's.

package/build/godot/addons/gdharness_runtime/runtime_items.gd

@@ -162,7 +162,7 @@ static func _menu_title_size(menus: MenuBar, menu: int, style: StyleBox) -> Vect
 
 
 ## Scrolls [param control] until it draws [param item], and answers whether it asked anything to
-## move. A tab bar and a tree have a call for it; a list is scrolled by its own bar, by as little as
+## move. A tab bar and a tree have a call for it. A list is scrolled by its own bar, by as little as
 ## brings the whole entry in.
 static func _scroll_to(control: Control, item: Variant) -> bool:
 	var index: int = item if item is int else -1