gdharness 1.3.5 → 1.3.7

package/build/keeper.js

@@ -106,6 +106,9 @@ public static class GdharnessDesktop {
   [DllImport("kernel32.dll")] static extern bool GetExitCodeProcess(IntPtr handle, out uint code);
   [DllImport("kernel32.dll")] static extern bool CloseHandle(IntPtr handle);
   [DllImport("kernel32.dll")] static extern bool TerminateProcess(IntPtr handle, uint code);
+  [DllImport("kernel32.dll")] static extern uint SetErrorMode(uint mode);
+  const uint FailCriticalErrors = 0x1;
+  const uint NoOpenFileErrorBox = 0x8000;
 
   delegate bool EachWindow(IntPtr window, IntPtr unused);
   [DllImport("user32.dll")] static extern bool EnumWindows(EachWindow each, IntPtr unused);
@@ -179,6 +182,11 @@ public static class GdharnessDesktop {
     startup.output = GetStdHandle(-11);
     startup.error = startup.output;
     Started started;
+    // Inherited by what it starts: without SEM_NOGPFAULTERRORBOX, Windows Error Reporting runs when
+    // the target crashes and writes its dump, and with the other two no hard-error box can open.
+    // Set outright rather than cleared from this process's own: Windows PowerShell changes the mode
+    // it inherited as it starts, and was seen reading 0x1 here, without the open-file bit.
+    SetErrorMode(FailCriticalErrors | NoOpenFileErrorBox);
     if (noActivate) {
       LockSetForegroundWindow(LockForeground);
     }
@@ -360,6 +368,33 @@ function throughHelper(how, command, args, files, assembly = helperAssembly()) {
   };
 }
 
+// src/error-mode.ts
+import process3 from "node:process";
+var NO_FAULT_ERROR_BOX = 2;
+var cleared = process3.platform !== "win32";
+async function letWindowsReportCrashes() {
+  if (cleared || !("bun" in process3.versions)) {
+    return;
+  }
+  try {
+    const { dlopen, FFIType } = await import("bun:ffi");
+    const kernel32 = dlopen("kernel32.dll", {
+      GetErrorMode: { args: [], returns: FFIType.u32 },
+      SetErrorMode: { args: [FFIType.u32], returns: FFIType.u32 }
+    });
+    try {
+      const mode = kernel32.symbols.GetErrorMode();
+      kernel32.symbols.SetErrorMode(mode & ~NO_FAULT_ERROR_BOX);
+      cleared = true;
+    } finally {
+      kernel32.close();
+    }
+  } catch {}
+}
+function crashesReported() {
+  return cleared;
+}
+
 // src/game-debugger.ts
 import { createServer } from "node:net";
 
@@ -668,6 +703,8 @@ function readMessage(body) {
 // src/game-debugger.ts
 var PAUSE_MS = 30000;
 var STEP_MS = 1e4;
+var ADDON_STEP_MS = 5000;
+var RUNTIME_ADDON = "res://addons/gdharness_runtime/";
 var READ_MS = 5000;
 var REPLIES = new Set([
   "debug_enter",
@@ -1050,9 +1087,29 @@ class GameDebugger {
         };
       }
     }
+    let frames = await this.stack();
+    const stepping = Date.now();
+    while (frames !== null && this.held !== null && (frames[0]?.script.startsWith(RUNTIME_ADDON) ?? false) && Date.now() - stepping < ADDON_STEP_MS) {
+      this.forget("debug_enter");
+      this.send("step", [], this.held.thread);
+      if (await this.next(GameDebugger.named("debug_enter"), STEP_MS) === null) {
+        return {
+          paused: false,
+          note: `The game stopped in gdharness's runtime addon and was stepped on to reach its own script, and did not stop again within ${STEP_MS / 1000}s. It stops at the next line of script it runs; debug_state stack reads it then.`
+        };
+      }
+      frames = await this.stack();
+    }
     this.stoppedBy("Paused");
-    const frames = await this.stack();
-    return { paused: true, held: this.heldState(), stack: frames ?? [] };
+    const stack = frames ?? [];
+    return {
+      paused: true,
+      held: this.heldState(),
+      stack,
+      ...stack[0]?.script.startsWith(RUNTIME_ADDON) === true ? {
+        note: `The game is held in gdharness's runtime addon, whose _process runs first in every frame: ${ADDON_STEP_MS / 1000}s of stepping reached no line of the game's own script, so it runs none from frame to frame. A breakpoint in the game's script stops it there.`
+      } : {}
+    };
   }
   stoppedBy(cause) {
     if (this.held !== null) {
@@ -1073,7 +1130,7 @@ class GameDebugger {
       return await exited === null ? { refused: `The game did not say it had gone on within ${READ_MS / 1000}s.` } : { continued: true };
     }
     this.forget("debug_enter");
-    this.send(how, [], held.thread);
+    this.send(held.hasStack ? how : "step", [], held.thread);
     const entered = await this.next(GameDebugger.named("debug_enter"), STEP_MS);
     if (entered === null) {
       return {
@@ -1142,7 +1199,7 @@ import { mkdtempSync as mkdtempSync2, rmSync as rmSync2 } from "node:fs";
 import { connect, createServer as createServer2 } from "node:net";
 import { tmpdir as tmpdir2 } from "node:os";
 import { join as join2 } from "node:path";
-import process3 from "node:process";
+import process4 from "node:process";
 var DEBUG_PREFIX = "debug ";
 function endedOrWhyNot(end) {
   try {
@@ -1169,7 +1226,7 @@ function errorText(error) {
 async function listenForTheServer(end, debug) {
   let directory = null;
   try {
-    directory = process3.platform === "win32" ? null : mkdtempSync2(join2(tmpdir2(), "gdharness-keeper-"));
+    directory = process4.platform === "win32" ? null : mkdtempSync2(join2(tmpdir2(), "gdharness-keeper-"));
     const address = directory === null ? `\\\\.\\pipe\\gdharness-keeper-${randomUUID()}` : join2(directory, "keeper.sock");
     const server = createServer2((socket) => {
       socket.setEncoding("utf8");
@@ -1469,13 +1526,13 @@ function recordAt(path) {
 import { existsSync as existsSync2, mkdtempSync as mkdtempSync3, readdirSync as readdirSync2, rmSync as rmSync5 } from "node:fs";
 import { tmpdir as tmpdir4 } from "node:os";
 import { join as join6 } from "node:path";
-import process4 from "node:process";
+import process5 from "node:process";
 var SWEPT = { recursive: true, force: true };
 var AGAIN_AFTER_MS = [250, 500, 1000, 2000, 4000, 8000, 16000];
 var waiting = new Set;
 var atExit = new Set;
 function scratchDirectory(kind) {
-  return mkdtempSync3(join6(tmpdir4(), `gdharness-${kind}-${process4.pid}-`));
+  return mkdtempSync3(join6(tmpdir4(), `gdharness-${kind}-${process5.pid}-`));
 }
 function discardWith(remove, paths) {
   const left = [];
@@ -1533,7 +1590,7 @@ function lastTryOnExit() {
     return;
   }
   lastTryWatched = true;
-  process4.once("exit", () => {
+  process5.once("exit", () => {
     for (const path of [...waiting, ...atExit]) {
       try {
         remove(path);
@@ -1937,7 +1994,7 @@ async function startThroughHelper(spec, output, stopFile) {
   const scratch = scratchDirectory("desktop");
   const pidFile = join7(scratch, "pid");
   const errorFile = join7(scratch, "error");
-  const where = spec.desktop === undefined ? "without activation" : `on the ${spec.desktop} desktop`;
+  const where = spec.desktop !== undefined ? `on the ${spec.desktop} desktop` : spec.noActivate === true ? "without activation" : "through the desktop helper";
   try {
     const compiled = await ensureHelperCompiled();
     if (compiled !== null) {
@@ -2020,10 +2077,10 @@ async function startDetached(spec, output, hidden, stopFile = "") {
   return throughTheHelper(spec) ? await startThroughHelper(spec, output, stopFile) : await startDirectly(spec, output, hidden);
 }
 function throughTheHelper(spec) {
-  return process.platform === "win32" && (spec.desktop !== undefined || spec.noActivate === true);
+  return needsItsHelperKept(spec) || process.platform === "win32" && !crashesReported();
 }
 function needsItsHelperKept(spec) {
-  return throughTheHelper(spec);
+  return process.platform === "win32" && (spec.desktop !== undefined || spec.noActivate === true);
 }
 async function launch() {
   const spec = await receivedSpec();
@@ -2158,6 +2215,7 @@ async function keep() {
   }
   process.exit(0);
 }
+await letWindowsReportCrashes();
 var mode = process.argv[2];
 if (mode === "launch") {
   await launch();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gdharness",
-  "version": "1.3.5",
+  "version": "1.3.7",
   "mcpName": "io.github.Aureliolo/gdharness",
   "description": "A harness for driving a Godot 4 project from an agent: editor addons, a runtime bridge into the running game, an MCP server in front of them, and a CLI that installs and diagnoses the Godot side.",
   "type": "module",