gdharness 1.3.45 → 1.3.46

package/build/godot/addons/gdharness_runtime/runtime_paths.gd

@@ -503,7 +503,7 @@ static func can_read(holder: Variant, named: String) -> bool:
 		var object: Object = holder
 		if not method.is_empty():
 			return call_refused(object, method, "", args.size()).is_empty()
-		return _has_property(object, named)
+		return _has_property(object, named) or not constant_of(object, named).is_empty()
 	return false
 
 
@@ -876,7 +876,7 @@ static func read_under(holder: Variant, named: String) -> Variant:
 	if not method.is_empty():
 		var args: Array = arguments_of(named)["args"]
 		return object.callv(method, args)
-	return object.get(named)
+	return constant_of(object, named)[0] if is_constant(object, named) else object.get(named)
 
 
 ## Where [param named] lands in a list of [param size], or -1 for a step that is not in it.
@@ -1030,3 +1030,30 @@ static func _has_property(holder: Object, named: String) -> bool:
 		if str(entry["name"]) == named:
 			return true
 	return false
+
+
+## The constant [param named] that [param holder]'s script or a script it extends declares, in a
+## list of one, or an empty list. A constant is no property, so the property list never names it,
+## and `get` answers null for one.
+static func constant_of(holder: Variant, named: String) -> Array:
+	if not holder is Object:
+		return []
+	var object: Object = holder
+	var attached: Variant = object.get_script()
+	if not attached is Script:
+		return []
+	var script: Script = attached
+	while script != null:
+		var constants: Dictionary = script.get_script_constant_map()
+		if constants.has(named):
+			return [constants[named]]
+		script = script.get_base_script()
+	return []
+
+
+## Whether [param named] reaches a constant on [param holder] rather than a property.
+static func is_constant(holder: Variant, named: String) -> bool:
+	if not holder is Object:
+		return false
+	var object: Object = holder
+	return not _has_property(object, named) and not constant_of(object, named).is_empty()

package/build/godot/operations/animation_reads.gd

@@ -11,6 +11,11 @@ const LOOP_MODE_NAMES: Dictionary[int, String] = {
 	Animation.LOOP_LINEAR: "linear",
 	Animation.LOOP_PINGPONG: "pingpong",
 }
+const UPDATE_MODE_NAMES: Dictionary[int, String] = {
+	Animation.UPDATE_CONTINUOUS: "continuous",
+	Animation.UPDATE_DISCRETE: "discrete",
+	Animation.UPDATE_CAPTURE: "capture",
+}
 const TRACK_TYPE_NAMES: Dictionary[int, String] = {
 	Animation.TYPE_VALUE: "property",
 	Animation.TYPE_POSITION_3D: "position_3d",
@@ -166,6 +171,9 @@ static func _track(anim: Animation, track: int, values: GdhSerialisation) -> Dic
 	var property: String = str(path.get_concatenated_subnames())
 	if not property.is_empty():
 		shaped["property"] = property
+	if kind == Animation.TYPE_VALUE:
+		var mode: int = anim.value_track_get_update_mode(track)
+		shaped["update"] = UPDATE_MODE_NAMES.get(mode, str(mode))
 	var keyframes: Array[Dictionary] = []
 	var methods: Dictionary = {}
 	for key: int in anim.track_get_key_count(track):

package/build/godot/operations/editor_tools.gd

@@ -81,6 +81,8 @@ static func run(params: Dictionary) -> Dictionary:
 		var answered: Dictionary = answer
 		if not GdhSceneFile.also_saved.is_empty():
 			answered["alsoSaved"] = GdhSceneFile.also_saved.duplicate(true)
+		if not GdhSceneFile.unmade_note.is_empty():
+			answered["unmadeConnections"] = GdhSceneFile.unmade_note
 		if not GdhSceneUids.by_path.is_empty():
 			answered["namedByPath"] = (
 				(

package/build/godot/operations/patterns.gd

@@ -96,6 +96,11 @@ static func without_annotations(line: String) -> String:
 # brace opens before the `#` and closes on a later line. Held by a case, since the argument for the
 # difference is not visible from the code and reads like an oversight beside its neighbours.
 static func without_comment(line: String) -> String:
+	var start: int = _comment_start(line)
+	return (line if start == -1 else line.substr(0, start)).strip_edges()
+
+
+static func _comment_start(line: String) -> int:
 	var quote: String = ""
 	for i: int in range(line.length()):
 		var ch: String = line[i]
@@ -104,10 +109,30 @@ static func without_comment(line: String) -> String:
 				quote = ""
 			continue
 		if ch == "#":
-			return line.substr(0, i).strip_edges()
+			return i
 		if ch == '"' or ch == "'":
 			quote = ch
-	return line.strip_edges()
+	return -1
+
+
+## The code in front of each TODO or FIXME comment in [param content], one entry a comment.
+##
+## Read from the comments alone, as the editor highlights them, so `#TODO` counts and the same
+## words inside a string or a multi-line string do not.
+static func noted_work(content: String) -> Array[String]:
+	var noted: Array[String] = []
+	var in_string: bool = false
+	for line: String in content.split("\n"):
+		if in_string:
+			in_string = triple_quotes(line) % 2 == 0
+			continue
+		var start: int = _comment_start(line)
+		var code: String = line if start == -1 else line.substr(0, start)
+		if triple_quotes(code) % 2 == 1:
+			in_string = true
+		elif start != -1 and compiled("^#+\\s*(?:TODO|FIXME)\\b").search(line.substr(start)):
+			noted.append(code.strip_edges())
+	return noted
 
 
 ## How many triple quotes of either kind [param line] holds. An odd count opens or closes a string

package/build/godot/operations/project_diagnostics.gd

@@ -5,6 +5,7 @@ const GdhFileWalk = preload("file_walk.gd")
 const GdhImportPipeline = preload("import_pipeline.gd")
 const GdhInputActions = preload("input_actions.gd")
 const GdhLog = preload("logger.gd")
+const GdhPatterns = preload("patterns.gd")
 const GdhRead = preload("reading.gd")
 const GdhSceneConnections = preload("scene_connections.gd")
 const GdhScriptCheck = preload("script_check.gd")
@@ -87,7 +88,7 @@ func get_project_health(params: Dictionary) -> Dictionary:
 				var content: String = file.get_as_text()
 				file.close()
 
-				if "# TODO" in content or "# FIXME" in content:
+				if not GdhPatterns.noted_work(content).is_empty():
 					todo_count += 1
 
 		# Work noted for later, which no script fails on, so said rather than failed. A count of

package/build/godot/operations/project_validation.gd

@@ -8,6 +8,7 @@ const GdhFileWalk = preload("file_walk.gd")
 const GdhImportPipeline = preload("import_pipeline.gd")
 const GdhInputActions = preload("input_actions.gd")
 const GdhLog = preload("logger.gd")
+const GdhPatterns = preload("patterns.gd")
 const GdhRead = preload("reading.gd")
 const GdhSceneConnections = preload("scene_connections.gd")
 const GdhScriptCheck = preload("script_check.gd")
@@ -205,11 +206,12 @@ func validate_project(params: Dictionary) -> Dictionary:
 			var content: String = file.get_as_text()
 			file.close()
 
-			if "# TODO" in content or "# FIXME" in content:
+			var noted: Array[String] = GdhPatterns.noted_work(content)
+			if not noted.is_empty():
 				script_issues.append(
 					{ "path": script_path, "issue": "Contains TODO/FIXME comments" }
 				)
-			if "pass # TODO" in content:
+			if "pass" in noted:
 				script_issues.append(
 					{ "path": script_path, "issue": "Contains unimplemented functions" }
 				)

package/build/keeper.js

@@ -8895,6 +8895,7 @@ function frameEndLine() {
   return frameEnd;
 }
 var READ_MS = 5000;
+var EVALUATE_MS = 60000;
 var REPLIES = new Set([
   "debug_enter",
   "debug_exit",
@@ -9478,10 +9479,10 @@ class GameDebugger {
     }
     this.forget("evaluation_return");
     this.send("evaluate", [expression, frame], held.thread);
-    const answered = await this.next(GameDebugger.named("evaluation_return"), READ_MS);
+    const answered = await this.next(GameDebugger.named("evaluation_return"), EVALUATE_MS);
     if (answered === null || !("data" in answered)) {
       return {
-        refused: `The game worked out nothing for ${expression} within ${READ_MS / 1000}s. Ask again.`
+        refused: `The game worked out nothing for ${expression} within ${EVALUATE_MS / 1000}s. The first expression a game evaluates loads the script of every global class in the project first, static initialisers included, so one of those may still be running. Ask again.`
       };
     }
     const [, , type, value, hint] = answered.data;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gdharness",
-  "version": "1.3.45",
+  "version": "1.3.46",
   "mcpName": "io.github.Aureliolo/gdharness",
   "description": "A harness for driving a Godot 4 project from an agent: editor addons, a runtime bridge into the running game, an MCP server in front of them, and a CLI that installs and diagnoses the Godot side.",
   "type": "module",