gdharness 1.3.43 → 1.3.45

package/build/godot/operations/gdscript_analysis.gd

@@ -56,6 +56,25 @@ func get_gdscript_info(params: Dictionary) -> Dictionary:
 	# its first function would otherwise be judged against the default.
 	_mark_virtuals(functions, extends_name, full_script_path)
 
+	# The engine loads a base named by its path and a constant handed to load or preload as surely
+	# as a path written in the call, and both were left out while project_dependencies named them: a
+	# script extending "frame.gd" did not depend on it, nor one calling load(TYPE_CASE).
+	for written: String in _based_on_paths(extends_name, own.inner_classes):
+		if not written in dependencies:
+			dependencies.append(written)
+	var held: Dictionary = {}
+	for constant: Dictionary in own.constants:
+		held[str(constant.get("name", ""))] = _unquoted(str(constant.get("value", "")))
+	for code: String in GdhDependencies.code_by_line(content):
+		for loading: RegExMatch in (
+			GdhPatterns
+			. compiled("(?<![\\w.])(?:preload|load)\\s*\\(\\s*([A-Za-z_]\\w*)\\s*\\)")
+			. search_all(code)
+		):
+			var written: String = str(held.get(loading.get_string(1), ""))
+			if not written.is_empty() and not written in dependencies:
+				dependencies.append(written)
+
 	# A script typed by its class_name is depended on as surely as one preloaded, and the answer
 	# listed only the preloads: a `var stats: Stats` left stats.gd out, while project_dependencies
 	# named it. The same reading as that tool's, so the two agree.
@@ -131,7 +150,7 @@ func _members(
 		# Inside a string the raw line is counted, because a `#` in it is text and taking it for a
 		# comment would cut off the quotes that close the string.
 		if in_multiline_string:
-			if _triple_quotes(raw) % 2 == 1:
+			if GdhPatterns.triple_quotes(raw) % 2 == 1:
 				in_multiline_string = false
 			continue
 		# A `##` block documents what it sits directly above: the class when that is its class_name
@@ -165,7 +184,7 @@ func _members(
 		# it opened on. Toggling on any count lost `const HELP := """Usage"""`, and everything after
 		# it up to the next triple quote, with the state inverted from there to the end of the file.
 		# The line that opens one is still read: it can be the declaration the string belongs to.
-		if _triple_quotes(stripped) % 2 == 1:
+		if GdhPatterns.triple_quotes(stripped) % 2 == 1:
 			in_multiline_string = true
 
 		# Only a line at this body's own margin declares one of its members. Deeper, it is a
@@ -207,7 +226,7 @@ func _members(
 			while i + 1 < lines.size():
 				i += 1
 				stripped += "\n" + lines[i]
-				if _triple_quotes(lines[i]) % 2 == 1:
+				if GdhPatterns.triple_quotes(lines[i]) % 2 == 1:
 					break
 			in_multiline_string = false
 			header = GdhPatterns.without_annotations(stripped)
@@ -821,13 +840,31 @@ func _collect_dependencies(line: String, into: Array[String]) -> void:
 			into.append(dep)
 
 
-# How many triple quotes of either kind [param line] holds.
-static func _declares_variable(header: String) -> bool:
-	return header.begins_with("var ") or header.begins_with("static var ")
+## The paths a script and its inner classes extend by, as written: [param extends_name] the
+## script's own extends, and [param inner_classes] its inner classes as answered.
+static func _based_on_paths(extends_name: String, inner_classes: Array) -> Array[String]:
+	var paths: Array[String] = []
+	var written: String = _unquoted(extends_name)
+	if not written.is_empty():
+		paths.append(written)
+	for inner: Dictionary in inner_classes:
+		var deeper: Array = inner.get("inner_classes", [])
+		for path: String in _based_on_paths(str(inner.get("extends", "")), deeper):
+			if not path in paths:
+				paths.append(path)
+	return paths
+
+
+## The text of [param literal], a string literal as written; empty for anything else.
+static func _unquoted(literal: String) -> String:
+	var text: String = literal.strip_edges()
+	if text.length() >= 2 and text[0] in ["\"", "'"] and text[-1] == text[0]:
+		return text.substr(1, text.length() - 2)
+	return ""
 
 
-static func _triple_quotes(line: String) -> int:
-	return line.count('"""') + line.count("'''")
+static func _declares_variable(header: String) -> bool:
+	return header.begins_with("var ") or header.begins_with("static var ")
 
 
 func _extract_dependencies(line: String) -> Array[String]:

package/build/godot/operations/patterns.gd

@@ -108,3 +108,9 @@ static func without_comment(line: String) -> String:
 		if ch == '"' or ch == "'":
 			quote = ch
 	return line.strip_edges()
+
+
+## How many triple quotes of either kind [param line] holds. An odd count opens or closes a string
+## that runs across lines.
+static func triple_quotes(line: String) -> int:
+	return line.count('"""') + line.count("'''")

package/build/godot/operations/project_config.gd

@@ -387,8 +387,7 @@ func add_autoload(params: Dictionary) -> Dictionary:
 	var global: bool = GdhRead.as_bool(params.get("global", true), true)
 
 	# There is no disabled autoload in Godot 4: every entry in the list is loaded under the root at
-	# every start. `enabled: false` used to write the entry without its asterisk and answer that it
-	# was disabled, and the autoload ran all the same.
+	# every start. An entry without its asterisk is one whose name is not global, and it still runs.
 	if not GdhRead.as_bool(params.get("enabled", true), true):
 		return (
 			_log
@@ -433,12 +432,15 @@ func add_autoload(params: Dictionary) -> Dictionary:
 			"action": "unchanged",
 			"saved": false,
 		}
+	# The editor's Add replaces an entry of the same name too; said here, since the replaced script
+	# is no longer loaded and nothing else in the answer names it.
+	var held: String = str(ProjectSettings.get_setting(setting)) if was_updated else ""
 	ProjectSettings.set_setting(setting, entry)
 	var err: Error = GdhProjectFile.save([setting])
 	if err != OK:
 		return _log.failure("Failed to save project.godot: " + error_string(err))
 
-	return {
+	var answer: Dictionary = {
 		"name": name,
 		"path": path,
 		"enabled": true,
@@ -446,6 +448,9 @@ func add_autoload(params: Dictionary) -> Dictionary:
 		"action": "updated" if was_updated else "added",
 		"saved": true,
 	}
+	if was_updated:
+		answer["old_path"] = held.trim_prefix("*")
+	return answer
 
 
 ## Why [param name] cannot name an autoload, or empty when it can. The editor's Autoload tab refuses

package/build/godot/operations/project_validation.gd

@@ -196,9 +196,9 @@ func validate_project(params: Dictionary) -> Dictionary:
 	var scripts_checked: int = 0
 	var script_issues: Array[Dictionary] = []
 
-	# A hundred scripts is enough to say whether the project is tidy without a large one
-	# turning validation into a full read of its source tree.
-	for script_path: String in script_files.slice(0, 100):
+	# Every script, as health reads them: cut at the first hundred in walk order, the count sat
+	# beside a compile check of all 803 scripts of a game and read as how many were compiled.
+	for script_path: String in script_files:
 		scripts_checked += 1
 		var file: FileAccess = FileAccess.open(script_path, FileAccess.READ)
 		if file:
@@ -292,7 +292,6 @@ func validate_project(params: Dictionary) -> Dictionary:
 		"warnings": warnings,
 		"checks_performed": checks_performed,
 		"scripts_checked": scripts_checked,
-		# Said beside the count, so a project of four hundred scripts is not read as checked whole.
 		"scripts_total": script_files.size(),
 		"issue_count": issues.size(),
 		"warning_count": warnings.size(),

package/build/godot/operations/reading.gd

@@ -312,16 +312,25 @@ static func _bare(word: String) -> String:
 	return word.to_lower().replace("_", "").replace(" ", "")
 
 
-## The signals [param object] has that a caller can connect, its own class's first: the engine
-## lists them from Object down, which puts a Button's pressed after thirty a Control has, and names
-## starting with an underscore are the engine's own.
+## The signals [param object] has that a caller can connect, its own class's first: its script's,
+## as declared, then the engine's from the class down to Object. The engine lists its own from
+## Object down, which puts a Button's pressed after thirty a Control has, and its script's ahead of
+## those, so reversing the whole list put a game's own two signals after twenty-four of the
+## engine's. Names starting with an underscore are the engine's own.
 static func signals_of(object: Object) -> Array:
+	var declared: Array = []
+	var script: Script = object.get_script()
+	if script != null:
+		for entry: Dictionary in script.get_script_signal_list():
+			var name: String = str(entry["name"])
+			if not name.begins_with("_") and not name in declared:
+				declared.append(name)
 	var names: Array = []
 	for entry: Dictionary in object.get_signal_list():
 		var name: String = str(entry["name"])
-		if not name.begins_with("_"):
+		if not name.begins_with("_") and not name in declared:
 			names.push_front(name)
-	return names
+	return declared + names
 
 
 ## [param word] after the article it takes, "an AnimationTree" or "a Node2D".

package/build/godot/operations/setting_reads.gd

@@ -62,7 +62,7 @@ static func under(prefix: String, values: GdhSerialisation) -> Dictionary:
 		var value: Variant = ProjectSettings.get_setting(name)
 		var described: Dictionary = {
 			"setting": name,
-			"type": type_string(kind),
+			"type": type_named(kind, value),
 			"value": values.serialize_value(value),
 		}
 		# As a single get says it, so a family read can be told apart into what the project sets and
@@ -81,6 +81,47 @@ static func under(prefix: String, values: GdhSerialisation) -> Dictionary:
 	return { "prefix": prefix, "count": found.size(), "settings": found }
 
 
+## The type [param kind] names, with what [param value] holds when it is a typed array or
+## dictionary, as project.godot writes it: a `Dictionary[String, bool]` was answered as Dictionary,
+## which hides what its keys and values must be.
+static func type_named(kind: int, value: Variant) -> String:
+	if kind == TYPE_ARRAY and value is Array:
+		var list: Array = value
+		if list.is_typed():
+			var element: String = _held(
+				list.get_typed_builtin(), list.get_typed_class_name(), list.get_typed_script()
+			)
+			return "Array[%s]" % element
+	elif kind == TYPE_DICTIONARY and value is Dictionary:
+		var table: Dictionary = value
+		if table.is_typed():
+			var key: String = _held(
+				table.get_typed_key_builtin(),
+				table.get_typed_key_class_name(),
+				table.get_typed_key_script()
+			)
+			var held: String = _held(
+				table.get_typed_value_builtin(),
+				table.get_typed_value_class_name(),
+				table.get_typed_value_script()
+			)
+			return "Dictionary[%s, %s]" % [key, held]
+	return type_string(kind)
+
+
+## One side of a typed collection: a built-in type, a class, or a script by its class_name.
+static func _held(builtin: int, named: StringName, script: Variant) -> String:
+	if builtin == TYPE_NIL:
+		return "Variant"
+	if builtin != TYPE_OBJECT:
+		return type_string(builtin)
+	if script is Script:
+		var declared: Script = script
+		if not declared.get_global_name().is_empty():
+			return declared.get_global_name()
+	return str(named)
+
+
 ## The setting [param setting_path] overrides for builds with one feature, as
 ## `application/run/max_fps.mobile` does `application/run/max_fps`, or "" for a plain setting.
 static func override_base(setting_path: String) -> String:

package/build/keeper.js

@@ -6946,7 +6946,7 @@ var require_public_api = __commonJS(function(exports) {
 });
 
 // src/keeper.ts
-import { closeSync as closeSync2, existsSync as existsSync3, mkdtempSync as mkdtempSync4, openSync as openSync3, readFileSync as readFileSync6, rmSync as rmSync6, writeFileSync as writeFileSync3 } from "node:fs";
+import { closeSync as closeSync2, existsSync as existsSync3, mkdtempSync as mkdtempSync4, openSync as openSync3, readFileSync as readFileSync7, rmSync as rmSync6, writeFileSync as writeFileSync3 } from "node:fs";
 import { tmpdir as tmpdir5 } from "node:os";
 import { join as join10 } from "node:path";
 import { setTimeout as delay3 } from "node:timers/promises";
@@ -7435,7 +7435,7 @@ function crashesReported() {
 }
 
 // src/game-debugger.ts
-import { readFileSync as readFileSync4 } from "node:fs";
+import { readFileSync as readFileSync5 } from "node:fs";
 import { createServer } from "node:net";
 import { join as join6 } from "node:path";
 
@@ -7802,6 +7802,36 @@ var KEYWORDS = new Set([
   "TAU"
 ]);
 
+// src/whole-file.ts
+import { readFileSync as readFileSync2, renameSync, rmSync as rmSync2, writeFileSync as writeFileSync2 } from "node:fs";
+var HELD_FILE_MS = 1000;
+var HELD_FILE_RETRY_MS = 10;
+var HELD_BY_A_READER = new Set(["EPERM", "EACCES", "EBUSY"]);
+function writeWhole(path, text) {
+  const partial = `${path}.${process.pid}.partial`;
+  try {
+    writeFileSync2(partial, text, "utf8");
+  } catch {
+    return false;
+  }
+  const until = Date.now() + HELD_FILE_MS;
+  for (;; ) {
+    try {
+      renameSync(partial, path);
+      return true;
+    } catch (error) {
+      const code = error.code ?? "";
+      if (!HELD_BY_A_READER.has(code) || Date.now() >= until) {
+        try {
+          rmSync2(partial, { force: true });
+        } catch {}
+        return false;
+      }
+      Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, HELD_FILE_RETRY_MS);
+    }
+  }
+}
+
 // src/dictionary.ts
 function emptyRecord() {
   return Object.create(null);
@@ -8399,14 +8429,14 @@ var MEMORY_KEPT = 4 * 1024 ** 3;
 var MEMORY_PER_ENGINE = 1.5 * 1024 ** 3;
 
 // src/process-children.ts
-import { readFileSync as readFileSync2 } from "node:fs";
+import { readFileSync as readFileSync3 } from "node:fs";
 import { basename as basename3 } from "node:path";
 async function linuxStartTimes(pids) {
   const began = new Map;
   const hertz = await ticksPerSecond();
   let booted;
   try {
-    booted = Number(/^btime\s+(\d+)$/m.exec(readFileSync2("/proc/stat", "utf8"))?.[1] ?? Number.NaN) * 1000;
+    booted = Number(/^btime\s+(\d+)$/m.exec(readFileSync3("/proc/stat", "utf8"))?.[1] ?? Number.NaN) * 1000;
   } catch {
     return began;
   }
@@ -8416,7 +8446,7 @@ async function linuxStartTimes(pids) {
   for (const pid of pids) {
     let stat;
     try {
-      stat = readFileSync2(`/proc/${String(pid)}/stat`, "utf8");
+      stat = readFileSync3(`/proc/${String(pid)}/stat`, "utf8");
     } catch {
       continue;
     }
@@ -8516,36 +8546,6 @@ function commandWords(command) {
   return words;
 }
 
-// src/whole-file.ts
-import { renameSync, rmSync as rmSync2, writeFileSync as writeFileSync2 } from "node:fs";
-var HELD_FILE_MS = 1000;
-var HELD_FILE_RETRY_MS = 10;
-var HELD_BY_A_READER = new Set(["EPERM", "EACCES", "EBUSY"]);
-function writeWhole(path, text) {
-  const partial = `${path}.${process.pid}.partial`;
-  try {
-    writeFileSync2(partial, text, "utf8");
-  } catch {
-    return false;
-  }
-  const until = Date.now() + HELD_FILE_MS;
-  for (;; ) {
-    try {
-      renameSync(partial, path);
-      return true;
-    } catch (error) {
-      const code = error.code ?? "";
-      if (!HELD_BY_A_READER.has(code) || Date.now() >= until) {
-        try {
-          rmSync2(partial, { force: true });
-        } catch {}
-        return false;
-      }
-      Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, HELD_FILE_RETRY_MS);
-    }
-  }
-}
-
 // src/game-log.ts
 var COLOUR_CODE = new RegExp(`${String.fromCharCode(27)}\\[[0-9;]*m`, "g");
 var ADMITTED = {
@@ -8847,7 +8847,7 @@ function parseIniLikeValue(value) {
 }
 
 // src/server-version.ts
-import { readFileSync as readFileSync3 } from "node:fs";
+import { readFileSync as readFileSync4 } from "node:fs";
 
 // src/update-check.ts
 var CACHE_MS = 10 * 60 * 1000;
@@ -8858,7 +8858,7 @@ var MAX_RETRY_MS = 60 * 60 * 1000;
 var DEBUG_MODE = process.env["GDHARNESS_DEBUG"] === "1";
 var SERVER_VERSION = (() => {
   try {
-    const pkg = JSON.parse(readFileSync3(new URL("../package.json", import.meta.url), "utf8"));
+    const pkg = JSON.parse(readFileSync4(new URL("../package.json", import.meta.url), "utf8"));
     return typeof pkg.version === "string" ? pkg.version : "0.0.0";
   } catch {
     return "0.0.0";
@@ -8884,7 +8884,7 @@ var RUNTIME_AUTOLOAD2 = `${RUNTIME_ADDON}runtime_autoload.gd`;
 var frameEnd = null;
 function frameEndLine() {
   if (frameEnd === null) {
-    const lines = readFileSync4(join6(shippedAddonsDirectory(), "gdharness_runtime", "runtime_autoload.gd"), "utf8").split(`
+    const lines = readFileSync5(join6(shippedAddonsDirectory(), "gdharness_runtime", "runtime_autoload.gd"), "utf8").split(`
 `);
     const declared = lines.findIndex((line) => line.startsWith("func _notification("));
     if (declared === -1) {
@@ -9642,7 +9642,7 @@ function readLaunched(printed) {
 
 // src/run-record.ts
 import { createHash as createHash2 } from "node:crypto";
-import { mkdirSync, openSync as openSync2, readdirSync as readdirSync2, readFileSync as readFileSync5, rmSync as rmSync5, statSync as statSync3 } from "node:fs";
+import { mkdirSync, openSync as openSync2, readdirSync as readdirSync2, readFileSync as readFileSync6, rmSync as rmSync5, statSync as statSync3 } from "node:fs";
 import { basename as basename4, join as join9, resolve as resolve4 } from "node:path";
 
 // src/runtime-client.ts
@@ -9738,7 +9738,7 @@ function recordRunEnded(projectPath, pid, ending) {
 function recordAt(path) {
   let parsed;
   try {
-    parsed = JSON.parse(readFileSync5(path, "utf8"));
+    parsed = JSON.parse(readFileSync6(path, "utf8"));
   } catch {
     return null;
   }
@@ -10186,7 +10186,7 @@ async function startThroughHelper(spec, output, stopFile) {
       exited.now = true;
     });
     for (let waited = 0;waited < DESKTOP_START_MS; waited += 50) {
-      const pid = existsSync3(pidFile) ? Number(readFileSync6(pidFile, "utf8").trim()) : Number.NaN;
+      const pid = existsSync3(pidFile) ? Number(readFileSync7(pidFile, "utf8").trim()) : Number.NaN;
       if (Number.isInteger(pid) && pid > 0) {
         return { child: started.child, pid };
       }
@@ -10217,7 +10217,7 @@ function profiledBy(path, projectPath) {
   };
   let projectGodot = null;
   try {
-    projectGodot = readFileSync6(join10(projectPath, "project.godot"), "utf8");
+    projectGodot = readFileSync7(join10(projectPath, "project.godot"), "utf8");
   } catch {}
   const observer = new ProfileObserver((totals) => {
     const first = latest === null;
@@ -10456,7 +10456,7 @@ function restartSaid(notes, pid) {
     return null;
   }
   try {
-    const said = JSON.parse(readFileSync6(join10(notes, `exit-${String(pid)}.json`), "utf8"));
+    const said = JSON.parse(readFileSync7(join10(notes, `exit-${String(pid)}.json`), "utf8"));
     return typeof said === "object" && said !== null && "restart" in said && typeof said.restart === "boolean" ? said.restart : null;
   } catch {
     return null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gdharness",
-  "version": "1.3.43",
+  "version": "1.3.45",
   "mcpName": "io.github.Aureliolo/gdharness",
   "description": "A harness for driving a Godot 4 project from an agent: editor addons, a runtime bridge into the running game, an MCP server in front of them, and a CLI that installs and diagnoses the Godot side.",
   "type": "module",