gdharness 1.3.35 → 1.3.37

package/build/godot/operations/input_actions.gd

@@ -3,6 +3,17 @@ extends RefCounted
 const GdhRead = preload("reading.gd")
 const GdhLog = preload("logger.gd")
 const GdhProjectFile = preload("project_file.gd")
+const GdhPatterns = preload("patterns.gd")
+const GdhFileWalk = preload("file_walk.gd")
+## The calls that read an input action by name, Input's and an event's, up to the opening bracket.
+const READS_AN_ACTION: String = (
+	"\\b(?:is_action(?:_just)?_(?:pressed|released)|is_action|get_action(?:_raw)?_strength"
+	+ "|action_press|action_release|get_axis|get_vector)\\("
+)
+## InputMap's call that makes an action at run time, which a script then reads as its own.
+const ADDS_AN_ACTION: String = "\\badd_action\\("
+## An argument that is a name written in the call and nothing else, a String or a StringName.
+const NAME_ARGUMENT: String = "^&?(?:\"([^\"\\\\]*)\"|'([^'\\\\]*)')$"
 ## The device an event matches every device with, InputMap's ALL_DEVICES, which GDScript is not given.
 const ALL_DEVICES: int = -1
 const MOUSE_NAMES: String = (
@@ -113,6 +124,100 @@ func _init(p_log: GdhLog) -> void:
 	_log = p_log
 
 
+## The input actions the project's scripts read by a name written in the call that neither the
+## project nor the engine defines, each as {action, read_at} with the script and line of every read.
+## Godot answers such a read with false and an error on every frame, so the input never works and
+## nothing fails until the game runs. A name a script builds is not judged, and one a script adds
+## with InputMap.add_action is its own to define.
+func undefined_in_scripts() -> Array[Dictionary]:
+	var read: Dictionary = {}
+	var added: Dictionary = {}
+	for script: String in GdhFileWalk.new().find_files("res://", ".gd"):
+		var number: int = 0
+		for line: String in FileAccess.get_file_as_string(script).split("\n"):
+			number += 1
+			var code: String = GdhPatterns.without_comment(line)
+			for adding: RegExMatch in GdhPatterns.compiled(ADDS_AN_ACTION).search_all(code):
+				if not _in_a_string(code, adding.get_start()):
+					for name: String in _names_given(code, adding.get_end()):
+						added[name] = true
+			for reading: RegExMatch in GdhPatterns.compiled(READS_AN_ACTION).search_all(code):
+				if _in_a_string(code, reading.get_start()):
+					continue
+				for name: String in _names_given(code, reading.get_end()):
+					var at: Array = read.get_or_add(name, [])
+					var place: String = "%s:%d" % [script, number]
+					if not place in at:
+						at.append(place)
+	var names: Array = read.keys()
+	names.sort()
+	var undefined: Array[Dictionary] = []
+	for name: String in names:
+		if ProjectSettings.has_setting("input/" + name) or added.has(name):
+			continue
+		undefined.append({"action": name, "read_at": read[name]})
+	return undefined
+
+
+## One line for [param entry], one of [method undefined_in_scripts].
+static func undefined_line(entry: Dictionary) -> String:
+	var listed: Array = entry.get("read_at", [])
+	var at: PackedStringArray = PackedStringArray(listed)
+	return (
+		"%s is not an input action of this project, and %s %s it"
+		% [str(entry.get("action", "")), ", ".join(at), "reads" if at.size() == 1 else "read"]
+	)
+
+
+## The arguments of the call whose bracket opens before [param from] in [param code] that are each a
+## name written in the call, to its closing bracket or the end of the line.
+static func _names_given(code: String, from: int) -> Array[String]:
+	var names: Array[String] = []
+	var depth: int = 0
+	var quote: String = ""
+	var argument: String = ""
+	for at: int in range(from, code.length()):
+		var ch: String = code[at]
+		if not quote.is_empty():
+			if ch == quote and code[at - 1] != "\\":
+				quote = ""
+		elif ch == '"' or ch == "'":
+			quote = ch
+		elif ch == "(" or ch == "[" or ch == "{":
+			depth += 1
+		elif ch == ")" or ch == "]" or ch == "}":
+			if depth == 0:
+				_take_name(argument, names)
+				return names
+			depth -= 1
+		elif ch == "," and depth == 0:
+			_take_name(argument, names)
+			argument = ""
+			continue
+		argument += ch
+	return names
+
+
+## Whether [param at] in [param code] is inside a string literal, where a call is text rather than one.
+static func _in_a_string(code: String, at: int) -> bool:
+	var quote: String = ""
+	for index: int in range(at):
+		var ch: String = code[index]
+		if not quote.is_empty():
+			if ch == quote and code[index - 1] != "\\":
+				quote = ""
+		elif ch == '"' or ch == "'":
+			quote = ch
+	return not quote.is_empty()
+
+
+static func _take_name(argument: String, names: Array[String]) -> void:
+	var named: RegExMatch = GdhPatterns.compiled(NAME_ARGUMENT).search(argument.strip_edges())
+	if named != null:
+		var single: String = named.get_string(2)
+		names.append(named.get_string(1) if single.is_empty() else single)
+
+
 # Add an input action to the InputMap
 func add_input_action(params: Dictionary) -> Dictionary:
 	var action_name: String = str(params.get("action_name", ""))

package/build/godot/operations/project_diagnostics.gd

@@ -3,6 +3,7 @@ extends RefCounted
 const GdhDependencies = preload("dependencies.gd")
 const GdhFileWalk = preload("file_walk.gd")
 const GdhImportPipeline = preload("import_pipeline.gd")
+const GdhInputActions = preload("input_actions.gd")
 const GdhLog = preload("logger.gd")
 const GdhRead = preload("reading.gd")
 const GdhSceneConnections = preload("scene_connections.gd")
@@ -119,6 +120,9 @@ func get_project_health(params: Dictionary) -> Dictionary:
 		for entry: Dictionary in GdhDependencies.new(_log).missing_references():
 			details.append(GdhDependencies.missing_line(entry))
 			deductions += 5
+		for entry: Dictionary in GdhInputActions.new(_log).undefined_in_scripts():
+			details.append(GdhInputActions.undefined_line(entry))
+			deductions += 5
 		checks["references"] = {"name": "References", "passed": details.is_empty(), "details": details}
 
 	# 4. Scenes Check

package/build/godot/operations/project_validation.gd

@@ -7,6 +7,7 @@ const GdhDependencies = preload("dependencies.gd")
 const GdhExportPresets = preload("export_presets.gd")
 const GdhFileWalk = preload("file_walk.gd")
 const GdhImportPipeline = preload("import_pipeline.gd")
+const GdhInputActions = preload("input_actions.gd")
 const GdhLog = preload("logger.gd")
 const GdhRead = preload("reading.gd")
 const GdhSceneConnections = preload("scene_connections.gd")
@@ -219,6 +220,20 @@ func validate_project(params: Dictionary) -> Dictionary:
 			)
 		)
 
+	# An action read by a name the input map lacks answers false on every frame, so the input it was
+	# for never works, and the engine says so only while the game runs.
+	checks_performed.append("input_actions")
+	for entry: Dictionary in GdhInputActions.new(_log).undefined_in_scripts():
+		issues.append(
+			_finding(
+				"error",
+				"input_actions",
+				GdhInputActions.undefined_line(entry),
+				"Add it with project_settings add_input_action, or correct the name the script reads",
+				include_suggestions
+			)
+		)
+
 	# A connection whose method or signal is not there loads without a word and fails only once the
 	# game runs, on every emission or not at all; the references check sees files, not members.
 	checks_performed.append("connections")

package/build/godot/operations/reading.gd

@@ -215,7 +215,8 @@ static func offered(said: String, word: String, names: Array) -> String:
 ## [param said], the refusal for [param property], which [param target] does not declare, with the
 ## names it declares nearest it when any are, as a misspelt one is usually one of them, or else the
 ## variables its script declares. The engine's own are not listed when none is near, since an object
-## has a hundred, while a script's are the few a caller most likely meant.
+## has a hundred, while a script's are the few a caller most likely meant; an object with no script
+## is told where they are listed instead, since the refusal alone left nothing to try.
 static func near_property(said: String, target: Object, property: String) -> String:
 	var headings: int = PROPERTY_USAGE_CATEGORY | PROPERTY_USAGE_GROUP | PROPERTY_USAGE_SUBGROUP
 	var names: Array[String] = []
@@ -233,8 +234,15 @@ static func near_property(said: String, target: Object, property: String) -> Str
 	var close: PackedStringArray = nearest(property, PackedStringArray(names))
 	if not close.is_empty():
 		return "%s; the nearest it has %s %s" % [said, "is" if close.size() == 1 else "are", ", ".join(close)]
-	if scripted.is_empty():
+	# With a script that declares nothing readable, as one that does not compile, the name is likelier
+	# the script's than the class's, so the class's list would point the wrong way.
+	if scripted.is_empty() and target.get_script() != null:
 		return said
+	if scripted.is_empty():
+		return (
+			"%s; editor_classes info with className %s and includeInherited true lists the ones it has"
+			% [said, target.get_class()]
+		)
 	scripted.sort()
 	return "%s; its script declares %s" % [said, ", ".join(PackedStringArray(scripted))]
 

package/build/keeper.js

@@ -9190,7 +9190,7 @@ class GameDebugger {
       case "stack": {
         const frames = await this.stack();
         if (frames === null) {
-          return this.notHeld();
+          return this.notHeld("stack to read");
         }
         return {
           held: this.heldState(),
@@ -9218,9 +9218,9 @@ class GameDebugger {
       ...this.held.canContinue ? {} : { canContinue: false }
     };
   }
-  notHeld() {
+  notHeld(what) {
     return {
-      refused: "The game is running, not held, so it has no stack to read: debug_control pause stops it where it is, and a breakpoint stops it on its line."
+      refused: `The game is running, not held, so it has no ${what}: debug_control pause stops it where it is, and a breakpoint stops it on its line.`
     };
   }
   async stack() {
@@ -9384,7 +9384,7 @@ class GameDebugger {
   async variables(frame) {
     const held = this.held;
     if (held === null) {
-      return this.notHeld();
+      return this.notHeld("frame whose variables could be read");
     }
     const frames = await this.stack();
     if (frames === null) {
@@ -9431,7 +9431,7 @@ class GameDebugger {
   async evaluate(frame, expression) {
     const held = this.held;
     if (held === null) {
-      return this.notHeld();
+      return this.notHeld("frame to work an expression out in");
     }
     const read = await this.variables(frame);
     if (!Array.isArray(read["scopes"])) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gdharness",
-  "version": "1.3.35",
+  "version": "1.3.37",
   "mcpName": "io.github.Aureliolo/gdharness",
   "description": "A harness for driving a Godot 4 project from an agent: editor addons, a runtime bridge into the running game, an MCP server in front of them, and a CLI that installs and diagnoses the Godot side.",
   "type": "module",