gdharness 1.3.19 → 1.3.21

package/build/cli.js

@@ -48378,14 +48378,14 @@ var init_suites_scene = __esm(() => {
 });
 
 // src/test-selection.ts
-import { existsSync as existsSync33, readFileSync as readFileSync36 } from "node:fs";
+import { existsSync as existsSync33 } from "node:fs";
 import { basename as basename12, join as join42 } from "node:path";
-function casesIn(projectPath, suite) {
-  const text = readFileSync36(join42(projectPath, suite.slice("res://".length)), "utf8");
-  return [...text.matchAll(/^func\s+(test_\w*)\s*\(/gm)].map((match) => match[1] ?? "");
+function casesIn(scripts, suite) {
+  return scripts.suite(suite)?.cases ?? scripts.script(suite)?.funcs.filter((name) => name.startsWith("test_")) ?? [];
 }
 function scriptsWithoutCases(projectPath, asked) {
-  return asked.filter((path) => path.endsWith(".gd") && existsSync33(join42(projectPath, path.slice("res://".length))) && casesIn(projectPath, path).length === 0);
+  const scripts = new ProjectScripts(projectPath);
+  return asked.filter((path) => path.endsWith(".gd") && existsSync33(join42(projectPath, path.slice("res://".length))) && casesIn(scripts, path).length === 0);
 }
 function suitesUnder(projectPath, asked) {
   const scripts = projectFiles(projectPath, [".gd"]).map((path) => `res://${path}`);
@@ -48401,7 +48401,8 @@ function selectTests(projectPath, asked, given) {
   if (entries.length === 0) {
     return { ok: false, reason: "tests is an empty list: name a case, or leave tests out to run every one." };
   }
-  const declared = suitesUnder(projectPath, asked).flatMap((suite) => casesIn(projectPath, suite).map((test) => ({ suite, test })));
+  const scripts = new ProjectScripts(projectPath);
+  const declared = suitesUnder(projectPath, asked).flatMap((suite) => casesIn(scripts, suite).map((test) => ({ suite, test })));
   const nameOf = (suite) => basename12(suite, ".gd");
   const selected = [];
   for (const [index, entry] of entries.entries()) {
@@ -48442,6 +48443,7 @@ function selectTests(projectPath, asked, given) {
 }
 var init_test_selection = __esm(() => {
   init_project_scan();
+  init_suite_plan();
 });
 
 // src/server.ts
@@ -48456,7 +48458,7 @@ import {
   mkdirSync as mkdirSync23,
   openSync as openSync6,
   readdirSync as readdirSync19,
-  readFileSync as readFileSync37,
+  readFileSync as readFileSync36,
   readSync as readSync3,
   realpathSync as realpathSync5,
   rmdirSync as rmdirSync2,
@@ -48477,9 +48479,9 @@ function greetingWaitMs() {
   return waitFromEnv("GDHARNESS_GREETING_WAIT_MS", 1e4);
 }
 function pictureToSend(pngPath, jpegPath) {
-  const png = readFileSync37(pngPath);
+  const png = readFileSync36(pngPath);
   const beside = pngPath.replace(/\.png$/, ".jpg");
-  const jpeg = jpegPath !== undefined && normalize2(jpegPath) === normalize2(beside) && existsSync34(beside) ? readFileSync37(beside) : null;
+  const jpeg = jpegPath !== undefined && normalize2(jpegPath) === normalize2(beside) && existsSync34(beside) ? readFileSync36(beside) : null;
   const sent = jpeg !== null && jpeg.length < png.length ? jpeg : png;
   return {
     data: sent.toString("base64"),
@@ -48958,7 +48960,7 @@ function endedToStartThis(ended) {
   return ` ${which} was ended to start this one; its output is no longer what editor_output answers about.`;
 }
 function lineNothingStopsOn(absolutePath, relativePath, line) {
-  const text = readFileSync37(absolutePath, "utf8");
+  const text = readFileSync36(absolutePath, "utf8");
   const lines = text === "" ? 0 : text.split(`
 `).length - (text.endsWith(`
 `) ? 1 : 0);
@@ -49169,7 +49171,7 @@ function notRunNote(notRun, failFast) {
 function presetsIn(projectPath) {
   let text;
   try {
-    text = readFileSync37(join43(projectPath, "export_presets.cfg"), "utf8");
+    text = readFileSync36(join43(projectPath, "export_presets.cfg"), "utf8");
   } catch {
     return null;
   }
@@ -49319,7 +49321,7 @@ function rewriteBusNamed(projectPath, from, to) {
   const rewritten = [];
   for (const file of projectFiles(projectPath, [".tscn", ".tres"])) {
     const absolute = join43(projectPath, file);
-    const lines = readFileSync37(absolute, "utf8").split(`
+    const lines = readFileSync36(absolute, "utf8").split(`
 `);
     const at = [];
     const after = lines.map((line, index) => {
@@ -49338,7 +49340,7 @@ function rewriteBusNamed(projectPath, from, to) {
   }
   const namedInScripts = [];
   for (const file of projectFiles(projectPath, [".gd"])) {
-    readFileSync37(join43(projectPath, file), "utf8").split(`
+    readFileSync36(join43(projectPath, file), "utf8").split(`
 `).forEach((line, index) => {
       if (line.includes(`"${from}"`)) {
         namedInScripts.push({ file: `res://${file}`, line: index + 1, text: line.trim() });
@@ -49613,7 +49615,7 @@ function profileFrameFunctions(projectPath) {
   let projectGodot = null;
   if (projectPath !== null) {
     try {
-      projectGodot = readFileSync37(join43(projectPath, "project.godot"), "utf8");
+      projectGodot = readFileSync36(join43(projectPath, "project.godot"), "utf8");
     } catch {}
   }
   return frameFunctionsFor(queuedMessagesOf(projectGodot));
@@ -49637,7 +49639,7 @@ function projectSourceOf(projectPath) {
       let source = null;
       if (inside.ok) {
         try {
-          source = readFileSync37(inside.absolutePath, "utf8");
+          source = readFileSync36(inside.absolutePath, "utf8");
         } catch {}
       }
       read.set(script, source);
@@ -49796,7 +49798,7 @@ function foldedEntriesAnswer(log, floor = "warning") {
 }
 function gdUnitFailsOnScriptErrors(projectPath) {
   try {
-    return settingKeys(readFileSync37(join43(projectPath, "project.godot"), "utf8")).get("gdunit4/report/godot/script_error") !== false;
+    return settingKeys(readFileSync36(join43(projectPath, "project.godot"), "utf8")).get("gdunit4/report/godot/script_error") !== false;
   } catch {
     return true;
   }
@@ -49924,11 +49926,11 @@ function isDirectory(path) {
   }
 }
 function mainSceneOf(projectFile) {
-  const scene = parseProjectGodot(readFileSync37(projectFile, "utf8"))["application"]?.["run/main_scene"];
+  const scene = parseProjectGodot(readFileSync36(projectFile, "utf8"))["application"]?.["run/main_scene"];
   return typeof scene === "string" && scene !== "" ? scene : null;
 }
 function editorPlaysHeadless(projectFile) {
-  const runArgs = parseProjectGodot(readFileSync37(projectFile, "utf8"))["editor"]?.["run/main_run_args"];
+  const runArgs = parseProjectGodot(readFileSync36(projectFile, "utf8"))["editor"]?.["run/main_run_args"];
   return typeof runArgs === "string" && /(?:^|\s)--headless(?:\s|$)/.test(runArgs);
 }
 function ownArguments(params) {
@@ -51823,7 +51825,7 @@ class GodotServer {
     if (!engine.ok) {
       return engine.response;
     }
-    const application = parseProjectGodot(readFileSync37(project.value.file, "utf8"))["application"] ?? {};
+    const application = parseProjectGodot(readFileSync36(project.value.file, "utf8"))["application"] ?? {};
     const name = application["config/name"];
     const mainScene = application["run/main_scene"];
     const info = {
@@ -52343,13 +52345,13 @@ ${platform}`;
     const reportsDir = join43(project.value.path, ".godot", ...ours.split("/"));
     let report = null;
     let reportProblem = null;
-    const casePrinted = withNestedErrors(readRun(existsSync34(engineLog) ? readFileSync37(engineLog, "utf8") : ""), run.log.all);
+    const casePrinted = withNestedErrors(readRun(existsSync34(engineLog) ? readFileSync36(engineLog, "utf8") : ""), run.log.all);
     const declaredErrors = readExpected(expectedFile);
     try {
       const written = existsSync34(reportsDir) && notCompiled === null ? readdirSync19(reportsDir).filter((name) => name.startsWith("report_")).sort((a, b) => Number(a.slice("report_".length)) - Number(b.slice("report_".length))) : [];
       const newest = written.at(-1);
       if (newest !== undefined) {
-        report = parseJUnit(readFileSync37(join43(reportsDir, newest, "results.xml"), "utf8"));
+        report = parseJUnit(readFileSync36(join43(reportsDir, newest, "results.xml"), "utf8"));
       }
     } catch (error) {
       reportProblem = errorMessage(error);
@@ -52828,7 +52830,7 @@ ${error.text}`;
         return null;
       }
       try {
-        return readFileSync37(contained.absolutePath, "utf8");
+        return readFileSync36(contained.absolutePath, "utf8");
       } catch {
         return null;
       }
@@ -52922,7 +52924,7 @@ ${error.text}`;
       return null;
     }
     try {
-      return readFileSync37(contained.absolutePath, "utf8");
+      return readFileSync36(contained.absolutePath, "utf8");
     } catch {
       return null;
     }
@@ -53425,7 +53427,7 @@ ${error.text}`;
       return null;
     }
     try {
-      return settingKeys(readFileSync37(join43(projectPath, "project.godot"), "utf8"));
+      return settingKeys(readFileSync36(join43(projectPath, "project.godot"), "utf8"));
     } catch {
       return null;
     }
@@ -54205,7 +54207,7 @@ ${error.text}`;
       return 0;
     }
     try {
-      return reportAlreadyInTranscript(readFileSync37(game.transcript), readFileSync37(report));
+      return reportAlreadyInTranscript(readFileSync36(game.transcript), readFileSync36(report));
     } catch (error) {
       this.logDebug(`Could not compare a picked-up run's report with its transcript: ${errorMessage(error)}`);
       return 0;
@@ -56538,7 +56540,7 @@ ${error.text}`;
     }
     const escaped = symbol.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
     const declared = new RegExp(`^\\s*(?:@\\w+(?:\\([^)]*\\))?\\s+)*class_name\\s+${escaped}\\b`, "m");
-    if (declared.test(readFileSync37(scriptPath, "utf8"))) {
+    if (declared.test(readFileSync36(scriptPath, "utf8"))) {
       return null;
     }
     const checked = await this.classesTheEditorCannotSee(args);
@@ -57454,7 +57456,7 @@ metadata:
 
 # gdharness
 
-An MCP server and three Godot addons. Together they answer about the editor that is open, the game
+An MCP server and four Godot addons. Together they answer about the editor that is open, the game
 that is running, and the project on disk. ${TOOL_SPECS.length} tools, named \`domain_verb\`.
 
 \`references/tools.md\` is every tool, op and argument.
@@ -59124,6 +59126,9 @@ async function upgrade() {
   const digestBefore = installedEditorDigest(projectPath);
   for (const addon of installAddons(projectPath)) {
     console.log(`${addon.replaced ? "replaced" : "installed"} ${addon.path}`);
+    if (!addon.replaced) {
+      console.log(`  addons/${addon.name}/ is new to this project: a .gitignore entry or export filter naming gdharness's addons one by one has to name it too`);
+    }
   }
   const enabled = await enablePlugins(godot, projectPath, EDITOR_PLUGINS);
   for (const [index, outcome] of enabled.entries()) {

package/build/godot/tests/listed.gd

@@ -80,6 +80,11 @@ class GdhRunner:
 	var together: GDScript = null
 	## The cases dealt by their rows, by `res://suite.gd:test_case`.
 	var row_shares: Dictionary[String, GdhRowShare] = {}
+	## The cases to leave out, by `res://suite.gd:test_case` of the suite running them. gdUnit4's own
+	## list is matched against the script declaring a case, which for a case a suite inherits is its
+	## base, so an inherited case left out under its suite ran in every engine the suite was dealt to,
+	## and a case of `res://tests/a_test.gd` was also left out of `res://more/tests/a_test.gd`.
+	var left_out: Dictionary[String, bool] = {}
 	## The cases gdUnit4 said it finished, which [GdhSessionCheck] holds the session's lookups against.
 	var cases_ended: int = 0
 	## The marker of the shutdown walk's oldest end, made as the run starts.
@@ -106,10 +111,40 @@ class GdhRunner:
 			return options
 		return options_of(OS.get_cmdline_args(), own_path)
 
+	## gdUnit4's own discovery, with each case filed under the suite it was found in before it is
+	## asked whether to leave the case out. gdUnit4 files a case under the script declaring it, which
+	## for a case a suite inherits is its base: its reports added such a case to no suite, so
+	## project_test counted none of them, and a parameterised one ran as a suite of the base's own,
+	## outside the suite inheriting it and its hooks, and was judged a case that suite never ran.
+	func discover_tests() -> Array[GdUnitTestCase]:
+		var added: Signal = GdUnitSignals.instance().gdunit_test_discover_added
+		_test_cases = _runner_config.test_cases()
+		var scanner: GdUnitTestSuiteScanner = GdUnitTestSuiteScanner.new()
+		for path: String in _included_tests:
+			for script: Script in scanner.scan(path):
+				var suite: String = script.resource_path
+				var found: Callable = func(test: GdUnitTestCase) -> void:
+					filed_under(test, suite)
+					if not is_skipped(test):
+						_test_cases.append(test)
+						added.emit(test)
+				GdUnitTestDiscoverer.discover_tests(script, found)
+		return _test_cases
+
+	## [param test] as a case of the suite at [param suite], under which gdUnit4 groups, reports and
+	## leaves out its cases.
+	static func filed_under(test: GdUnitTestCase, suite: String) -> void:
+		if test.suite_resource_path == suite and test.source_file == suite:
+			return
+		test.suite_resource_path = suite
+		test.source_file = suite
+		test.suite_name = suite.get_file().get_basename()
+		test._build_fully_qualified_name(suite)
+
 	## gdUnit4 asks this of every case it finds, a parameterised case once a row, each row carrying
 	## its index.
 	func is_skipped(test: GdUnitTestCase) -> bool:
-		if super(test):
+		if left_out.has("%s:%s" % [test.suite_resource_path, test.test_name]) or super(test):
 			return true
 		var share: GdhRowShare = row_shares.get("%s:%s" % [test.suite_resource_path, test.test_name], null)
 		if share == null or not share.leaves_out(test.attribute_index):
@@ -348,7 +383,11 @@ static func started(given: PackedStringArray) -> GdhRunner:
 	if not expected_out.is_empty():
 		write_expected(expected_out, suites)
 	runner.add_test_suites(suites)
-	runner.skip_test_suites(listed(asked, SKIPPING))
+	for entry: String in listed(asked, SKIPPING):
+		if is_one_case(entry):
+			runner.left_out[entry] = true
+		else:
+			runner.skip_test_suite(entry)
 	runner.row_shares = row_shares_of(listed(asked, ROWS))
 	# Added to the list itself rather than through `register`, which saves every hook it holds into
 	# `project.godot`.
@@ -426,6 +465,19 @@ static func listed(args: PackedStringArray, flag: String) -> PackedStringArray:
 	return named
 
 
+## Whether [param entry] of a [constant SKIPPING] file names one case of one suite file, as
+## `res://suite.gd:test_case`, rather than a suite or a case by gdUnit4's looser names, which go to
+## gdUnit4 as they are.
+static func is_one_case(entry: String) -> bool:
+	var at: int = entry.rfind(":")
+	return (
+		entry.begins_with("res://")
+		and at > "res://".length()
+		and entry.substr(0, at).ends_with(".gd")
+		and entry.substr(at + 1).is_valid_ascii_identifier()
+	)
+
+
 ## The row shares [param lines] of a [constant ROWS] file give, by case.
 static func row_shares_of(lines: PackedStringArray) -> Dictionary[String, GdhRowShare]:
 	var shares: Dictionary[String, GdhRowShare] = {}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gdharness",
-  "version": "1.3.19",
+  "version": "1.3.21",
   "mcpName": "io.github.Aureliolo/gdharness",
   "description": "A harness for driving a Godot 4 project from an agent: editor addons, a runtime bridge into the running game, an MCP server in front of them, and a CLI that installs and diagnoses the Godot side.",
   "type": "module",