gdharness 1.2.8 → 1.2.9

package/build/cli.js

@@ -9347,7 +9347,7 @@ function bodyHolding(body, offset) {
   const inner = body.inner.find((one) => one.start <= offset && offset <= one.end);
   return inner === undefined ? body : bodyHolding(inner, offset);
 }
-function callSitesOf(source, name, otherClasses = new Set) {
+function callSitesOf(source, name, otherClasses = new Set, property = false) {
   const regions = regionsOf(source);
   const code = codeOf(source, regions);
   const codeLines = code.split(`
@@ -9377,7 +9377,7 @@ function callSitesOf(source, name, otherClasses = new Set) {
     if (localAt(codeLines, index, name) !== null) {
       return false;
     }
-    return !bodyHolding(shape.body, one.offset).declarations.some((declared) => declared.name === name && MEMBER_KINDS.has(declared.kind));
+    return !bodyHolding(shape.body, one.offset).declarations.some((declared) => declared.name === name && MEMBER_KINDS.has(declared.kind) && !(property && declared.kind === "var"));
   }).map((one) => {
     const line = lines.positionOf(one.offset).line + 1;
     const after = code.slice(one.offset + name.length).trimStart();
@@ -18377,7 +18377,7 @@ var init_tool_definitions = __esm(() => {
         callersOf: {
           type: "string",
           ops: ["profile"],
-          description: "profile: also answer, under callers, where the project's scripts name this function in code: its name, or Class.name for the functions of one class. Each place has its script, line, the named function it is written in (within), whether the function is called there or passed on as a Callable (called), and the profile's calls, self and total milliseconds for the function it is in, those taking the most time first, forty at most. Found by name in the source, since the engine's profiler records nothing about who made a call, so a method of the same name on another class is listed too, except, when Class.name was asked, one called through another class of the project by name or through a parameter, local or class variable declared as one, and a call made through a string is not. A parameter, local or class variable of the same name is not the function and is not listed."
+          description: "profile: also answer, under callers, where the project's scripts name this function in code: its name, or Class.name for the functions of one class. Each place has its script, line, the named function it is written in (within), whether the function is called there or passed on as a Callable (called), and the profile's calls, self and total milliseconds for the function it is in, those taking the most time first, forty at most. Found by name in the source, since the engine's profiler records nothing about who made a call, so a method of the same name on another class is listed too, except, when Class.name was asked, one called through another class of the project by name or through a parameter, local or class variable declared as one, and a call made through a string is not. A parameter, local or class variable of the same name is not the function and is not listed. A property's get or set block, which the profile names Class.@name_getter or Class.@name_setter, is asked about by that name or by the property's: the places are where the property is named, and the rows are both blocks'."
         },
         limit: {
           type: "integer",
@@ -18413,7 +18413,7 @@ var init_tool_definitions = __esm(() => {
         },
         wait: { summary: "wait for the run to end, then answer as editor_output does", requires: [] },
         profile: {
-          summary: "where the run spends its time by GDScript function, while it runs or after it ended: per function its script, the function (Class.name when the script declares a class_name), the line its body's first statement is on, for a lambda the named function it is written in (within), calls, and self and total milliseconds, sorted by self time, with functionsCounted, scriptMs (the self time of them all) and coveredMs. complete is true when the engine's own totals arrived, which it sends only when the profiler is switched off: the runtime addon does that as a game quits, so a scene that does its work in _ready and quits is covered whole; otherwise the answer is the frames summed so far and the note says what that misses. Self time counts a call into the engine's own methods as the caller's, and a call through super too, while the overridden function's row counts it again: such a row carries selfIncludesSuper, so self times along an override chain overlap. The profiler's own cost of timing a call lands in the self time of the function called; with the runtime addon it is measured each run on an empty function, as perCallOverheadUs, and a row with at least half its selfMs in it carries overheadMs, since a small function called often costs that much less without the profiler. A function the profiler started inside is left out, since its time would be counted from the engine's start. The milliseconds are time passed while the function ran, not processor time given to it, so they grow when other processes compete for the processor: compare two profiles taken under the same load. A run started with profile: true is profiled from its start. A game the editor plays that was not is profiled from the moment this is asked, and the answer says so; a run this server started without it is refused, since its debugger is fixed as it starts",
+          summary: "where the run spends its time by GDScript function, while it runs or after it ended: per function its script, the function (Class.name when the script declares a class_name), the line its body's first statement is on, for a lambda the named function it is written in (within), calls, and self and total milliseconds, sorted by self time, with functionsCounted, scriptMs (the self time of them all) and coveredMs. complete is true when the engine's own totals arrived, which it sends only when the profiler is switched off: the runtime addon does that as a game quits, so a scene that does its work in _ready and quits is covered whole; otherwise the answer is the frames summed so far and the note says what that misses. Self time counts a call into the engine's own methods as the caller's, and a call through super too, while the overridden function's row counts it again: such a row carries selfIncludesSuper, so self times along an override chain overlap. The profiler's own cost of timing a call lands in the self time of the function called; with the runtime addon it is measured each run on an empty function, as perCallOverheadUs, and a row with at least half its selfMs in it carries overheadMs, since a small function called often costs that much less without the profiler. A function the profiler started inside is left out, since its time would be counted from the engine's start. The milliseconds are time passed while the function ran, not processor time given to it, so they grow when other processes compete for the processor: compare two profiles taken under the same load. They are also summed over every thread: a function run by WorkerThreadPool or a Thread on several threads at once counts each thread's time, the engine does not say which thread a call ran on, and a function waiting for them has the wait in its own self time, so selfMs is not time taken from frames, and scriptMs can exceed coveredMs, which the note then says. A property's get and set blocks are named Class.@name_getter and Class.@name_setter, as the engine names them, and their rows carry property, the property's name. A run started with profile: true is profiled from its start. A game the editor plays that was not is profiled from the moment this is asked, and the answer says so; a run this server started without it is refused, since its debugger is fixed as it starts",
           requires: []
         }
       },
@@ -42603,6 +42603,9 @@ function queuedMessagesOf(projectGodot) {
   const set = projectGodot === null ? undefined : parseProjectGodot(projectGodot)["network"]?.[QUEUE_SETTING];
   return typeof set === "number" && Number.isInteger(set) && set > 0 ? set : QUEUE_DEFAULT;
 }
+function propertyOf(fn) {
+  return /^@(.+)_(?:getter|setter)$/.exec(bareName(fn))?.[1] ?? null;
+}
 function signatureParts(signature) {
   const parts = signature.split("::");
   if (parts.length < 3) {
@@ -42624,7 +42627,8 @@ function profiledFunctions(totals, limit, sourceOf = () => null) {
     superCallers: rows.filter((row) => row.selfIncludesSuper === true).length,
     perCallUs,
     overheadDominated: rows.filter((row) => row.overheadMs !== undefined).length,
-    overheadNamed: rows.filter((row) => row.overheadMs !== undefined).map((row) => row.function)
+    overheadNamed: rows.filter((row) => row.overheadMs !== undefined).map((row) => row.function),
+    overheadReach: rows.findLastIndex((row) => row.overheadMs !== undefined) + 1
   };
 }
 function isCalibration(signature) {
@@ -42659,6 +42663,7 @@ function rowsOf(totals, sourceOf) {
   return Object.entries(totals.functions).filter(([signature, sum]) => sum.calls > 0 && !isCalibration(signature)).map(([signature, sum]) => {
     const parts = signatureParts(signature);
     const code = codeOfScript(parts.script);
+    const property = propertyOf(parts.function);
     return {
       script: parts.script,
       function: parts.function,
@@ -42666,7 +42671,8 @@ function rowsOf(totals, sourceOf) {
       calls: sum.calls,
       selfMs: ms(sum.selfSeconds),
       totalMs: ms(sum.totalSeconds),
-      ...code !== null && bodyCallsSuper(code, parts.line, parts.function.endsWith("(lambda)")) ? { selfIncludesSuper: true } : {}
+      ...code !== null && bodyCallsSuper(code, parts.line, parts.function.endsWith("(lambda)")) ? { selfIncludesSuper: true } : {},
+      ...property === null ? {} : { property }
     };
   }).sort((a, b) => b.selfMs - a.selfMs || b.totalMs - a.totalMs || a.function.localeCompare(b.function));
 }
@@ -42690,9 +42696,11 @@ function callersOf(totals, name, scripts) {
   const listed = [...scripts];
   const sources = new Map(listed);
   const rows = rowsOf(totals, (script) => sources.get(script) ?? null);
-  const bare = bareName(name);
-  const target = rows.filter((row) => name.includes(".") ? row.function === name : bareName(row.function) === bare);
   const asked = name.includes(".") ? name.slice(0, name.lastIndexOf(".")) : null;
+  const bare = propertyOf(name) ?? bareName(name);
+  const ownerOf = (fn) => fn.includes(".") ? fn.slice(0, fn.lastIndexOf(".")) : null;
+  const target = rows.filter((row) => (bareName(row.function) === bare || row.property === bare) && (asked === null || ownerOf(row.function) === asked));
+  const property = propertyOf(name) !== null || target.some((row) => row.property === bare);
   const otherClasses = new Set;
   if (asked !== null) {
     for (const [, source] of listed) {
@@ -42705,7 +42713,7 @@ function callersOf(totals, name, scripts) {
   }
   const sites = [];
   for (const [script, source] of listed) {
-    for (const site of callSitesOf(source, bare, otherClasses)) {
+    for (const site of callSitesOf(source, bare, otherClasses, property)) {
       const within = site.within === null ? undefined : rows.find((row) => row.script === script && bareName(row.function) === site.within);
       sites.push({
         script,
@@ -43526,8 +43534,8 @@ function profileAnswer(reading, limit) {
   }
   const table = profiledFunctions(totals, limit, reading.sourceOf);
   const notes = [];
-  const addonNote = reading.runtimeAddon ? "" : " This project has no gdharness runtime addon, which switches the profiler off as the game quits so the engine sends its totals: setup installs it.";
-  const totalsWithheld = reading.runtimeAddon ? " The runtime addon switches the profiler off as the game quits, and did not here: either it was no longer running in this game by then, which a project can arrange for some scenes; or the game ended without taking its tree down, as a crash or a kill does; or the totals did not reach the debugger before the game exited, which the game then says in its output." : addonNote;
+  const addonNote = reading.runtimeAddon === true ? "" : reading.runtimeAddon === null ? " The run's project is no longer at its path, so whether it had the gdharness runtime addon, which switches the profiler off as the game quits so the engine sends its totals, cannot be read." : " This project has no gdharness runtime addon, which switches the profiler off as the game quits so the engine sends its totals: setup installs it.";
+  const totalsWithheld = reading.runtimeAddon === true ? " The runtime addon switches the profiler off as the game quits, and did not here: either it was no longer running in this game by then, which a project can arrange for some scenes; or the game ended without taking its tree down, as a crash or a kill does; or the totals did not reach the debugger before the game exited, which the game then says in its output." : addonNote;
   if (totals.complete && reading.running) {
     notes.push(`The engine's totals arrived while the game is still running, which it sends only when the profiler is switched off, so ${reading.through === "editor" ? "the editor's Profiler tab or the game itself, through EngineDebugger," : "the game itself, through EngineDebugger,"} switched it off before the game ended. They cover the run up to then and nothing after.`);
   } else if (totals.complete) {} else if (reading.running && totals.frames === 0) {
@@ -43543,7 +43551,11 @@ function profileAnswer(reading, limit) {
     notes.push(`${table.superCallers === 1 ? "One function calls" : `${table.superCallers} functions call`} through super, marked selfIncludesSuper: the engine takes every other call out of the caller's self time, and not a super call, so ${table.superCallers === 1 ? "its" : "their"} selfMs holds the overridden function's time, which that function's own row counts again. Self time therefore cannot be added along an override chain, and scriptMs counts the time under a super call once more for each level above it.`);
   }
   if (table.overheadDominated > 0 && table.perCallUs !== null) {
-    notes.push(`The profiler costs about ${table.perCallUs}µs a call in this run, measured on an empty function the runtime addon calls as it goes on, and that time lands in the self time of the function called. ${table.overheadDominated === 1 ? "One function has" : `${table.overheadDominated} functions have`} at least half ${table.overheadDominated === 1 ? "its" : "their"} selfMs in it, under overheadMs: ${namedFew(table.overheadNamed)}. That much of ${table.overheadDominated === 1 ? "its" : "their"} time is the profiler's and goes once the profiler is off, whether the function is inlined or not. What inlining saves is the call itself, which costs something without the profiler too, not the work inside it.`);
+    const one = table.overheadDominated === 1;
+    notes.push(`The profiler costs about ${table.perCallUs}µs a call in this run, measured on an empty function the runtime addon calls as it goes on, and that time lands in the self time of the function called. ${one ? "One function has" : `${table.overheadDominated} functions have`} at least half ${one ? "its" : "their"} selfMs in it: ${namedFew(table.overheadNamed)}.${overheadRowsReturned(table, one)} That much of ${one ? "its" : "their"} time is the profiler's and goes once the profiler is off, whether the function is inlined or not. What inlining saves is the call itself, which costs something without the profiler too, not the work inside it.`);
+  }
+  if (reading.coveredMs > 0 && table.scriptMs > reading.coveredMs) {
+    notes.push(`scriptMs, ${table.scriptMs}ms, is more than the ${reading.coveredMs}ms the profile covers.${table.superCallers > 0 ? " The super calls above, counted twice, can account for some or all of that; whatever they do not is" : " One thread cannot spend more time than passes, so that is"} functions running on several threads at once, through WorkerThreadPool or Thread. The engine adds every thread's time to the same function and does not say which thread a call ran on, so a function's selfMs is summed over every thread it ran on rather than taken out of frames, and a function that waits for the others, through wait_for_group_task_completion or wait_to_finish, has the wait in its own selfMs as well.`);
   }
   notes.push(...cappedNotes(totals));
   if (totals.unreadable > 0) {
@@ -43565,6 +43577,17 @@ function profileAnswer(reading, limit) {
     note: notes.length > 0 ? notes.join(" ") : undefined
   };
 }
+function overheadRowsReturned(table, one) {
+  const shown = table.functions.filter((row) => row.overheadMs !== undefined).length;
+  const returned = table.functions.length;
+  if (shown === table.overheadDominated) {
+    return one ? " Its row carries that share as overheadMs." : " Their rows carry that share as overheadMs.";
+  }
+  if (shown === 0) {
+    return one ? ` Its row, which carries that share as overheadMs, is not among the ${returned} returned; limit ${table.overheadReach} returns it.` : ` Their rows, which carry that share as overheadMs, are none of the ${returned} returned; limit ${table.overheadReach} returns them all.`;
+  }
+  return ` Their rows carry that share as overheadMs, and ${shown} of them ${shown === 1 ? "is" : "are"} among the ${returned} returned; limit ${table.overheadReach} returns them all.`;
+}
 function namedFew(names) {
   const shown = names.slice(0, 5);
   const more = names.length - shown.length;
@@ -43584,12 +43607,29 @@ function cappedNotes(totals) {
     const capped = totals.cappedFrames ?? 0;
     notes.push(`${capped === totals.frames ? capped === 1 ? "The one frame" : `All ${capped} frames` : `${capped} of the ${totals.frames} frames`} carried the most functions the profiler asks for in one, ${most}, so the functions with the least time in ${capped === 1 ? "it" : "them"} are not counted there: ${why}`);
   }
-  const unnamed = Object.entries(totals.functions).filter(([name, sum]) => name.startsWith(UNNAMED_PREFIX) && sum.calls > 0).length;
+  const unnamed = unnamedCalled(totals);
   if (unnamed > 0) {
     notes.push(`${unnamed === 1 ? "One function" : `${unnamed} functions`} arrived without ${unnamed === 1 ? "its name" : "their names"}, shown as ${UNNAMED_PREFIX} and the number the engine gave ${unnamed === 1 ? "it" : "them"}: the engine names a function once, as it first appears, and the game's debugger queue was full when that message was sent. They are script functions of the game; which ones cannot be recovered from this profile.`);
   }
   return notes;
 }
+function unnamedCalled(totals) {
+  return Object.entries(totals.functions).filter(([name, sum]) => name.startsWith(UNNAMED_PREFIX) && sum.calls > 0).length;
+}
+function uncountedCallee(totals, name) {
+  const others = [];
+  const most = totals.frameFunctions;
+  const capped = totals.complete ? totals.totalCapped === true : (totals.cappedFrames ?? 0) > 0;
+  if (most !== undefined && capped) {
+    others.push(`its calls took too little time to be among the ${most} functions ${totals.complete ? "the engine's totals" : "a frame"} carried`);
+  }
+  const unnamed = unnamedCalled(totals);
+  if (unnamed > 0) {
+    others.push(`it is ${unnamed === 1 ? "the function" : `one of the ${unnamed} functions`} whose name never arrived`);
+  }
+  const ranNot = "none of these places ran it while the profiler was on: withinCalls says the function a place is in ran, not that the line did";
+  return others.length === 0 ? `The profile counts no call of ${name}, so ${ranNot}.` : `The profile counts no call of ${name}: either ${ranNot}, or ${others.join(", or ")}.`;
+}
 function callersAnswer(totals, asked) {
   const found = callersOf(totals, asked.name, asked.scripts());
   return {
@@ -43597,7 +43637,7 @@ function callersAnswer(totals, asked) {
     rows: found.target,
     sites: found.sites,
     omitted: found.omitted > 0 ? found.omitted : undefined,
-    note: found.sites.length === 0 ? `No script in the project names ${asked.name} in code, outside its declaration: a call made through a string, such as call("name"), is not found by name.` : found.target.length === 0 ? `${CALLERS_FOUND_BY_NAME} The profile counts no call of ${asked.name}, so these places are where it would be called from.` : CALLERS_FOUND_BY_NAME
+    note: found.sites.length === 0 ? `No script in the project names ${asked.name} in code, outside its declaration: a call made through a string, such as call("name"), is not found by name.` : found.target.length === 0 ? `${CALLERS_FOUND_BY_NAME} ${uncountedCallee(totals, asked.name)}` : CALLERS_FOUND_BY_NAME
   };
 }
 function foldedEntriesAnswer(log) {
@@ -46940,6 +46980,7 @@ class GodotServer {
     const transcript = openTranscript(startedAt);
     closeSync2(transcript.fd);
     const gameEnv = profiled ? { ...env ?? process.env, [PROFILE_FROM_START]: "1" } : env;
+    const profile = profiled ? profilePath(startedAt) : undefined;
     const launched = await launchOutsideTheTree({
       command: godotPath,
       args: cmdArgs,
@@ -46949,7 +46990,7 @@ class GodotServer {
         startedAt,
         projectPath,
         ...this.servedBy(),
-        ...profiled ? { profile: profilePath(startedAt) } : {}
+        ...profile === undefined ? {} : { profile }
       },
       ...desktop === undefined ? {} : { desktop }
     });
@@ -46970,6 +47011,7 @@ class GodotServer {
       startedAt,
       startedBy,
       ...keeper === undefined ? {} : { keeper },
+      ...profile === undefined ? {} : { profile },
       command: godotPath,
       exitCode: null,
       exitSignal: null,
@@ -47210,6 +47252,7 @@ class GodotServer {
       startedAt: record.startedAt,
       ...record.startedBy === undefined ? {} : { startedBy: record.startedBy },
       ...record.keeper === undefined ? {} : { keeper: record.keeper },
+      ...record.profile === undefined ? {} : { profile: record.profile },
       ...record.command === undefined ? {} : { command: record.command },
       exitCode: null,
       exitSignal: null,
@@ -47362,12 +47405,16 @@ class GodotServer {
     }
     const limit = readPositiveNumber(args, "limit") ?? PROFILE_FUNCTIONS;
     const callersName = readString(args, "callersOf");
-    if (callersName !== undefined && !callersName.split(".").every(isIdentifier)) {
+    if (callersName !== undefined && !callersName.replace(/@([^.@]+)_(?:getter|setter)$/, "$1").split(".").every(isIdentifier)) {
       return this.createErrorResponse(`callersOf takes a function's name, or Class.name for the functions of one class, and ${JSON.stringify(callersName)} is neither.`, ["editor_run profile names each function as it answers; pass one of those"]);
     }
     const going = await this.runStillGoing(run);
     const projectPath = run.projectPath;
-    const fromProject = projectPath === null ? { runtimeAddon: false } : {
+    const projectGone = projectPath !== null && !existsSync20(join26(projectPath, "project.godot"));
+    if (projectGone && callersName !== undefined) {
+      return this.createErrorResponse(`callersOf reads the project's scripts, and the run's project at ${projectPath} has no project.godot any more.`, ["editor_run profile without callersOf answers with the profile itself"]);
+    }
+    const fromProject = projectPath === null ? { runtimeAddon: false } : projectGone ? { runtimeAddon: null } : {
       runtimeAddon: runtimeAddonRegistered(projectPath),
       sourceOf: projectSourceOf(projectPath),
       ...callersName === undefined ? {} : { callersOf: { name: callersName, scripts: () => projectScripts(projectPath) } }
@@ -47375,8 +47422,7 @@ class GodotServer {
     if (run.throughEditor) {
       return await this.profileOfThePlayedGame(going, projectPath, fromProject, limit);
     }
-    const record = run.projectPath === null ? null : readRunRecord(run.projectPath);
-    const path = record !== null && record.pid === run.pid ? record.profile : undefined;
+    const path = run.profile;
     if (path === undefined) {
       return this.createErrorResponse("This run was started without profile: true, and a game this server starts can be profiled only from its start: its debugger is whatever it dials as it starts, once.", ["editor_run start with profile: true starts the run again with the profiler on"]);
     }

package/build/index.js

@@ -26720,7 +26720,7 @@ function bodyHolding(body, offset) {
   const inner = body.inner.find((one) => one.start <= offset && offset <= one.end);
   return inner === undefined ? body : bodyHolding(inner, offset);
 }
-function callSitesOf(source, name, otherClasses = new Set) {
+function callSitesOf(source, name, otherClasses = new Set, property = false) {
   const regions = regionsOf(source);
   const code = codeOf(source, regions);
   const codeLines = code.split(`
@@ -26750,7 +26750,7 @@ function callSitesOf(source, name, otherClasses = new Set) {
     if (localAt(codeLines, index, name) !== null) {
       return false;
     }
-    return !bodyHolding(shape.body, one.offset).declarations.some((declared) => declared.name === name && MEMBER_KINDS.has(declared.kind));
+    return !bodyHolding(shape.body, one.offset).declarations.some((declared) => declared.name === name && MEMBER_KINDS.has(declared.kind) && !(property && declared.kind === "var"));
   }).map((one) => {
     const line = lines.positionOf(one.offset).line + 1;
     const after = code.slice(one.offset + name.length).trimStart();
@@ -33394,6 +33394,9 @@ function queuedMessagesOf(projectGodot) {
 }
 var UNNAMED_PREFIX = "#";
 var PROFILE_FROM_START = "GDHARNESS_PROFILE_FROM_START";
+function propertyOf(fn) {
+  return /^@(.+)_(?:getter|setter)$/.exec(bareName(fn))?.[1] ?? null;
+}
 function signatureParts(signature) {
   const parts = signature.split("::");
   if (parts.length < 3) {
@@ -33416,7 +33419,8 @@ function profiledFunctions(totals, limit, sourceOf = () => null) {
     superCallers: rows.filter((row) => row.selfIncludesSuper === true).length,
     perCallUs,
     overheadDominated: rows.filter((row) => row.overheadMs !== undefined).length,
-    overheadNamed: rows.filter((row) => row.overheadMs !== undefined).map((row) => row.function)
+    overheadNamed: rows.filter((row) => row.overheadMs !== undefined).map((row) => row.function),
+    overheadReach: rows.findLastIndex((row) => row.overheadMs !== undefined) + 1
   };
 }
 var RUNTIME_SCRIPT = "gdharness_runtime/runtime_autoload.gd";
@@ -33454,6 +33458,7 @@ function rowsOf(totals, sourceOf) {
   return Object.entries(totals.functions).filter(([signature, sum]) => sum.calls > 0 && !isCalibration(signature)).map(([signature, sum]) => {
     const parts = signatureParts(signature);
     const code = codeOfScript(parts.script);
+    const property = propertyOf(parts.function);
     return {
       script: parts.script,
       function: parts.function,
@@ -33461,7 +33466,8 @@ function rowsOf(totals, sourceOf) {
       calls: sum.calls,
       selfMs: ms(sum.selfSeconds),
       totalMs: ms(sum.totalSeconds),
-      ...code !== null && bodyCallsSuper(code, parts.line, parts.function.endsWith("(lambda)")) ? { selfIncludesSuper: true } : {}
+      ...code !== null && bodyCallsSuper(code, parts.line, parts.function.endsWith("(lambda)")) ? { selfIncludesSuper: true } : {},
+      ...property === null ? {} : { property }
     };
   }).sort((a, b) => b.selfMs - a.selfMs || b.totalMs - a.totalMs || a.function.localeCompare(b.function));
 }
@@ -33486,9 +33492,11 @@ function callersOf(totals, name, scripts) {
   const listed = [...scripts];
   const sources = new Map(listed);
   const rows = rowsOf(totals, (script) => sources.get(script) ?? null);
-  const bare = bareName(name);
-  const target = rows.filter((row) => name.includes(".") ? row.function === name : bareName(row.function) === bare);
   const asked = name.includes(".") ? name.slice(0, name.lastIndexOf(".")) : null;
+  const bare = propertyOf(name) ?? bareName(name);
+  const ownerOf = (fn) => fn.includes(".") ? fn.slice(0, fn.lastIndexOf(".")) : null;
+  const target = rows.filter((row) => (bareName(row.function) === bare || row.property === bare) && (asked === null || ownerOf(row.function) === asked));
+  const property = propertyOf(name) !== null || target.some((row) => row.property === bare);
   const otherClasses = new Set;
   if (asked !== null) {
     for (const [, source] of listed) {
@@ -33501,7 +33509,7 @@ function callersOf(totals, name, scripts) {
   }
   const sites = [];
   for (const [script, source] of listed) {
-    for (const site of callSitesOf(source, bare, otherClasses)) {
+    for (const site of callSitesOf(source, bare, otherClasses, property)) {
       const within = site.within === null ? undefined : rows.find((row) => row.script === script && bareName(row.function) === site.within);
       sites.push({
         script,
@@ -34506,7 +34514,7 @@ var TOOL_SPECS = [
       callersOf: {
         type: "string",
         ops: ["profile"],
-        description: "profile: also answer, under callers, where the project's scripts name this function in code: its name, or Class.name for the functions of one class. Each place has its script, line, the named function it is written in (within), whether the function is called there or passed on as a Callable (called), and the profile's calls, self and total milliseconds for the function it is in, those taking the most time first, forty at most. Found by name in the source, since the engine's profiler records nothing about who made a call, so a method of the same name on another class is listed too, except, when Class.name was asked, one called through another class of the project by name or through a parameter, local or class variable declared as one, and a call made through a string is not. A parameter, local or class variable of the same name is not the function and is not listed."
+        description: "profile: also answer, under callers, where the project's scripts name this function in code: its name, or Class.name for the functions of one class. Each place has its script, line, the named function it is written in (within), whether the function is called there or passed on as a Callable (called), and the profile's calls, self and total milliseconds for the function it is in, those taking the most time first, forty at most. Found by name in the source, since the engine's profiler records nothing about who made a call, so a method of the same name on another class is listed too, except, when Class.name was asked, one called through another class of the project by name or through a parameter, local or class variable declared as one, and a call made through a string is not. A parameter, local or class variable of the same name is not the function and is not listed. A property's get or set block, which the profile names Class.@name_getter or Class.@name_setter, is asked about by that name or by the property's: the places are where the property is named, and the rows are both blocks'."
       },
       limit: {
         type: "integer",
@@ -34542,7 +34550,7 @@ var TOOL_SPECS = [
       },
       wait: { summary: "wait for the run to end, then answer as editor_output does", requires: [] },
       profile: {
-        summary: "where the run spends its time by GDScript function, while it runs or after it ended: per function its script, the function (Class.name when the script declares a class_name), the line its body's first statement is on, for a lambda the named function it is written in (within), calls, and self and total milliseconds, sorted by self time, with functionsCounted, scriptMs (the self time of them all) and coveredMs. complete is true when the engine's own totals arrived, which it sends only when the profiler is switched off: the runtime addon does that as a game quits, so a scene that does its work in _ready and quits is covered whole; otherwise the answer is the frames summed so far and the note says what that misses. Self time counts a call into the engine's own methods as the caller's, and a call through super too, while the overridden function's row counts it again: such a row carries selfIncludesSuper, so self times along an override chain overlap. The profiler's own cost of timing a call lands in the self time of the function called; with the runtime addon it is measured each run on an empty function, as perCallOverheadUs, and a row with at least half its selfMs in it carries overheadMs, since a small function called often costs that much less without the profiler. A function the profiler started inside is left out, since its time would be counted from the engine's start. The milliseconds are time passed while the function ran, not processor time given to it, so they grow when other processes compete for the processor: compare two profiles taken under the same load. A run started with profile: true is profiled from its start. A game the editor plays that was not is profiled from the moment this is asked, and the answer says so; a run this server started without it is refused, since its debugger is fixed as it starts",
+        summary: "where the run spends its time by GDScript function, while it runs or after it ended: per function its script, the function (Class.name when the script declares a class_name), the line its body's first statement is on, for a lambda the named function it is written in (within), calls, and self and total milliseconds, sorted by self time, with functionsCounted, scriptMs (the self time of them all) and coveredMs. complete is true when the engine's own totals arrived, which it sends only when the profiler is switched off: the runtime addon does that as a game quits, so a scene that does its work in _ready and quits is covered whole; otherwise the answer is the frames summed so far and the note says what that misses. Self time counts a call into the engine's own methods as the caller's, and a call through super too, while the overridden function's row counts it again: such a row carries selfIncludesSuper, so self times along an override chain overlap. The profiler's own cost of timing a call lands in the self time of the function called; with the runtime addon it is measured each run on an empty function, as perCallOverheadUs, and a row with at least half its selfMs in it carries overheadMs, since a small function called often costs that much less without the profiler. A function the profiler started inside is left out, since its time would be counted from the engine's start. The milliseconds are time passed while the function ran, not processor time given to it, so they grow when other processes compete for the processor: compare two profiles taken under the same load. They are also summed over every thread: a function run by WorkerThreadPool or a Thread on several threads at once counts each thread's time, the engine does not say which thread a call ran on, and a function waiting for them has the wait in its own self time, so selfMs is not time taken from frames, and scriptMs can exceed coveredMs, which the note then says. A property's get and set blocks are named Class.@name_getter and Class.@name_setter, as the engine names them, and their rows carry property, the property's name. A run started with profile: true is profiled from its start. A game the editor plays that was not is profiled from the moment this is asked, and the answer says so; a run this server started without it is refused, since its debugger is fixed as it starts",
         requires: []
       }
     },
@@ -36021,8 +36029,8 @@ function profileAnswer(reading, limit) {
   }
   const table = profiledFunctions(totals, limit, reading.sourceOf);
   const notes = [];
-  const addonNote = reading.runtimeAddon ? "" : " This project has no gdharness runtime addon, which switches the profiler off as the game quits so the engine sends its totals: setup installs it.";
-  const totalsWithheld = reading.runtimeAddon ? " The runtime addon switches the profiler off as the game quits, and did not here: either it was no longer running in this game by then, which a project can arrange for some scenes; or the game ended without taking its tree down, as a crash or a kill does; or the totals did not reach the debugger before the game exited, which the game then says in its output." : addonNote;
+  const addonNote = reading.runtimeAddon === true ? "" : reading.runtimeAddon === null ? " The run's project is no longer at its path, so whether it had the gdharness runtime addon, which switches the profiler off as the game quits so the engine sends its totals, cannot be read." : " This project has no gdharness runtime addon, which switches the profiler off as the game quits so the engine sends its totals: setup installs it.";
+  const totalsWithheld = reading.runtimeAddon === true ? " The runtime addon switches the profiler off as the game quits, and did not here: either it was no longer running in this game by then, which a project can arrange for some scenes; or the game ended without taking its tree down, as a crash or a kill does; or the totals did not reach the debugger before the game exited, which the game then says in its output." : addonNote;
   if (totals.complete && reading.running) {
     notes.push(`The engine's totals arrived while the game is still running, which it sends only when the profiler is switched off, so ${reading.through === "editor" ? "the editor's Profiler tab or the game itself, through EngineDebugger," : "the game itself, through EngineDebugger,"} switched it off before the game ended. They cover the run up to then and nothing after.`);
   } else if (totals.complete) {} else if (reading.running && totals.frames === 0) {
@@ -36038,7 +36046,11 @@ function profileAnswer(reading, limit) {
     notes.push(`${table.superCallers === 1 ? "One function calls" : `${table.superCallers} functions call`} through super, marked selfIncludesSuper: the engine takes every other call out of the caller's self time, and not a super call, so ${table.superCallers === 1 ? "its" : "their"} selfMs holds the overridden function's time, which that function's own row counts again. Self time therefore cannot be added along an override chain, and scriptMs counts the time under a super call once more for each level above it.`);
   }
   if (table.overheadDominated > 0 && table.perCallUs !== null) {
-    notes.push(`The profiler costs about ${table.perCallUs}µs a call in this run, measured on an empty function the runtime addon calls as it goes on, and that time lands in the self time of the function called. ${table.overheadDominated === 1 ? "One function has" : `${table.overheadDominated} functions have`} at least half ${table.overheadDominated === 1 ? "its" : "their"} selfMs in it, under overheadMs: ${namedFew(table.overheadNamed)}. That much of ${table.overheadDominated === 1 ? "its" : "their"} time is the profiler's and goes once the profiler is off, whether the function is inlined or not. What inlining saves is the call itself, which costs something without the profiler too, not the work inside it.`);
+    const one = table.overheadDominated === 1;
+    notes.push(`The profiler costs about ${table.perCallUs}µs a call in this run, measured on an empty function the runtime addon calls as it goes on, and that time lands in the self time of the function called. ${one ? "One function has" : `${table.overheadDominated} functions have`} at least half ${one ? "its" : "their"} selfMs in it: ${namedFew(table.overheadNamed)}.${overheadRowsReturned(table, one)} That much of ${one ? "its" : "their"} time is the profiler's and goes once the profiler is off, whether the function is inlined or not. What inlining saves is the call itself, which costs something without the profiler too, not the work inside it.`);
+  }
+  if (reading.coveredMs > 0 && table.scriptMs > reading.coveredMs) {
+    notes.push(`scriptMs, ${table.scriptMs}ms, is more than the ${reading.coveredMs}ms the profile covers.${table.superCallers > 0 ? " The super calls above, counted twice, can account for some or all of that; whatever they do not is" : " One thread cannot spend more time than passes, so that is"} functions running on several threads at once, through WorkerThreadPool or Thread. The engine adds every thread's time to the same function and does not say which thread a call ran on, so a function's selfMs is summed over every thread it ran on rather than taken out of frames, and a function that waits for the others, through wait_for_group_task_completion or wait_to_finish, has the wait in its own selfMs as well.`);
   }
   notes.push(...cappedNotes(totals));
   if (totals.unreadable > 0) {
@@ -36060,6 +36072,17 @@ function profileAnswer(reading, limit) {
     note: notes.length > 0 ? notes.join(" ") : undefined
   };
 }
+function overheadRowsReturned(table, one) {
+  const shown = table.functions.filter((row) => row.overheadMs !== undefined).length;
+  const returned = table.functions.length;
+  if (shown === table.overheadDominated) {
+    return one ? " Its row carries that share as overheadMs." : " Their rows carry that share as overheadMs.";
+  }
+  if (shown === 0) {
+    return one ? ` Its row, which carries that share as overheadMs, is not among the ${returned} returned; limit ${table.overheadReach} returns it.` : ` Their rows, which carry that share as overheadMs, are none of the ${returned} returned; limit ${table.overheadReach} returns them all.`;
+  }
+  return ` Their rows carry that share as overheadMs, and ${shown} of them ${shown === 1 ? "is" : "are"} among the ${returned} returned; limit ${table.overheadReach} returns them all.`;
+}
 function namedFew(names) {
   const shown = names.slice(0, 5);
   const more = names.length - shown.length;
@@ -36079,12 +36102,29 @@ function cappedNotes(totals) {
     const capped = totals.cappedFrames ?? 0;
     notes.push(`${capped === totals.frames ? capped === 1 ? "The one frame" : `All ${capped} frames` : `${capped} of the ${totals.frames} frames`} carried the most functions the profiler asks for in one, ${most}, so the functions with the least time in ${capped === 1 ? "it" : "them"} are not counted there: ${why}`);
   }
-  const unnamed = Object.entries(totals.functions).filter(([name, sum]) => name.startsWith(UNNAMED_PREFIX) && sum.calls > 0).length;
+  const unnamed = unnamedCalled(totals);
   if (unnamed > 0) {
     notes.push(`${unnamed === 1 ? "One function" : `${unnamed} functions`} arrived without ${unnamed === 1 ? "its name" : "their names"}, shown as ${UNNAMED_PREFIX} and the number the engine gave ${unnamed === 1 ? "it" : "them"}: the engine names a function once, as it first appears, and the game's debugger queue was full when that message was sent. They are script functions of the game; which ones cannot be recovered from this profile.`);
   }
   return notes;
 }
+function unnamedCalled(totals) {
+  return Object.entries(totals.functions).filter(([name, sum]) => name.startsWith(UNNAMED_PREFIX) && sum.calls > 0).length;
+}
+function uncountedCallee(totals, name) {
+  const others = [];
+  const most = totals.frameFunctions;
+  const capped = totals.complete ? totals.totalCapped === true : (totals.cappedFrames ?? 0) > 0;
+  if (most !== undefined && capped) {
+    others.push(`its calls took too little time to be among the ${most} functions ${totals.complete ? "the engine's totals" : "a frame"} carried`);
+  }
+  const unnamed = unnamedCalled(totals);
+  if (unnamed > 0) {
+    others.push(`it is ${unnamed === 1 ? "the function" : `one of the ${unnamed} functions`} whose name never arrived`);
+  }
+  const ranNot = "none of these places ran it while the profiler was on: withinCalls says the function a place is in ran, not that the line did";
+  return others.length === 0 ? `The profile counts no call of ${name}, so ${ranNot}.` : `The profile counts no call of ${name}: either ${ranNot}, or ${others.join(", or ")}.`;
+}
 function callersAnswer(totals, asked) {
   const found = callersOf(totals, asked.name, asked.scripts());
   return {
@@ -36092,7 +36132,7 @@ function callersAnswer(totals, asked) {
     rows: found.target,
     sites: found.sites,
     omitted: found.omitted > 0 ? found.omitted : undefined,
-    note: found.sites.length === 0 ? `No script in the project names ${asked.name} in code, outside its declaration: a call made through a string, such as call("name"), is not found by name.` : found.target.length === 0 ? `${CALLERS_FOUND_BY_NAME} The profile counts no call of ${asked.name}, so these places are where it would be called from.` : CALLERS_FOUND_BY_NAME
+    note: found.sites.length === 0 ? `No script in the project names ${asked.name} in code, outside its declaration: a call made through a string, such as call("name"), is not found by name.` : found.target.length === 0 ? `${CALLERS_FOUND_BY_NAME} ${uncountedCallee(totals, asked.name)}` : CALLERS_FOUND_BY_NAME
   };
 }
 var MOST_ENGINE_ENTRIES = 200;
@@ -39438,6 +39478,7 @@ class GodotServer {
     const transcript = openTranscript(startedAt);
     closeSync2(transcript.fd);
     const gameEnv = profiled ? { ...env ?? process.env, [PROFILE_FROM_START]: "1" } : env;
+    const profile = profiled ? profilePath(startedAt) : undefined;
     const launched = await launchOutsideTheTree({
       command: godotPath,
       args: cmdArgs,
@@ -39447,7 +39488,7 @@ class GodotServer {
         startedAt,
         projectPath,
         ...this.servedBy(),
-        ...profiled ? { profile: profilePath(startedAt) } : {}
+        ...profile === undefined ? {} : { profile }
       },
       ...desktop === undefined ? {} : { desktop }
     });
@@ -39468,6 +39509,7 @@ class GodotServer {
       startedAt,
       startedBy,
       ...keeper === undefined ? {} : { keeper },
+      ...profile === undefined ? {} : { profile },
       command: godotPath,
       exitCode: null,
       exitSignal: null,
@@ -39708,6 +39750,7 @@ class GodotServer {
       startedAt: record.startedAt,
       ...record.startedBy === undefined ? {} : { startedBy: record.startedBy },
       ...record.keeper === undefined ? {} : { keeper: record.keeper },
+      ...record.profile === undefined ? {} : { profile: record.profile },
       ...record.command === undefined ? {} : { command: record.command },
       exitCode: null,
       exitSignal: null,
@@ -39860,12 +39903,16 @@ class GodotServer {
     }
     const limit = readPositiveNumber(args, "limit") ?? PROFILE_FUNCTIONS;
     const callersName = readString(args, "callersOf");
-    if (callersName !== undefined && !callersName.split(".").every(isIdentifier)) {
+    if (callersName !== undefined && !callersName.replace(/@([^.@]+)_(?:getter|setter)$/, "$1").split(".").every(isIdentifier)) {
       return this.createErrorResponse(`callersOf takes a function's name, or Class.name for the functions of one class, and ${JSON.stringify(callersName)} is neither.`, ["editor_run profile names each function as it answers; pass one of those"]);
     }
     const going = await this.runStillGoing(run);
     const projectPath = run.projectPath;
-    const fromProject = projectPath === null ? { runtimeAddon: false } : {
+    const projectGone = projectPath !== null && !existsSync17(join22(projectPath, "project.godot"));
+    if (projectGone && callersName !== undefined) {
+      return this.createErrorResponse(`callersOf reads the project's scripts, and the run's project at ${projectPath} has no project.godot any more.`, ["editor_run profile without callersOf answers with the profile itself"]);
+    }
+    const fromProject = projectPath === null ? { runtimeAddon: false } : projectGone ? { runtimeAddon: null } : {
       runtimeAddon: runtimeAddonRegistered(projectPath),
       sourceOf: projectSourceOf(projectPath),
       ...callersName === undefined ? {} : { callersOf: { name: callersName, scripts: () => projectScripts(projectPath) } }
@@ -39873,8 +39920,7 @@ class GodotServer {
     if (run.throughEditor) {
       return await this.profileOfThePlayedGame(going, projectPath, fromProject, limit);
     }
-    const record = run.projectPath === null ? null : readRunRecord(run.projectPath);
-    const path = record !== null && record.pid === run.pid ? record.profile : undefined;
+    const path = run.profile;
     if (path === undefined) {
       return this.createErrorResponse("This run was started without profile: true, and a game this server starts can be profiled only from its start: its debugger is whatever it dials as it starts, once.", ["editor_run start with profile: true starts the run again with the profiler on"]);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gdharness",
-  "version": "1.2.8",
+  "version": "1.2.9",
   "mcpName": "io.github.Aureliolo/gdharness",
   "description": "A harness for driving a Godot 4 project from an agent: editor addons, a runtime bridge into the running game, an MCP server in front of them, and a CLI that installs and diagnoses the Godot side.",
   "type": "module",