gdharness 1.2.41 → 1.2.42

package/build/godot/addons/gdharness_editor/tools/scene_tools.gd

@@ -5,22 +5,14 @@ extends Node
 
 const FileReads = preload("../file_reads.gd")
 const Read = preload("../reading.gd")
+const Kin = preload("scene_kin.gd")
+const Paths = preload("scene_paths.gd")
 const Placing = preload("scene_placing.gd")
 const PropertyValues = preload("../property_values.gd")
 const ResourceTools = preload("resource_tools.gd")
 const SceneFile = preload("../scene_file.gd")
 const Serialisation = preload("../serialisation.gd")
 
-## The names Object.ConnectFlags gives each bit. The number alone left a reader guessing that 2 is
-## the persistence every connection in a saved scene carries.
-const CONNECT_FLAG_NAMES: Dictionary[int, String] = {
-	Object.CONNECT_DEFERRED: "deferred",
-	Object.CONNECT_PERSIST: "persist",
-	Object.CONNECT_ONE_SHOT: "one_shot",
-	Object.CONNECT_REFERENCE_COUNTED: "reference_counted",
-	Object.CONNECT_APPEND_SOURCE_OBJECT: "append_source_object",
-}
-
 var _editor_plugin: EditorPlugin = null
 var _values: Serialisation = Serialisation.new()
 var _properties: PropertyValues = PropertyValues.new()
@@ -30,19 +22,6 @@ func set_editor_plugin(plugin: EditorPlugin) -> void:
 	_editor_plugin = plugin
 
 
-## Each bit set in [param flags] by name, and whatever bits are left unnamed as one number.
-static func _flag_names(flags: int) -> Array[String]:
-	var names: Array[String] = []
-	var rest: int = flags
-	for bit: int in CONNECT_FLAG_NAMES:
-		if flags & bit:
-			names.append(CONNECT_FLAG_NAMES[bit])
-			rest &= ~bit
-	if rest != 0:
-		names.append(str(rest))
-	return names
-
-
 func _ensure_res_path(path: String) -> String:
 	if not path.begins_with("res://"):
 		return "res://" + path
@@ -175,17 +154,42 @@ func _collect_nodes_recursive(node: Node, path: String, out_nodes: Array) -> voi
 		_collect_nodes_recursive(child, child_path, out_nodes)
 
 
+func _inherited(args: Dictionary) -> Dictionary:
+	var project_path: String = str(args.get("projectPath", ""))
+	var script_path: String = str(args.get("script", ""))
+	return Kin.inherited(
+		args,
+		_new_scene_path(args),
+		_to_scene_res_path(project_path, str(args.get("inherits", ""))),
+		"" if script_path.is_empty() else _to_scene_res_path(project_path, script_path)
+	)
+
+
+## The res:// path a create in [param args] writes, given .tscn when it has no extension, or "".
+func _new_scene_path(args: Dictionary) -> String:
+	var scene_path: String = _to_scene_res_path(
+		str(args.get("projectPath", "")), str(args.get("scenePath", ""))
+	)
+	if scene_path == "res://":
+		return ""
+	return scene_path if scene_path.ends_with(".tscn") else scene_path + ".tscn"
+
+
 func create_scene(args: Dictionary) -> Dictionary:
+	if str(args.get("inherits", "")).is_empty():
+		return _create_of_a_class(args)
+	return _inherited(args)
+
+
+func _create_of_a_class(args: Dictionary) -> Dictionary:
 	var project_path: String = str(args.get("projectPath", ""))
-	var scene_path: String = _to_scene_res_path(project_path, str(args.get("scenePath", "")))
+	var scene_path: String = _new_scene_path(args)
 	var root_node_type: String = str(args.get("rootNodeType", "Node"))
 	var root_node_name: String = str(args.get("rootNodeName", root_node_type))
 	var script_path: String = str(args.get("script", ""))
 
-	if scene_path == "res://":
+	if scene_path.is_empty():
 		return {"ok": false, "error": "Missing scenePath"}
-	if not scene_path.ends_with(".tscn"):
-		scene_path += ".tscn"
 	var asked_type: String = root_node_type
 	var made: Dictionary = SceneFile.made_as(
 		root_node_type,
@@ -208,19 +212,8 @@ func create_scene(args: Dictionary) -> Dictionary:
 	var unfit: String = SceneFile.unfit_name(root_node_name)
 	if not unfit.is_empty():
 		return {"ok": false, "error": unfit}
-	# Saving over a scene that is there replaced it, nodes and all, and answered as a new scene.
 	if FileAccess.file_exists(scene_path):
-		return {
-			"ok": false,
-			"error":
-			(
-				(
-					"%s already exists, and scene_create op=create would replace everything in it. Edit it "
-					+ "with scene_node, or create the scene under another path."
-				)
-				% scene_path
-			)
-		}
+		return Kin.taken(scene_path)
 
 	var root: Node = ClassDB.instantiate(root_node_type)
 	root.name = root_node_name
@@ -395,6 +388,8 @@ func delete_node(args: Dictionary) -> Dictionary:
 	var at: String = scene.path_of(node)
 	node.get_parent().remove_child(node)
 	node.free()
+	var carried: Paths = Paths.new()
+	var _rewritten: int = carried.carry(scene, {at: ""})
 
 	var written: Dictionary = scene.write(
 		func(saved: Node) -> String:
@@ -405,7 +400,9 @@ func delete_node(args: Dictionary) -> Dictionary:
 	if not written.is_empty():
 		return written
 
-	return {"ok": true, "deletedNodePath": at}
+	var answer: Dictionary = {"ok": true, "deletedNodePath": at}
+	answer.merge(Kin.follow(scene_path, at, "", carried))
+	return answer
 
 
 func duplicate_node(args: Dictionary) -> Dictionary:
@@ -458,6 +455,7 @@ func duplicate_node(args: Dictionary) -> Dictionary:
 	scene.copied(copies)
 
 	var new_path: String = scene.path_of(duplicated_node)
+	var placed: Array = [scene.path_of(target_parent), duplicated_node.get_index()]
 	var written: Dictionary = scene.write(
 		func(saved: Node) -> String:
 			if saved.get_node_or_null(new_path) == null:
@@ -467,7 +465,14 @@ func duplicate_node(args: Dictionary) -> Dictionary:
 	if not written.is_empty():
 		return written
 
-	return {"ok": true, "nodePath": node_path, "newName": new_name, "newNodePath": new_path}
+	return {
+		"ok": true,
+		"nodePath": node_path,
+		"newName": new_name,
+		"newNodePath": new_path,
+		"parentNodePath": placed[0],
+		"index": placed[1],
+	}
 
 
 func reparent_node(args: Dictionary) -> Dictionary:
@@ -525,6 +530,8 @@ func reparent_node(args: Dictionary) -> Dictionary:
 
 	var new_path: String = scene.path_of(node)
 	var index: int = node.get_index()
+	var carried: Paths = Paths.new()
+	var _rewritten: int = carried.carry(scene, {old_path: new_path} if new_path != old_path else {})
 	var written: Dictionary = scene.write(
 		func(saved: Node) -> String:
 			var copy: Node = saved.get_node_or_null(new_path)
@@ -537,15 +544,19 @@ func reparent_node(args: Dictionary) -> Dictionary:
 			return ""
 	)
 	if not written.is_empty():
+		carried.put_back(scene_path)
 		return written
 
-	return {
+	var answer: Dictionary = {
 		"ok": true,
 		"nodePath": old_path,
 		"newParentPath": new_parent_path,
 		"newNodePath": new_path,
 		"index": index,
 	}
+	if new_path != old_path:
+		answer.merge(Kin.follow(scene_path, old_path, new_path, carried))
+	return answer
 
 
 func set_node_properties(args: Dictionary) -> Dictionary:
@@ -553,6 +564,9 @@ func set_node_properties(args: Dictionary) -> Dictionary:
 	var scene_path: String = _to_scene_res_path(project_path, str(args.get("scenePath", "")))
 	var node_path: String = str(args.get("nodePath", "."))
 	var properties: Dictionary = _parse_properties_arg(args.get("properties", {}))
+	var editable: Variant = args.get("editableChildren")
+	if properties.is_empty() and editable == null:
+		return {"ok": false, "error": "set takes properties, editableChildren, or both."}
 
 	var opened: Array = _open(scene_path, true)
 	var scene: SceneFile = opened[0]
@@ -574,6 +588,15 @@ func set_node_properties(args: Dictionary) -> Dictionary:
 		if not unusable.is_empty():
 			return scene.refuse(unusable)
 
+	var dropped: Dictionary = {}
+	if editable != null:
+		var not_an_instance: String = Kin.set_editable(scene, node, Read.as_bool(editable))
+		if not not_an_instance.is_empty():
+			return scene.refuse(not_an_instance)
+		if not Read.as_bool(editable):
+			dropped = scene.held_under(scene.path_of(node))
+
+	var old_path: String = scene.path_of(node)
 	scene.asked(node, properties.keys())
 	var refused_property: String = _properties.write_all(node, properties)
 	if not refused_property.is_empty():
@@ -583,13 +606,29 @@ func set_node_properties(args: Dictionary) -> Dictionary:
 	for key: Variant in properties:
 		held[str(key)] = _readable(node, _properties.read_at(node, str(key)))
 	var new_path: String = scene.path_of(node)
+	var carried: Paths = Paths.new()
+	var _rewritten: int = carried.carry(scene, {old_path: new_path} if new_path != old_path else {})
 	var written: Dictionary = scene.write(
-		func(saved: Node) -> String: return _kept(scene, saved, node, properties.keys())
+		func(saved: Node) -> String:
+			var unkept: String = _kept(scene, saved, node, properties.keys())
+			if unkept.is_empty() and editable != null:
+				if saved.is_editable_instance(saved.get_node(new_path)) != Read.as_bool(editable):
+					return "%s would load with editableChildren %s." % [new_path, not Read.as_bool(editable)]
+			return unkept
 	)
 	if not written.is_empty():
+		carried.put_back(scene_path)
 		return written
 
-	return {"ok": true, "nodePath": new_path, "properties": held}
+	var answer: Dictionary = {"ok": true, "nodePath": new_path, "properties": held}
+	if editable != null:
+		answer["editableChildren"] = Read.as_bool(editable)
+	if not dropped.is_empty():
+		answer["droppedValues"] = dropped["values"]
+		answer["droppedNodes"] = dropped["nodes"]
+	if new_path != old_path:
+		answer.merge(Kin.follow(scene_path, old_path, new_path, carried))
+	return answer
 
 
 func get_node_properties(args: Dictionary) -> Dictionary:
@@ -614,8 +653,11 @@ func get_node_properties(args: Dictionary) -> Dictionary:
 	# names this scene's file sets are always answered.
 	var props: Dictionary = _properties_of(node, include_defaults, scene.set_here(node))
 	var cells: Dictionary = ResourceTools.cells_of(node)
-	scene.close()
 	var answer: Dictionary = {"ok": true, "nodePath": node_path, "properties": props}
+	if node != scene.root and node.owner != null and not node.scene_file_path.is_empty():
+		answer["instanceOf"] = node.scene_file_path
+		answer["editableChildren"] = scene.root.is_editable_instance(node)
+	scene.close()
 	# Only an editor holds anything unsaved; a headless engine answering false would say it looked.
 	if Engine.is_editor_hint():
 		answer["unsavedInEditor"] = SceneFile.unsaved(scene_path)
@@ -770,7 +812,7 @@ func connect_signal(args: Dictionary) -> Dictionary:
 		"targetNodePath": to,
 		"methodName": method_name,
 		"flags": saved_flags[0],
-		"flagNames": _flag_names(Read.as_int(saved_flags[0])),
+		"flagNames": SceneFile.flag_names(Read.as_int(saved_flags[0])),
 		# Connected either way, as the editor's own dialog allows, since the method may be written
 		# next; a caller told nothing learnt of a misspelt one only when the signal fired.
 		"methodFound": method_found
@@ -781,7 +823,7 @@ func connect_signal(args: Dictionary) -> Dictionary:
 	if flags_before >= 0:
 		answer["alreadyConnected"] = true
 		if flags_before != Read.as_int(saved_flags[0]):
-			answer["flagsBefore"] = _flag_names(flags_before)
+			answer["flagsBefore"] = SceneFile.flag_names(flags_before)
 	return answer
 
 
@@ -934,7 +976,7 @@ func list_connections(args: Dictionary) -> Dictionary:
 							"targetNodePath": target_path,
 							"methodName": str(callable.get_method()),
 							"flags": flags,
-							"flagNames": _flag_names(flags),
+							"flagNames": SceneFile.flag_names(flags),
 							# False for a connection an instanced scene makes inside itself, which only that
 							# scene can change.
 							"editable": editable

package/build/godot/addons/gdharness_runtime/reading.gd

@@ -22,6 +22,9 @@ extends RefCounted
 # number was expected. Absent keys never reach here: the callers pass their own default to
 # `Dictionary.get`, so what arrives is that default.
 
+## How many of a node's children a refusal for a path missing below it names.
+const NAMED_CHILDREN: int = 12
+
 
 static func as_int(value: Variant, fallback: int = 0) -> int:
 	if value is int:
@@ -114,3 +117,25 @@ static func from_the_root(said: String, node_path: String, root_name: String) ->
 	if not rest.is_empty():
 		how += ', so this one is "%s"' % rest
 	return "%s%s %s." % [said, "" if said.ends_with(".") else ".", how]
+
+
+## [param said], the refusal for a path a scene does not have, with where the path leaves it: the
+## last node of the path it has, [param reached] from the root, called [param root_name], when that
+## is empty; the name below it that is missing; and [param children], the names that node has, as
+## after a node was moved or renamed. Names up to [constant NAMED_CHILDREN] of them.
+static func missing_below(
+	said: String, root_name: String, reached: PackedStringArray, missing: String, children: PackedStringArray
+) -> String:
+	var shown: String = ", ".join(children.slice(0, NAMED_CHILDREN))
+	if children.size() > NAMED_CHILDREN:
+		shown += " and %d more" % (children.size() - NAMED_CHILDREN)
+	return (
+		"%s%s %s has no %s; %s."
+		% [
+			said,
+			"" if said.ends_with(".") else ".",
+			"The root, %s," % root_name if reached.is_empty() else "/".join(reached),
+			missing,
+			"its children are " + shown if not children.is_empty() else "it has no children",
+		]
+	)

package/build/godot/addons/gdharness_runtime/serialisation.gd

@@ -664,8 +664,12 @@ func _serialize_array(value: Array) -> Array:
 
 # Base64 rather than a list of numbers. A byte array is a texture, a sound or a save file often
 # enough that the list would be the whole answer, megabytes of it, and unreadable either way.
+#
+# The engine's encoder raises an error on an empty array, and an empty tile_map_data is every
+# TileMapLayer with nothing painted yet, so a read of one carried an engine error in its answer.
 func _serialize_bytes(value: PackedByteArray) -> Dictionary:
-	return {"base64": Marshalls.raw_to_base64(value), "size": value.size(), "_type": "PackedByteArray"}
+	var text: String = "" if value.is_empty() else Marshalls.raw_to_base64(value)
+	return {"base64": text, "size": value.size(), "_type": "PackedByteArray"}
 
 
 # The packed vector and colour arrays, each element serialised the way one of them on its own is.

package/build/godot/operations/animation_reads.gd

@@ -62,10 +62,13 @@ static func _bare(scene_path: String, node_path: String, kind: String) -> Array:
 	var type: String = str(read.get("type", ""))
 	if not ClassDB.class_exists(type) or not ClassDB.is_parent_class(type, kind):
 		var said: String = "%s not found at: %s" % [kind, node_path]
-		if read.is_empty() and FileReads.scene_node(scene_path, node_path.get_slice("/", 0)).is_empty():
-			said = Read.from_the_root(
-				said, node_path, str(FileReads.scene_node(scene_path, ".").get("name", ""))
-			)
+		if read.is_empty():
+			var hinted: String = said
+			if FileReads.scene_node(scene_path, node_path.get_slice("/", 0)).is_empty():
+				hinted = Read.from_the_root(
+					said, node_path, str(FileReads.scene_node(scene_path, ".").get("name", ""))
+				)
+			said = hinted if hinted != said else FileReads.missing_from(said, scene_path, node_path)
 		return [null, {"ok": false, "error": said}]
 	var bare: Node = ClassDB.instantiate(type)
 	bare.name = str(read["name"])

package/build/godot/operations/editor_tools.gd

@@ -10,6 +10,7 @@ extends RefCounted
 const AnimationTools = preload("../addons/gdharness_editor/tools/animation_tools.gd")
 const ResourceTools = preload("../addons/gdharness_editor/tools/resource_tools.gd")
 const SceneTools = preload("../addons/gdharness_editor/tools/scene_tools.gd")
+const SceneFile = preload("../addons/gdharness_editor/scene_file.gd")
 
 const SCENE_COMMANDS: Array[String] = [
 	"create_scene",
@@ -60,7 +61,24 @@ static func run(params: Dictionary) -> Dictionary:
 	var answer: Variant = tools.call(command, arguments)
 	tools.free()
 	if answer is Dictionary:
-		return answer
+		var answered: Dictionary = answer
+		if not SceneFile.by_path.is_empty():
+			answered["namedByPath"] = (
+				(
+					"%s %s named by path rather than by uid. A uid in a file's own header is resolved "
+					+ "through the project's uid cache, which holds none for %s yet, as with a file "
+					+ "made since the project was last scanned, and a uid it does not hold would warn "
+					+ "on every load. project_import refresh_uids scans the project, and writes after "
+					+ "it name %s by uid."
+				)
+				% [
+					", ".join(SceneFile.by_path),
+					"is" if SceneFile.by_path.size() == 1 else "are",
+					"it" if SceneFile.by_path.size() == 1 else "them",
+					"it" if SceneFile.by_path.size() == 1 else "them",
+				]
+			)
+		return answered
 	return {
 		"ok": false, "error": "%s answered %s rather than an object." % [command, type_string(typeof(answer))]
 	}

package/build/godot/operations/file_reads.gd

@@ -15,9 +15,10 @@ const Read = preload("reading.gd")
 const Serialisation = preload("serialisation.gd")
 
 
-## The nodes of [param scene_path] as {name, type, path, children}, with instanceOf on a node that
-## instances another scene and every stored property when [param include_properties] is set, the
-## file's value or the default where it sets none. [param depth] -1 reads every level.
+## The nodes of [param scene_path] as {name, type, path, children}, with instanceOf and
+## editableChildren on a node that instances another scene and every stored property when
+## [param include_properties] is set, the file's value or the default where it sets none.
+## [param depth] -1 reads every level.
 static func scene_tree(scene_path: String, depth: int, include_properties: bool) -> Dictionary:
 	var laid: Dictionary = _laid(scene_path)
 	if not laid.get("ok", false):
@@ -41,6 +42,31 @@ static func scene_node(scene_path: String, node_path: String) -> Dictionary:
 	return {"ok": true, "name": found["name"], "type": found["type"], "properties": found["properties"]}
 
 
+## [param said], the refusal for [param node_path], which [param scene_path] does not have, with
+## where the path leaves the scene as [method Read.missing_below] says it.
+static func missing_from(said: String, scene_path: String, node_path: String) -> String:
+	var laid: Dictionary = _laid(scene_path)
+	if not laid.get("ok", false):
+		return said
+	var nodes: Dictionary = laid["nodes"]
+	var parts: PackedStringArray = node_path.trim_prefix("./").split("/", false)
+	var at: String = "."
+	var reached: PackedStringArray = []
+	for part: String in parts:
+		var below: String = _joined(at, part)
+		if not nodes.has(below):
+			break
+		at = below
+		var _walked: bool = reached.append(part)
+	if reached.size() >= parts.size():
+		return said
+	var names: PackedStringArray = []
+	var children: Array[String] = nodes[at]["children"]
+	for child: String in children:
+		var _named: bool = names.append(str(nodes[child]["name"]))
+	return Read.missing_below(said, str(nodes["."]["name"]), reached, parts[reached.size()], names)
+
+
 ## Every node of [param scene_path] as {ok, nodes}, keyed by path, or a refusal.
 static func _laid(scene_path: String) -> Dictionary:
 	if not FileAccess.file_exists(scene_path):
@@ -51,13 +77,11 @@ static func _laid(scene_path: String) -> Dictionary:
 	if loaded == null:
 		return {"ok": false, "error": "Failed to load %s as a scene" % scene_path}
 	if not loaded is PackedScene:
+		var kind: String = loaded.get_class()
+		var sort: String = ("an " if kind.left(1).to_upper() in ["A", "E", "I", "O", "U"] else "a ") + kind
 		return {
 			"ok": false,
-			"error":
-			(
-				"%s is a %s, not a scene: resource_edit read reads its properties."
-				% [scene_path, loaded.get_class()]
-			)
+			"error": "%s is %s, not a scene: resource_edit read reads its properties." % [scene_path, sort]
 		}
 	var packed: PackedScene = loaded
 	var nodes: Dictionary = {}
@@ -82,8 +106,18 @@ static func _lay(state: SceneState, prefix: String, nodes: Dictionary, within: A
 		var refused: String = _lay(base, prefix, nodes, within)
 		if not refused.is_empty():
 			return refused
+	var ids: Array[int] = _unique_ids(state.get_path(), state.get_node_count())
 	for index: int in state.get_node_count():
 		var path: String = _joined(prefix, str(state.get_node_path(index)))
+		var recovered: bool = false
+		if not nodes.has(path) and index > 0 and _overrides(state, index) and ids[index] >= 0:
+			# The engine finds an entry whose node was renamed or moved in the scene it comes from by
+			# the node's unique_id, and keeps the node's new name.
+			var parent: String = _joined(prefix, str(state.get_node_path(index, true)))
+			var found: String = _by_id(nodes, _owner_of(nodes, parent, prefix), ids[index])
+			recovered = not found.is_empty()
+			if recovered:
+				path = found
 		var fresh: bool = not nodes.has(path)
 		if fresh:
 			var instance: PackedScene = state.get_node_instance(index)
@@ -98,6 +132,7 @@ static func _lay(state: SceneState, prefix: String, nodes: Dictionary, within: A
 				if not nodes.has(path):
 					return "%s holds no nodes" % instance.resource_path
 				nodes[path]["instanceOf"] = instance.resource_path
+				nodes[path]["editableChildren"] = false
 			elif state.is_node_instance_placeholder(index):
 				nodes[path] = _made("InstancePlaceholder")
 				nodes[path]["instanceOf"] = state.get_node_instance_placeholder(index)
@@ -106,9 +141,12 @@ static func _lay(state: SceneState, prefix: String, nodes: Dictionary, within: A
 				continue
 			else:
 				nodes[path] = _made(str(state.get_node_type(index)))
+			if ids[index] >= 0:
+				nodes[path]["uniqueId"] = ids[index]
 		# The name is the state's even for an entry laid already, since an inherited scene names its
 		# root itself; a root instanced inside another scene is renamed by that scene once laid.
-		nodes[path]["name"] = str(state.get_node_name(index))
+		if not recovered:
+			nodes[path]["name"] = str(state.get_node_name(index))
 		if fresh:
 			# The root of what is laid here is placed by whoever instanced it.
 			if path != prefix:
@@ -123,6 +161,86 @@ static func _lay(state: SceneState, prefix: String, nodes: Dictionary, within: A
 			held[str(state.get_node_property_name(index, property))] = state.get_node_property_value(
 				index, property
 			)
+	# Only the scene being read and the scenes it inherits share its root, the owner whose editable
+	# instances a write here sets; a file instanced below makes its own owner's editable.
+	if prefix == ".":
+		for editable: String in _editable_in(state.get_path()):
+			var at: String = _joined(prefix, editable)
+			var marked: Dictionary = nodes.get(at, {})
+			if marked.has("editableChildren"):
+				marked["editableChildren"] = true
+	return ""
+
+
+## The paths of the instances [param scene_path] gives editable children, from its root. SceneState
+## does not give them to a script, so they are read off the scene's bundle.
+static func _editable_in(scene_path: String) -> PackedStringArray:
+	var found: PackedStringArray = []
+	var loaded: Resource = ResourceLoader.load(scene_path, "", ResourceLoader.CACHE_MODE_IGNORE)
+	if not loaded is PackedScene:
+		return found
+	var given: Variant = loaded.get("_bundled")
+	if not given is Dictionary:
+		return found
+	var bundled: Dictionary = given
+	var listed: Variant = bundled.get("editable_instances", [])
+	if listed is Array:
+		for one: Variant in listed:
+			var _kept: bool = found.append(str(one))
+	return found
+
+
+## The unique_id of each node entry in the text scene at [param scene_path], in the order its state
+## holds them, -1 where an entry has none. All -1 for a binary scene, and for a file whose entries do
+## not number [param count], since SceneState does not give the ids to a script.
+static func _unique_ids(scene_path: String, count: int) -> Array[int]:
+	var ids: Array[int] = []
+	var _sized: int = ids.resize(count)
+	ids.fill(-1)
+	if not scene_path.ends_with(".tscn") or not FileAccess.file_exists(scene_path):
+		return ids
+	var read: Array[int] = []
+	var pattern: RegEx = RegEx.create_from_string(" unique_id=(\\d+)")
+	for line: String in FileAccess.get_file_as_string(scene_path).split("\n"):
+		if line.begins_with("[node "):
+			var found: RegExMatch = pattern.search(line)
+			read.append(int(found.get_string(1)) if found != null else -1)
+	return read if read.size() == count else ids
+
+
+## Whether entry [param index] of [param state] only sets values on a node another file makes.
+static func _overrides(state: SceneState, index: int) -> bool:
+	return (
+		state.get_node_instance(index) == null
+		and not state.is_node_instance_placeholder(index)
+		and str(state.get_node_type(index)).is_empty()
+	)
+
+
+## The node whose file owns what sits under [param parent]: the nearest instance at or above it, or
+## [param prefix], the root of what is being laid, as the engine searches.
+static func _owner_of(nodes: Dictionary, parent: String, prefix: String) -> String:
+	var at: String = parent
+	while at != prefix and at != "." and nodes.has(at):
+		var entry: Dictionary = nodes[at]
+		if entry.has("instanceOf"):
+			break
+		at = "." if not at.contains("/") else at.get_base_dir()
+	return at if nodes.has(at) else prefix
+
+
+## The path of the node [param owner] owns whose unique_id is [param id], or "": one under an instance
+## nested below [param owner] belongs to that instance's file, whose ids are numbered apart.
+static func _by_id(nodes: Dictionary, owner: String, id: int) -> String:
+	for path: String in nodes:
+		if path == owner or not (owner == "." or path.begins_with(owner + "/")):
+			continue
+		var entry: Dictionary = nodes[path]
+		if Read.as_int(entry.get("uniqueId", -1), -1) != id:
+			continue
+		var above: String = "." if not path.contains("/") else path.get_base_dir()
+		if _owner_of(nodes, above, owner) == owner:
+			return path
 	return ""
 
 
@@ -162,12 +280,18 @@ static func _entry(
 	# The root's file is the scene being read, so only another node's names a second scene.
 	if path != "." and node.has("instanceOf"):
 		data["instanceOf"] = node["instanceOf"]
+		if node.has("editableChildren"):
+			data["editableChildren"] = node["editableChildren"]
 	if include_properties:
 		var given: Dictionary = node["properties"]
 		data["properties"] = _stored(str(node["type"]), given)
+	var below: Array[String] = node["children"]
+	# Counted rather than left as an empty list, which reads as a node with no children.
 	if depth >= 0 and current_depth >= depth:
+		if not below.is_empty():
+			data["childrenNotListed"] = below.size()
 		return data
-	for child: String in node["children"]:
+	for child: String in below:
 		children.append(_entry(nodes, child, include_properties, depth, current_depth + 1))
 	return data
 

package/build/godot/operations/reading.gd

@@ -22,6 +22,9 @@ extends RefCounted
 # number was expected. Absent keys never reach here: the callers pass their own default to
 # `Dictionary.get`, so what arrives is that default.
 
+## How many of a node's children a refusal for a path missing below it names.
+const NAMED_CHILDREN: int = 12
+
 
 static func as_int(value: Variant, fallback: int = 0) -> int:
 	if value is int:
@@ -114,3 +117,25 @@ static func from_the_root(said: String, node_path: String, root_name: String) ->
 	if not rest.is_empty():
 		how += ', so this one is "%s"' % rest
 	return "%s%s %s." % [said, "" if said.ends_with(".") else ".", how]
+
+
+## [param said], the refusal for a path a scene does not have, with where the path leaves it: the
+## last node of the path it has, [param reached] from the root, called [param root_name], when that
+## is empty; the name below it that is missing; and [param children], the names that node has, as
+## after a node was moved or renamed. Names up to [constant NAMED_CHILDREN] of them.
+static func missing_below(
+	said: String, root_name: String, reached: PackedStringArray, missing: String, children: PackedStringArray
+) -> String:
+	var shown: String = ", ".join(children.slice(0, NAMED_CHILDREN))
+	if children.size() > NAMED_CHILDREN:
+		shown += " and %d more" % (children.size() - NAMED_CHILDREN)
+	return (
+		"%s%s %s has no %s; %s."
+		% [
+			said,
+			"" if said.ends_with(".") else ".",
+			"The root, %s," % root_name if reached.is_empty() else "/".join(reached),
+			missing,
+			"its children are " + shown if not children.is_empty() else "it has no children",
+		]
+	)

package/build/godot/operations/serialisation.gd

@@ -664,8 +664,12 @@ func _serialize_array(value: Array) -> Array:
 
 # Base64 rather than a list of numbers. A byte array is a texture, a sound or a save file often
 # enough that the list would be the whole answer, megabytes of it, and unreadable either way.
+#
+# The engine's encoder raises an error on an empty array, and an empty tile_map_data is every
+# TileMapLayer with nothing painted yet, so a read of one carried an engine error in its answer.
 func _serialize_bytes(value: PackedByteArray) -> Dictionary:
-	return {"base64": Marshalls.raw_to_base64(value), "size": value.size(), "_type": "PackedByteArray"}
+	var text: String = "" if value.is_empty() else Marshalls.raw_to_base64(value)
+	return {"base64": text, "size": value.size(), "_type": "PackedByteArray"}
 
 
 # The packed vector and colour arrays, each element serialised the way one of them on its own is.