gdharness 1.2.38 → 1.2.39

package/build/godot/addons/gdharness_runtime/runtime_autoload.gd

@@ -352,11 +352,14 @@ func _process(_delta: float) -> void:
 	_queries.note_frame(Time.get_ticks_usec())
 	_calibrate_the_profiler()
 
-	if _server.is_connection_available():
+	# Every connection waiting rather than one a frame: the engine queues eight a game has not
+	# taken and refuses the rest, so calls sent together would be refused as if the game were not up.
+	while _server.is_connection_available():
 		var client: StreamPeerTCP = _server.take_connection()
-		if client:
-			_clients.append(client)
-			_send_welcome(client)
+		if client == null:
+			break
+		_clients.append(client)
+		_send_welcome(client)
 
 	var gone: Array[StreamPeerTCP] = []
 	for client: StreamPeerTCP in _clients:

package/build/godot/addons/gdharness_runtime/runtime_capture.gd

@@ -343,6 +343,16 @@ func _capture(viewport: Viewport, params: Dictionary, with_windows: bool = false
 	var screenshot_path: String = requested_path
 	if screenshot_path.begins_with("user://") or screenshot_path.begins_with("res://"):
 		screenshot_path = ProjectSettings.globalize_path(screenshot_path)
+	# The server makes the folder for each capture and takes it away when it stops waiting for one,
+	# and a server replaced since the capture was asked for took it with it. Saving into a folder that
+	# is gone raises an engine error, which counts against a game that did nothing wrong.
+	if not DirAccess.dir_exists_absolute(screenshot_path.get_base_dir()):
+		return _refused(
+			(
+				"The folder to save the capture in, %s, is gone: the server that asked for it stopped waiting"
+				% screenshot_path.get_base_dir()
+			)
+		)
 	var save_error: Error = image.save_png(screenshot_path)
 	if save_error != OK:
 		return {"type": "error", "message": "Failed to save screenshot as PNG: " + str(save_error)}

package/build/godot/addons/gdharness_runtime/runtime_changes.gd

@@ -164,8 +164,8 @@ func _argument_for(
 			"type": "error",
 			"message":
 			(
-				"%s.%s takes %s as argument %d and was given %s, which it would have to be cut to fit"
-				% [called, named, type_string(wants), index + 1, JSON.stringify(sent)]
+				"%s.%s takes %s as argument %d and was given %s, which %s cannot hold without changing it"
+				% [called, named, type_string(wants), index + 1, JSON.stringify(sent), Values.cut_by(wants)]
 			)
 		}
 	var rounded: String = Values.inexact(sent, wants)
@@ -259,8 +259,8 @@ func _value_for(
 			"type": "error",
 			"message":
 			(
-				"%s.%s holds %s and the value given is %s, which it would have to be cut to fit"
-				% [called, named, type_string(wanted), JSON.stringify(value)]
+				"%s.%s holds %s and the value given is %s, which %s cannot hold without changing it"
+				% [called, named, type_string(wanted), JSON.stringify(value), Values.cut_by(wanted)]
 			)
 		}
 	if declared != TYPE_NIL or (not cut and Values.acceptable(as_sent, wanted)):
@@ -563,6 +563,10 @@ static func _walk_from(object: Object, path: String) -> Dictionary:
 ## null, and the method list says how many a method takes: its parameters less those with defaults,
 ## up to all of them, or any number past that for one taking varargs.
 static func _argument_count_refused(holder: Object, method: String, given: int) -> String:
+	# A node's method list runs to hundreds of entries, and walking it costs a couple of milliseconds
+	# of the game's frame; a call giving exactly the arguments the method declares needs no walk.
+	if given == holder.get_method_argument_count(method):
+		return ""
 	for entry: Dictionary in holder.get_method_list():
 		if str(entry.get("name", "")) != method:
 			continue

package/build/godot/addons/gdharness_runtime/runtime_values.gd

@@ -156,6 +156,11 @@ static func cuts(given: Variant, type: int) -> bool:
 	return not (whole and (value == 0.0 or value == 1.0))
 
 
+## The slot [method cuts] speaks of, with its article, for a refusal to name: "an int" or "a bool".
+static func cut_by(type: int) -> String:
+	return "an int" if type == TYPE_INT else "a bool"
+
+
 ## Why [param given] may not be the whole number sent, or "": see [method Serialisation.inexact].
 static func inexact(given: Variant, type: int) -> String:
 	return Serialisation.inexact(given, type)

package/build/godot/addons/gdharness_runtime/runtime_waits.gd

@@ -411,10 +411,10 @@ static func _cut_to_fit(given: Variant, type: int, node_path: String, property:
 		return ""
 	return (
 		(
-			"%s.%s holds %s and the value to wait for is %s, which it would have to be cut to fit:"
+			"%s.%s holds %s and the value to wait for is %s, which %s cannot hold without changing it:"
 			+ " waiting on it would answer about a state nobody asked for."
 		)
-		% [node_path, property, type_string(type), str(given)]
+		% [node_path, property, type_string(type), str(given), Values.cut_by(type)]
 	)