gdharness 1.2.13 → 1.2.14

package/build/cli.js

@@ -11005,7 +11005,7 @@ var init_tool_definitions = __esm(() => {
     {
       name: "project_settings",
       title: "Project settings",
-      description: "Reads or writes project.godot: settings, autoloads, the main scene, input actions, plugins and audio buses. A write with an editor open on the project is handed to the editor, which takes the settings the write changed or names from the file (named under editorAdopted), including a setting the file already held, since the editor can hold another value after the file was put back, or reloads the bus layout, so it answers the new values and does not save the old ones back over them. editorNote is an editor that could not take the write, one on an addon from before this, which still holds the old values until editor_launch restart. An enabled plugin's code still loads on the editor's next start.",
+      description: "Reads or writes project.godot: settings, autoloads, the main scene, input actions, plugins and audio buses. A write with an editor open on the project is handed to the editor, which takes the settings the write changed or names from the file (named under editorAdopted), including a setting the file already held, since the editor can hold another value after the file was put back, or reloads the bus layout, so it answers the new values and does not save the old ones back over them. editorNote is an editor that could not take the write, one on an addon from before this, which still holds the old values until editor_launch restart. An enabled plugin's code still loads on the editor's next start. set answers old_value and new_value, with was_new true when project.godot did not set the setting before, and was_default true when what it held was the engine's own default, which old_value then is.",
       parameters: {
         projectPath: PROJECT_PATH,
         setting: { type: "string", description: 'Setting path, such as "display/window/size/viewport_width".' },
@@ -11708,7 +11708,7 @@ var init_tool_definitions = __esm(() => {
         },
         check: {
           effect: "additive",
-          summary: "boot headless, quit after a few frames, and report the verdict",
+          summary: "boot headless, quit after a few frames, and report the verdict. booted is that verdict rather than whether the game came up: true only for a run that quit on its own within timeoutMs, exited 0 and printed no error, so a game that reached _ready and then raised an error answers false. hung is a run killed at timeoutMs, and errors and warnings count what it printed, which comes back under entries with repeats folded together",
           requires: ["projectPath"]
         },
         wait: {

package/build/godot/operations/classdb_queries.gd

@@ -283,6 +283,7 @@ func _methods_of(class_name_str: String, include_inherited: bool) -> Array[Dicti
 				{
 					"name": a.get("name", ""),
 					"type": a.get("type", 0),
+					"type_name": _type_name(a, "Variant"),
 					"class_name": a.get("class_name", ""),
 					"hint_string": a.get("hint_string", "")
 				}
@@ -293,7 +294,11 @@ func _methods_of(class_name_str: String, include_inherited: bool) -> Array[Dicti
 				"name": m.get("name", ""),
 				"args": args,
 				"return":
-				{"type": return_info.get("type", 0), "class_name": return_info.get("class_name", "")},
+				{
+					"type": return_info.get("type", 0),
+					"type_name": _type_name(return_info, "void"),
+					"class_name": return_info.get("class_name", "")
+				},
 				"flags": m.get("flags", 0),
 				"default_args": m.get("default_args", [])
 			}
@@ -302,6 +307,20 @@ func _methods_of(class_name_str: String, include_inherited: bool) -> Array[Dicti
 	return methods
 
 
+# What [param info]'s type is called: its class for an object of one, and otherwise the engine's own
+# name for the type, beside the number the engine reports, which reads as nothing without its enum.
+# Nil is a value that can be anything when the usage says so, and [param nil_name] otherwise: void
+# for what a method returns, and Variant for an argument or property with no type.
+static func _type_name(info: Dictionary, nil_name: String) -> String:
+	var type: int = Read.as_int(info.get("type", 0))
+	var named: String = str(info.get("class_name", ""))
+	if type == TYPE_OBJECT and not named.is_empty():
+		return named
+	if type == TYPE_NIL:
+		return "Variant" if Read.as_int(info.get("usage", 0)) & PROPERTY_USAGE_NIL_IS_VARIANT else nil_name
+	return type_string(type)
+
+
 func _properties_of(class_name_str: String, include_inherited: bool) -> Array[Dictionary]:
 	var properties: Array[Dictionary] = []
 
@@ -314,6 +333,7 @@ func _properties_of(class_name_str: String, include_inherited: bool) -> Array[Di
 			{
 				"name": p.get("name", ""),
 				"type": p.get("type", 0),
+				"type_name": _type_name(p, "Variant"),
 				"class_name": p.get("class_name", ""),
 				"hint": p.get("hint", 0),
 				"hint_string": p.get("hint_string", ""),
@@ -332,7 +352,12 @@ func _signals_of(class_name_str: String, include_inherited: bool) -> Array[Dicti
 		var declared_args: Array = s.get("args", [])
 		for a: Dictionary in declared_args:
 			sig_args.append(
-				{"name": a.get("name", ""), "type": a.get("type", 0), "class_name": a.get("class_name", "")}
+				{
+					"name": a.get("name", ""),
+					"type": a.get("type", 0),
+					"type_name": _type_name(a, "Variant"),
+					"class_name": a.get("class_name", "")
+				}
 			)
 		signals.append({"name": s.get("name", ""), "args": sig_args})
 

package/build/godot/operations/import_pipeline.gd

@@ -103,7 +103,16 @@ func get_import_status(params: Dictionary) -> Dictionary:
 
 			_tally(summary, status)
 
-	return {"resources": resources, "summary": summary}
+	var answer: Dictionary = {"resources": resources, "summary": summary}
+	# A total of none reads as a walk that found nothing when the project is full of scripts and
+	# scenes, which the engine loads as they are and never imports.
+	if resource_path.is_empty() and summary["total"] == 0:
+		answer["note"] = (
+			"Nothing in this project is imported: the engine imports images, audio, fonts, models and"
+			+ " the like, found by extension or by a .import sidecar beside them, and loads scripts and"
+			+ " scenes as they are."
+		)
+	return answer
 
 
 # Get import options for a resource

package/build/godot/operations/project_config.gd

@@ -94,6 +94,11 @@ func set_project_setting(params: Dictionary) -> Dictionary:
 	var had_value: bool = ProjectSettings.has_setting(setting_path)
 	if had_value:
 		old_value = ProjectSettings.get_setting(setting_path)
+	# A setting the engine registers is there with its default whether or not project.godot sets it,
+	# so has_setting alone called the description of a project that had never set one an old value.
+	# At its default, the file does not set it: the engine drops a key at its default when it saves.
+	var default_value: Variant = ProjectSettings.property_get_revert(setting_path)
+	var was_default: bool = had_value and default_value != null and old_value == default_value
 
 	var final_value: Variant = _values.deserialize_value(value)
 	var wanted: int = _wanted_type(setting_path, old_value if had_value else null)
@@ -116,7 +121,8 @@ func set_project_setting(params: Dictionary) -> Dictionary:
 		"setting_path": setting_path,
 		"old_value": _values.serialize_value(old_value) if had_value else null,
 		"new_value": _values.serialize_value(final_value),
-		"was_new": not had_value,
+		"was_new": not had_value or was_default,
+		"was_default": was_default,
 		"saved": true,
 	}
 

package/build/godot/operations/project_diagnostics.gd

@@ -30,16 +30,9 @@ func get_project_health(params: Dictionary) -> Dictionary:
 		if not FileAccess.file_exists("res://project.godot"):
 			details.append("Missing project.godot file")
 			deductions += 30
-
-		var recommended_dirs: Array[String] = ["res://scenes", "res://scripts", "res://assets"]
-		var missing_dirs: Array[String] = []
-		for dir: String in recommended_dirs:
-			if not DirAccess.dir_exists_absolute(ProjectSettings.globalize_path(dir)):
-				missing_dirs.append(dir)
-
-		if missing_dirs.size() > 0:
-			details.append("Consider organizing with directories: " + ", ".join(missing_dirs))
-			deductions += 2 * missing_dirs.size()
+		# No layout is asked for. A project without res://scenes, res://scripts and res://assets
+		# failed this check and lost points, while Godot's own guidance is to keep a scene's files
+		# together by feature, so the check failed projects for following the engine's advice.
 
 		checks["structure"] = {"name": "Project Structure", "passed": details.is_empty(), "details": details}
 
@@ -74,7 +67,6 @@ func get_project_health(params: Dictionary) -> Dictionary:
 
 		var script_files: Array[String] = _files.find_files("res://", ".gd")
 		var todo_count: int = 0
-		var empty_functions: int = 0
 
 		for script_path: String in script_files:
 			var file: FileAccess = FileAccess.open(script_path, FileAccess.READ)
@@ -84,16 +76,12 @@ func get_project_health(params: Dictionary) -> Dictionary:
 
 				if "# TODO" in content or "# FIXME" in content:
 					todo_count += 1
-				if "pass # " in content or content.ends_with("pass\n"):
-					empty_functions += 1
 
+		# Work noted for later, which no script fails on, so said rather than failed. A count of
+		# "empty functions" read off a script ending in `pass` went with it: a virtual left for an
+		# override to fill ends that way and is exactly right.
 		if todo_count > 0:
-			details.append(str(todo_count) + " scripts have TODO/FIXME comments")
-			deductions += todo_count
-
-		if empty_functions > 0:
-			details.append(str(empty_functions) + " scripts may have empty functions")
-			deductions += empty_functions
+			recommendations.append("%d scripts have TODO or FIXME comments to look at" % todo_count)
 
 		checks["scripts"] = {
 			"name": "Scripts",
@@ -136,10 +124,6 @@ func get_project_health(params: Dictionary) -> Dictionary:
 			details.append("No project name set")
 			deductions += 2
 
-		if not FileAccess.file_exists("res://export_presets.cfg"):
-			details.append("No export presets configured")
-			deductions += 3
-
 		checks["config"] = {"name": "Configuration", "passed": details.is_empty(), "details": details}
 
 	var score: int = maxi(0, 100 - deductions)
@@ -156,11 +140,11 @@ func get_project_health(params: Dictionary) -> Dictionary:
 	else:
 		grade = "F"
 
-	if deductions > 0:
-		if score < 70:
-			recommendations.append("Address critical issues to improve project stability")
-		if not FileAccess.file_exists("res://export_presets.cfg"):
-			recommendations.append("Configure export presets for your target platforms")
+	if score < 70:
+		recommendations.append("Address critical issues to improve project stability")
+	# A project still being made has no presets yet, which is no fault in it.
+	if "config" in check_categories and not FileAccess.file_exists("res://export_presets.cfg"):
+		recommendations.append("No export presets are configured: add them before exporting")
 
 	# Every detail costs points, so each is an issue; `issues` was always empty beside them, and a
 	# category said passed next to the failure it had just found.

package/build/index.js

@@ -33895,7 +33895,7 @@ var TOOL_SPECS = [
   {
     name: "project_settings",
     title: "Project settings",
-    description: "Reads or writes project.godot: settings, autoloads, the main scene, input actions, plugins and audio buses. A write with an editor open on the project is handed to the editor, which takes the settings the write changed or names from the file (named under editorAdopted), including a setting the file already held, since the editor can hold another value after the file was put back, or reloads the bus layout, so it answers the new values and does not save the old ones back over them. editorNote is an editor that could not take the write, one on an addon from before this, which still holds the old values until editor_launch restart. An enabled plugin's code still loads on the editor's next start.",
+    description: "Reads or writes project.godot: settings, autoloads, the main scene, input actions, plugins and audio buses. A write with an editor open on the project is handed to the editor, which takes the settings the write changed or names from the file (named under editorAdopted), including a setting the file already held, since the editor can hold another value after the file was put back, or reloads the bus layout, so it answers the new values and does not save the old ones back over them. editorNote is an editor that could not take the write, one on an addon from before this, which still holds the old values until editor_launch restart. An enabled plugin's code still loads on the editor's next start. set answers old_value and new_value, with was_new true when project.godot did not set the setting before, and was_default true when what it held was the engine's own default, which old_value then is.",
     parameters: {
       projectPath: PROJECT_PATH2,
       setting: { type: "string", description: 'Setting path, such as "display/window/size/viewport_width".' },
@@ -34598,7 +34598,7 @@ var TOOL_SPECS = [
       },
       check: {
         effect: "additive",
-        summary: "boot headless, quit after a few frames, and report the verdict",
+        summary: "boot headless, quit after a few frames, and report the verdict. booted is that verdict rather than whether the game came up: true only for a run that quit on its own within timeoutMs, exited 0 and printed no error, so a game that reached _ready and then raised an error answers false. hung is a run killed at timeoutMs, and errors and warnings count what it printed, which comes back under entries with repeats folded together",
         requires: ["projectPath"]
       },
       wait: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gdharness",
-  "version": "1.2.13",
+  "version": "1.2.14",
   "mcpName": "io.github.Aureliolo/gdharness",
   "description": "A harness for driving a Godot 4 project from an agent: editor addons, a runtime bridge into the running game, an MCP server in front of them, and a CLI that installs and diagnoses the Godot side.",
   "type": "module",