gdharness 1.1.33 → 1.1.34

package/build/cli.js

@@ -17758,7 +17758,7 @@ var init_tool_definitions = __esm(() => {
     },
     {
       name: "script_edit",
-      description: "Creates a GDScript file, or adds functions, variables and signals to one. Every declaration written carries a type. Both load what they wrote under the project's own warning settings and answer with parses; the engine's reasons for a refusal come back under engine_messages. create answers with the extends and class_name the engine read, and a script declaring a class_name is put in the project's class list, with registered saying whether it is there. modify makes every addition or none, and answers with the line each one is on in the file written. rename renames a class or a member wherever the engine uses it and writes every file or none: changed lists each file with its changed lines as they now read, and leftAlone lists every other whole-word occurrence of the old name with what the tokenizer makes of it (code, string, comment, doc, nodePath, scene, text, or ignored for a file under a .gdignore directory, which is never changed) and, where it is not plain, why: a find_children string, a word in a comment, a node named like the class, a call on a value whose type the analyser could not tell. Read leftAlone before calling the rename done; nothing in it was changed. Afterwards an open editor scans the changed files and reloads every changed script, which is also the compile check, and its answer comes back under editor; with no editor the class cache is rebuilt and the changed scripts are compiled in a fresh engine, under classCache and compiled.",
+      description: "Creates a GDScript file, or adds functions, variables and signals to one. Every declaration written carries a type. Both load what they wrote under the project's own warning settings and answer with parses; the engine's reasons for a refusal come back under engine_messages. create answers with the extends and class_name the engine read, and a script declaring a class_name is put in the project's class list, with registered saying whether it is there. modify makes every addition or none, and answers with the line each one is on in the file written. rename renames a class or a member wherever the engine uses it and writes every file or none. A new name already taken is refused with nothing written, a member's included when a class inheriting it already uses the name in code, as a local or a parameter. changed lists each file with its changed lines as they now read, and leftAlone lists every other whole-word occurrence of the old name with what the tokenizer makes of it (code, string, comment, doc, nodePath, scene, text, or ignored for a file under a .gdignore directory, which is never changed) and, where it is not plain, why: a find_children string, a node named like the class, a call on a value whose type the analyser could not tell. A comment or a line of a text file with nothing more to say is given under leftAloneInProse by file and line instead. Read both before calling the rename done; nothing in them was changed. Afterwards an open editor scans the changed files and reloads every changed script, which is also the compile check, and its answer comes back under editor; with no editor the class cache is rebuilt and the changed scripts are compiled in a fresh engine, under classCache and compiled. written is true once the files are written, and ok is false when what came after the write failed: the files are left changed, and note says so.",
       parameters: {
         projectPath: PROJECT_PATH,
         scriptPath: SCRIPT_PATH,
@@ -40684,6 +40684,20 @@ async function renameSymbol(request, services) {
         conflicts.push(`${newName} is already declared in ${id.endsWith("#") ? fileOf(id) : `${fileOf(id)}, class ${id.slice(id.lastIndexOf("#") + 1)}`}`);
       }
     }
+    const heirs = graph.descendants(root);
+    const inUse = [];
+    for (const script of scripts.values()) {
+      for (const occurrence of script.occurrences(newName)) {
+        const body = graph.bodyAt(script.path, occurrence.offset);
+        if (occurrence.kind === "code" && !occurrence.afterDot && heirs.has(body) && graph.declaration(body, newName)?.offset !== occurrence.offset) {
+          inUse.push({ file: script.path, line: script.lines.positionOf(occurrence.offset).line + 1 });
+        }
+      }
+    }
+    if (inUse.length > 0) {
+      const places = inUse.sort((a, b) => a.file.localeCompare(b.file) || a.line - b.line).slice(0, 10).map((place) => `${place.file}:${place.line}`);
+      conflicts.push(`${newName} is already used in code where ${symbol} is inherited, as a local, a parameter or another name the renamed ${what} would shadow or be shadowed by, at ${places.join(", ")}${inUse.length > places.length ? ` and ${inUse.length - places.length} more` : ""}`);
+    }
     if (conflicts.length > 0) {
       return {
         ok: false,
@@ -40755,7 +40769,7 @@ async function renameSymbol(request, services) {
       ...overrides.length > 0 ? { overridesRenamed: overrides } : {},
       ...moveTo === null ? {} : { moved: { from: declaringPath, to: moveTo } },
       changed: changedReport(plan.edits, rewrites),
-      leftAlone: plan.mentions,
+      ...leftAloneReport(plan.mentions),
       summary: summaryOf(plan.edits, plan.mentions, rewrites)
     }
   };
@@ -40850,6 +40864,27 @@ function changedReport(edits, rewrites) {
     };
   });
 }
+function leftAloneReport(mentions) {
+  const full = [];
+  const prose = new Map;
+  for (const mention of mentions) {
+    if ((mention.kind === "comment" || mention.kind === "text") && mention.why === undefined) {
+      const key = `${mention.file}
+${mention.kind}`;
+      const group = prose.get(key) ?? { file: mention.file, kind: mention.kind, lines: [] };
+      if (!group.lines.includes(mention.line)) {
+        group.lines.push(mention.line);
+      }
+      prose.set(key, group);
+    } else {
+      full.push(mention);
+    }
+  }
+  return {
+    leftAlone: full,
+    ...prose.size > 0 ? { leftAloneInProse: [...prose.values()] } : {}
+  };
+}
 function summaryOf(edits, mentions, rewrites) {
   const count = (values) => {
     const counted = {};
@@ -45995,7 +46030,18 @@ class GodotServer {
       rebuildCache: outcome.isClass || outcome.moved !== null,
       moved: outcome.moved !== null
     });
-    return this.jsonTextResponse({ ok: settled.ok, ...outcome.report, ...settled.report });
+    const said = readString(settled.report, "note");
+    const leftChanged = settled.ok ? said : [
+      "The rename was written: every file under changed now reads as shown there and is left that way. ok is false for what came after the write, said under editor or compiled.",
+      ...said === undefined ? [] : [said]
+    ].join(" ");
+    return this.jsonTextResponse({
+      ok: settled.ok,
+      written: true,
+      ...outcome.report,
+      ...settled.report,
+      ...leftChanged === undefined ? {} : { note: leftChanged }
+    });
   }
   async settleRenameInEditor(projectPath, changed, names) {
     const { gone, oldClass, newClass } = names;
@@ -47697,9 +47743,10 @@ that a setting nobody wrote down still answers with the default the engine regis
 
 To rename a class or a member across the project, use \`script_edit rename\` rather than a text
 replacement: it changes the uses the engine resolves, doc links and what scenes record, and lists
-every other occurrence of the word under \`leftAlone\`, a \`find_children\` string, a word in a
-comment or a file under a \`.gdignore\` directory, for you to read. Pass \`preview\` first on a
-large rename.
+every other occurrence of the word for you to read: a \`find_children\` string or a file under a
+\`.gdignore\` directory under \`leftAlone\`, and a word in a comment or a text file by line under
+\`leftAloneInProse\`. Pass \`preview\` first on a large rename. If the answer has \`ok: false\`
+beside \`written: true\`, the files were changed and a script did not compile afterwards.
 
 Editing a file while a game is running does not change the running game. \`auto_reload\` is an
 editor plugin and reloads into the editor's own process; the game is a separate process holding

package/build/index.js

@@ -31650,6 +31650,20 @@ async function renameSymbol(request, services) {
         conflicts.push(`${newName} is already declared in ${id.endsWith("#") ? fileOf(id) : `${fileOf(id)}, class ${id.slice(id.lastIndexOf("#") + 1)}`}`);
       }
     }
+    const heirs = graph.descendants(root);
+    const inUse = [];
+    for (const script of scripts.values()) {
+      for (const occurrence of script.occurrences(newName)) {
+        const body = graph.bodyAt(script.path, occurrence.offset);
+        if (occurrence.kind === "code" && !occurrence.afterDot && heirs.has(body) && graph.declaration(body, newName)?.offset !== occurrence.offset) {
+          inUse.push({ file: script.path, line: script.lines.positionOf(occurrence.offset).line + 1 });
+        }
+      }
+    }
+    if (inUse.length > 0) {
+      const places = inUse.sort((a, b) => a.file.localeCompare(b.file) || a.line - b.line).slice(0, 10).map((place) => `${place.file}:${place.line}`);
+      conflicts.push(`${newName} is already used in code where ${symbol} is inherited, as a local, a parameter or another name the renamed ${what} would shadow or be shadowed by, at ${places.join(", ")}${inUse.length > places.length ? ` and ${inUse.length - places.length} more` : ""}`);
+    }
     if (conflicts.length > 0) {
       return {
         ok: false,
@@ -31721,7 +31735,7 @@ async function renameSymbol(request, services) {
       ...overrides.length > 0 ? { overridesRenamed: overrides } : {},
       ...moveTo === null ? {} : { moved: { from: declaringPath, to: moveTo } },
       changed: changedReport(plan.edits, rewrites),
-      leftAlone: plan.mentions,
+      ...leftAloneReport(plan.mentions),
       summary: summaryOf(plan.edits, plan.mentions, rewrites)
     }
   };
@@ -31816,6 +31830,27 @@ function changedReport(edits, rewrites) {
     };
   });
 }
+function leftAloneReport(mentions) {
+  const full = [];
+  const prose = new Map;
+  for (const mention of mentions) {
+    if ((mention.kind === "comment" || mention.kind === "text") && mention.why === undefined) {
+      const key = `${mention.file}
+${mention.kind}`;
+      const group = prose.get(key) ?? { file: mention.file, kind: mention.kind, lines: [] };
+      if (!group.lines.includes(mention.line)) {
+        group.lines.push(mention.line);
+      }
+      prose.set(key, group);
+    } else {
+      full.push(mention);
+    }
+  }
+  return {
+    leftAlone: full,
+    ...prose.size > 0 ? { leftAloneInProse: [...prose.values()] } : {}
+  };
+}
 function summaryOf(edits, mentions, rewrites) {
   const count = (values) => {
     const counted = {};
@@ -33002,7 +33037,7 @@ var TOOL_SPECS = [
   },
   {
     name: "script_edit",
-    description: "Creates a GDScript file, or adds functions, variables and signals to one. Every declaration written carries a type. Both load what they wrote under the project's own warning settings and answer with parses; the engine's reasons for a refusal come back under engine_messages. create answers with the extends and class_name the engine read, and a script declaring a class_name is put in the project's class list, with registered saying whether it is there. modify makes every addition or none, and answers with the line each one is on in the file written. rename renames a class or a member wherever the engine uses it and writes every file or none: changed lists each file with its changed lines as they now read, and leftAlone lists every other whole-word occurrence of the old name with what the tokenizer makes of it (code, string, comment, doc, nodePath, scene, text, or ignored for a file under a .gdignore directory, which is never changed) and, where it is not plain, why: a find_children string, a word in a comment, a node named like the class, a call on a value whose type the analyser could not tell. Read leftAlone before calling the rename done; nothing in it was changed. Afterwards an open editor scans the changed files and reloads every changed script, which is also the compile check, and its answer comes back under editor; with no editor the class cache is rebuilt and the changed scripts are compiled in a fresh engine, under classCache and compiled.",
+    description: "Creates a GDScript file, or adds functions, variables and signals to one. Every declaration written carries a type. Both load what they wrote under the project's own warning settings and answer with parses; the engine's reasons for a refusal come back under engine_messages. create answers with the extends and class_name the engine read, and a script declaring a class_name is put in the project's class list, with registered saying whether it is there. modify makes every addition or none, and answers with the line each one is on in the file written. rename renames a class or a member wherever the engine uses it and writes every file or none. A new name already taken is refused with nothing written, a member's included when a class inheriting it already uses the name in code, as a local or a parameter. changed lists each file with its changed lines as they now read, and leftAlone lists every other whole-word occurrence of the old name with what the tokenizer makes of it (code, string, comment, doc, nodePath, scene, text, or ignored for a file under a .gdignore directory, which is never changed) and, where it is not plain, why: a find_children string, a node named like the class, a call on a value whose type the analyser could not tell. A comment or a line of a text file with nothing more to say is given under leftAloneInProse by file and line instead. Read both before calling the rename done; nothing in them was changed. Afterwards an open editor scans the changed files and reloads every changed script, which is also the compile check, and its answer comes back under editor; with no editor the class cache is rebuilt and the changed scripts are compiled in a fresh engine, under classCache and compiled. written is true once the files are written, and ok is false when what came after the write failed: the files are left changed, and note says so.",
     parameters: {
       projectPath: PROJECT_PATH,
       scriptPath: SCRIPT_PATH,
@@ -38567,7 +38602,18 @@ class GodotServer {
       rebuildCache: outcome.isClass || outcome.moved !== null,
       moved: outcome.moved !== null
     });
-    return this.jsonTextResponse({ ok: settled.ok, ...outcome.report, ...settled.report });
+    const said = readString(settled.report, "note");
+    const leftChanged = settled.ok ? said : [
+      "The rename was written: every file under changed now reads as shown there and is left that way. ok is false for what came after the write, said under editor or compiled.",
+      ...said === undefined ? [] : [said]
+    ].join(" ");
+    return this.jsonTextResponse({
+      ok: settled.ok,
+      written: true,
+      ...outcome.report,
+      ...settled.report,
+      ...leftChanged === undefined ? {} : { note: leftChanged }
+    });
   }
   async settleRenameInEditor(projectPath, changed, names) {
     const { gone, oldClass, newClass } = names;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gdharness",
-  "version": "1.1.33",
+  "version": "1.1.34",
   "mcpName": "io.github.Aureliolo/gdharness",
   "description": "A harness for driving a Godot 4 project from an agent: editor addons, a runtime bridge into the running game, an MCP server in front of them, and a CLI that installs and diagnoses the Godot side.",
   "type": "module",