gdharness 1.1.3 → 1.1.5

package/build/cli.js

@@ -114,11 +114,11 @@ function startTimesOf(pids) {
 }
 async function processTree() {
   try {
-    if (process.platform === "win32") {
-      return parseProcessTable(await askWindows(), true);
-    }
-    return parseProcessTable(await askPosix());
-  } catch {
+    const tree = process.platform === "win32" ? parseProcessTable(await askWindows(), true) : parseProcessTable(await askPosix());
+    lastListingFailure = undefined;
+    return tree;
+  } catch (error) {
+    lastListingFailure = error instanceof Error ? error.message : String(error);
     return;
   }
 }
@@ -256,7 +256,7 @@ async function askWindows() {
     "-NoProfile",
     "-NonInteractive",
     "-Command",
-    `${POWERSHELL_UTF8}Get-CimInstance Win32_Process | ForEach-Object { $began = 0; if ($_.CreationDate) { $began = ([DateTimeOffset]$_.CreationDate).ToUnixTimeMilliseconds() }; "$($_.ProcessId) $($_.ParentProcessId) $began $($_.CommandLine)" }`
+    `${POWERSHELL_UTF8}Get-CimInstance Win32_Process -Property ProcessId,ParentProcessId,CreationDate,CommandLine | ForEach-Object { $began = 0; if ($_.CreationDate) { $began = ([DateTimeOffset]$_.CreationDate).ToUnixTimeMilliseconds() }; "$($_.ProcessId) $($_.ParentProcessId) $began $($_.CommandLine)" }`
   ], { timeout: ASK_TIMEOUT_MS, windowsHide: true, maxBuffer: 16 * 1024 * 1024 });
   return stdout;
 }
@@ -267,7 +267,7 @@ async function askPosix() {
   });
   return stdout;
 }
-var run, POWERSHELL_UTF8 = "[Console]::OutputEncoding = [System.Text.Encoding]::UTF8; ", ASK_TIMEOUT_MS = 15000;
+var run, POWERSHELL_UTF8 = "[Console]::OutputEncoding = [System.Text.Encoding]::UTF8; ", ASK_TIMEOUT_MS = 15000, lastListingFailure;
 var init_process_children = __esm(() => {
   run = promisify(execFile);
 });
@@ -15992,7 +15992,7 @@ var init_tool_definitions = __esm(() => {
       requires: ["projectPath"],
       operations: {
         status: {
-          summary: "which resources are outdated or failed, or one resource with resourcePath: a source changed since its import, an import whose output under .godot/imported is gone (missing_outputs), and a glTF scene imported before the images it uses (imported_before), each with its reason",
+          summary: "which resources are outdated or failed, or one resource with resourcePath, judged by content as the editor judges it: a source whose hash differs from the one its import recorded, an import whose output under .godot/imported is gone (missing_outputs), and a glTF scene whose import does not depend on an image it names, because it was built before that image was imported (imported_without), each with its reason",
           requires: []
         },
         options: { summary: "the import options of one resource", requires: ["resourcePath"] },
@@ -41334,7 +41334,10 @@ class GodotServer {
       adopted.log.finish();
       adopted.exitCode = record.exitCode ?? null;
       adopted.exitSignal = record.exitSignal ?? null;
-      adopted.endedUnwatched = !exited(adopted);
+      const exitMayBeComing = !alive(record.pid) && !exited(adopted);
+      if (!exitMayBeComing) {
+        adopted.endedUnwatched = !exited(adopted);
+      }
     }
     this.activeProcess = adopted;
     return adopted;
@@ -41824,6 +41827,7 @@ class GodotServer {
     const ghosts = blind.stillHeld ?? [];
     let waitedForEditorMs = 0;
     let first;
+    let completedBefore;
     for (;; ) {
       const busySince = Date.now();
       let wasBusy = false;
@@ -41838,8 +41842,9 @@ class GodotServer {
       if (first.isError) {
         return first;
       }
-      const declined = asParams(JSON.parse(first.content[0]?.text ?? "{}"))["started"] === false;
-      if (!declined || Date.now() - started >= timeoutMs) {
+      const firstAnswer = asParams(JSON.parse(first.content[0]?.text ?? "{}"));
+      completedBefore = readNumber(firstAnswer, "scansCompletedBefore");
+      if (firstAnswer["started"] !== false || Date.now() - started >= timeoutMs) {
         break;
       }
       await new Promise((settle) => setTimeout(settle, 100));
@@ -41850,7 +41855,9 @@ class GodotServer {
       await new Promise((settle) => setTimeout(settle, 100));
       const status = asParams(await this.godotBridge.invokeTool("rescan_filesystem", { ...args, statusOnly: true }));
       const pending = Boolean(status["pending"]) && Date.now() - started < SCAN_START_MS;
-      busy = Boolean(status["scanning"]) || Boolean(status["importing"]) || pending;
+      const completed = readNumber(status, "scansCompleted");
+      const notYetOver = completedBefore !== undefined && completed !== undefined && completed <= completedBefore;
+      busy = Boolean(status["scanning"]) || Boolean(status["importing"]) || pending || notYetOver;
       if (busy) {
         idleSince = null;
       } else {

package/build/godot/addons/gdharness_editor/tools/scene_tools.gd

@@ -11,12 +11,14 @@ var _editor_plugin: EditorPlugin = null
 var _values: Serialisation = Serialisation.new()
 var _properties: PropertyValues = PropertyValues.new()
 
-## How many times the editor has said its filesystem changed, which a scan run on the main thread
-## does before `scan()` returns: counted so a rescan can tell a scan that ran there from one the
-## editor declined.
-var _scans_finished: int = 0
-
-## When the last scan finished, on the engine's clock, or -1 before the first. The editor writes
+## How many scans the editor has completed, counted off `sources_changed`, which it emits at the end
+## of every scan once the reimport the scan found is done: the one moment a scan is over. Neither
+## flag it offers says so. A threaded scan stops reporting itself when its thread finishes, and its
+## import runs a frame or more later when the thread is joined; an editor in the background took
+## long enough over that frame that a rescan answered before the import of 211 changed scenes began.
+var _scans_completed: int = 0
+
+## When the last scan completed, on the engine's clock, or -1 before the first. The editor writes
 ## the class cache a frame after it stops reporting a scan, measured on 4.7.2, so a game started
 ## in between reads a file being rewritten; how long ago the scan ended is what tells a caller
 ## whether that write can still be coming.
@@ -26,14 +28,14 @@ var _scan_finished_at_msec: int = -1
 func set_editor_plugin(plugin: EditorPlugin) -> void:
 	_editor_plugin = plugin
 	var filesystem: EditorFileSystem = EditorInterface.get_resource_filesystem()
-	if not filesystem.filesystem_changed.is_connected(_scan_finished):
-		var watched: int = filesystem.filesystem_changed.connect(_scan_finished)
+	if not filesystem.sources_changed.is_connected(_scan_completed):
+		var watched: int = filesystem.sources_changed.connect(_scan_completed)
 		if watched != OK:
-			push_error("gdharness could not watch for finished scans: %d" % watched)
+			push_error("gdharness could not watch for completed scans: %d" % watched)
 
 
-func _scan_finished() -> void:
-	_scans_finished += 1
+func _scan_completed(_sources_exist: bool) -> void:
+	_scans_completed += 1
 	_scan_finished_at_msec = Time.get_ticks_msec()
 
 
@@ -658,8 +660,8 @@ func rescan_filesystem(args: Dictionary) -> Dictionary:
 	# conditions from its progress dialog. Declined and said, so the caller waits and asks again.
 	var busy: bool = filesystem.is_scanning() or filesystem.is_importing()
 	var started: bool = false
+	var completed_before: int = _scans_completed
 	if not Read.as_bool(args.get("statusOnly", false)) and not busy:
-		var finished_before: int = _scans_finished
 		filesystem.scan()
 		# Whether the scan ran, read off the editor rather than assumed. `scan()` returns without
 		# a word while the thread of the scan before is still to be joined, which is a frame or
@@ -668,16 +670,19 @@ func rescan_filesystem(args: Dictionary) -> Dictionary:
 		# downstream, a rescan after 698 files were rewritten answered finished in 1.5s and the
 		# one changed file stayed on its old import. A threaded scan reports itself from inside
 		# the call, and one run on this thread has finished and signalled before it returns.
-		started = filesystem.is_scanning() or _scans_finished != finished_before
+		started = filesystem.is_scanning() or _scans_completed != completed_before
 
 	# Importing is reported separately from scanning, and a class is not registered until
-	# both are done, so a caller watching only one of them can look too early.
+	# both are done, so a caller watching only one of them can look too early. The two counts are
+	# what a caller waits on: the scan it asked for is over once the count has moved past the one
+	# from before it was asked.
 	return {
 		"ok": true,
 		"started": started,
 		"scanning": filesystem.is_scanning(),
 		"importing": filesystem.is_importing(),
-		"scansFinished": _scans_finished,
+		"scansCompletedBefore": completed_before,
+		"scansCompleted": _scans_completed,
 	}
 
 

package/build/godot/operations/import_pipeline.gd

@@ -8,6 +8,11 @@ const IMPORTABLE_EXTENSIONS: Array[String] = [
 	"png", "jpg", "jpeg", "webp", "svg", "wav", "mp3", "ogg", "ttf", "otf", "glb", "gltf", "fbx", "obj"
 ]
 
+## How many resources a scene's dependencies are followed through before the walk stops: a scene's
+## materials and what they use are a handful, and a project that references its way around a cycle
+## is not walked for ever.
+const DEPENDENCY_WALK_LIMIT: int = 200
+
 var _log: Log
 var _files: FileWalk = FileWalk.new()
 
@@ -383,10 +388,6 @@ func _import_status_of(resource_path: String, import_file_path: String) -> Dicti
 	var status: Dictionary = {
 		"path": resource_path, "status": "up_to_date", "import_file_exists": true, "source_exists": true
 	}
-	if FileAccess.get_modified_time(resource_path) > FileAccess.get_modified_time(import_file_path):
-		status["status"] = "needs_reimport"
-		status["reason"] = "the source changed after it was imported"
-		return status
 
 	# The sidecar alone does not say the import is there: deleting the outputs under
 	# .godot/imported is the ordinary way to force one, and a resource whose output is gone was
@@ -402,23 +403,90 @@ func _import_status_of(resource_path: String, import_file_path: String) -> Dicti
 		status["missing_outputs"] = missing
 		return status
 
-	# A scene imported before the textures it uses were: it loads each image as it imports, so one
-	# imported ahead of them is built without them, and nothing about its own files says so. A second
-	# reimport started over one in progress did exactly that downstream, and 64 scenes that were
-	# untextured all read as up to date here.
-	var built_at: int = _oldest(outputs, import_file_path)
-	var before: Array[String] = []
-	for image: String in _images_of(resource_path):
-		if FileAccess.file_exists(image + ".import"):
-			if _newest(_outputs_of(image + ".import"), image + ".import") > built_at:
-				before.append(image)
-	if not before.is_empty():
+	# By content, as the editor judges it: the hash of the source the import recorded, against the
+	# file. By time, an installer that rewrote 31 images byte for byte made every one read as changed,
+	# and the editor, which compares the hash, rightly imported none of them.
+	var recorded: String = _recorded_source_md5(resource_path)
+	var changed: bool = (
+		FileAccess.get_md5(resource_path) != recorded
+		if not recorded.is_empty()
+		else FileAccess.get_modified_time(resource_path) > FileAccess.get_modified_time(import_file_path)
+	)
+	if changed:
 		status["status"] = "needs_reimport"
-		status["reason"] = "it was imported before the images it uses, so it was built without them"
-		status["imported_before"] = before
+		status["reason"] = "the source changed after it was imported"
+		return status
+
+	# A scene built without an image it names: it loads each one as it imports, so one imported
+	# before the image was is built without it. Read off what the imported scene depends on, not off
+	# file times: a texture a 3D scene uses is reimported compressed after the scene, so its outputs
+	# are always the newer, and 33 correct scenes read as stale when judged that way.
+	#
+	# Followed through the resources the scene depends on, since a post-import script that swaps each
+	# material for a saved one leaves the scene depending on the material and only the material on
+	# the image: 211 correct scenes read as stale when only the scene's own list was read. And not
+	# held against a scene an import script shaped at all, since the script may replace a material
+	# with one using other images entirely, which is the scene it was meant to build.
+	var without: Array[String] = []
+	var images: Array[String] = _images_of(resource_path)
+	if not images.is_empty() and not _shaped_by_a_script(import_file_path):
+		var depended: Dictionary[String, bool] = _depended_on(resource_path)
+		for image: String in images:
+			if FileAccess.file_exists(image + ".import") and not depended.has(image):
+				without.append(image)
+	if not without.is_empty():
+		status["status"] = "needs_reimport"
+		status["reason"] = "it was imported without images it uses, which were not imported yet"
+		status["imported_without"] = without
 	return status
 
 
+## The hash of its source that [param resource_path]'s last import recorded, or "" when there is no
+## record: the editor keeps it beside the outputs, under the same base name with [code].md5[/code].
+static func _recorded_source_md5(resource_path: String) -> String:
+	var record: String = (
+		"res://.godot/imported/%s-%s.md5" % [resource_path.get_file(), resource_path.md5_text()]
+	)
+	var config: ConfigFile = ConfigFile.new()
+	if config.load(record) != OK:
+		return ""
+	return str(config.get_value("", "source_md5", ""))
+
+
+## The path of one entry [method ResourceLoader.get_dependencies] lists, past any uid and type.
+static func _path_of(entry: String) -> String:
+	var at: int = entry.rfind("::")
+	return entry if at < 0 else entry.substr(at + 2)
+
+
+## Every path [param resource_path] depends on, through the resources it depends on in turn, as far
+## as [constant DEPENDENCY_WALK_LIMIT] resources; a set, keyed by path.
+static func _depended_on(resource_path: String) -> Dictionary[String, bool]:
+	var found: Dictionary[String, bool] = {}
+	var pending: Array[String] = [resource_path]
+	var walked: int = 0
+	while not pending.is_empty() and walked < DEPENDENCY_WALK_LIMIT:
+		var next: String = pending.pop_back()
+		walked += 1
+		for entry: String in ResourceLoader.get_dependencies(next):
+			var path: String = _path_of(entry)
+			if found.has(path):
+				continue
+			found[path] = true
+			# Only what can hold further references: an image or a sound depends on nothing.
+			if path.get_extension().to_lower() in ["tres", "res", "tscn", "scn", "material"]:
+				pending.append(path)
+	return found
+
+
+## Whether the import of the file [param import_file_path] describes runs a post-import script.
+static func _shaped_by_a_script(import_file_path: String) -> bool:
+	var config: ConfigFile = ConfigFile.new()
+	if config.load(import_file_path) != OK:
+		return false
+	return not str(config.get_value("params", "import_script/path", "")).is_empty()
+
+
 ## The files an import wrote, from its sidecar's [code]dest_files[/code]; empty when it lists none.
 static func _outputs_of(import_file_path: String) -> Array[String]:
 	var config: ConfigFile = ConfigFile.new()
@@ -432,25 +500,6 @@ static func _outputs_of(import_file_path: String) -> Array[String]:
 	return outputs
 
 
-## When the earliest of [param outputs] was written, or [param fallback] when none is on disk.
-static func _oldest(outputs: Array[String], fallback: String) -> int:
-	var oldest: int = -1
-	for output: String in outputs:
-		if FileAccess.file_exists(output):
-			var at: int = FileAccess.get_modified_time(output)
-			oldest = at if oldest < 0 else mini(oldest, at)
-	return oldest if oldest >= 0 else FileAccess.get_modified_time(fallback)
-
-
-## When the latest of [param outputs] was written, or [param fallback] when none is on disk.
-static func _newest(outputs: Array[String], fallback: String) -> int:
-	var newest: int = -1
-	for output: String in outputs:
-		if FileAccess.file_exists(output):
-			newest = maxi(newest, FileAccess.get_modified_time(output))
-	return newest if newest >= 0 else FileAccess.get_modified_time(fallback)
-
-
 ## The image files a glTF scene refers to by path, resolved against the scene's own directory.
 ## Embedded images and every other scene format answer nothing.
 static func _images_of(scene_path: String) -> Array[String]:

package/build/index.js

@@ -24952,14 +24952,15 @@ function startTimesOf(pids) {
 var ASK_TIMEOUT_MS = 15000;
 async function processTree() {
   try {
-    if (process.platform === "win32") {
-      return parseProcessTable(await askWindows(), true);
-    }
-    return parseProcessTable(await askPosix());
-  } catch {
+    const tree = process.platform === "win32" ? parseProcessTable(await askWindows(), true) : parseProcessTable(await askPosix());
+    lastListingFailure = undefined;
+    return tree;
+  } catch (error) {
+    lastListingFailure = error instanceof Error ? error.message : String(error);
     return;
   }
 }
+var lastListingFailure;
 function parseProcessTable(printed, started = false) {
   const tree = new Map;
   for (const line of printed.split(/\r?\n/)) {
@@ -25094,7 +25095,7 @@ async function askWindows() {
     "-NoProfile",
     "-NonInteractive",
     "-Command",
-    `${POWERSHELL_UTF8}Get-CimInstance Win32_Process | ForEach-Object { $began = 0; if ($_.CreationDate) { $began = ([DateTimeOffset]$_.CreationDate).ToUnixTimeMilliseconds() }; "$($_.ProcessId) $($_.ParentProcessId) $began $($_.CommandLine)" }`
+    `${POWERSHELL_UTF8}Get-CimInstance Win32_Process -Property ProcessId,ParentProcessId,CreationDate,CommandLine | ForEach-Object { $began = 0; if ($_.CreationDate) { $began = ([DateTimeOffset]$_.CreationDate).ToUnixTimeMilliseconds() }; "$($_.ProcessId) $($_.ParentProcessId) $began $($_.CommandLine)" }`
   ], { timeout: ASK_TIMEOUT_MS, windowsHide: true, maxBuffer: 16 * 1024 * 1024 });
   return stdout;
 }
@@ -30118,7 +30119,7 @@ var TOOL_SPECS = [
     requires: ["projectPath"],
     operations: {
       status: {
-        summary: "which resources are outdated or failed, or one resource with resourcePath: a source changed since its import, an import whose output under .godot/imported is gone (missing_outputs), and a glTF scene imported before the images it uses (imported_before), each with its reason",
+        summary: "which resources are outdated or failed, or one resource with resourcePath, judged by content as the editor judges it: a source whose hash differs from the one its import recorded, an import whose output under .godot/imported is gone (missing_outputs), and a glTF scene whose import does not depend on an image it names, because it was built before that image was imported (imported_without), each with its reason",
         requires: []
       },
       options: { summary: "the import options of one resource", requires: ["resourcePath"] },
@@ -34072,7 +34073,10 @@ class GodotServer {
       adopted.log.finish();
       adopted.exitCode = record.exitCode ?? null;
       adopted.exitSignal = record.exitSignal ?? null;
-      adopted.endedUnwatched = !exited(adopted);
+      const exitMayBeComing = !alive(record.pid) && !exited(adopted);
+      if (!exitMayBeComing) {
+        adopted.endedUnwatched = !exited(adopted);
+      }
     }
     this.activeProcess = adopted;
     return adopted;
@@ -34562,6 +34566,7 @@ class GodotServer {
     const ghosts = blind.stillHeld ?? [];
     let waitedForEditorMs = 0;
     let first;
+    let completedBefore;
     for (;; ) {
       const busySince = Date.now();
       let wasBusy = false;
@@ -34576,8 +34581,9 @@ class GodotServer {
       if (first.isError) {
         return first;
       }
-      const declined = asParams(JSON.parse(first.content[0]?.text ?? "{}"))["started"] === false;
-      if (!declined || Date.now() - started >= timeoutMs) {
+      const firstAnswer = asParams(JSON.parse(first.content[0]?.text ?? "{}"));
+      completedBefore = readNumber(firstAnswer, "scansCompletedBefore");
+      if (firstAnswer["started"] !== false || Date.now() - started >= timeoutMs) {
         break;
       }
       await new Promise((settle) => setTimeout(settle, 100));
@@ -34588,7 +34594,9 @@ class GodotServer {
       await new Promise((settle) => setTimeout(settle, 100));
       const status = asParams(await this.godotBridge.invokeTool("rescan_filesystem", { ...args, statusOnly: true }));
       const pending = Boolean(status["pending"]) && Date.now() - started < SCAN_START_MS;
-      busy = Boolean(status["scanning"]) || Boolean(status["importing"]) || pending;
+      const completed = readNumber(status, "scansCompleted");
+      const notYetOver = completedBefore !== undefined && completed !== undefined && completed <= completedBefore;
+      busy = Boolean(status["scanning"]) || Boolean(status["importing"]) || pending || notYetOver;
       if (busy) {
         idleSince = null;
       } else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gdharness",
-  "version": "1.1.3",
+  "version": "1.1.5",
   "mcpName": "io.github.Aureliolo/gdharness",
   "description": "A harness for driving a Godot 4 project from an agent: editor addons, a runtime bridge into the running game, an MCP server in front of them, and a CLI that installs and diagnoses the Godot side.",
   "type": "module",