gdharness 0.4.2 → 0.5.1

package/build/godot/addons/gdharness_editor/tools/play_tools.gd

@@ -8,6 +8,9 @@ extends Node
 ## editor to play means the debugger it owns is holding the game, which is what makes the debug
 ## tools answer at all.
 
+## What the display server calls itself when the engine was started with no display at all.
+const HEADLESS_DISPLAY: String = "headless"
+
 var _editor_plugin: EditorPlugin = null
 
 
@@ -56,7 +59,12 @@ func restart_editor(_args: Dictionary) -> Dictionary:
 	# editor restarted by anybody comes up as a project manager with no project, holding the
 	# desktop of whoever was unlucky enough to be watching. A windowed editor was started with
 	# none of that, so Godot's own restart brings back the same editor on the same project.
-	if not DisplayServer.window_can_draw():
+	#
+	# Asked of the display server rather than of the window, because window_can_draw answers no
+	# for a window that is merely minimised. An editor sitting in the taskbar was told it was
+	# headless and refused to restart, which is exactly the editor somebody wants restarted after
+	# an upgrade: nobody minimises a window they are watching.
+	if DisplayServer.get_name() == HEADLESS_DISPLAY:
 		return {
 			"ok": false,
 			"error":

package/build/godot/addons/gdharness_runtime/runtime_input.gd

@@ -162,14 +162,22 @@ func click(params: Dictionary) -> Dictionary:
 	var centre: Vector2 = control.get_global_transform_with_canvas() * (control.size * 0.5)
 	var position: Vector2 = viewport.get_final_transform() * centre
 	# The GUI only delivers to what is inside the viewport, so a centre outside it would be a
-	# click that silently reached nothing.
+	# click that silently reached nothing. A game with no window has a 64 by 64 viewport
+	# whatever the project settings say, which is the usual reason to be here and is not
+	# something the caller can read off the rect on its own.
 	if not viewport.get_visible_rect().has_point(centre):
+		var why: String = ""
+		if not _host.get_tree().root.can_draw():
+			why = (
+				". This game has no window, and a game with no window has a 64 by 64 viewport "
+				+ "whatever the project settings say: run it with a window to reach this control"
+			)
 		return {
 			"type": "error",
 			"message":
 			(
-				"%s has its centre at %s, outside the viewport %s, so nothing can click it"
-				% [node_path, centre, viewport.get_visible_rect()]
+				"%s has its centre at %s, outside the viewport %s, so nothing can click it%s"
+				% [node_path, centre, viewport.get_visible_rect(), why]
 			)
 		}
 	var button: int = _resolve_mouse_button(params.get("button", MOUSE_BUTTON_LEFT))