gcf-harness-aif-ext 0.4.0 → 0.5.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/README.md CHANGED
@@ -11,7 +11,7 @@ The harness turns policy-as-text into an executable pipeline. It has **no memory
11
11
 
12
12
  ## Requirements
13
13
 
14
- - [`gcf-aif-ext`](../gcf-aif-ext) `^0.3.0` installed, with a `gcf/` tree in the project — declared as a peer dependency, and `gcf-harness init` refuses when the `gcf` command is not registered
14
+ - [`gcf-aif-ext`](../gcf-aif-ext) `^0.4.1` installed, with a `gcf/` tree in the project — declared as a peer dependency, and `gcf-harness init` refuses when the `gcf` command is not registered
15
15
  - Claude Code 2.1.270+ (hooks, dynamic workflows) — the only supported runtime
16
16
  - AI Factory 2.x, Node.js ≥ 22.14
17
17
 
@@ -43,6 +43,12 @@ ai-factory extension update gcf-harness-aif-ext
43
43
 
44
44
  Updating keeps the hook entry valid — it points into the extension's install directory, which an update refreshes in place.
45
45
 
46
+ 0.5.0 drives work items (`gcf/work/<id>.md`, schema 3) instead of cards and requires `gcf-aif-ext` 0.4.0 — update both together; against an older core the gate refuses with `gcf-aif-ext >= 0.4.0 is required`. A project still holding schema 2 cards in `gcf/cards/` re-creates them first (see the core's "Upgrading from 0.3.x"). What changes for you: `/gcf-run` takes ids of items in `ready`; it no longer stops at `built` but ends each item with `submit`, `close` or `block`; the plan is improved in passes until it converges; the WIP cap counts only items that end waiting for a verdict.
47
+
48
+ 0.5.1 is a fix release. During a run, `gcf/config.yml` is always readable, and a Grep inside `gcf/` reads only readset files. An import breaks a `depends:` cycle the pair checks closed and asks a D1 about it. It cuts a section longer than a segment at paragraphs, and lens and pair prompts carry a window around the quote. `/gcf-run` checks the plan against each pillar's invariant and asks each pillar's review question over the diff. Use it with core 0.4.1, which brings the parent feature into the readset.
49
+
50
+ 0.4.1 is a patch release. `/gcf-run` now commits the implementation first, then flips the card to `built` in a second commit, with `built_at` set to the implementation commit's hash. Update the core to 0.3.1 together with the harness: without it, an audit run before a verdict makes the pre-commit gate refuse that verdict.
51
+
46
52
  To remove the extension:
47
53
 
48
54
  ```bash
@@ -53,9 +59,9 @@ Removal does not touch `.claude/settings.json`: delete the `PreToolUse` entry wh
53
59
 
54
60
  ## What it adds
55
61
 
56
- **`/gcf-run <card-id…>`** — drives a card from the backlog to `built`, with every gate checked *before* the tokens are spent: the audit ritual, collapsed dependencies, the tune limit, the WIP cap, the context budget. It stops at `built` and prints the playtest list — the verdict belongs to the human, and there is no stage past the build.
62
+ **`/gcf-run <item-id…>`** — drives work items through plan, implementation and DoD, with every gate checked *before* the tokens are spent: the audit ritual, the gate below, the context budget. The plan is written by `aif-plan`, then improved in passes, each by a fresh subagent that reads only the plan and the readset and records every default it picks; `ai-factory gcf plan check <id>` runs after each pass, and a pass that changes no task ends the loop. A plan still changing after `plan_passes` passes, or a question only the human can answer (a save format, a public API, a new dependency, a pillar conflict), blocks the item before any code is written. The DoD is the project's `dod.test` and `dod.build` commands from `gcf/config.yml` plus a review by a fresh subagent, up to `dod_attempts` attempts. Every item ends in a state the core records: `gcf submit` (gate `verdict` or `decision` — waits for the human), `gcf close` (gate `auto` — done, or a soft unit closed as `unplayed`) or `gcf block` with the reason. The verdict and the decision belong to the human: the pipeline stops at `submit` and prints the playtest list.
57
63
 
58
- **`ai-factory gcf-harness gate <card-id…>`** — the `/gcf-run` gate as code. It reads one `gcf audit --json` report and exits 1 with a one-line reason when the cards may not go: a `schema:` other than 1, a card that is not `proposed` or `tuning`, an unplayed dependency, the tune limit, no WIP room for the whole batch (`built` count + batch size over `wip_built_limit`), or two cards of the batch touching the same system. The skill runs it and stops on a non-zero exit — no model compares the numbers.
64
+ **`ai-factory gcf-harness gate <item-id…>`** — the `/gcf-run` gate as code. It reads one `gcf audit --json` report and exits 1 with a one-line reason when the items may not go: a core older than 0.4.0, a `schema:` other than 1 in `gcf/config.yml`, an id with no work item, a feature (run its children; the feature closes when they are finished), an item that is not `ready`, an unplayed dependency, no WIP room for the batch (items awaiting a verdict + the batch's `gate: verdict` items over `wip_built_limit`), or two items of the batch touching the same system unless both say `parallel: ok`. The tune limit is not a gate rule: `verdict tune` itself refuses at the limit, and an item tuned up to it still gets its last build. The skill runs it and stops on a non-zero exit — no model compares the numbers.
59
65
 
60
66
  **`/gcf-run-ingest <gdd.md>`** — imports a design document as a fan-out workflow: parallel aspect extraction, provenance verified by code rather than by an agent (a quote either is a verbatim substring of its section or it is not), completeness lenses per candidate, and an interaction matrix computed from the candidates that write the same state.
61
67
 
@@ -15,38 +15,56 @@ const SESSION_RULE = /^(\/|\*\*\/)?\.gcf-session\/?$/;
15
15
 
16
16
  // ─── gate ────────────────────────────────────────────────────────────────────────────
17
17
 
18
- /** Why one card may not go, or null. */
19
- function cardProblem(id, card, report) {
20
- if (!card) return `${id} has no card file — take the unit into work first (/gcf-card)`;
21
- if (!['proposed', 'tuning'].includes(card.status)) {
22
- return `${id} is ${card.status} — only proposed and tuning cards are driven`;
18
+ /** Why one work item may not go, or null. */
19
+ function itemProblem(id, item, report) {
20
+ if (!item) return `${id} has no work item — take the unit or create the item first (/gcf-card)`;
21
+ if (item.type === 'feature') {
22
+ return `${id} is a feature — run its children, the feature closes when they are finished`;
23
23
  }
24
24
 
25
- // A dependency inside the same batch lands here too: the dependent waits for its verdict.
25
+ if (item.status !== 'ready') {
26
+ return `${id} is ${item.status} — only ready items are driven`;
27
+ }
28
+
29
+ // A child of a feature paused after a death does not start: the decision may kill it.
30
+ const parent = item.parent ? report.items.find((p) => p.id === item.parent) : null;
31
+ if (parent?.status === 'awaiting-decision') {
32
+ return `${id}: its feature ${parent.id} awaits a decision — decide it first`;
33
+ }
34
+
35
+ // A dependency inside the same batch lands here too: the dependent waits for it.
26
36
  const open = report.open_depends.find((o) => o.id === id);
27
- if (open) return `${id} depends on unplayed ${open.depends.join(', ')} — playtest them first`;
28
- if (report.tune_limit.some((t) => t.id === id)) {
29
- return `${id} is at the tune limit — kill or redesign it`;
37
+ if (open) {
38
+ return (
39
+ `${id} depends on unplayed ${open.depends.join(', ')} — playtest them first; ` +
40
+ 'a killed one never plays: take it out of depends, or drop'
41
+ );
30
42
  }
31
43
 
44
+ // The tune limit is held by `verdict tune` itself: an item tuned up to the limit is still
45
+ // built once more, and refusing that run would leave it stuck in ready.
32
46
  return null;
33
47
  }
34
48
 
35
49
  /** Why the batch as a whole may not go, or null. */
36
- function batchProblem(cards, wip) {
37
- // `wip.over` is false at count === limit, and this run adds every card of the batch.
38
- if (wip.count + cards.length > wip.limit) {
50
+ function batchProblem(items, wip) {
51
+ // Only an item that ends waiting for a verdict takes a WIP place; `wip.over` is false at
52
+ // count === limit, and this run adds every such item of the batch.
53
+ const waiting = items.filter((i) => i.gate === 'verdict').length;
54
+ if (waiting && wip.count + waiting > wip.limit) {
39
55
  return (
40
- `WIP: ${wip.count} built + ${cards.length} in this run exceeds the limit of ${wip.limit}` +
41
- ' — playtest first'
56
+ `WIP: ${wip.count} awaiting a verdict + ${waiting} in this run exceeds the limit of ` +
57
+ `${wip.limit} — playtest first`
42
58
  );
43
59
  }
44
60
 
45
- for (let i = 0; i < cards.length; i++) {
46
- for (const other of cards.slice(i + 1)) {
47
- const shared = cards[i].system.filter((s) => other.system.includes(s));
48
- if (shared.length) {
49
- const pair = `${cards[i].id} and ${other.id}`;
61
+ for (let i = 0; i < items.length; i++) {
62
+ for (const other of items.slice(i + 1)) {
63
+ const shared = items[i].system.filter((s) => other.system.includes(s));
64
+ // `parallel: ok` on both is the operator's explicit permission (Methodology §7).
65
+ const allowed = items[i].parallel === 'ok' && other.parallel === 'ok';
66
+ if (shared.length && !allowed) {
67
+ const pair = `${items[i].id} and ${other.id}`;
50
68
 
51
69
  return `${pair} both touch ${shared.join(', ')} — run them separately`;
52
70
  }
@@ -59,12 +77,12 @@ function batchProblem(cards, wip) {
59
77
  const verdict = (reason) => ({ pass: !reason, reason: reason ?? '' });
60
78
 
61
79
  /**
62
- * Decides whether the cards may enter the paid stages, from one `gcf audit --json` report.
80
+ * Decides whether the work items may enter the paid stages, from one `gcf audit --json` report.
63
81
  * Pure: the report is the whole input, so every rule has a test and no model compares numbers.
64
82
  */
65
83
  export function gate(report, ids) {
66
- if (!Array.isArray(report?.cards)) {
67
- return verdict('the audit report has no card summary — gcf-aif-ext >= 0.2.6 is required');
84
+ if (!Array.isArray(report?.items)) {
85
+ return verdict('the audit report has no work item summary — gcf-aif-ext >= 0.4.0 is required');
68
86
  }
69
87
 
70
88
  if (report.schema !== SCHEMA) {
@@ -73,9 +91,9 @@ export function gate(report, ids) {
73
91
  return verdict(`gcf/config.yml has schema: ${report.schema}; ${drives}`);
74
92
  }
75
93
 
76
- const byId = new Map(report.cards.map((c) => [c.id, c]));
94
+ const byId = new Map(report.items.map((c) => [c.id, c]));
77
95
  for (const id of ids) {
78
- const problem = cardProblem(id, byId.get(id), report);
96
+ const problem = itemProblem(id, byId.get(id), report);
79
97
  if (problem) return verdict(problem);
80
98
  }
81
99
 
@@ -216,7 +234,7 @@ export function register(program) {
216
234
 
217
235
  harness
218
236
  .command('gate <ids...>')
219
- .description('Gate cards before the paid stages of /gcf-run: exit 1 with the reason')
237
+ .description('Gate work items before the paid stages of /gcf-run: exit 1 with the reason')
220
238
  .option('--json', 'machine output: {pass, reason}')
221
239
  .action(runGate);
222
240
  }
package/extension.json CHANGED
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "$schema": "https://raw.githubusercontent.com/lee-to/ai-factory/2.x/schemas/extension.schema.json",
3
3
  "name": "gcf-harness-aif-ext",
4
- "version": "0.4.0",
4
+ "version": "0.5.1",
5
5
  "description": "GCF orchestration harness for Claude Code: one-command card pipeline, readset guard",
6
6
  "skills": [
7
7
  "skills/gcf-run",
@@ -49,22 +49,32 @@ function outsideVerdict(input, abs, gcfRoot) {
49
49
  return { allow: false, reason: UNSCOPED_GREP };
50
50
  }
51
51
 
52
- /** The paths a manifest allows, plus the two every stage may always read. */
53
- function allowedPaths(manifest) {
52
+ /**
53
+ * The files a manifest allows, plus the two every stage may always read: the index, and the
54
+ * config whose DoD commands and limits the run reads at its plan and DoD steps.
55
+ */
56
+ function allowedFiles(manifest) {
54
57
  // `gcf context --json` emits files as {path, tokens_est}; accept that shape as well as
55
58
  // the projected string list, so a manifest written either way still gates correctly.
56
59
  const files = (manifest.files ?? []).map((f) => (typeof f === 'string' ? f : f?.path));
57
60
 
58
- return new Set([...files.filter(Boolean), 'gcf/INDEX.md', 'gcf']);
61
+ return new Set([...files.filter(Boolean), 'gcf/INDEX.md', 'gcf/config.yml']);
59
62
  }
60
63
 
61
- /** A path inside gcf/ passes only through the readset. */
62
- function insideVerdict(rel, manifest) {
63
- const allowed = allowedPaths(manifest);
64
+ /**
65
+ * A path inside gcf/ passes only through the readset. A Grep reads every file under a
66
+ * directory, so it gets exact files only; Glob and Read may name a directory holding one.
67
+ */
68
+ function insideVerdict(rel, manifest, tool) {
69
+ const allowed = allowedFiles(manifest);
64
70
  if (allowed.has(rel)) return { allow: true };
65
- // ponytail: a directory path passes when any allowed file lives under it, so Grep over
66
- // gcf/systems can still see sibling files' content; per-file grep scoping if it leaks.
67
- if ([...allowed].some((f) => f.startsWith(`${rel}/`))) return { allow: true };
71
+ const holds = [...allowed].some((f) => f.startsWith(`${rel}/`));
72
+ if (holds && tool !== 'Grep') return { allow: true };
73
+ if (holds)
74
+ return {
75
+ allow: false,
76
+ reason: `a Grep over ${rel} reads files outside the readset — Grep a readset file by path.`,
77
+ };
68
78
 
69
79
  return {
70
80
  allow: false,
@@ -72,7 +82,7 @@ function insideVerdict(rel, manifest) {
72
82
  // agent told about it on every denial will reach for it and turn a leak into a bypass.
73
83
  reason:
74
84
  `${rel} is outside the current readset (.gcf-session/readset.json). ` +
75
- 'Extend it via `ai-factory gcf context <card>`, ' +
85
+ 'Extend it via `ai-factory gcf context <item>`, ' +
76
86
  'or work from the files already in the readset.',
77
87
  };
78
88
  }
@@ -94,7 +104,7 @@ export function decide(input, projectDir, manifest) {
94
104
  // The gcf root itself relativizes to '' — unguarded it becomes 'gcf/' and matches nothing.
95
105
  const relPosix = relFromGcf.replaceAll('\\', '/');
96
106
 
97
- return insideVerdict(relPosix ? `gcf/${relPosix}` : 'gcf', manifest);
107
+ return insideVerdict(relPosix ? `gcf/${relPosix}` : 'gcf', manifest, input.tool_name);
98
108
  }
99
109
 
100
110
  function readManifest(projectDir) {
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "gcf-harness-aif-ext",
3
- "version": "0.4.0",
3
+ "version": "0.5.1",
4
4
  "description": "GCF orchestration harness for Claude Code: one-command card pipeline, readset guard",
5
5
  "type": "module",
6
6
  "license": "MIT",
@@ -28,7 +28,7 @@
28
28
  "prepack": "node -e \"const p=require('./package.json'),e=require('./extension.json');if(p.version!==e.version)throw new Error('version mismatch: package.json '+p.version+' vs extension.json '+e.version)\""
29
29
  },
30
30
  "peerDependencies": {
31
- "gcf-aif-ext": "^0.3.0"
31
+ "gcf-aif-ext": "^0.4.1"
32
32
  },
33
33
  "files": [
34
34
  "extension.json",
@@ -1,35 +1,49 @@
1
1
  ---
2
2
  name: gcf-run
3
- description: Drive one or more GCF units from the backlog to built in a single run - gates before tokens, readset discipline, playtest list at the end. Use when the user says "прогони карточку" / "run the card".
3
+ description: Drive one or more GCF work items through plan, implement and DoD in a single run - gates before tokens, a converging plan, readset discipline, then submit, close or block. Use when the user says "прогони задачу" / "прогони карточку" / "run the item".
4
4
  ---
5
5
 
6
6
  mode: pipeline
7
7
 
8
8
  purpose:
9
- - drive a card through gate, readset, plan, implement and build with the stop rules checked before each paid stage
9
+ - drive a work item through gate, readset, plan, implement and its DoD with the stop rules checked before each paid stage
10
+ - end every item in a state the core records: `submit` (waits for the human), `close` (gate auto, done) or `block` (needs the human)
10
11
 
11
12
  inputs:
12
- - 1 or more unit or card ids; a batch shares one build and one playtest list
13
+ - 1 or more work item or design unit ids; a batch shares one build and one playtest list
13
14
 
14
15
  preconditions:
15
16
  - `gcf/` exists and `ai-factory gcf audit` runs (the gcf-aif-ext extension provides it)
16
17
 
17
18
  forbidden_behaviors:
18
- - do not go past `built`: the verdict belongs to the human, this pipeline has no stage after the build
19
+ - do not give a verdict or a decision: `verdict` and `decide` belong to the human, this pipeline stops at `submit`
19
20
  - do not read a `gcf/` file outside the readset from `ai-factory gcf context`
20
21
  - do not continue past a failed gate: report the one-line reason, delete `.gcf-session/readset.json`, and stop - a stop is a normal outcome
21
- - do not compare the audit numbers yourself: the gate command is the only judge of whether a card may go
22
+ - do not compare the audit numbers yourself: the gate command is the only judge of whether an item may go
23
+ - do not ask the human about a reversible choice during planning: pick the safe default and write it into the plan
24
+ - do not edit `status:` or `gcf/LIVE.md` by hand: `submit`, `close` and `block` own them
22
25
 
23
26
  workflow:
24
- 1. session ritual: delete a `.gcf-session/readset.json` left by a killed run; run `ai-factory gcf audit --json`; read `gcf/INDEX.md`; stale built cards with live dependents mean stop - print the playtest list instead of building
25
- 2. for a unit still in `gcf/design/`: take it with the gcf-card skill; a hard unit leaves the pipeline for the normal AIF cycle here
26
- 3. gate: run `ai-factory gcf-harness gate <card-ids...>` over the whole batch; a non-zero exit is a failed gate, its stderr line is the reason
27
- 4. readset: run `ai-factory gcf context <card-id> --json`; write `{"card":"<id>","files": ctx.files.map(f => f.path)}` to `.gcf-session/readset.json` - paths, not objects; `over_budget: true` stops the run with a D1 question naming the subsystem
28
- 5. plan with aif-plan, shaped by the card slots, reading only the readset files
29
- 6. implement with aif-implement, then verify: autotests plus the card's negative constraints; retries <= 2 with a diagnosis each, then stop
30
- 7. build the project; flip the card frontmatter to `status: built` with `built_at:` set to the implementation commit hash, commit via aif-commit
31
- 8. close the run: delete `.gcf-session/readset.json`, run `ai-factory gcf playtest` and hand the list to the human
32
- 9. after a tune verdict, re-enter this pipeline at step 3: the gates re-run because the counters moved
27
+ 1. session ritual: delete a `.gcf-session/readset.json` left by a killed run; run `ai-factory gcf audit --json`; read `gcf/INDEX.md`; report the audit first line to the human
28
+ 2. for a unit still in `gcf/design/`: take it with the gcf-card skill first
29
+ 3. for a feature id: replace it with its `ready` children from the audit report's `items` (`parent` names the feature) that are not in `open_depends`; a feature in `awaiting-decision` starts none of them
30
+ 4. of those children, keep one per subsystem unless every child sharing it says `parallel: ok`; the rest wait for the next run; an empty list: report "nothing to run" and stop
31
+ 5. gate: run `ai-factory gcf-harness gate <item-ids...>` over the whole batch; a non-zero exit is a failed gate, its stderr line is the reason
32
+ 6. readset: run `ai-factory gcf context <item-id> --json`; write `{"item":"<id>","files": ctx.files.map(f => f.path)}` to `.gcf-session/readset.json` - paths, not objects; `over_budget: true` stops the run with a D1 question naming the subsystem
33
+ 7. plan: run aif-plan full for the item into its `plan:` path, by default `.ai-factory/plans/<id>.md`, reading only the readset files; an existing plan (the item came back after a tune, an unblock or a continue) is kept, not rewritten
34
+ 8. improve the plan in passes, each pass a fresh subagent that reads only the plan and the readset and applies aif-improve without questions, writing each default it picks into the plan
35
+ 9. each pass also checks every task against the `invariant` of each pillar in `gcf/PILLARS.md`: the pass reworks a task that breaks one, and a conflict no rework removes is a pillar conflict of step 12
36
+ 10. after each pass run `ai-factory gcf plan check <id>`; a failure blocks the item with its reason; a pass that changes no task ends the loop - the plan converged
37
+ 11. passes <= `plan_passes` from `gcf/config.yml` (5 by default); a plan still changing after the last pass: run `ai-factory gcf block <id> --reason "plan did not converge"` and stop
38
+ 12. a question only the human can answer - a save format, a public API, a new dependency, a pillar conflict: run `ai-factory gcf block <id> --reason "<question>"` and stop
39
+ 13. implement with aif-implement, then verify: the project's `dod.test` and `dod.build` commands from `gcf/config.yml`, plus the item's negative constraints; attempts <= `dod_attempts`, each with a diagnosis
40
+ 14. review the diff with a fresh subagent; fix what it finds before the commit; DoD still red after the attempts: commit nothing, run `ai-factory gcf block <id> --reason "<diagnosis>"`
41
+ 15. the reviewer also answers the `review_question` of each pillar in `gcf/PILLARS.md` over the diff: an answer that breaks the pillar is a finding
42
+ 16. commit the implementation via aif-commit; write the item's `live:` delta
43
+ 17. gate `verdict` or `decision`: run `ai-factory gcf submit <id>`; gate `auto`: run `ai-factory gcf close <id>` - a soft unit closes unplayed
44
+ 18. a dependency still waiting for its verdict refuses the close: run `ai-factory gcf block <id> --reason "waits for <dep>"`
45
+ 19. close the run: delete `.gcf-session/readset.json`, run `ai-factory gcf playtest` and hand the list to the human, with one report row per plan pass: pass, tasks changed, result
46
+ 20. after a tune verdict or an unblock, re-enter this pipeline at step 5: the gates re-run because the counters moved
33
47
 
34
48
  invocation:
35
- - run when the user names a card or a unit to drive; batches share steps 1 and 8
49
+ - run when the user names a work item or a unit to drive; batches share steps 1 and 19
@@ -15,7 +15,7 @@ preconditions:
15
15
  - `gcf/` exists; the user has opted into multi-agent orchestration (the Workflow tool requires it)
16
16
 
17
17
  forbidden_behaviors:
18
- - do not create card files: the package holds design units, a card exists only when `/gcf-card` takes one
18
+ - do not create work items: the package holds design units, a work item exists only when `/gcf-card` takes one
19
19
  - do not let an agent write gcf files from inside the workflow: the script returns data, this skill writes
20
20
  - do not paste the package into PILLARS.md: pillar candidates go to the human as D1
21
21
  - do not write anything from a failed workflow: a dead agent fails it on purpose, so report its label and stop
@@ -140,12 +140,13 @@ const COHERENCE = [
140
140
  const sectionText = (s) => `[${s.anchor}] ${s.heading ?? '(preamble)'}\n${s.body}`;
141
141
 
142
142
  /**
143
- * GCF-PRD §11.7: a large GDD is cut into segments, each agent sees one. A section is never
144
- * split — quotes are verified against whole sections. ponytail: chars, not tokens.
143
+ * GCF-PRD §11.7: a large GDD is cut into segments, each agent sees one. A section longer than
144
+ * a segment is cut at paragraphs, each part keeps the section's anchor: quotes are verified
145
+ * against the whole section (bodyOf). ponytail: chars, not tokens.
145
146
  */
146
147
  function packSegments(sections, limit) {
147
148
  const segments = [];
148
- for (const s of sections) {
149
+ for (const s of sections.flatMap((x) => sectionParts(x, limit))) {
149
150
  const last = segments[segments.length - 1];
150
151
  const text = sectionText(s);
151
152
  if (last && last.size + text.length <= limit) {
@@ -159,6 +160,62 @@ function packSegments(sections, limit) {
159
160
  return segments;
160
161
  }
161
162
 
163
+ /** A section as parts that fit `limit`: whole paragraphs, a paragraph too long cut by length. */
164
+ function sectionParts(s, limit) {
165
+ if (sectionText(s).length <= limit) return [s];
166
+ // 24: room for the ` (part N of M)` the heading gains. A floor of 500: a segment_chars at or
167
+ // below the heading would otherwise cut the body into one part per character.
168
+ const room = Math.max(500, limit - sectionText({ ...s, body: '' }).length - 24);
169
+ const paras = s.body
170
+ .split(/\n\s*\n/)
171
+ .flatMap((p) =>
172
+ Array.from({ length: Math.ceil(p.length / room) || 1 }, (_, i) =>
173
+ p.slice(i * room, (i + 1) * room),
174
+ ),
175
+ );
176
+ const bodies = [];
177
+ for (const p of paras) {
178
+ const last = bodies.length - 1;
179
+ if (last >= 0 && bodies[last].length + 2 + p.length <= room) bodies[last] += `\n\n${p}`;
180
+ else bodies.push(p);
181
+ }
182
+
183
+ return bodies.map((body, i) => ({
184
+ ...s,
185
+ heading: `${s.heading ?? '(preamble)'} (part ${i + 1} of ${bodies.length})`,
186
+ body,
187
+ }));
188
+ }
189
+
190
+ const escapeRe = (s) => s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
191
+
192
+ /**
193
+ * The part of a section an agent judging one unit needs: the whole body when it fits `limit`,
194
+ * else a window of `limit` chars centred on the quote, its edges pulled in to paragraph breaks
195
+ * that keep the quote. The quote matches across any whitespace, as provenance does, so one
196
+ * spanning two paragraphs is found too; a quote absent from the body yields its head.
197
+ */
198
+ function around(body, quote, rawLimit) {
199
+ const limit = Math.max(500, rawLimit);
200
+ if (body.length <= limit) return body;
201
+ const words = String(quote ?? '')
202
+ .trim()
203
+ .split(/\s+/)
204
+ .filter(Boolean);
205
+ const m = words.length ? new RegExp(words.map(escapeRe).join('\\s+')).exec(body) : null;
206
+ if (!m) return body.slice(0, limit);
207
+ const qEnd = m.index + m[0].length;
208
+ let start = Math.max(0, m.index - Math.max(0, Math.floor((limit - m[0].length) / 2)));
209
+ let end = Math.min(body.length, start + limit);
210
+ start = Math.max(0, Math.min(start, end - limit));
211
+ const from = body.indexOf('\n\n', start);
212
+ if (start > 0 && from >= 0 && from + 2 <= m.index) start = from + 2;
213
+ const to = body.lastIndexOf('\n\n', end);
214
+ if (end < body.length && to >= qEnd) end = to;
215
+
216
+ return body.slice(start, end);
217
+ }
218
+
162
219
  // A line wrap in the GDD is not an edit: whitespace runs compare equal, as in `gcf quotes`.
163
220
  const ws = (t) => String(t).replace(/\s+/g, ' ').trim();
164
221
 
@@ -212,6 +269,30 @@ function crossingPairs(cands) {
212
269
  return pairs;
213
270
  }
214
271
 
272
+ /**
273
+ * Drop the edge that closes each cycle of `deps` (id → ids it depends on), in place, and return
274
+ * each dropped edge with its cycle: which of the two really comes first is the designer's call.
275
+ */
276
+ function breakCycles(deps) {
277
+ const broken = [];
278
+ const state = new Map();
279
+ const visit = (id, trail) => {
280
+ state.set(id, 'open');
281
+ for (const d of [...deps[id]]) {
282
+ if (state.get(d) === 'open') {
283
+ deps[id] = deps[id].filter((x) => x !== d);
284
+ broken.push({ id, dep: d, cycle: [...trail.slice(trail.indexOf(d)), id, d] });
285
+ } else if (!state.has(d)) visit(d, [...trail, id]);
286
+ }
287
+
288
+ state.set(id, 'done');
289
+ };
290
+
291
+ for (const id of Object.keys(deps)) if (!state.has(id)) visit(id, []);
292
+
293
+ return broken;
294
+ }
295
+
215
296
  /** An id no unit has used yet: the agent's slug, suffixed -2, -3… on a collision. */
216
297
  function freeId(wanted, taken) {
217
298
  const base = /^[a-z0-9]+(-[a-z0-9]+)*$/.test(wanted ?? '') ? wanted : 'unit';
@@ -342,7 +423,8 @@ const spread = args.spread ?? 0.3;
342
423
  // Every id the project has used (`ai-factory gcf where --json`): a dropped or done unit's id
343
424
  // is never minted again, or the new unit would collide with the old one's history.
344
425
  const taken = new Set(Array.isArray(args.taken) ? args.taken : []);
345
- const segments = packSegments(sections, Number(args.segment_chars) || 60000);
426
+ const segmentChars = Number(args.segment_chars) || 60000;
427
+ const segments = packSegments(sections, segmentChars);
346
428
  const bodyOf = new Map(sections.map((s) => [s.anchor, s.body]));
347
429
  const multi = segments.length > 1;
348
430
 
@@ -370,7 +452,7 @@ log(`${inferred.length} inferred units diverted to questions`);
370
452
 
371
453
  phase('Lenses');
372
454
  const enriched = await pipeline(candidates, (c) =>
373
- ask(lensPrompt(c, subsystemNames, bodyOf.get(c.anchor) ?? ''), {
455
+ ask(lensPrompt(c, subsystemNames, around(bodyOf.get(c.anchor) ?? '', c.quote, segmentChars)), {
374
456
  label: `lens:${c.name}`,
375
457
  phase: 'Lenses',
376
458
  schema: CAND_LENS,
@@ -396,10 +478,19 @@ const coherence = coherenceResults.flatMap((r) => r.findings);
396
478
  phase('Conflicts');
397
479
  const pairs = crossingPairs(cands);
398
480
  log(`${pairs.length} crossing pair(s) from the interaction matrix`);
399
- const pairSections = ({ a, b }) =>
400
- [...new Set([a.anchor, b.anchor])].map((anchor) =>
401
- sectionText(sections.find((s) => s.anchor === anchor) ?? { anchor, body: '' }),
402
- );
481
+ // Two units share the prompt, so each section gets half of a segment around its own quote.
482
+ const pairSections = ({ a, b }) => {
483
+ const units = a.anchor === b.anchor ? [a] : [a, b];
484
+
485
+ return units.map((u) => {
486
+ const s = sections.find((x) => x.anchor === u.anchor) ?? { anchor: u.anchor, body: '' };
487
+ const quotes = a.anchor === b.anchor ? [a.quote, b.quote] : [u.quote];
488
+ const body = quotes.map((q) => around(s.body, q, segmentChars / units.length / quotes.length));
489
+
490
+ return sectionText({ ...s, body: [...new Set(body)].join('\n\n[…]\n\n') });
491
+ });
492
+ };
493
+
403
494
  const conflictResults = await pipeline(pairs, (p) =>
404
495
  ask(conflictPrompt(p, pairSections(p)), {
405
496
  label: `conflict:${p.a.name}×${p.b.name}`,
@@ -415,6 +506,16 @@ for (const { order, pair } of conflictResults) {
415
506
  if (order === 'b_first') deps[pair.a.id].push(pair.b.id);
416
507
  }
417
508
 
509
+ // Each pair agent decided alone: their orders may close a cycle the gate would never open.
510
+ const anchorOf = new Map(cands.map((c) => [c.id, c.anchor]));
511
+ const cycleQuestions = breakCycles(deps).map(({ id, dep, cycle }) => ({
512
+ lens: 'depends',
513
+ anchors: [...new Set(cycle.map((x) => anchorOf.get(x)))],
514
+ class: 'D1',
515
+ question: `the pair orders close a cycle ${cycle.join(' -> ')}: which comes first?`,
516
+ proposed: `${id} does not depend on ${dep}`,
517
+ }));
518
+
418
519
  // ─── Package: deterministic code — an agent never writes the final report ────────────
419
520
 
420
521
  const provenanceQuestions = inferred.map((u) => ({
@@ -448,6 +549,7 @@ const questions = [
448
549
  ...gddQuestions,
449
550
  ...coherence,
450
551
  ...conflicts,
552
+ ...cycleQuestions,
451
553
  ...provenanceQuestions,
452
554
  ...envelopeQuestions,
453
555
  ];