gaunt-sloth-assistant 0.1.3 → 0.1.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gaunt-sloth-assistant",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "description": "",
   "license": "MIT",
   "author": "Andrew Kondratev",

package/spec/reviewCommand.spec.js

@@ -125,6 +125,46 @@ describe('reviewCommand',  function (){
         td.verify(this.review('sloth-DIFF-review', "INTERNAL PREAMBLE\nPROJECT PREAMBLE", "JIRA Requirements"));
     });
 
+    it('Should display meaningful error, when JIRA is enabled, but JIRA token is absent', async function() {
+        const testOutput = { text: '' };
+
+        const { reviewCommand } = await import("../src/commands/reviewCommand.js");
+        const program = new Command();
+        program.configureOutput({
+            writeOut: (str) => testOutput.text += str,
+            writeErr: (str) => testOutput.text += str
+        });
+
+        const context = {
+            config: {
+                requirementsProvider: 'jira-legacy',
+                requirementsProviderConfig: {
+                    'jira-legacy': {
+                        username: 'test-user',
+                        baseUrl: 'https://test-jira.atlassian.net/rest/api/2/issue/'
+                    }
+                }
+            }
+        };
+
+        // Mock the jira provider
+        const jiraProvider = td.func();
+        td.when(jiraProvider(td.matchers.anything(), 'JIRA-123')).thenResolve('JIRA Requirements');
+
+
+        await reviewCommand(program, context);
+        try {
+            await program.parseAsync(['na', 'na', 'pr', 'content-id', 'JIRA-123']);
+        } catch (e) {
+            expect(e.message)
+                .toContain(
+                    'Missing JIRA Legacy API token. ' +
+                    'The legacy token can be defined as JIRA_LEGACY_API_TOKEN environment variable ' +
+                    'or as "token" in config.'
+                );
+        }
+    });
+
     it('Should call review with predefined content provider', async function() {
         const { reviewCommand } = await import("../src/commands/reviewCommand.js");
         const program = new Command();

package/src/providers/jiraIssueLegacyAccessTokenProvider.js

@@ -1,4 +1,5 @@
 import {display, displayWarning} from "../consoleUtils.js";
+import { env } from "../systemUtils.js";
 
 export async function get(config, prId) {
     const issueData = await getJiraIssue(config, prId);
@@ -18,15 +19,23 @@ export async function get(config, prId) {
  * @throws {Error} Throws an error if the fetch fails, authentication is wrong, the issue is not found, or the response status is not OK.
  */
 async function getJiraIssue(config, jiraKey) {
-    const {username, token, baseUrl} = config;
+    const {username, baseUrl} = config;
     if (!jiraKey) {
         displayWarning("No jiraKey provided, skipping Jira issue fetching.");
         return "";
     }
+    const token = env.JIRA_LEGACY_API_TOKEN ?? config?.token;
+
+    if (!token) {
+        throw new Error(
+            'Missing JIRA Legacy API token. ' +
+            'The legacy token can be defined as JIRA_LEGACY_API_TOKEN environment variable or as "token" in config.'
+        );
+    }
 
     // Validate essential inputs
-    if (!username || !token || !baseUrl) {
-        throw new Error('Missing required parameters in config (username, token, baseUrl) or missing jiraKey.');
+    if (!username || !baseUrl) {
+        throw new Error('Missing required parameters in config: username or baseUrl');
     }
 
     // Ensure baseUrl doesn't end with a slash to avoid double slashes in the URL