gatsby-core-theme 26.0.0 → 27.0.0

package/CHANGELOG.md

@@ -1,3 +1,21 @@
+# [27.0.0](https://git.ilcd.rocks/team-floyd/themes/gatsby-themes/compare/v26.0.0...v27.0.0) (2023-08-18)
+
+
+### Code Refactoring
+
+* add reading time to cards to show correct card reading time instead of page reading ([ad014ae](https://git.ilcd.rocks/team-floyd/themes/gatsby-themes/commit/ad014aeddd44011b1fb470fd5080312d945090fc))
+* complete changes to add reading time to all pages including to modules in search pages and archive pages ([4afbd96](https://git.ilcd.rocks/team-floyd/themes/gatsby-themes/commit/4afbd960d21abbd09b3ca998aa5a0d9bdb518862))
+* minor change for form ([c9f4eaf](https://git.ilcd.rocks/team-floyd/themes/gatsby-themes/commit/c9f4eafeceb7c9c091736019acfd745447ab7dd7))
+
+
+* Merge branch 'tm-3573-news' into 'master' ([4dc2e41](https://git.ilcd.rocks/team-floyd/themes/gatsby-themes/commit/4dc2e41e9714e4e3c053958da65425a4da67b637))
+* Merge branch 'master' into tm-3573-news ([a2366b1](https://git.ilcd.rocks/team-floyd/themes/gatsby-themes/commit/a2366b1de8ca7acb3f7daa2dad1de9f1733de2cf))
+
+
+### Tests
+
+* add test ([69eabbd](https://git.ilcd.rocks/team-floyd/themes/gatsby-themes/commit/69eabbda0e957f31bd3e76f8ec97619b0af23827))
+
 # [26.0.0](https://git.ilcd.rocks/team-floyd/themes/gatsby-themes/compare/v25.0.14...v26.0.0) (2023-08-16)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gatsby-core-theme",
-  "version": "26.0.0",
+  "version": "27.0.0",
   "description": "Gatsby Theme NPM Package",
   "main": "index.js",
   "directories": {

package/src/components/organisms/form/form.module.scss

@@ -20,6 +20,7 @@
   
   @include min(tablet) {
     padding: 2.4rem;
+    gap: 2.4rem;
   }
 
   h2 {
@@ -196,7 +197,7 @@
 
   @include min(tablet) {
     display: grid;
-    grid-template-columns: repeat(2, 1fr);
+    grid-template-columns: repeat(2, minmax(0, 1fr));
     column-gap: 4.8rem;
     row-gap: 1.6rem;
   }

package/src/constants/pick-keys.mjs

@@ -12,6 +12,7 @@ export const pickPageKeys = [
   'description',
   'true_votes',
   'false_votes',
+  'reading_time',
 ];
 
 export const topListPickKeys = [

package/src/helpers/processor/index.mjs

@@ -106,9 +106,6 @@ export function processSections(sections, skipPost = false, page, translations,
   const pageId = page ? page.id : null;
   const relationData = page && page.relation;
 
-  let minutes = 0;
-  let seconds = 0;
-
   Object.keys(sections).forEach((sectionKey) => {
     if (skipPost && sectionKey.includes('post_main')) {
       return;
@@ -139,7 +136,20 @@ export function processSections(sections, skipPost = false, page, translations,
             savedModules[module.module_value_id] = module;
           }
         }
+      });
+    }
+  });
 
+  return sections;
+}
+
+export function getReadingTime(sections) {
+  let minutes = 0;
+  let seconds = 0;
+
+  Object.keys(sections).forEach((sectionKey) => {
+    if (sections[sectionKey] && sections[sectionKey].modules) {
+      sections[sectionKey].modules.forEach((module) => {
         // calculate reading time
         if (module.name === 'content') {
           const nrOfWords = removeTags(module.value).split(' ').length / 250;
@@ -152,6 +162,7 @@ export function processSections(sections, skipPost = false, page, translations,
       });
     }
   });
+
   // transform seconds to minutes as last step
   if (seconds > 60) {
     const mins = Math.floor(seconds / 60);
@@ -161,11 +172,7 @@ export function processSections(sections, skipPost = false, page, translations,
     seconds = decimalSeconds;
   }
 
-  if (page) {
-    page.reading_time = getRoundMinutes(`${zeroPadding(minutes, 2)}:${zeroPadding(seconds, 2)}`);
-  }
-
-  return sections;
+  return getRoundMinutes(`${zeroPadding(minutes, 2)}:${zeroPadding(seconds, 2)}`) || null;
 }
 
 function processSearchData(data, fs) {
@@ -311,6 +318,9 @@ export default {
             transformedPages[market][pageType][index].page_styles = data.page_styles[page.style_id];
           }
 
+          // add reading time for each page
+          transformedPages[market][pageType][index].reading_time = getReadingTime(transformedPages[market][pageType][index]?.sections);
+
           // add breadcrumbs array to page
           const pageBreadcrumbIds = transformedPages[market][pageType][index].breadcrumb_ids;
           if (pageBreadcrumbIds) {

package/src/helpers/processor/index.test.js

@@ -1,7 +1,21 @@
-import { transform, processExtraFields, processSections, processSitemapPages } from './index';
+import { transform, processExtraFields, processSections, getReadingTime } from './index';
 import pages from '~tests/factories/pages/pages.factory.js';
+import getPageList from '~tests/factories/pages/page.factory';
 import multipleMarketsPages from '~tests/factories/pages/multiple-markets-pages.factory.js';
 
+const tempContent = {
+  value: `What is Lorem Ipsum?
+  Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.        
+  Why do we use it?
+  It is a long established fact that a reader will be distracted by the readable content of a page when looking at its layout. The point of using Lorem Ipsum is that it has a more-or-less normal distribution of letters, as opposed to using 'Content here, content here', making it look like readable English. Many desktop publishing packages and web page editors now use Lorem Ipsum as their default model text, and a search for 'lorem ipsum' will uncover many web sites still in their infancy. Various versions have evolved over the years, sometimes by accident, sometimes on purpose (injected humour and the like).        
+  Where does it come from?
+  Contrary to popular belief, Lorem Ipsum is not simply random text. It has roots in a piece of classical Latin literature from 45 BC, making it over 2000 years old. Richard McClintock, a Latin professor at Hampden-Sydney College in Virginia, looked up one of the more obscure Latin words, consectetur, from a Lorem Ipsum passage, and going through the cites of the word in classical literature, discovered the undoubtable source. Lorem Ipsum comes from sections 1.10.32 and 1.10.33 of "de Finibus Bonorum et Malorum" (The Extremes of Good and Evil) by Cicero, written in 45 BC. This book is a treatise on the theory of ethics, very popular during the Renaissance. The first line of Lorem Ipsum, "Lorem ipsum dolor sit amet..", comes from a line in section 1.10.32.
+  The standard chunk of Lorem Ipsum used since the 1500s is reproduced below for those interested. Sections 1.10.32 and 1.10.33 from "de Finibus Bonorum et Malorum" by Cicero are also reproduced in their exact original form, accompanied by English versions from the 1914 translation by H. Rackham.
+  Where can I get some?
+  There are many variations of passages of Lorem Ipsum available, but the majority have suffered alteration in some form, by injected humour, or randomised words which don't look even slightly believable. If you are going to use a passage of Lorem Ipsum, you need to be sure there isn't anything embarrassing hidden in the middle of text. All the Lorem Ipsum generators on the Internet tend to repeat predefined chunks as necessary, making this the first true generator on the Internet. It uses a dictionary of over 200 Latin words, combined with a handful of model sentence structures, to generate Lorem Ipsum which looks reasonable. The generated Lorem Ipsum is therefore always free from repetition, injected humour, or non-characteristic words etc.`,
+  name: 'content',
+};
+
 describe('Index Processor', () => {
   test('Transform', () => {
     const results = transform(pages);
@@ -31,4 +45,47 @@ describe('Index Processor', () => {
     const result = processSections(pages.prefilled_market_modules);
     expect(result).toBeTruthy();
   });
+  test('reading time', () => {
+    const relationType = 'author';
+    const market = 'ie_en';
+    const page = {
+      [market]: {
+        [relationType]: getPageList({
+          template: relationType,
+          count: 3,
+          relation: null,
+          relation_id: 5,
+        }),
+      },
+    };
+    const result = getReadingTime(page[market][relationType][0].sections);
+    page.reading_time = result;
+
+    expect(result).toBe(1);
+    expect(page.reading_time).toBeTruthy();
+    expect(page.reading_time).toBe(result);
+
+    // Add more content for testing purpose of longer reading time
+    const page1 = {
+      [market]: {
+        [relationType]: getPageList({
+          template: relationType,
+          count: 3,
+          relation: null,
+          relation_id: 5,
+        }),
+      },
+    };
+
+    // eslint-disable-next-line no-plusplus
+    for (let index = 0; index < 5; index++) {
+      page1[market][relationType][1].sections.main.modules.push(tempContent);
+    }
+    const result1 = getReadingTime(page1[market][relationType][1].sections);
+    page.reading_time = result1;
+
+    expect(result1).toBe(11);
+    expect(page.reading_time).toBeTruthy();
+    expect(page.reading_time).toBe(result1);
+  });
 });

package/tests/factories/pages/page.factory.js

@@ -14,7 +14,48 @@ const getDefaultProps = (index = 1, template) => ({
   logo_url: '#',
   banner: '313df295c19d7c5f137ceda9d0cc5df7.jpeg',
   rating: '4.88',
-  sections: { main: { extra_fields: { logos: { value: 339, type: 'default' } } } },
+  sections: {
+    main: {
+      modules: [
+        {
+          value:
+            "<p>'<em>'Whether it's crafting blog posts, articles, product descriptions, or marketing copy, I approach every project with the same level of passion and dedication. My ability to adapt my writing style to suit different niches and target audiences has earned me a reputation as a versatile and dependable writer</em>.''</p>",
+          name: 'content',
+        },
+        {
+          mode: 'image_text',
+          show_read_more: null,
+          read_more_text: null,
+          items: [Array],
+          module_value_id: 401446,
+          name: 'spotlights',
+        },
+        {
+          cards_page_type: null,
+          cards_page_type_id: null,
+          cards_selector: 'use_filters',
+          cards_selector_manual_list: [],
+          cards_selector_filters_limit: null,
+          cards_selector_filters: [Object],
+          cards_selector_filters_sort_by: 'latest',
+          cards_enable_pagination: false,
+          module_value_id: 401448,
+          name: 'cards_v2',
+          anchored: 0,
+        },
+        {
+          value_id: 309998,
+          value_type: 'prefilled_module_market',
+          anchor_label: null,
+          anchor_slug: null,
+          module_value_id: 401447,
+        },
+      ],
+      extra_fields: {
+        logos: { value: 339, type: 'default' },
+      },
+    },
+  },
   extra_fields: { related_operator: {} },
   breadcrumbs: [{ label: 'Sport', path: 'sport' }],
   preconnect_links: ['1', '2', '3'],