gantt-lib 0.52.0 → 0.53.0

package/dist/index.mjs

@@ -721,6 +721,22 @@ function validateDependencies(tasks) {
       }
     }
   }
+  for (const task of tasks) {
+    if (!task.dependencies) continue;
+    for (const dep of task.dependencies) {
+      if (!taskIds.has(dep.taskId)) {
+        continue;
+      }
+      if (areTasksHierarchicallyRelated(task.id, dep.taskId, tasks)) {
+        errors.push({
+          type: "constraint",
+          taskId: task.id,
+          message: `Dependencies between parent and child tasks are not allowed: ${dep.taskId} -> ${task.id}`,
+          relatedTaskIds: [dep.taskId, task.id]
+        });
+      }
+    }
+  }
   const cycleResult = detectCycles(tasks);
   if (cycleResult.hasCycle && cycleResult.cyclePath) {
     errors.push({
@@ -979,6 +995,28 @@ function findParentId(taskId, tasks) {
   const task = tasks.find((t) => t.id === taskId);
   return task?.parentId;
 }
+function isAncestorTask(ancestorId, taskId, tasks) {
+  const taskById = new Map(tasks.map((task) => [task.id, task]));
+  const visited = /* @__PURE__ */ new Set();
+  let current = taskById.get(taskId);
+  while (current?.parentId) {
+    if (current.parentId === ancestorId) {
+      return true;
+    }
+    if (visited.has(current.parentId)) {
+      return false;
+    }
+    visited.add(current.parentId);
+    current = taskById.get(current.parentId);
+  }
+  return false;
+}
+function areTasksHierarchicallyRelated(taskId1, taskId2, tasks) {
+  if (taskId1 === taskId2) {
+    return true;
+  }
+  return isAncestorTask(taskId1, taskId2, tasks) || isAncestorTask(taskId2, taskId1, tasks);
+}
 function getAllDescendants(parentId, tasks) {
   const descendants = [];
   const visited = /* @__PURE__ */ new Set();
@@ -5834,7 +5872,7 @@ var TaskList = ({
   const [selectingPredecessorFor, setSelectingPredecessorFor] = useState6(null);
   const [dependencyPickMode, setDependencyPickMode] = useState6("successor");
   const [typeMenuOpen, setTypeMenuOpen] = useState6(false);
-  const [cycleError, setCycleError] = useState6(false);
+  const [dependencyError, setDependencyError] = useState6(null);
   const overlayRef = useRef6(null);
   const [selectedChip, setSelectedChip] = useState6(null);
   const handleChipSelect = useCallback5((chip) => {
@@ -5869,6 +5907,12 @@ var TaskList = ({
   }, [selectingPredecessorFor, selectedChip, selectedTaskId, onTaskSelect, onSelectedChipChange]);
   const handleAddDependency = useCallback5((successorTaskId, predecessorTaskId, linkType) => {
     if (successorTaskId === predecessorTaskId) return;
+    if (areTasksHierarchicallyRelated(successorTaskId, predecessorTaskId, tasks)) {
+      setDependencyError("\u0421\u0432\u044F\u0437\u0438 \u043C\u0435\u0436\u0434\u0443 \u0440\u043E\u0434\u0438\u0442\u0435\u043B\u0435\u043C \u0438 \u043F\u043E\u0442\u043E\u043C\u043A\u043E\u043C \u0437\u0430\u043F\u0440\u0435\u0449\u0435\u043D\u044B");
+      setTimeout(() => setDependencyError(null), 3e3);
+      setSelectingPredecessorFor(null);
+      return;
+    }
     const successor = tasks.find((t) => t.id === successorTaskId);
     if (!successor) return;
     const alreadyExists = (successor.dependencies ?? []).some(
@@ -5884,8 +5928,11 @@ var TaskList = ({
     );
     const validation = validateDependencies(hypothetical);
     if (!validation.isValid) {
-      setCycleError(true);
-      setTimeout(() => setCycleError(false), 3e3);
+      const hasHierarchyConstraint = validation.errors.some((error) => error.type === "constraint");
+      setDependencyError(
+        hasHierarchyConstraint ? "\u0421\u0432\u044F\u0437\u0438 \u043C\u0435\u0436\u0434\u0443 \u0440\u043E\u0434\u0438\u0442\u0435\u043B\u0435\u043C \u0438 \u043F\u043E\u0442\u043E\u043C\u043A\u043E\u043C \u0437\u0430\u043F\u0440\u0435\u0449\u0435\u043D\u044B" : "\u0426\u0438\u043A\u043B \u0437\u0430\u0432\u0438\u0441\u0438\u043C\u043E\u0441\u0442\u0435\u0439!"
+      );
+      setTimeout(() => setDependencyError(null), 3e3);
       return;
     }
     const updatedTask = hypothetical.find((t) => t.id === successorTaskId);
@@ -6209,7 +6256,7 @@ var TaskList = ({
                       lt
                     )) }) })
                   ] }),
-                  cycleError && /* @__PURE__ */ jsx14("div", { className: "gantt-tl-dep-error", children: "\u0426\u0438\u043A\u043B \u0437\u0430\u0432\u0438\u0441\u0438\u043C\u043E\u0441\u0442\u0435\u0439!" })
+                  dependencyError && /* @__PURE__ */ jsx14("div", { className: "gantt-tl-dep-error", children: dependencyError })
                 ]
               },
               col.id
@@ -7010,6 +7057,7 @@ export {
   addBusinessDays,
   alignToWorkingDay,
   and,
+  areTasksHierarchicallyRelated,
   buildAdjacencyList,
   buildTaskRangeFromEnd,
   buildTaskRangeFromStart,
@@ -7056,6 +7104,7 @@ export {
   getWeekSpans,
   getYearSpans,
   inDateRange,
+  isAncestorTask,
   isTaskExpired,
   isTaskParent,
   isToday,