gaia-framework 1.54.0 → 1.54.1

package/README.md

@@ -460,7 +460,7 @@ The single source of truth is `_gaia/_config/global.yaml`:
 
 ```yaml
 framework_name: "GAIA"
-framework_version: "1.49.0"
+framework_version: "1.54.1"
 user_name: "your-name"
 project_name: "your-project"
 ```

package/bin/gaia-framework.js

@@ -35,9 +35,9 @@ function findBash() {
 
   // 1. Try Git for Windows FIRST (preferred — simpler path mapping)
   const gitBashPaths = [
-    join(process.env.ProgramFiles || "C:\\Program Files", "Git", "bin", "bash.exe"),
-    join(process.env["ProgramFiles(x86)"] || "C:\\Program Files (x86)", "Git", "bin", "bash.exe"),
-    join(process.env.LOCALAPPDATA || "", "Programs", "Git", "bin", "bash.exe"),
+    path.join(process.env.ProgramFiles || "C:\\Program Files", "Git", "bin", "bash.exe"),
+    path.join(process.env["ProgramFiles(x86)"] || "C:\\Program Files (x86)", "Git", "bin", "bash.exe"),
+    path.join(process.env.LOCALAPPDATA || "", "Programs", "Git", "bin", "bash.exe"),
   ];
 
   for (const p of gitBashPaths) {
@@ -83,9 +83,9 @@ function info(message) {
 }
 
 function cleanup() {
-  if (tempDir && existsSync(tempDir)) {
+  if (tempDir && fs.existsSync(tempDir)) {
     try {
-      rmSync(tempDir, { recursive: true, force: true });
+      fs.rmSync(tempDir, { recursive: true, force: true });
     } catch {
       // Best-effort cleanup
     }
@@ -94,7 +94,7 @@ function cleanup() {
 
 function ensureGit() {
   try {
-    execSync("git --version", { stdio: "ignore" });
+    childProcess.execSync("git --version", { stdio: "ignore" });
   } catch {
     fail(
       "git is required but was not found.\n" +
@@ -104,8 +104,7 @@ function ensureGit() {
 }
 
 function readPackageVersion(pkgPath) {
-  const { readFileSync } = require("fs");
-  const raw = readFileSync(pkgPath, "utf8");
+  const raw = fs.readFileSync(pkgPath, "utf8");
   const pkg = JSON.parse(raw);
   if (!pkg.version) {
     throw new Error(`No version field found in ${pkgPath}`);
@@ -143,7 +142,15 @@ Examples:
 
 // ─── Main ───────────────────────────────────────────────────────────────────
 
-function main() {
+function main(deps) {
+  // Dependency injection for testability — defaults to real modules
+  const _exec = deps && deps.execSync || childProcess.execSync;
+  const _execFile = deps && deps.execFileSync || childProcess.execFileSync;
+  const _mkdtemp = deps && deps.mkdtempSync || fs.mkdtempSync;
+  const _exists = deps && deps.existsSync || fs.existsSync;
+  const _join = deps && deps.join || path.join;
+  const _tmpdir = deps && deps.tmpdir || os.tmpdir;
+
   const args = process.argv.slice(2);
 
   // Handle help / no args
@@ -190,7 +197,7 @@ function main() {
   info("Cloning GAIA framework from GitHub...");
 
   try {
-    execSync(`git clone --depth 1 ${REPO_URL} "${tempDir}"`, {
+    _exec(`git clone --depth 1 ${REPO_URL} "${tempDir}"`, {
       stdio: ["ignore", "ignore", "pipe"],
     });
   } catch (err) {
@@ -201,8 +208,8 @@ function main() {
   }
 
   // Locate the installer script
-  const scriptPath = join(tempDir, SCRIPT_NAME);
-  if (!existsSync(scriptPath)) {
+  const scriptPath = _join(tempDir, SCRIPT_NAME);
+  if (!_exists(scriptPath)) {
     fail(`Installer script not found in cloned repo: ${SCRIPT_NAME}`);
   }
 
@@ -246,4 +253,8 @@ function main() {
   }
 }
 
-main();
+if (require.main === module) {
+  main();
+}
+
+module.exports = { findBash, ensureGit, showUsage, fail, info, cleanup, readPackageVersion, main };

package/gaia-install.sh

@@ -6,7 +6,7 @@ set -euo pipefail
 # Installs, updates, validates, and reports on GAIA installations.
 # ─────────────────────────────────────────────────────────────────────────────
 
-readonly VERSION="1.54.0"
+readonly VERSION="1.54.1"
 readonly GITHUB_REPO="https://github.com/jlouage/Gaia-framework.git"
 readonly MANIFEST_REL="_gaia/_config/manifest.yaml"
 
@@ -105,6 +105,11 @@ clone_from_github() {
   echo "$TEMP_CLONE_DIR"
 }
 
+normalize_path() {
+  local p="${1//\\//}"
+  echo "$p"
+}
+
 resolve_source() {
   local resolved=""
 
@@ -116,10 +121,14 @@ resolve_source() {
   elif [[ -n "${GAIA_SOURCE:-}" ]]; then
     resolved="$GAIA_SOURCE"
     [[ "$OPT_VERBOSE" == true ]] && detail "Source from \$GAIA_SOURCE: $resolved" >&2
-  # 3. Self-detect: script's own directory
-  elif [[ -d "$(dirname "$(realpath "$0")")/_gaia" ]]; then
+  # 3. Self-detect: script's own directory (guard realpath for Git Bash compatibility)
+  elif command -v realpath &>/dev/null && [[ -d "$(dirname "$(realpath "$0")")/_gaia" ]]; then
     resolved="$(dirname "$(realpath "$0")")"
     [[ "$OPT_VERBOSE" == true ]] && detail "Source from script location: $resolved" >&2
+  # 3b. Fallback when realpath is unavailable (e.g., Git Bash without MSYS2 extras)
+  elif [[ -d "$(cd "$(dirname "$0")" && pwd)/_gaia" ]]; then
+    resolved="$(cd "$(dirname "$0")" && pwd)"
+    [[ "$OPT_VERBOSE" == true ]] && detail "Source from script location (cd fallback): $resolved" >&2
   # 4. GitHub clone
   else
     resolved="$(clone_from_github)"
@@ -182,6 +191,77 @@ copy_with_backup() {
   [[ "$OPT_VERBOSE" == true ]] && detail "Updated (backed up): $dst" || true
 }
 
+# Remove .resolved/*.yaml files from target _gaia/ directory.
+# Called after cp/tar copy to replicate rsync's --exclude behavior.
+# Only .resolved/*.yaml is relevant to the _gaia/ subtree; the other rsync
+# --exclude patterns target _memory/ paths outside _gaia/ and never match.
+clean_resolved_yaml() {
+  local target_gaia="$1"
+  find "$target_gaia" -path '*/.resolved/*.yaml' -delete 2>/dev/null || true
+}
+
+# Copy _gaia/ directory from source to target using a fallback chain:
+#   rsync → cp -rp → tar
+# Tries each tool in order. If a tool is found but fails at runtime (e.g.,
+# broken rsync stub on Windows), falls through to the next tool. Exits with
+# a diagnostic error if all tools fail or none are available.
+#
+# Excludes .resolved/*.yaml files from the final output (rsync handles this
+# natively via --exclude; cp and tar do a post-copy cleanup).
+#
+# Note: No symlinks currently exist in _gaia/. If symlinks are introduced
+# in the future, verify that cp -rp behavior matches rsync -a on all
+# target platforms (ADR-004).
+copy_gaia_files() {
+  local src="$1" dst="$2"
+  local copy_done=false
+
+  # Try rsync first (preferred — handles excludes natively)
+  if command -v rsync >/dev/null 2>&1; then
+    if rsync -a \
+      --exclude='_memory/checkpoints/*.yaml' \
+      --exclude='_memory/checkpoints/completed/*.yaml' \
+      --exclude='.resolved/*.yaml' \
+      --exclude='_memory/*-sidecar/*.md' \
+      --exclude='_memory/*-sidecar/*.yaml' \
+      "$src/_gaia/" "$dst/_gaia/" 2>/dev/null; then
+      detail "Copied framework files using rsync"
+      copy_done=true
+    else
+      detail "rsync found but failed — trying fallback methods"
+    fi
+  fi
+
+  # Fallback: cp -rp (preserves permissions like rsync -a)
+  if [[ "$copy_done" == false ]] && command -v cp >/dev/null 2>&1; then
+    if cp -rp "$src/_gaia/" "$dst/_gaia/" 2>/dev/null; then
+      clean_resolved_yaml "$dst/_gaia"
+      detail "Copied framework files using cp -rp (rsync unavailable)"
+      copy_done=true
+    else
+      error "cp failed to copy framework files — check permissions and disk space"
+      exit 1
+    fi
+  fi
+
+  # Fallback: tar (last resort — available on virtually all POSIX systems)
+  if [[ "$copy_done" == false ]] && command -v tar >/dev/null 2>&1; then
+    if (tar -cf - -C "$src" _gaia | tar -xf - -C "$dst") 2>/dev/null; then
+      clean_resolved_yaml "$dst/_gaia"
+      detail "Copied framework files using tar (rsync and cp unavailable)"
+      copy_done=true
+    else
+      error "tar failed to copy framework files — check permissions and disk space"
+      exit 1
+    fi
+  fi
+
+  if [[ "$copy_done" == false ]]; then
+    error "No suitable copy tool found (tried rsync, cp, tar). Cannot copy framework files."
+    exit 1
+  fi
+}
+
 append_if_missing() {
   local file="$1" marker="$2" content="$3"
   if [[ -f "$file" ]] && grep -qF "$marker" "$file"; then
@@ -261,18 +341,22 @@ cmd_init() {
   done
 
   # Step 2: Copy _gaia/ recursively (excluding checkpoints and .resolved/*.yaml)
+  # Uses rsync if available, falls back to cp -rp, then tar (ADR-004: Windows best-effort)
   step "Copying framework files..."
   if [[ "$OPT_DRY_RUN" == true ]]; then
-    detail "[dry-run] Would copy _gaia/ (excluding checkpoints and .resolved/*.yaml)"
+    if command -v rsync >/dev/null 2>&1; then
+      detail "[dry-run] Would copy _gaia/ using rsync (excluding checkpoints and .resolved/*.yaml)"
+    elif command -v cp >/dev/null 2>&1; then
+      detail "[dry-run] Would copy _gaia/ using cp -rp (rsync unavailable)"
+    elif command -v tar >/dev/null 2>&1; then
+      detail "[dry-run] Would copy _gaia/ using tar (rsync and cp unavailable)"
+    else
+      error "No suitable copy tool found (tried rsync, cp, tar)"
+      exit 1
+    fi
   else
     mkdir -p "$TARGET/_gaia"
-    rsync -a \
-      --exclude='_memory/checkpoints/*.yaml' \
-      --exclude='_memory/checkpoints/completed/*.yaml' \
-      --exclude='.resolved/*.yaml' \
-      --exclude='_memory/*-sidecar/*.md' \
-      --exclude='_memory/*-sidecar/*.yaml' \
-      "$source/_gaia/" "$TARGET/_gaia/"
+    copy_gaia_files "$source" "$TARGET"
   fi
 
   # Step 3: Create _memory/ directory tree at project root (ADR-013)
@@ -351,7 +435,10 @@ cmd_init() {
   else
     local global_file="$TARGET/_gaia/_config/global.yaml"
     if [[ -f "$global_file" ]]; then
-      # Use portable sed for both macOS and Linux
+      # Use portable sed for both macOS and Linux.
+      # macOS (Darwin) requires sed -i '' (empty extension). Linux/GNU sed uses sed -i (no arg).
+      # Git Bash on Windows: uname returns "MINGW64_NT-*", which falls into the else branch
+      # (GNU sed), which is correct — Git for Windows ships GNU sed.
       if [[ "$(uname)" == "Darwin" ]]; then
         sed -i '' "s|^project_name:.*|project_name: \"$project_name\"|" "$global_file"
         sed -i '' "s|^user_name:.*|user_name: \"$user_name\"|" "$global_file"
@@ -430,6 +517,21 @@ GITIGNORE
   echo ""
 }
 
+# ─── find_files_in_dir ──────────────────────────────────────────────────────
+# Lists all files in a directory tree. Uses null-delimited output (find -print0)
+# when supported, falls back to newline-delimited output on systems where -print0
+# is unavailable (e.g., Windows Git Bash with busybox find).
+# GAIA file paths never contain newlines, so the newline-delimited fallback is safe.
+
+find_files_in_dir() {
+  local dir="$1"
+  if find /dev/null -maxdepth 0 -print0 2>/dev/null | head -c0 2>/dev/null; then
+    find "$dir" -type f -print0
+  else
+    find "$dir" -type f
+  fi
+}
+
 # ─── cmd_update ─────────────────────────────────────────────────────────────
 
 cmd_update() {
@@ -497,6 +599,12 @@ cmd_update() {
   step "Updating framework files..."
   local updated=0 skipped=0 changed=0
 
+  # Feature-detect find -print0 support once before the loop (E6-S2)
+  local use_print0=false
+  if find /dev/null -maxdepth 0 -print0 2>/dev/null | head -c0 2>/dev/null; then
+    use_print0=true
+  fi
+
   for entry in "${update_targets[@]}"; do
     local src_path="$source/_gaia/$entry"
     local dst_path="$TARGET/_gaia/$entry"
@@ -515,12 +623,24 @@ cmd_update() {
       copy_with_backup "$src_path" "$dst_path" "$backup_dir"
       updated=$((updated + 1))
     elif [[ -d "$src_path" ]]; then
-      # Directory — update each file
-      while IFS= read -r -d '' file; do
-        local rel="${file#$src_path/}"
-        copy_with_backup "$file" "$dst_path/$rel" "$backup_dir"
-        updated=$((updated + 1))
-      done < <(find "$src_path" -type f -print0) || true
+      # Directory — update each file via find_files_in_dir helper
+      if [[ "$use_print0" == true ]]; then
+        # Null-delimited path (macOS/Linux with GNU or BSD find)
+        while IFS= read -r -d '' file; do
+          local rel="${file#$src_path/}"
+          copy_with_backup "$file" "$dst_path/$rel" "$backup_dir"
+          updated=$((updated + 1))
+        done < <(find_files_in_dir "$src_path") || true
+      else
+        # Newline-delimited fallback (Windows Git Bash / busybox find)
+        # Safe because GAIA file paths never contain newlines
+        while IFS= read -r file; do
+          [[ -z "$file" ]] && continue
+          local rel="${file#$src_path/}"
+          copy_with_backup "$file" "$dst_path/$rel" "$backup_dir"
+          updated=$((updated + 1))
+        done < <(find_files_in_dir "$src_path") || true
+      fi
     fi
   done
 
@@ -830,7 +950,7 @@ parse_args() {
           error "--source requires a path argument"
           exit 1
         fi
-        SOURCE_FLAG="$2"
+        SOURCE_FLAG="$(normalize_path "$2")"
         shift 2
         ;;
       --yes|-y)
@@ -858,7 +978,7 @@ parse_args() {
           error "Unexpected argument: $1"
           exit 1
         fi
-        TARGET="$1"
+        TARGET="$(normalize_path "$1")"
         shift
         ;;
     esac

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "gaia-framework",
-  "version": "1.54.0",
+  "version": "1.54.1",
   "description": "GAIA — Generative Agile Intelligence Architecture installer",
   "bin": {
     "gaia-framework": "./bin/gaia-framework.js"
   },
   "scripts": {
-    "test": "vitest run",
+    "test": "vitest run --coverage",
     "test:watch": "vitest",
     "test:coverage": "vitest run --coverage",
     "test:unit": "vitest run test/unit",