ga4-export-fixer 0.9.0-dev.10 → 0.9.0-dev.12

package/helpers/ga4Transforms.js

@@ -235,13 +235,15 @@ const itemListAttributionExpr = (lookbackType, timestampColumn, lookbackTimeMs)
     frameBounds = `range between ${lookbackMicros} preceding and current row`;
   }
 
-  return `last_value(
+  // Refund events occur outside the selection-driven journey window — propagating
+  // item_list_* attribution into them would misattribute. Suppress attribution on refund rows.
+  return `if(event_name = 'refund', null, last_value(
       if(${selectEvents}, ${structExpr}, null) ignore nulls
     ) over(
       partition by ${partitionBy}
       order by ${timestampColumn} asc
       ${frameBounds}
-    )`;
+    ))`;
 };
 
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ga4-export-fixer",
-  "version": "0.9.0-dev.10",
+  "version": "0.9.0-dev.12",
   "description": "",
   "main": "index.js",
   "files": [

package/tables/ga4EventsEnhanced/index.js

@@ -162,8 +162,18 @@ const _generateEnhancedEventsSQL = (mergedConfig) => {
 
     // item list attribution config
     const itemListAttribution = mergedConfig.itemListAttribution;
-    const ecommerceEventsFilter = itemListAttribution
-        ? helpers.ga4EcommerceEvents.filter(e => e !== 'refund').map(e => `'${e}'`).join(', ')
+
+    // Build enrichment-source CTEs and gather per-level join/column data. The utility routes
+    // event-level and item-level entries through separate output channels. Done up here so the
+    // items-scaffold activation state is known before building event_data (which needs
+    // _item_row_id when the scaffold is active for any reason).
+    const { steps: enrichmentSteps, event: eventEnrichments, item: itemEnrichments }
+        = utils.buildEnrichments(mergedConfig.enrichments);
+    const itemEnrichmentsActive = itemEnrichments.joins.length > 0;
+    const itemsScaffoldActive = !!itemListAttribution || itemEnrichmentsActive;
+
+    const ecommerceEventsFilter = itemsScaffoldActive
+        ? helpers.ga4EcommerceEvents.map(e => `'${e}'`).join(', ')
         : null;
 
     // auto-adjust bufferDays for time-based item list attribution lookback
@@ -220,7 +230,7 @@ const _generateEnhancedEventsSQL = (mergedConfig) => {
         // ecommerce
         ecommerce: helpers.fixEcommerceStruct('ecommerce'),
         // assign a unique row id, used for handling item-level attribution and enrichment
-        _item_row_id: itemListAttribution ? helpers.itemRowId(ecommerceEventsFilter) : undefined,
+        _item_row_id: itemsScaffoldActive ? helpers.itemRowId(ecommerceEventsFilter) : undefined,
         // flag if the data is "final" and is not expected to change anymore
         data_is_final: helpers.isFinalData(mergedConfig.dataIsFinal.detectionMethod, mergedConfig.dataIsFinal.dayThreshold),
         export_type: helpers.getGa4ExportType('_table_suffix'),
@@ -263,11 +273,6 @@ ${excludedEventsSQL}`,
         'group by': 'session_id',
     };
 
-    // Build enrichment-source CTEs and gather per-level join/column data. The utility routes
-    // event-level and item-level entries through separate output channels.
-    const { steps: enrichmentSteps, event: eventEnrichments, item: itemEnrichments }
-        = utils.buildEnrichments(mergedConfig.enrichments);
-
     // Validate item-level joinKey columns and collect any event_data columns that need to
     // be carried up to items_unnested as top-level columns (so the LEFT JOIN inside
     // items_rebuilt can USING(...) on them). Item-struct fields are already top-level on
@@ -300,8 +305,6 @@ ${excludedEventsSQL}`,
     //    LEFT JOIN enrich_<name> for each item-level enrichment.
     // Activation: emitted when EITHER itemListAttribution is configured OR at least one
     // item-level enrichment is present.
-    const itemEnrichmentsActive = itemEnrichments.joins.length > 0;
-    const itemsScaffoldActive = !!itemListAttribution || itemEnrichmentsActive;
     const itemListSteps = itemsScaffoldActive ? (() => {
         const passthroughEvents = `event_name in ('view_item_list', 'select_item', 'view_promotion', 'select_promotion')`;
 
@@ -316,8 +319,8 @@ ${excludedEventsSQL}`,
 
         // Carry up any event_data joinKey columns used by item-level enrichments so the
         // USING(...) clause in items_rebuilt can bind against top-level identifiers.
-        // Skip ones already in the base columns above (e.g. event_date is always carried).
-        const baseColumnNames = new Set(['_item_row_id', 'event_name', 'event_date', ...Object.keys(itemFieldColumns)]);
+        // Skip ones already in the base columns above
+        const baseColumnNames = new Set(['_item_row_id', 'event_name', ...Object.keys(itemFieldColumns)]);
         const extraJoinKeyColumns = {};
         for (const c of itemJoinKeysFromEventData) {
             if (!baseColumnNames.has(c)) {
@@ -331,8 +334,6 @@ ${excludedEventsSQL}`,
         const unnestedSelectColumns = {
             '_item_row_id': '_item_row_id',
             'event_name': 'event_name',
-            // event_date is carried forward for ability to use it in data enrichment joins
-            'event_date': 'event_date',
             ...itemFieldColumns,
             ...extraJoinKeyColumns,
         };