ft-scout 9.0.8 → 9.1.0

package/bin/src/engine/agentEngine.js

@@ -9,7 +9,7 @@ import { saveAgentSession, getRecentSessionsSummary } from '../utils/session.js'
 import { safeNote, renderMarkdown } from '../utils/markdown.js';
 import { openai, callOpenAIWithRetry, isQuotaExceededError, sanitizeMessage, sanitizeMessages } from './llm.js';
 import { checkFileSyntax, verifyAndSelfHealFiles, executeSmartCommand, extractErrorDiagnostics } from './verifier.js';
-import { speakText, listenSpeechToText } from './voiceEngine.js';
+import { speakText, listenSpeechToText, cleanTextForSpeech } from './voiceEngine.js';
 import { TaskStateManager } from './agentState.js';
 import { SemanticBrowserController } from './browser/index.js';
 import { ActionVerifier } from './actionVerifier.js';
@@ -293,11 +293,14 @@ export const AGENT_TOOLS = [
     },
     {
         name: 'task_completed',
-        description: 'Signal that the user goal has been fully completed with a final teardown summary.',
+        description: 'Signal that the user goal has been fully completed with the full answer, results, and summary.',
         parameters: {
             type: 'object',
             properties: {
-                summary: { type: 'string', description: 'Comprehensive teardown report of completed changes' },
+                summary: {
+                    type: 'string',
+                    description: 'The complete answer, findings, and results delivered directly to the user. For lookups or questions, this MUST include all retrieved details, accounts, URLs, or data.',
+                },
             },
             required: ['summary'],
         },
@@ -376,10 +379,12 @@ export class AgentExecutionLoop {
     executionIntent;
     userTier;
     currentGoal = '';
+    isAudioMode = false;
     constructor(options) {
         this.cwd = process.cwd();
         this.autoApprove = Boolean(options?.autoApprove);
         this.mockMode = Boolean(options?.mockMode);
+        this.isAudioMode = Boolean(options?.isAudioMode);
         this.userTier = (options?.tier || loadAuthConfig().currentTier || 'free').toLowerCase();
         // Free tier is bounded to basic direct actions (max 5 steps). Full autonomous multi-step loops require Pro/Enterprise.
         const isPaid = this.mockMode || this.userTier === 'pro' || this.userTier === 'enterprise';
@@ -586,6 +591,8 @@ PLAN TIER & CAPABILITIES: DEVELOPER FREE (BASIC DEVELOPER OPS ONLY)
 `;
         const mcpRouting = getMCPManager().routeTools(this.currentGoal);
         const mcpCapabilitiesSection = mcpRouting.capabilitiesSummary ? `\n${mcpRouting.capabilitiesSummary}\n` : '';
+        const recentSessionsMemory = getRecentSessionsSummary(3);
+        const sessionHistorySection = recentSessionsMemory ? `\n${recentSessionsMemory}\n` : '';
         return `You are Scout Agent, an elite AI Principal Software Engineer & Autonomous Computer-Use Operator (developed by FrontTerrain).
 
 Working Directory: "${this.cwd}"
@@ -594,6 +601,7 @@ Current Date & Time: "${new Date().toISOString()}" (Current Year: ${new Date().g
 ${tierDirective}
 ${intentInfo}
 ${mcpCapabilitiesSection}
+${sessionHistorySection}
 Workspace Overview (first 100 files):
 ${filesList.join('\n')}
 
@@ -620,10 +628,18 @@ CORE ARCHITECTURAL PRINCIPLES:
 6. MULTILINGUAL & INTENT COMPREHENSION: Understand user intent in any language (English, Hinglish like "likho", "bnao", "code karo", "fix karo", "samjha do", Hindi, Spanish, etc.).
 7. FOR CODE & REPO TASKS: When the task is a coding, project refactoring, or repository maintenance task, use direct code modification tools (write_file, edit_file, run_command, read_file, grep_search).
 8. RUN & VERIFY COMMANDS: Execute shell commands, tests, builds, and formatters using run_command.
-9. CRITICAL TERMINATION & CONVERSATIONAL VOICE RULE: As soon as you have finished creating/modifying the necessary files, running verification checks, or completing the desktop application workflow, YOU MUST CALL task_completed tool immediately.
-   - CONVERSATIONAL CO-PILOT TONE: In your 'summary' parameter for task_completed, speak directly and warmly to the developer like an elite human co-pilot (e.g. "I've launched Chrome for you and it's active on your screen. What should we tackle next?" or "I've created the authentication controller and all unit tests pass with zero regressions!"). Never output dry mechanical robot logs or third-person phrases like "Objective achieved with 1 tool call". Talk directly to the user!
+9. CRITICAL TERMINATION, RESULTS DELIVERY & CONVERSATIONAL VOICE RULE:
+   - For ANY lookup, question, status check, external data retrieval, or inquiry (e.g. "Lookup up my github account", "What is X", "Check my PRs"):
+     Your 'summary' argument in task_completed (or your direct response) MUST contain the COMPLETE, ACCURATE, AND DETAILED ANSWER with all specific data found (usernames, repository names, statistics, URLs, findings, or explanations).
+     NEVER output a vacuous meta-summary like "Task completed" or "Looked up account" without providing the actual information the user asked for!
+   - For coding/modification tasks: Detail what was changed, created, and tested.
+   - CONVERSATIONAL CO-PILOT TONE: In your 'summary' parameter for task_completed, speak directly and warmly to the developer like an elite human co-pilot (e.g. "Here are your GitHub account details: your username is ..."). Never output dry mechanical robot logs or third-person phrases like "Objective achieved with 1 tool call". Talk directly to the user!
 10. THOUGHT TRANSPARENCY PROTOCOL: In EVERY step before calling any tools or ending a turn, you MUST provide a clear 1-2 sentence explanation in your text response describing your current reasoning, what file/action you are taking, and why you are taking it.
 11. APPLICATION LAUNCH & SIMPLE ACTION TERMINATION: When the user's objective is simply to open, launch, close, or focus an application (e.g. "Open Chrome", "Launch Notepad", "Open Calculator"): Immediately after calling computer_open_app or computer_close_app, your goal is 100% complete! You MUST call task_completed on the very next step with your friendly conversational summary. NEVER explore the repository or call list_dir, read_file, grep_search, or edit_file for app launching tasks!
+12. STRICT ACTIVE GOAL ISOLATION & ACCURACY:
+   - You must strictly execute ONLY the current active goal provided in the user prompt.
+   - Historical workspace sessions are provided for background context ONLY. NEVER re-run, repeat, or resume past session tasks unless the user explicitly requests it in the current prompt.
+   - For lookups, questions, status checks, or external service queries (e.g. GitHub account, MCP tools, web): deliver the concrete results directly and do NOT attempt to edit or rewrite unrelated workspace files.
 
 When returning tool calls, use standard OpenAI function calling format or JSON tool call payload format:
 \`\`\`json
@@ -637,6 +653,7 @@ When returning tool calls, use standard OpenAI function calling format or JSON t
     async executeGoal(userGoal) {
         this.resetContext();
         this.currentGoal = userGoal;
+        this.taskStateManager.createTaskState(userGoal);
         this.executionIntent = inferExecutionIntent(userGoal);
         this.taskStateManager.setObjective(userGoal);
         if (this.computerController.setExpectedApplication && this.executionIntent.requiredApplications.length > 0) {
@@ -659,19 +676,14 @@ When returning tool calls, use standard OpenAI function calling format or JSON t
             };
         }
         this.historyMessages.push({ role: 'system', content: this.systemPrompt() });
-        // Load persistent session history memory (minimum 3 sessions Context)
-        const recentSessionsMemory = getRecentSessionsSummary(3);
-        if (recentSessionsMemory) {
-            this.historyMessages.push({
-                role: 'user',
-                content: recentSessionsMemory,
-            });
-        }
-        // Robust Target File Discovery: Only run file discovery if the goal is NOT a simple desktop application launch/action
+        // Robust Target File Discovery: Only run file discovery if the goal has explicit code editing/modification intent
         const simpleAppCheck = checkSimpleAppAction(userGoal);
+        const lowerGoal = userGoal.toLowerCase().trim();
+        const hasCodeEditIntent = /\b(edit|modify|fix|update|change|refactor|write|create|implement|patch|delete|remove|add\s+code|add\s+function|debug)\b/i.test(lowerGoal) &&
+            !/\b(lookup|look\s*up|who|what|why|where|how|explain|describe|tell|status|check|github|mcp)\b/i.test(lowerGoal);
         const filesList = getDirectoryFiles(this.cwd);
         const matchedFiles = [];
-        if (!simpleAppCheck.isSimple) {
+        if (hasCodeEditIntent && !simpleAppCheck.isSimple) {
             const isIgnoredFile = (filePath) => {
                 const norm = filePath.replace(/\\/g, '/').toLowerCase();
                 const ext = path.extname(norm);
@@ -709,7 +721,7 @@ When returning tool calls, use standard OpenAI function calling format or JSON t
                     }
                 }
             }
-            // Keyword fallback if no direct path matched
+            // Keyword fallback only if explicit path wasn't matched and code edit intent exists
             if (matchedFiles.length === 0) {
                 const stopWords = new Set([
                     'the', 'a', 'an', 'in', 'is', 'for', 'to', 'of', 'and', 'or', 'on', 'at', 'by', 'from',
@@ -755,7 +767,7 @@ When returning tool calls, use standard OpenAI function calling format or JSON t
                         this.readFilesHistory.add(file.replace(/\\/g, '/').toLowerCase());
                         this.historyMessages.push({
                             role: 'user',
-                            content: `[Reference Workspace Context - Pre-loaded target file "${file}" (${lines.length} lines)]:\n\`\`\`\n${previewSnippet}\n\`\`\`\nCRITICAL DIRECTIVE: The target file "${file}" is ALREADY fully pre-loaded into your reference context above. DO NOT call read_file or list_dir for this file again! Immediately begin calling write_file, edit_file, or run_command to satisfy the user goal.`,
+                            content: `[Reference Workspace Context - Pre-loaded target file "${file}" (${lines.length} lines)]:\n\`\`\`\n${previewSnippet}\n\`\`\`\n(Note: "${file}" is pre-loaded above for your reference. Use this context if relevant to completing the user goal.)`,
                         });
                     }
                     catch {
@@ -767,7 +779,7 @@ When returning tool calls, use standard OpenAI function calling format or JSON t
         if (userGoal && userGoal.trim()) {
             this.historyMessages.push({
                 role: 'user',
-                content: userGoal,
+                content: `USER GOAL: "${userGoal.trim()}"\n\nPlease execute the necessary steps and tools to fulfill this exact goal now.`,
             });
         }
         const estTotalSecs = Math.round(this.maxSteps * 12);
@@ -866,6 +878,12 @@ You MUST output exactly ONE JSON code block per tool call. Do NOT describe what
                 const textContent = msg.content || '';
                 if (textContent.trim()) {
                     safeNote(renderMarkdown(textContent), `Scout Thought (Step ${step})`);
+                    if (this.isAudioMode) {
+                        const speechText = cleanTextForSpeech(textContent);
+                        if (speechText) {
+                            speakText(speechText.length > 200 ? speechText.slice(0, 200) + '...' : speechText, { async: true });
+                        }
+                    }
                 }
                 // Check native tool calls
                 if (msg.tool_calls && msg.tool_calls.length > 0) {
@@ -878,6 +896,21 @@ You MUST output exactly ONE JSON code block per tool call. Do NOT describe what
                                 args = JSON.parse(tc.function.arguments || '{}');
                             }
                             catch { }
+                            if (this.isAudioMode && fnName !== 'task_completed') {
+                                let actionPhrase = '';
+                                if (fnName === 'run_command')
+                                    actionPhrase = `Running command ${args.command ? args.command.slice(0, 40) : ''}`;
+                                else if (fnName === 'read_file')
+                                    actionPhrase = `Reading ${path.basename(args.filePath || '')}`;
+                                else if (fnName === 'write_file')
+                                    actionPhrase = `Creating ${path.basename(args.filePath || '')}`;
+                                else if (fnName === 'edit_file')
+                                    actionPhrase = `Editing ${path.basename(args.filePath || '')}`;
+                                else if (fnName.startsWith('mcp_') || fnName.includes('github'))
+                                    actionPhrase = `Querying ${fnName}`;
+                                if (actionPhrase)
+                                    speakText(actionPhrase, { async: true });
+                            }
                             const toolResult = await this.dispatchToolCall(fnName, args);
                             this.historyMessages.push({
                                 role: 'user',
@@ -998,8 +1031,13 @@ You MUST output exactly ONE JSON code block per tool call. Do NOT describe what
                         lowerText.includes('file created') ||
                         lowerText.includes('implementation complete') ||
                         lowerText.includes('work is complete');
-                    // If explicit completion phrase found, OR files have already been modified and assistant returned a final summary without calling tools
-                    if (isExplicitCompletion || (this.modifiedFiles.size > 0 && !lowerText.includes('?') && textContent.length > 50)) {
+                    const isInformationalGoal = /^(?:lookup|look\s*up|check|find|who|what|why|where|how|tell|show|explain|display|list|search|query|status|info|get|fetch|describe)\b/i.test(userGoal.trim()) ||
+                        !/\b(create|make|write|edit|modify|fix|update|refactor|build|delete|remove|patch|implement)\b/i.test(userGoal.trim());
+                    const isAnsweringInformational = isInformationalGoal && textContent.trim().length > 20 && !lowerText.includes('error occurred') && !lowerText.includes('cannot complete');
+                    const isSummaryAfterModifications = this.modifiedFiles.size > 0 && !lowerText.includes('?') && textContent.trim().length > 30;
+                    const isSummaryAfterToolExecution = this.totalToolCalls > 0 && textContent.trim().length > 30 && !lowerText.includes('calling tool') && !lowerText.includes('next step');
+                    // If explicit completion phrase found, OR informational answer provided, OR files were modified, OR tools were executed and assistant is delivering the summary
+                    if (isExplicitCompletion || isAnsweringInformational || isSummaryAfterModifications || isSummaryAfterToolExecution) {
                         saveAgentSession({
                             goal: userGoal,
                             summary: textContent,
@@ -1412,17 +1450,6 @@ You MUST output exactly ONE JSON code block per tool call. Do NOT describe what
                 const actionText = fileExists ? 'Editing file' : 'Creating file';
                 const writeSpin = spinner();
                 writeSpin.start(chalk.yellow(`️ ${actionText} ${targetPath}...`));
-                if (!this.autoApprove && process.stdout.isTTY) {
-                    writeSpin.stop();
-                    const ok = await confirm({
-                        message: chalk.yellow(`Allow Scout Agent to write file: ${chalk.bold.cyan(targetPath)}?`),
-                        initialValue: true,
-                    });
-                    if (isCancel(ok) || !ok) {
-                        return { result: `User rejected write_file to "${targetPath}"` };
-                    }
-                    writeSpin.start(chalk.yellow(`️ ${actionText} ${targetPath}...`));
-                }
                 let origContent = '__FT_WAS_NEW__';
                 if (fileExists) {
                     origContent = fs.readFileSync(fullPath, 'utf-8');
@@ -1486,17 +1513,6 @@ You MUST output exactly ONE JSON code block per tool call. Do NOT describe what
                     editSpin.stop(chalk.yellow(`Edit snippet failed for ${targetPath}.`));
                     return { result: `Error editing "${targetPath}": ${replaceRes.error}` };
                 }
-                if (!this.autoApprove && process.stdout.isTTY) {
-                    editSpin.stop();
-                    const ok = await confirm({
-                        message: chalk.yellow(`Allow Scout Agent to edit snippet in file: ${chalk.bold.cyan(targetPath)}?`),
-                        initialValue: true,
-                    });
-                    if (isCancel(ok) || !ok) {
-                        return { result: `User rejected edit_file to "${targetPath}"` };
-                    }
-                    editSpin.start(chalk.yellow(`️ Editing file ${targetPath}...`));
-                }
                 this.backups.push({ filePath: targetPath, originalContent: origContent });
                 fs.writeFileSync(fullPath, replaceRes.updatedContent, 'utf-8');
                 this.modifiedFiles.add(targetPath);
@@ -1555,15 +1571,6 @@ You MUST output exactly ONE JSON code block per tool call. Do NOT describe what
                 }
                 const isTestCmd = /\b(?:test|vitest|jest|pytest|mocha|jasmine|cargo test|go test)\b/i.test(cmd);
                 const actionLabel = isTestCmd ? `Running command for testing: \`${cmd}\`` : `Running command: \`${cmd}\``;
-                if (!this.autoApprove && process.stdout.isTTY) {
-                    const ok = await confirm({
-                        message: chalk.yellow(`Allow Scout Agent to run shell command: ${chalk.bold.cyan(cmd)}?`),
-                        initialValue: true,
-                    });
-                    if (isCancel(ok) || !ok) {
-                        return { result: `User rejected shell execution: "${cmd}"` };
-                    }
-                }
                 const runSpin = spinner();
                 runSpin.start(chalk.cyan(` ${actionLabel}...`));
                 const res = await executeSmartCommand(cmd, this.cwd, 3000);
@@ -2149,7 +2156,6 @@ You MUST output exactly ONE JSON code block per tool call. Do NOT describe what
                         };
                     }
                 }
-                speakText(summaryStr, { async: true });
                 this.taskStateManager.setStatus('completed');
                 this.taskStateManager.completeStep(this.currentStep, summaryStr);
                 return { result: summaryStr };