freight-club 0.0.1 → 0.0.3

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.0.3
+
+- Refuse a 200 that is not JSON, naming the content type and the URL that answered. Error pages arrive with a 200, and a whole marketing page was once printed as the reason there were no freight quotes.
+
+## 0.0.2
+
+- No functional changes; first release published from CI
+
 ## 0.0.1
 
 - Initial release, covering Freight Club API Documentation version 2.4: `bookShipment`, `cancelShipment`, `downloadBol`, `exportOrders`, `getBol`, `getLabel`, `getOrderStatus`, `getRate`, `getRates` and `getShipmentTracking`

package/index.js

@@ -1,11 +1,12 @@
 const HttpError = require('@stores.com/http-error');
 
 /**
- * Throws an HttpError for any non-200 response and returns the parsed JSON body otherwise.
+ * Throws for anything that is not a JSON 200 and returns the parsed JSON body otherwise.
  *
  * @private
  * @param {Response} res - A fetch Response.
  * @returns {Promise.<Object>} The parsed JSON body.
+ * @throws {Error} If the response is not JSON.
  * @throws {HttpError} If the response status is not 200.
  */
 async function parseResponse(res) {
@@ -13,6 +14,13 @@ async function parseResponse(res) {
         throw await HttpError.from(res);
     }
 
+    // Error pages, WAF challenges and marketing sites all arrive with a 200, and res.json() on one throws a parse error naming a character offset
+    const contentType = res.headers.get('content-type');
+
+    if (!contentType?.includes('json')) {
+        throw new Error(`Freight Club answered ${res.url} with ${contentType || 'no content type'} rather than JSON.`);
+    }
+
     return await res.json();
 }
 

package/package.json

@@ -32,5 +32,5 @@
         "test": "node --test --test-force-exit test",
         "test:only": "node --test --test-force-exit --test-only test"
     },
-    "version": "0.0.1"
+    "version": "0.0.3"
 }