freebuff 0.1.1 → 0.1.2

package/launcher.js

@@ -257,6 +257,39 @@ function createLauncher(productConfig) {
     )
   }
 
+  /**
+   * Bun's own crash report saying this CPU cannot run the optimized build.
+   *
+   * On Windows the exit code does not carry that. Bun's crash handler catches
+   * EXCEPTION_ILLEGAL_INSTRUCTION itself, prints a report, then leaves through
+   * Zig's std.posix.abort(), which on Windows is ExitProcess(3). So an AVX2
+   * build on a CPU without AVX2 exits with plain code 3, neither
+   * 0xC000001D nor 0xC0000409, and both checks above miss it. The Sept 27
+   * report (i3-2100, Bun 1.3.14) is exactly this:
+   *
+   *   CPU: sse42 avx
+   *   Features: no_avx2
+   *   panic: Illegal instruction at address 0x7FF61902F82C
+   *   panicked during a panic. Aborting.
+   *
+   * The report is in the stderr tail watchLaunch() keeps on Windows. Either line
+   * is proof, not a guess. `Features: no_avx2` is Bun's own CPUID answer, and a
+   * Bun "Illegal instruction" panic is the same Windows exception
+   * 0xC000001D reports, intercepted before it became the exit code. Only Bun's
+   * exact formats count, so ordinary output that mentions them does not.
+   */
+  const BUN_NO_AVX2_FEATURE = /^Features:[^\n]*\bno_avx2\b/m
+  const BUN_ILLEGAL_INSTRUCTION_PANIC =
+    /^panic(?:\([^)\n]*\))?: Illegal instruction at address 0x[0-9a-f]+/im
+
+  function stderrReportsMissingCpuFeature(code, signal, stderrTail) {
+    if (!stderrTail || (code === 0 && !signal)) return false
+    const text = sanitizeForReplay(stderrTail)
+    return (
+      BUN_NO_AVX2_FEATURE.test(text) || BUN_ILLEGAL_INSTRUCTION_PANIC.test(text)
+    )
+  }
+
   function createConfig(packageName) {
     const homeDir = os.homedir()
     const configDir =
@@ -1406,7 +1439,9 @@ function createLauncher(productConfig) {
     const { msAlive = null, stderrTail = '' } = context
     // Windows NTSTATUS codes (unsigned DWORD)
     const unsignedCode = getUnsignedExitCode(code)
-    const isIllegalInstruction = isIllegalInstructionExit(code, signal)
+    const isIllegalInstruction =
+      isIllegalInstructionExit(code, signal) ||
+      stderrReportsMissingCpuFeature(code, signal, stderrTail)
     const isAccessViolation =
       signal === 'SIGSEGV' ||
       (process.platform === 'win32' && unsignedCode === 0xc0000005)
@@ -1429,7 +1464,15 @@ function createLauncher(productConfig) {
       )
       console.error('This typically affects CPUs from before 2013.')
       console.error('')
-      printBaselineOverrideHint()
+      if (getCurrentMetadata()?.target === getBaselineFallbackTargetKey()) {
+        console.error(
+          'This is already the older-CPU (baseline) build — please include the',
+        )
+        console.error('output below in your report.')
+        console.error('')
+      } else {
+        printBaselineOverrideHint()
+      }
     } else if (isAccessViolation) {
       console.error('The binary crashed with an access violation.')
       console.error('')
@@ -1664,11 +1707,15 @@ function createLauncher(productConfig) {
     }
   }
 
-  async function tryFallbackToBaseline(code, signal, msAlive) {
-    // Two spellings of one failure, at two levels of certainty. SIGILL /
-    // STATUS_ILLEGAL_INSTRUCTION is proof this CPU cannot run this build; a
-    // Windows startup abort is a strong suspicion (see isStartupCpuFeatureCrash).
-    const confirmed = isIllegalInstructionExit(code, signal)
+  async function tryFallbackToBaseline(code, signal, msAlive, stderrTail = '') {
+    // Three spellings of one failure, at two levels of certainty. SIGILL /
+    // STATUS_ILLEGAL_INSTRUCTION, or Bun's crash report naming the missing
+    // feature (see stderrReportsMissingCpuFeature), is proof this CPU cannot
+    // run this build; a Windows startup abort is a strong suspicion (see
+    // isStartupCpuFeatureCrash).
+    const confirmed =
+      isIllegalInstructionExit(code, signal) ||
+      stderrReportsMissingCpuFeature(code, signal, stderrTail)
     if (!confirmed && !isStartupCpuFeatureCrash(code, signal, msAlive)) {
       return false
     }
@@ -1741,15 +1788,18 @@ function createLauncher(productConfig) {
       // as a startup crash and trigger a download.
       const msAlive = child.launch ? child.launch.msAlive() : Infinity
 
+      // Any failed exit, not only a native crash code: a Bun crash on Windows
+      // usually exits with plain code 3, and the reason is only in its stderr
+      // (see stderrReportsMissingCpuFeature). Clean exits skip the wait.
       let stderrTail = ''
-      if (child.launch && (isWindowsNativeCrashCode(code) || signal)) {
+      if (child.launch && (code !== 0 || signal)) {
         await child.launch.drained()
         stderrTail = child.launch.stderrTail()
       }
 
       if (
         allowBaselineFallback &&
-        (await tryFallbackToBaseline(code, signal, msAlive))
+        (await tryFallbackToBaseline(code, signal, msAlive, stderrTail))
       ) {
         return
       }
@@ -1795,6 +1845,7 @@ function createLauncher(productConfig) {
       readCachedAvx2,
       isIllegalInstructionExit,
       isStartupCpuFeatureCrash,
+      stderrReportsMissingCpuFeature,
       tryFallbackToBaseline,
       printCrashDiagnostics,
       checkForUpdates,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "freebuff",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "The world's strongest free coding agent",
   "license": "MIT",
   "bin": {
@@ -41,13 +41,13 @@
     "provenance": false
   },
   "binaryChecksums": {
-    "linux-x64": "d23432f34ecbd4f14cbeb1e7f370bad058a03e30f0f65cbca431405cc6bb05ad",
-    "linux-x64-baseline": "5ce3b598e49f500db1aa8577656600e8e6bc17a938b104290e47a23e5d605bca",
-    "linux-arm64": "e697880ee488b5e6707f6d7dd65f60c03d14db65c455146d29c5c5ee62042b3a",
-    "darwin-x64": "93557a697af5a9956e409f02937e4e247e93341754669f3d3dd1af85b42f18cb",
-    "darwin-x64-baseline": "bd6b48ddfb5e4305855b87248eed25b9d0727d2cbea705cc5cc52b03494bd815",
-    "darwin-arm64": "be1af482d5c96e0b28a54bb76936755c3928939251d31aa3fca55409353a3144",
-    "win32-x64": "d7ce3ff20dab76f558a5f65d8f8f7a7c2b78b9f5e45f35889ef98ce86589afbd",
-    "win32-x64-baseline": "18f9ce899d9e5d9ec1cb58445340e440db074ef7a8a0ae96fd1e58c0aea044a8"
+    "linux-x64": "2a149ec595d8f27ec8654b5ab072c22020d5e4f4bd0a0d2c0a1a334b6a063f71",
+    "linux-x64-baseline": "22b13efa9eb52d9a074ed2e67feb6474a551796e22d0fa0e7a9a3081943ef16b",
+    "linux-arm64": "ef43f44264cae55d86f5d0df45f4c948543d0bf92525c1b296b910badc2f0c71",
+    "darwin-x64": "cba39ca908625a8b43335942879fa6c9bd91a2a623f4a26d8a9e0d3e39b080e3",
+    "darwin-x64-baseline": "8be9ca67c635dd4bac21d1e726353c24df5d421d598a2c94fff43540a8062369",
+    "darwin-arm64": "529b4b2352690c9d3cfc8436e8b15649bc043eb58e07781d6986c6f0f2577f4e",
+    "win32-x64": "fc97aa41e2a59304afa49e27bb2f22aa8d7b47f39d182a3abd99c5ca33c5ddd2",
+    "win32-x64-baseline": "d280003c00ce1d91b19cbeee3ead6fee516f9aba665c175a8e19553d0a6dfe8c"
   }
 }