free-coding-models 0.5.78 → 0.5.79

package/changelog/v0.5.79.md

@@ -0,0 +1,12 @@
+# Changelog v0.5.79 - 2026-08-23
+
+### Fixed
+- **Fast-coding pool malformed tool_calls hang (fixes #124).** Some providers returned `finish_reason: tool_calls` without a `tool_calls` array, causing pi and other OpenAI clients to wait forever. Router now normalizes such responses to `finish_reason: stop` in `src/core/router-daemon.js` (`normalizeToolCallsResponse`) before forwarding, making the response spec-compliant even when upstream is quirky. Thanks @stgreenb.
+
+- **Docker mandatory update EACCES crash (fixes #109).** Inside Docker the app lives at `/app` and runs as non-root `fcm`, so `npm i -g` always hit EACCES on `/usr/local/lib/node_modules` and showed "Mandatory update failed" then exited. Added `isRunningInDocker()` in `src/core/updater.js` (checks `/.dockerenv` and `/app` prefix) to skip mandatory startup updates in containers; rebuild the image to update. Thanks @karneaud.
+
+### Changed
+- Closed older user feature requests with concise responses: #51 Nix module (PR welcome), #30 oh-my-opencode (wrapper externe, pas de duplication), #27 Claude Code integration (now via router `fcm`). Only vava's own issues (75, 21, 18) remain open.
+
+### Tests
+- 813/813 passing. Router now re-stringifies normalized JSON only when needed.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "free-coding-models",
-  "version": "0.5.78",
+  "version": "0.5.79",
   "description": "Find the fastest coding LLM models in seconds — ping free models from multiple providers, pick the best one for OpenCode, Cursor, or any AI coding assistant.",
   "keywords": [
     "nvidia",

package/src/core/router-daemon.js

@@ -118,6 +118,32 @@ const __dirname = dirname(fileURLToPath(import.meta.url))
 const CLI_ENTRY_PATH = join(__dirname, '..', '..', 'bin', 'free-coding-models.js')
 const LOCAL_VERSION = JSON.parse(readFileSync(join(__dirname, '..', '..', 'package.json'), 'utf8')).version
 const MAX_BODY_BYTES = 10 * 1024 * 1024
+/**
+ * 📖 normalizeToolCallsResponse — fix malformed tool_calls from upstream.
+ * Some providers return finish_reason: "tool_calls" but message has no tool_calls array,
+ * which hangs OpenAI-compatible clients (pi agent waits for tool_calls that never arrives).
+ * Normalize to finish_reason: "stop" when tool_calls is missing/empty per OpenAI spec.
+ * This is defensive: it makes the router spec-compliant regardless of upstream quirks.
+ * @param {object} data - parsed JSON response object
+ * @returns {boolean} true if mutated
+ */
+function normalizeToolCallsResponse(data) {
+  if (!data || typeof data !== 'object' || !Array.isArray(data.choices)) return false
+  let mutated = false
+  for (const choice of data.choices) {
+    if (!choice || typeof choice !== 'object') continue
+    if (choice.finish_reason !== 'tool_calls') continue
+    const msg = choice.message
+    if (!msg || typeof msg !== 'object') continue
+    const tc = msg.tool_calls
+    if (!Array.isArray(tc) || tc.length === 0) {
+      choice.finish_reason = 'stop'
+      mutated = true
+    }
+  }
+  return mutated
+}
+
 const MAX_REQUEST_LOG = 200
 const MAX_SSE_CLIENTS = 10
 const MAX_CONCURRENT_REQUESTS = 50
@@ -2226,13 +2252,20 @@ class RouterRuntime {
           failover: attemptIndex > 0,
         })
         this.logger.info(`Routed to ${key} - ${latencyMs}ms`, { request_id: requestId, status: response.status })
+        // 📖 Fix #124: normalize malformed tool_calls (finish_reason tool_calls without tool_calls array)
+        let responseText = text
+        try {
+          if (normalizeToolCallsResponse(parsed.value)) {
+            responseText = JSON.stringify(parsed.value)
+          }
+        } catch {}
         if (!res.writableEnded) {
           res.writeHead(response.status, {
             ...headerEntries(response.headers),
             'x-fcm-router-model': key,
             'x-request-id': requestId,
           })
-          res.end(text)
+          res.end(responseText)
         }
         return { done: true }
       }

package/src/core/updater.js

@@ -110,6 +110,25 @@ export function isPackageDevMode() {
   return process.env.FCM_DEV === '1' || existsSync(join(PACKAGE_ROOT, '.git'))
 }
 
+/**
+ * 📖 isRunningInDocker: detect Docker/container environment where global npm writes fail.
+ * In Docker the app lives at /app (not /usr/local/lib/node_modules) and runs as non-root `fcm`.
+ * Mandatory updates would always EACCES, so we skip them gracefully.
+ * @returns {boolean}
+ */
+export function isRunningInDocker() {
+  // 📖 Standard Docker marker file, plus explicit env override for testing
+  if (process.env.FCM_DOCKER === '1' || process.env.DOCKER_CONTAINER === '1') return true
+  try {
+    if (existsSync('/.dockerenv')) return true
+  } catch {}
+  // 📖 Fallback: check if package is at /app (Docker COPY) vs global prefix
+  try {
+    if (String(PACKAGE_ROOT) === '/app' || String(PACKAGE_ROOT).startsWith('/app/')) return true
+  } catch {}
+  return false
+}
+
 /**
  * 📖 getUpdateInstallFailureCount: sanitized persistent failure counter.
  * @param {object} config
@@ -265,6 +284,11 @@ export async function enforceMandatoryStartupUpdate(config, options = {}) {
   }
 
   if (devMode) return base
+  if (isRunningInDocker()) {
+    // 📖 In Docker, global npm install as non-root always EACCES. Skip mandatory update
+    // 📖 and let the container run with the baked-in version. User can rebuild image for updates.
+    return base
+  }
 
   const { latestVersion, error } = await checkForUpdateDetailed()
   base.checked = true