fraim 2.0.342 → 2.0.343

package/dist/src/config/persona-hiring.js

@@ -282,7 +282,13 @@ function buildPersonaAvatarUrl(personaKey) {
     return `https://api.dicebear.com/9.x/${avatar.style}/svg?${params.toString()}`;
 }
 function isPersonaHireKey(value) {
-    return value in exports.PERSONA_HIRE_CATALOG;
+    // Own properties only. `in` also answers true for every Object.prototype member,
+    // so 'constructor', 'toString', '__proto__' and friends passed this guard and then
+    // indexed the catalog to a prototype member rather than a persona. The guard is the
+    // input validation in front of the hire-checkout and entitlement reads, where the
+    // value is caller-supplied, and (issue #1925) in front of the employee-record reader,
+    // where it is file-supplied.
+    return Object.prototype.hasOwnProperty.call(exports.PERSONA_HIRE_CATALOG, value);
 }
 function getPersonaHireAmountCents(personaKey, mode) {
     const persona = exports.PERSONA_HIRE_CATALOG[personaKey];

package/dist/src/core/ai-mentor.js

@@ -65,6 +65,9 @@ class AIMentor {
         const unique = Array.from(new Set(matches));
         throw new Error(`Unresolved include directives in ${context}: ${unique.join(', ')}`);
     }
+    buildPhaseArrivalInstruction(jobName, phaseId) {
+        return `## On Arrival\nBefore starting any work in this phase, call \`seekMentoring({ jobName: "${jobName}", issueNumber: "<issue_number>", currentPhase: "${phaseId}", status: "starting" })\`.\n\n`;
+    }
     buildReportBackFooter(jobName, phaseId, phaseFlow) {
         if (!phaseFlow)
             return '';
@@ -140,6 +143,9 @@ class AIMentor {
             targetPhase = isVeryFirstCall ? targetDefinition.setup.phase : targetDefinition.recur.phase;
         }
         let message = `### Current Phase: ${targetPhase}\n\n`;
+        if (isVeryFirstCall) {
+            message += this.buildPhaseArrivalInstruction(workflow.metadata.name, targetPhase);
+        }
         let instructions = workflow.phases.get(targetPhase);
         if (instructions) {
             instructions = skipIncludes ? instructions : await this.resolveIncludes(instructions, workflow.path);
@@ -229,6 +235,7 @@ class AIMentor {
         }
         else if (nextPhaseId) {
             message += `Moving to the next phase: **${nextPhaseId}**.\n\n`;
+            message += this.buildPhaseArrivalInstruction(workflow.metadata.name, nextPhaseId);
             let nextInstructions = workflow.phases.get(nextPhaseId);
             if (nextInstructions) {
                 nextInstructions = skipIncludes ? nextInstructions : await this.resolveIncludes(nextInstructions, workflow.path);
@@ -275,6 +282,13 @@ class AIMentor {
                 ?? (!(0, resolve_phase_edge_1.isRecurrencePhase)(phaseMeta) ? phaseMeta?.onFailure : undefined), (0, resolve_phase_edge_1.resolveDiscriminant)(findings, evidence)) || phaseId)
             : phaseId;
         let message = `### Current Phase: ${targetPhaseId}\n\n`;
+        // Issue #1935: a `failure` commits a completion for the phase being left, so
+        // the phase resolved above is entered with no open instance and needs its own
+        // `status: "starting"` call, for a back-edge and for the self-retry alike.
+        // `incomplete` commits nothing and never leaves the phase, so it gets none.
+        if (status === 'failure') {
+            message += this.buildPhaseArrivalInstruction(workflow.metadata.name, targetPhaseId);
+        }
         let instructions = workflow.phases.get(targetPhaseId);
         if (instructions) {
             instructions = skipIncludes ? instructions : await this.resolveIncludes(instructions, workflow.path);

package/dist/src/core/handoff-contracts.js

@@ -297,11 +297,16 @@ function upsertPhaseStarted(marker, phaseId, timestamp) {
     startedPhases[phaseId] = timestamp;
     return { startedPhases };
 }
-/** Builds the warn-only notice for any phase completed without an on-arrival start. */
-function buildPhaseStartWarning(phaseId) {
-    return (`⚠️ **Phase-start notice**: phase \`${phaseId}\` completed without an on-arrival ` +
+/** Builds the warn-only notice for any phase completed without an on-arrival start.
+ * When nextPhase is supplied, a forward-looking instruction is appended so the agent
+ * knows to call seekMentoring({status:"starting"}) before beginning the next phase. */
+function buildPhaseStartWarning(phaseId, nextPhase) {
+    const base = (`⚠️ **Phase-start notice**: phase \`${phaseId}\` completed without an on-arrival ` +
         `\`seekMentoring({ currentPhase: "${phaseId}", status: "starting" })\` call in this session. ` +
         `The missing call was flagged, but this completion remains accepted.\n\n`);
+    if (!nextPhase)
+        return base;
+    return base + `Before starting any work in **${nextPhase}**, call \`seekMentoring({ currentPhase: "${nextPhase}", status: "starting" })\` immediately.\n\n`;
 }
 function isAbsoluteHttpUrl(url) {
     if (typeof url !== 'string' || !url)

package/dist/src/local-mcp-server/stdio-server.js

@@ -1371,7 +1371,7 @@ class FraimLocalMCPServer {
             updated.phaseInstances = updated.phaseInstances?.filter((instance) => instance.jobId && instance.jobId !== args.jobId);
         }
         this.writeRunStateMarker(sessionId, args.jobName, updated);
-        return (inspection.missingStart ? (0, handoff_contracts_1.buildPhaseStartWarning)(args.currentPhase) : '')
+        return (inspection.missingStart ? (0, handoff_contracts_1.buildPhaseStartWarning)(args.currentPhase, nextPhase ?? undefined) : '')
             + (!args.jobId ? `Run-tracking notice: phase ${args.currentPhase} has no jobId; matching used the session, job name and phase.\n\n` : '');
     }
     readCachedTemplateFile(filename) {

package/dist/src/mcp/tool-schemas.js

@@ -343,7 +343,7 @@ Do not use this tool for other repositories or external project issue trackers.`
                     },
                     currentPhase: {
                         type: 'string',
-                        description: 'The phase you are currently in or have just finished (e.g., "implement-scoping"). For initial workflow start, use "starting".'
+                        description: 'The phase you are currently in or have just finished (e.g., "implement-scoping"). For initial workflow start, pass "starting" as a one-time bootstrap — this is distinct from the per-phase status:"starting" on-arrival call you make at the beginning of every phase.'
                     },
                     status: {
                         type: 'string',

package/dist/src/services/mcp-service.js

@@ -824,7 +824,7 @@ class McpService {
             else if (isPhaseCompletion) {
                 const inspection = (0, handoff_contracts_1.inspectPhaseCompletion)(marker, context);
                 if (inspection.missingStart)
-                    phaseStartWarning = (0, handoff_contracts_1.buildPhaseStartWarning)(args.currentPhase);
+                    phaseStartWarning = (0, handoff_contracts_1.buildPhaseStartWarning)(args.currentPhase, result.nextPhase ?? undefined);
                 const completed = (0, handoff_contracts_1.commitPhaseCompletion)(marker, inspection, { ...context, timestamp });
                 this.phaseStartMarkers.set(markerKey, completed);
                 if (args.status === 'complete' && result.nextPhase === null) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fraim",
-  "version": "2.0.342",
+  "version": "2.0.343",
   "description": "FRAIM core CLI and MCP package.",
   "main": "index.js",
   "bin": {