fraim 2.0.317 → 2.0.319

package/dist/src/cli/commands/first-run.js

@@ -1,4 +1,37 @@
 "use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
 var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
@@ -7,9 +40,6 @@ exports.firstRunCommand = exports.runFirstRun = void 0;
 const commander_1 = require("commander");
 const chalk_1 = __importDefault(require("chalk"));
 const child_process_1 = require("child_process");
-const server_1 = require("../../first-run/server");
-const session_service_1 = require("../../first-run/session-service");
-const ports_1 = require("../../core/utils/ports");
 function openBrowser(url) {
     try {
         if (process.platform === 'win32') {
@@ -33,17 +63,22 @@ function openBrowser(url) {
     }
 }
 const runFirstRun = async (options) => {
+    const [{ FirstRunServer }, { FirstRunSessionService }, { findAvailablePort }] = await Promise.all([
+        Promise.resolve().then(() => __importStar(require('../../first-run/server'))),
+        Promise.resolve().then(() => __importStar(require('../../first-run/session-service'))),
+        Promise.resolve().then(() => __importStar(require('../../core/utils/ports'))),
+    ]);
     // Issue #646: the key is optional. When launched by the no-terminal macOS
     // installer (.pkg), no key is passed — the wizard prompts the user to paste it.
     const key = options.key || process.env.FRAIM_API_KEY || process.env.FRAIM_SETUP_KEY || process.env.FRAIM_INSTALL_KEY || '';
-    const sessionService = new session_service_1.FirstRunSessionService({
+    const sessionService = new FirstRunSessionService({
         key,
         headless: options.headless,
         resume: options.resume,
         projectRoot: options.projectRoot,
     });
-    const server = new server_1.FirstRunServer({ sessionService });
-    const port = await (0, ports_1.findAvailablePort)(43120);
+    const server = new FirstRunServer({ sessionService });
+    const port = await findAvailablePort(43120);
     const url = `http://127.0.0.1:${port}/first-run/`;
     await server.start(port);
     console.log(chalk_1.default.blue('Starting FRAIM first-run...'));

package/dist/src/cli/doctor/checks/mcp-connectivity-checks.js

@@ -52,6 +52,7 @@ const fs_1 = __importDefault(require("fs"));
 const path_1 = __importDefault(require("path"));
 const os_1 = __importDefault(require("os"));
 const child_process_1 = require("child_process");
+const win32_cmd_spawn_1 = require("../../utils/win32-cmd-spawn");
 const axios_1 = __importDefault(require("axios"));
 const toml = __importStar(require("toml"));
 const ide_detector_1 = require("../../setup/ide-detector");
@@ -673,23 +674,9 @@ async function spawnAndHandshake(command, args, timeoutMs = STDIO_HANDSHAKE_TIME
             env: process.env
         };
         if (process.platform === 'win32') {
-            // On Windows, wrap in cmd.exe so .cmd wrappers are resolved.
-            // cmd.exe /d /s /c requires special handling when the command path contains spaces:
-            //   cmd /c ""path with spaces" arg1 arg2"
-            // The outer pair of double-quotes is mandatory when the first token is quoted.
-            // We must also pass windowsVerbatimArguments: true so Node's CreateProcess call
-            // does not re-escape our already-quoted command string.
-            const comSpec = process.env.ComSpec || 'cmd.exe';
-            const quotedTokens = [command, ...args].map((a) => {
-                const v = String(a);
-                return /[\s"&|<>^]/.test(v) ? `"${v.replace(/"/g, '""')}"` : v;
-            });
-            const innerCmd = quotedTokens.join(' ');
-            // Wrap in outer quotes only when the command contains spaces (i.e. was itself quoted).
-            const needsOuterQuote = /[\s"&|<>^]/.test(String(command));
-            const cmdString = needsOuterQuote ? `"${innerCmd}"` : innerCmd;
-            spawnCommand = comSpec;
-            spawnArgs = ['/d', '/s', '/c', cmdString];
+            const built = (0, win32_cmd_spawn_1.buildCmdExeArgs)(command, args.map(String));
+            spawnCommand = built.command;
+            spawnArgs = built.args;
             spawnOptions = { ...spawnOptions, windowsVerbatimArguments: true };
         }
         else {

package/dist/src/cli/mcp/fraim-mcp-latest-launcher.js

@@ -138,6 +138,16 @@ function runtimeFromEnv(env = process.env) {
         ? { executable: env.FRAIM_PACKAGED_CLI_EXECUTABLE, script: env.FRAIM_PACKAGED_CLI_SCRIPT }
         : null;
 }
+// Regular Node.js (and ELECTRON_RUN_AS_NODE) cannot see inside Electron's
+// .asar archives. For paths like …/app.asar/node_modules/…, verify the
+// archive file itself rather than the internal entry.
+function existsOrAsarExists(filePath) {
+    const normalized = filePath.replace(/\\/g, '/');
+    const asarSep = normalized.indexOf('.asar/');
+    if (asarSep === -1)
+        return fs_1.default.existsSync(filePath);
+    return fs_1.default.existsSync(filePath.slice(0, asarSep + '.asar'.length));
+}
 function getPackagedFraimRuntime(env = process.env) {
     const envRuntime = runtimeFromEnv(env);
     if (envRuntime)
@@ -146,7 +156,7 @@ function getPackagedFraimRuntime(env = process.env) {
         const raw = JSON.parse(fs_1.default.readFileSync(getPackagedFraimRuntimePath(), 'utf8'));
         if (!raw.executable || !raw.script)
             return null;
-        if (!fs_1.default.existsSync(raw.executable) || !fs_1.default.existsSync(raw.script))
+        if (!fs_1.default.existsSync(raw.executable) || !existsOrAsarExists(raw.script))
             return null;
         return { executable: raw.executable, script: raw.script };
     }

package/dist/src/cli/utils/win32-cmd-spawn.js

@@ -0,0 +1,38 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.spawnViaCmdExe = spawnViaCmdExe;
+exports.buildCmdExeArgs = buildCmdExeArgs;
+const child_process_1 = require("child_process");
+function quoteCmdToken(s) {
+    return /[\s"&|<>^]/.test(s) ? `"${s.replace(/"/g, '""')}"` : s;
+}
+/**
+ * Spawn a command through cmd.exe on Windows so .cmd shims resolve correctly.
+ * Applies outer-quote wrapping and windowsVerbatimArguments:true so paths
+ * containing spaces are not double-escaped by Node's CreateProcess call.
+ */
+function spawnViaCmdExe(command, args, options) {
+    const comSpec = process.env.ComSpec || 'cmd.exe';
+    const tokens = [command, ...args].map(quoteCmdToken);
+    const innerCmd = tokens.join(' ');
+    const needsOuterQuote = /[\s"&|<>^]/.test(command);
+    const cmdString = needsOuterQuote ? `"${innerCmd}"` : innerCmd;
+    return (0, child_process_1.spawnSync)(comSpec, ['/d', '/s', '/c', cmdString], {
+        ...options,
+        windowsVerbatimArguments: true,
+    });
+}
+/**
+ * Build cmd.exe args for async spawn callers (e.g. mcp-connectivity-checks).
+ * Returns the command, args, and a verbatim flag to set windowsVerbatimArguments: true.
+ */
+function buildCmdExeArgs(command, args) {
+    const tokens = [command, ...args].map(quoteCmdToken);
+    const innerCmd = tokens.join(' ');
+    const needsOuterQuote = /[\s"&|<>^]/.test(command);
+    return {
+        command: process.env.ComSpec || 'cmd.exe',
+        args: ['/d', '/s', '/c', needsOuterQuote ? `"${innerCmd}"` : innerCmd],
+        verbatim: true,
+    };
+}

package/dist/src/config/persona-capability-bundles.js

@@ -72,7 +72,7 @@ exports.PERSONA_CAPABILITY_BUNDLES = {
         personaKey: 'qasm',
         bundleId: 'persona-qasm-core',
         catalogMetadata: buildCatalogMetadata('qasm', ['test-authoring', 'iterative-quality-improvement', 'ui-polish-validation']),
-        protectedJobs: ['test-authoring', 'ui-polish-validation', 'codebase-quality-assessment', 'test-quality-assessment', 'user-testing-and-bug-bash', 'iterative-quality-improvement', 'accessibility-audit', 'api-testing', 'performance-benchmarking'],
+        protectedJobs: ['test-authoring', 'ui-polish-validation', 'codebase-quality-assessment', 'test-quality-assessment', 'user-testing-and-bug-bash', 'iterative-quality-improvement', 'accessibility-audit', 'api-testing', 'stress-test-app-under-load', 'performance-quality-assessment'],
         protectedAliases: ['qa', 'quality-assurance'],
         defaultHireMode: 'job',
         lockCopy: 'Hire QAsm to unlock QA validation for this request.'

package/dist/src/core/ai-mentor.js

@@ -26,7 +26,8 @@ class AIMentor {
             const phases = workflow.metadata.phases || {};
             const hasMetadata = !!phases[args.currentPhase];
             const hasMarkdown = workflow.phases.has(args.currentPhase);
-            if (!hasMetadata && !hasMarkdown && args.currentPhase !== 'starting') {
+            const isRecurrenceMember = !!(0, resolve_phase_edge_1.findRecurrenceForMember)(phases, args.currentPhase);
+            if (!hasMetadata && !hasMarkdown && !isRecurrenceMember && args.currentPhase !== 'starting') {
                 throw new Error(`Phase "${args.currentPhase}" not found in job "${args.jobName}".`);
             }
         }
@@ -133,7 +134,11 @@ class AIMentor {
             };
         }
         const isVeryFirstCall = phaseId === 'starting';
-        const targetPhase = isVeryFirstCall ? (workflow.metadata.initialPhase || 'starting') : phaseId;
+        let targetPhase = isVeryFirstCall ? (workflow.metadata.initialPhase || 'starting') : phaseId;
+        const targetDefinition = workflow.metadata.phases?.[targetPhase];
+        if ((0, resolve_phase_edge_1.isRecurrencePhase)(targetDefinition)) {
+            targetPhase = isVeryFirstCall ? targetDefinition.setup.phase : targetDefinition.recur.phase;
+        }
         let message = `### Current Phase: ${targetPhase}\n\n`;
         let instructions = workflow.phases.get(targetPhase);
         if (instructions) {
@@ -143,7 +148,10 @@ class AIMentor {
         else {
             message += `No specific instructions found for phase: ${targetPhase}`;
         }
-        const phaseFlow = workflow.metadata.phases?.[targetPhase];
+        const recurrenceMember = (0, resolve_phase_edge_1.findRecurrenceForMember)(workflow.metadata.phases, targetPhase);
+        const phaseFlow = recurrenceMember
+            ? { onSuccess: undefined, onFailure: recurrenceMember.node[recurrenceMember.role].onFailure }
+            : ((0, resolve_phase_edge_1.isRecurrencePhase)(workflow.metadata.phases?.[targetPhase]) ? undefined : workflow.metadata.phases?.[targetPhase]);
         message += this.buildReportBackFooter(workflow.metadata.name, targetPhase, phaseFlow);
         if (!skipIncludes) {
             this.assertNoUnresolvedIncludes(message, `${workflow.metadata.name}:${targetPhase} (starting)`);
@@ -165,13 +173,43 @@ class AIMentor {
                 status: 'complete'
             };
         }
-        const phaseFlow = workflow.metadata.phases?.[phaseId];
+        const phases = workflow.metadata.phases;
+        const phaseFlow = phases?.[phaseId];
+        const recurrenceMember = (0, resolve_phase_edge_1.findRecurrenceForMember)(phases, phaseId);
         let nextPhaseId = null;
-        if (phaseFlow && phaseFlow.onSuccess) {
+        if (recurrenceMember?.role === 'setup') {
+            nextPhaseId = resolve_phase_edge_1.WAITING_FOR_NEXT_INVOCATION;
+        }
+        else if (recurrenceMember?.role === 'recur') {
+            const selectedAction = evidence?.selectedReviewAction;
+            if (!selectedAction) {
+                nextPhaseId = evidence?.reviewHandoff?.reviewRequired === true
+                    ? resolve_phase_edge_1.AWAITING_RECURRING_REVIEW
+                    : recurrenceMember.node.recur.phase;
+            }
+            else if (selectedAction.kind === 'request_changes') {
+                nextPhaseId = recurrenceMember.node.recur.phase;
+            }
+            else if (selectedAction.kind === 'approve') {
+                const finalInvocation = (0, resolve_phase_edge_1.resolveDiscriminant)(findings, evidence) === 'final-invocation';
+                nextPhaseId = finalInvocation
+                    ? (evidence?.assignmentInactive === true
+                        ? recurrenceMember.node.done.phase
+                        : recurrenceMember.node.recur.phase)
+                    : resolve_phase_edge_1.WAITING_FOR_NEXT_INVOCATION;
+            }
+            else {
+                nextPhaseId = recurrenceMember.node.recur.phase;
+            }
+        }
+        else if (phaseFlow && !(0, resolve_phase_edge_1.isRecurrencePhase)(phaseFlow) && phaseFlow.onSuccess) {
             // Issue #1123: resolved through the shared authority so the success and
             // failure paths cannot read the discriminant differently.
             nextPhaseId = (0, resolve_phase_edge_1.resolvePhaseEdge)(phaseFlow.onSuccess, (0, resolve_phase_edge_1.resolveDiscriminant)(findings, evidence));
         }
+        const nextDefinition = nextPhaseId ? phases?.[nextPhaseId] : undefined;
+        if ((0, resolve_phase_edge_1.isRecurrencePhase)(nextDefinition))
+            nextPhaseId = nextDefinition.setup.phase;
         let message = '';
         if (nextPhaseId === resolve_phase_edge_1.WAITING_FOR_NEXT_INVOCATION) {
             message += [
@@ -182,6 +220,13 @@ class AIMentor {
                 '<!-- FRAIM_RECURRING_PARK -->',
             ].join('\n');
         }
+        else if (nextPhaseId === resolve_phase_edge_1.AWAITING_RECURRING_REVIEW) {
+            message += [
+                '### Recurring Result Awaiting Review',
+                '',
+                'The current recurring result is waiting for manager review. Do not park or advance until an explicit review action is selected.',
+            ].join('\n');
+        }
         else if (nextPhaseId) {
             message += `Moving to the next phase: **${nextPhaseId}**.\n\n`;
             let nextInstructions = workflow.phases.get(nextPhaseId);
@@ -189,7 +234,10 @@ class AIMentor {
                 nextInstructions = skipIncludes ? nextInstructions : await this.resolveIncludes(nextInstructions, workflow.path);
                 message += nextInstructions;
             }
-            const nextPhaseFlow = workflow.metadata.phases?.[nextPhaseId];
+            const nextRecurrenceMember = (0, resolve_phase_edge_1.findRecurrenceForMember)(phases, nextPhaseId);
+            const nextPhaseFlow = nextRecurrenceMember
+                ? { onSuccess: undefined, onFailure: nextRecurrenceMember.node[nextRecurrenceMember.role].onFailure }
+                : ((0, resolve_phase_edge_1.isRecurrencePhase)(workflow.metadata.phases?.[nextPhaseId]) ? undefined : workflow.metadata.phases?.[nextPhaseId]);
             message += this.buildReportBackFooter(workflow.metadata.name, nextPhaseId, nextPhaseFlow);
         }
         else {
@@ -216,13 +264,15 @@ class AIMentor {
             };
         }
         const phaseMeta = workflow.metadata.phases?.[phaseId];
+        const recurrenceMember = (0, resolve_phase_edge_1.findRecurrenceForMember)(workflow.metadata.phases, phaseId);
         // Issue #1123: the failure edge may be a discriminant map. Resolving to
         // null (terminal, malformed, or a map with no `default` and no match)
         // falls back to self-retry, which is what the previous `|| phaseId` did
         // for an absent edge. The old expression could not do this: an object is
         // truthy, so it was returned as the target and `phases.get()` then missed.
         const targetPhaseId = status === 'failure'
-            ? ((0, resolve_phase_edge_1.resolvePhaseEdge)(phaseMeta?.onFailure, (0, resolve_phase_edge_1.resolveDiscriminant)(findings, evidence)) || phaseId)
+            ? ((0, resolve_phase_edge_1.resolvePhaseEdge)(recurrenceMember?.node[recurrenceMember.role].onFailure
+                ?? (!(0, resolve_phase_edge_1.isRecurrencePhase)(phaseMeta) ? phaseMeta?.onFailure : undefined), (0, resolve_phase_edge_1.resolveDiscriminant)(findings, evidence)) || phaseId)
             : phaseId;
         let message = `### Current Phase: ${targetPhaseId}\n\n`;
         let instructions = workflow.phases.get(targetPhaseId);

package/dist/src/core/job-phases.js

@@ -129,6 +129,10 @@ function loadJobPhases(jobId, projectPath, discriminant = 'feature') {
         const phaseDef = fm.phases[cursor];
         if (!phaseDef)
             break;
+        if ((0, resolve_phase_edge_1.isRecurrencePhase)(phaseDef)) {
+            ordered.splice(ordered.length - 1, 1, phaseDef.setup.phase, phaseDef.recur.phase, phaseDef.done.phase);
+            break;
+        }
         cursor = (0, resolve_phase_edge_1.resolvePhaseEdge)(phaseDef.onSuccess, discriminant);
     }
     const labels = fm.phaseLabels || {};
@@ -143,7 +147,18 @@ function loadAllJobPhaseIds(jobId, projectPath) {
         const phases = loadJobPhasesFromSteps(stubPath);
         return new Set(phases.map((p) => p.id));
     }
-    return new Set(Object.keys(fm.phases));
+    const ids = new Set();
+    for (const [phaseId, phase] of Object.entries(fm.phases)) {
+        if ((0, resolve_phase_edge_1.isRecurrencePhase)(phase)) {
+            ids.add(phase.setup.phase);
+            ids.add(phase.recur.phase);
+            ids.add(phase.done.phase);
+        }
+        else {
+            ids.add(phaseId);
+        }
+    }
+    return ids;
 }
 function labelForPhaseId(phaseId, jobId, projectPath) {
     const stubPath = findJobStubPath(projectPath, jobId);

package/dist/src/core/quality-evidence.js

@@ -43,6 +43,8 @@ exports.QUALITY_REGISTRY = {
     'ui-quality-assessment': { stage: 'ui-ux-quality', enforced: true, telemetryKind: 'score' },
     // Test Quality
     'test-quality-assessment': { stage: 'test-quality', enforced: true, telemetryKind: 'score' },
+    // Performance Quality
+    'performance-quality-assessment': { stage: 'performance-quality', enforced: true, telemetryKind: 'score' },
     // Security
     'security-review': { stage: 'security', enforced: true, telemetryKind: 'score' },
     'production-readiness-review': { stage: 'production-readiness', enforced: true, telemetryKind: 'score' },
@@ -80,6 +82,7 @@ exports.STAGE_DISPLAY_NAMES = {
     'product-quality': 'Product Quality',
     'ui-ux-quality': 'UI/UX Quality',
     'test-quality': 'Test Quality',
+    'performance-quality': 'Performance Quality',
     'security': 'Security',
     'production-readiness': 'Production Readiness',
     'fundraising': 'Fundraising',
@@ -95,6 +98,7 @@ exports.ALL_STAGE_CATEGORIES = [
     'product-quality',
     'ui-ux-quality',
     'test-quality',
+    'performance-quality',
     'security',
     'production-readiness',
     'fundraising',
@@ -169,6 +173,12 @@ const QUALITY_SCORE_DIMENSIONS = {
         'testDesign',
         'reliability'
     ],
+    'performance-quality-assessment': [
+        'memoryEfficiency',
+        'cpuEfficiency',
+        'diskIO',
+        'startupCost'
+    ],
     'security-review': [
         'findingSeverity',
         'remediationReadiness',

package/dist/src/core/resolve-phase-edge.js

@@ -15,15 +15,33 @@
  * change inert for every job that authors no map.
  */
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.FEEDBACK_PHASE_ID = exports.WAITING_FOR_NEXT_INVOCATION = void 0;
+exports.FEEDBACK_PHASE_ID = exports.AWAITING_RECURRING_REVIEW = exports.WAITING_FOR_NEXT_INVOCATION = void 0;
+exports.isRecurrencePhase = isRecurrencePhase;
+exports.findRecurrenceForMember = findRecurrenceForMember;
 exports.resolvePhaseEdge = resolvePhaseEdge;
 exports.resolveDiscriminant = resolveDiscriminant;
 exports.discriminantKeys = discriminantKeys;
 exports.derivePredecessorPhase = derivePredecessorPhase;
+function isRecurrencePhase(phase) {
+    return !!phase && 'type' in phase && phase.type === 'recurrence';
+}
+function findRecurrenceForMember(phases, phaseId) {
+    for (const [nodeId, phase] of Object.entries(phases ?? {})) {
+        if (!isRecurrencePhase(phase))
+            continue;
+        for (const role of ['setup', 'recur', 'done']) {
+            if (phase[role].phase === phaseId)
+                return { nodeId, node: phase, role };
+        }
+    }
+    return null;
+}
 /** The default discriminant, and the mandatory key on every authored map. */
 const DEFAULT_DISCRIMINANT = 'default';
 /** Reserved transition target that parks a recurring job until the scheduler invokes it again. */
 exports.WAITING_FOR_NEXT_INVOCATION = 'waiting-for-next-invocation';
+/** Reserved controller target while a recurring result awaits manager review. */
+exports.AWAITING_RECURRING_REVIEW = 'awaiting-recurring-review';
 /**
  * Resolve an edge to the next phase id.
  *
@@ -97,7 +115,7 @@ exports.FEEDBACK_PHASE_ID = 'address-feedback';
 function derivePredecessorPhase(phases, targetPhaseId) {
     const predecessors = [];
     for (const [phaseId, edges] of Object.entries(phases ?? {})) {
-        if (phaseId === targetPhaseId || !edges)
+        if (phaseId === targetPhaseId || !edges || isRecurrencePhase(edges))
             continue;
         const edge = edges.onSuccess;
         const targets = typeof edge === 'string'

package/dist/src/first-run/session-service.js

@@ -135,13 +135,19 @@ function persistShellPath(includePackagedFraimBin = false) {
         // Versioned dir first (has fresh installs, matches getManagedAgentBinDirs()
         // order), flat dir second (retains bare POSIX agent scripts as fallback).
         exportLine = portableNodeBin !== nodeRoot
-            ? `export PATH=”$PATH:$HOME/.fraim/node/${path_1.default.basename(portableNodeBin)}:$HOME/.fraim/node${fraimBinEntry}”`
-            : `export PATH=”$PATH:$HOME/.fraim/node${fraimBinEntry}”`;
+            ? `export PATH="$PATH:$HOME/.fraim/node/${path_1.default.basename(portableNodeBin)}:$HOME/.fraim/node${fraimBinEntry}"`
+            : `export PATH="$PATH:$HOME/.fraim/node${fraimBinEntry}"`;
     }
     else {
         exportLine = includePackagedFraimBin
-            ? 'export PATH=”$PATH:$HOME/.fraim/bin:$HOME/.fraim/node/bin”'
-            : 'export PATH=”$PATH:$HOME/.fraim/node/bin”';
+            ? 'export PATH="$PATH:$HOME/.fraim/bin:$HOME/.fraim/node/bin"'
+            : 'export PATH="$PATH:$HOME/.fraim/node/bin"';
+    }
+    // Guard against editor-autocorrect curly-quote regression (issue #1688):
+    // U+201C/201D/2018/2019 in exportLine would be written verbatim to shell
+    // profiles and break PATH resolution for all pre-existing PATH entries.
+    if (/[“”‘’]/.test(exportLine)) {
+        throw new Error(`persistShellPath: exportLine contains curly quotes. Writing this to a shell profile would corrupt PATH resolution. Check for editor autocorrect in session-service.ts. Line: ${JSON.stringify(exportLine)}`);
     }
     const stanza = `\n${marker}\n${exportLine}\n`;
     if (process.platform === 'win32') {
@@ -149,7 +155,16 @@ function persistShellPath(includePackagedFraimBin = false) {
             ? [path_1.default.join((0, script_sync_utils_1.getUserFraimDir)(), 'bin'), ...(0, managed_agent_paths_1.getManagedAgentBinDirs)()]
             : (0, managed_agent_paths_1.getManagedAgentBinDirs)();
         const psCmd = buildPersistShellPathWindowsCommand(bins);
-        (0, child_process_1.spawnSync)('powershell', ['-NoProfile', '-NonInteractive', '-Command', psCmd], { encoding: 'utf8' });
+        // Issue #1692: a sandboxed test run (row detection on load, node row
+        // success, fraim row success all reach this function) must never write
+        // its temp fake-home bin dirs into the real, registry-backed Windows
+        // User PATH. FRAIM_TEST_SANDBOX is already the canonical "this process
+        // is a sandboxed test run" signal set by every test runner (see
+        // getUserFraimDirPath() in project-fraim-paths.ts) rather than a
+        // dedicated flag for this call site.
+        if (process.env.FRAIM_TEST_SANDBOX !== '1') {
+            (0, child_process_1.spawnSync)('powershell', ['-NoProfile', '-NonInteractive', '-Command', psCmd], { encoding: 'utf8' });
+        }
         // Fall through to write POSIX profile files for Git Bash (VS Code
         // integrated terminal, Claude Code, etc.) which do not inherit the
         // Windows user PATH written above.
@@ -190,7 +205,7 @@ function persistShellPath(includePackagedFraimBin = false) {
                 if (!content.includes(exportLine)) {
                     // Stale export line: versioned dir changed, includePackagedFraimBin
                     // toggled, or platform-specific line was never written. Replace it.
-                    fs_1.default.writeFileSync(profile, content.replace(/export PATH=”[^”]*\.fraim[^”]*”/, exportLine), 'utf8');
+                    fs_1.default.writeFileSync(profile, content.replace(/export PATH=[\u201D"][^\u201D"]*\.fraim[^\u201D"]*[\u201D"]/, exportLine), 'utf8');
                 }
                 continue;
             }

package/dist/src/local-mcp-server/learning-context-builder.js

@@ -545,11 +545,14 @@ function collectPendingL0SourceFiles(workspaceRoot, resolvedUserId, roots) {
  * it cannot drift from the read path again.
  */
 function orgCacheDisplayPath(fileName) {
-    const fraimDir = (0, project_fraim_paths_1.getUserFraimDirPath)();
     const cachePath = (0, path_1.join)((0, pack_home_1.resolvePackHome)('org').contentRoot, 'learnings', fileName);
-    const rel = cachePath.startsWith(fraimDir)
-        ? cachePath.slice(fraimDir.length).replace(/\\/g, '/').replace(/^\//, '')
-        : cachePath.replace(/\\/g, '/');
+    return userFraimDisplayPathFor(cachePath);
+}
+function userFraimDisplayPathFor(absolutePath) {
+    const fraimDir = (0, project_fraim_paths_1.getUserFraimDirPath)();
+    const rel = absolutePath.startsWith(fraimDir)
+        ? absolutePath.slice(fraimDir.length).replace(/\\/g, '/').replace(/^\//, '')
+        : absolutePath.replace(/\\/g, '/');
     return (0, project_fraim_paths_1.getUserFraimDisplayPath)(rel);
 }
 /**
@@ -944,7 +947,7 @@ function resolveOrgContextFile(workspaceRoot, relativePath, orgCacheEligible = t
             if ((0, fs_1.existsSync)(cachePath)) {
                 return {
                     present: true,
-                    displayPath: (0, project_fraim_paths_1.getUserFraimDisplayPath)(`org/${relativePath}`)
+                    displayPath: userFraimDisplayPathFor(cachePath)
                 };
             }
         }

package/dist/src/local-mcp-server/learning-usage-attestation.js

@@ -46,13 +46,37 @@ function buildEntryIndex(workspaceRoot, userId) {
             continue;
         }
         for (const entry of entries) {
+            const fileType = fileTypeOf(entry);
+            const attestable = {
+                key: entry.id ?? (0, learning_usage_store_1.titleUsageKey)(fileType, entry.title),
+                family: 'learning',
+                title: entry.title,
+                fileType,
+                level: entry.level,
+            };
             if (entry.id && !byId.has(entry.id))
-                byId.set(entry.id, entry);
-            const key = (0, learning_usage_store_1.normalizeEntryTitle)(entry.title);
-            if (!byTitle.has(key))
-                byTitle.set(key, entry);
+                byId.set(entry.id, attestable);
+            const titleKey = (0, learning_usage_store_1.normalizeEntryTitle)(entry.title);
+            if (!byTitle.has(titleKey))
+                byTitle.set(titleKey, attestable);
         }
     }
+    for (const rule of (0, learning_context_builder_1.collectOfferedRuleFiles)(workspaceRoot, true)) {
+        const attestable = {
+            key: rule.key,
+            family: 'rule',
+            title: rule.title,
+            fileType: rule.fileType,
+            level: rule.level,
+        };
+        if (!byId.has(rule.key))
+            byId.set(rule.key, attestable);
+        const titleKey = (0, learning_usage_store_1.normalizeEntryTitle)(rule.title);
+        if (!byTitle.has(titleKey))
+            byTitle.set(titleKey, attestable);
+        if (rule.id && !byId.has(rule.id))
+            byId.set(rule.id, attestable);
+    }
     return { byId, byTitle };
 }
 function fileTypeOf(entry) {
@@ -99,12 +123,11 @@ function recordAttestationsFromRetrospective(workspaceRoot, userId, options) {
                 continue;
             }
         }
-        const fileType = fileTypeOf(entry);
         inputs.push({
-            key: entry.id ?? (0, learning_usage_store_1.titleUsageKey)(fileType, entry.title),
-            family: 'learning',
+            key: entry.key,
+            family: entry.family,
             title: entry.title,
-            fileType,
+            fileType: entry.fileType,
             level: entry.level,
             outcome: item.outcome,
             note: item.note,

package/dist/src/mcp/tool-schemas.js

@@ -347,7 +347,7 @@ Do not use this tool for other repositories or external project issue trackers.`
                     },
                     status: {
                         type: 'string',
-                        description: 'Status of your work in the current phase',
+                        description: 'Status of your work in the current phase.',
                         enum: ['starting', 'complete', 'incomplete', 'failure']
                     },
                     findings: {

package/dist/src/services/demo-seed-service.js

@@ -106,6 +106,7 @@ async function seedDemoDataForUser(dbService, userId) {
         { category: 'product-quality', jobName: 'codebase-quality-assessment' },
         { category: 'ui-ux-quality', jobName: 'ui-quality-assessment' },
         { category: 'test-quality', jobName: 'test-quality-assessment' },
+        { category: 'performance-quality', jobName: 'performance-quality-assessment' },
         { category: 'security', jobName: 'security-review' },
         { category: 'production-readiness', jobName: 'production-readiness-review' },
         { category: 'fundraising', jobName: 'fundraising-evidence-review' },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fraim",
-  "version": "2.0.317",
+  "version": "2.0.319",
   "description": "FRAIM core CLI and MCP package.",
   "main": "index.js",
   "bin": {