fraim 2.0.298 → 2.0.299

package/dist/src/cli/utils/user-config.js

@@ -4,6 +4,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getLayerBackend = getLayerBackend;
+exports.isLayerMisconfigured = isLayerMisconfigured;
 exports.setLayerBackend = setLayerBackend;
 exports.readUserFraimConfig = readUserFraimConfig;
 exports.writeUserFraimConfig = writeUserFraimConfig;
@@ -29,6 +30,25 @@ function getLayerBackend(layer) {
         return getManagerStorageConfig();
     return null;
 }
+/**
+ * Returns true when the layer has a config entry whose backend is recognized
+ * but the required pointer field is missing (git with no gitUrl, local-folder
+ * with no localPath). Callers use this to distinguish "not configured" from
+ * "misconfigured" so the UI can surface a warning instead of silently falling
+ * back to single-machine. (issue #1465, R3)
+ */
+function isLayerMisconfigured(layer) {
+    const raw = layer === 'org'
+        ? readUserFraimConfig().organization
+        : readUserFraimConfig().managerStorage;
+    if (!raw || typeof raw !== 'object')
+        return false;
+    if (raw.backend === 'git' && !raw.gitUrl)
+        return true;
+    if (raw.backend === 'local-folder' && !raw.localPath)
+        return true;
+    return false;
+}
 /** Write the backend config for a named layer (issue #834). */
 function setLayerBackend(layer, config) {
     if (layer === 'org') {

package/dist/src/config/persona-capability-bundles.js

@@ -113,11 +113,20 @@ exports.PERSONA_CAPABILITY_BUNDLES = {
         defaultHireMode: 'job',
         lockCopy: 'Hire SEChar to unlock security setup, review, and findings-command work for this request.'
     },
+    travis: {
+        personaKey: 'travis',
+        bundleId: 'persona-travis-core',
+        catalogMetadata: buildCatalogMetadata('travis', ['travel-planning', 'travel-disruption-rebooking', 'travel-fare-watch']),
+        protectedJobs: ['travel-planning', 'travel-disruption-rebooking', 'travel-fare-watch'],
+        protectedAliases: ['travel-agent', 'travel', 'trip-planning', 'rebooking', 'fare-watch', 'flight-watch'],
+        defaultHireMode: 'job',
+        lockCopy: 'Hire TRAVis to unlock trip planning, fare watching, travel disruption handling, and rebooking support for this request.'
+    },
     ashley: {
         personaKey: 'ashley',
         bundleId: 'persona-ashley-core',
         catalogMetadata: buildCatalogMetadata('ashley', ['chief-of-staff-briefing', 'executive-assistant', 'analyze-transcript']),
-        protectedJobs: ['chief-of-staff-briefing', 'calendar-triage', 'meeting-preparation', 'executive-assistant', 'analyze-transcript', 'travel-planning', 'travel-disruption-rebooking'],
+        protectedJobs: ['chief-of-staff-briefing', 'calendar-triage', 'meeting-preparation', 'executive-assistant', 'analyze-transcript'],
         protectedAliases: ['executive-assistant', 'operations-assistant'],
         defaultHireMode: 'job',
         lockCopy: 'Hire AshLey to unlock executive-assistant work for this request.'

package/dist/src/config/persona-hiring.js

@@ -199,6 +199,15 @@ exports.PERSONA_HIRE_CATALOG = {
         jobPriceCents: 890,
         fulltimePriceCents: 4990,
     },
+    travis: {
+        displayName: 'TRAVis',
+        role: 'Travel Agent',
+        emoji: '\u{1F9ED}',
+        gradient: 'linear-gradient(135deg, #0f766e 0%, #0ea5e9 100%)',
+        blurb: 'Plans trips, watches fares, handles travel disruptions, and helps with rebooking options while keeping provider limits and booking boundaries clear.',
+        jobPriceCents: 890,
+        fulltimePriceCents: 4990,
+    },
     ashley: {
         displayName: 'AshLey',
         role: 'Executive Assistant',
@@ -251,6 +260,7 @@ exports.PERSONA_AVATAR_CATALOG = {
     ricardo: { seed: 'RICARDO-recruiter', bg: 'ede9fe', style: 'notionists' },
     hari: { seed: 'HARI-hr', bg: 'ccfbf1', style: 'notionists' },
     careena: { seed: 'CAREENA-career-coach', bg: 'e0f2fe', style: 'notionists' },
+    travis: { seed: 'TRAVIS-travel-agent', bg: 'ccfbf1', style: 'notionists' },
     sade: { seed: 'SADE-salesforce', bg: 'bae6fd', style: 'notionists' },
     sam: { seed: 'SAM-sales-account', bg: 'd1fae5', style: 'notionists' },
     casey: { seed: 'CASEY-cx', bg: 'a5f3fc', style: 'notionists' },

package/dist/src/core/ai-mentor.js

@@ -83,7 +83,7 @@ class AIMentor {
         const validOutcomes = (0, resolve_phase_edge_1.discriminantKeys)(onSuccess)
             .map((key) => `"${key}"`)
             .join(' | ');
-        return `\n\n---\n\n## Report Back\nWhen this phase is done, call \`seekMentoring({ jobName: "${jobName}", issueNumber: "<issue_number>", currentPhase: "${phaseId}", status: "complete", findings: { issueType: "<outcome>" } })\` with one of: ${validOutcomes}.${failureNote}`;
+        return `\n\n---\n\n## Report Back\nWhen this phase is done, call \`seekMentoring({ jobName: "${jobName}", issueNumber: "<issue_number>", currentPhase: "${phaseId}", status: "complete", findings: { phaseOutcome: "<outcome>" } })\` with one of: ${validOutcomes}.${failureNote}`;
     }
     /** Phase-authority content injected for all phased workflows. Loaded from orchestration/phase-authority.md. */
     async getPhaseAuthorityContent() {
@@ -173,7 +173,14 @@ class AIMentor {
             nextPhaseId = (0, resolve_phase_edge_1.resolvePhaseEdge)(phaseFlow.onSuccess, (0, resolve_phase_edge_1.resolveDiscriminant)(findings, evidence));
         }
         let message = '';
-        if (nextPhaseId) {
+        if (nextPhaseId === resolve_phase_edge_1.WAITING_FOR_NEXT_INVOCATION) {
+            message += [
+                '### Waiting For Next Invocation',
+                '',
+                'Send a concise status update that this recurring assignment is waiting for its next scheduled check, then stop.'
+            ].join('\n');
+        }
+        else if (nextPhaseId) {
             message += `Moving to the next phase: **${nextPhaseId}**.\n\n`;
             let nextInstructions = workflow.phases.get(nextPhaseId);
             if (nextInstructions) {

package/dist/src/core/handoff-contracts.js

@@ -96,6 +96,42 @@ function validateAddressFeedbackApproval(evidence) {
     }
     return null;
 }
+function isAbsoluteHttpUrl(url) {
+    if (typeof url !== 'string' || !url)
+        return false;
+    try {
+        const parsed = new URL(url);
+        return parsed.protocol === 'http:' || parsed.protocol === 'https:';
+    }
+    catch {
+        return false;
+    }
+}
+function validateReviewArtifactEntry(artifact, index) {
+    const errors = [];
+    const label = `evidence.reviewHandoff.artifacts[${index}]`;
+    if (!artifact || typeof artifact !== 'object' || Array.isArray(artifact)) {
+        errors.push(`${label} must be an object`);
+        return errors;
+    }
+    const entry = artifact;
+    if ('kind' in entry && !('type' in entry)) {
+        errors.push(`${label} uses kind but must use type — use type, not kind for artifact type (e.g. "markdown", "docx", "source_file")`);
+    }
+    else if (!entry.type || typeof entry.type !== 'string' || !entry.type.trim()) {
+        errors.push(`${label}.type must be a non-empty string (e.g. "markdown", "docx", "source_file")`);
+    }
+    if (!entry.label || typeof entry.label !== 'string' || !entry.label.trim()) {
+        errors.push(`${label}.label must be a non-empty string`);
+    }
+    if ('url' in entry) {
+        errors.push(`${label} must not include url — artifact_set artifacts are local files; use path`);
+    }
+    if (!entry.path || typeof entry.path !== 'string' || !entry.path.trim()) {
+        errors.push(`${label}.path must be a non-empty local path`);
+    }
+    return errors;
+}
 /**
  * Validates evidence.reviewHandoff. Returns null if valid, or an array of
  * human-readable error strings describing what is wrong.
@@ -103,9 +139,16 @@ function validateAddressFeedbackApproval(evidence) {
  * Required minimum shape:
  * {
  *   reviewRequired: boolean,
- *   reviewTarget: object | null,
  *   artifacts: array,
+ *   // when reviewRequired is true:
+ *   reviewTarget: { type: "pull_request", label: string, url: string } | { type: "artifact_set", label: string },
+ *   reviewActions: [{ kind: "approve", ... }, { kind: "request_changes", ... }],
  * }
+ *
+ * Hub normalizers (server.ts + script.js) both read reviewTarget.type, not .kind.
+ * Using reviewTarget.kind produces a payload that passes validation but is silently
+ * un-renderable. This validator enforces the renderable contract so malformed payloads
+ * are rejected before phase advancement.
  */
 function validateReviewHandoff(value) {
     if (value === undefined || value === null) {
@@ -119,7 +162,42 @@ function validateReviewHandoff(value) {
     if (typeof obj.reviewRequired !== 'boolean') {
         errors.push(`evidence.reviewHandoff.reviewRequired must be a boolean (got ${obj.reviewRequired === undefined ? 'missing' : typeof obj.reviewRequired})`);
     }
+    // artifacts must always be present and be an array
+    if (!('artifacts' in obj) || !Array.isArray(obj.artifacts)) {
+        errors.push('evidence.reviewHandoff.artifacts must be an array');
+    }
     if (obj.reviewRequired === true) {
+        const target = obj.reviewTarget;
+        if (target === undefined || target === null) {
+            errors.push('evidence.reviewHandoff.reviewTarget must be a non-null object with type equal to "pull_request" or "artifact_set" when reviewRequired is true');
+        }
+        else if (typeof target !== 'object' || Array.isArray(target)) {
+            errors.push('evidence.reviewHandoff.reviewTarget must be an object with type equal to "pull_request" or "artifact_set"');
+        }
+        else {
+            const t = target;
+            if ('kind' in t && !('type' in t)) {
+                errors.push(`evidence.reviewHandoff.reviewTarget uses kind but must use type — use type, not kind (e.g. { type: "pull_request", label: "...", url: "https://..." })`);
+            }
+            else if (t.type !== 'pull_request' && t.type !== 'artifact_set') {
+                errors.push(`evidence.reviewHandoff.reviewTarget.type must be "pull_request" or "artifact_set" (got ${t.type === undefined ? 'missing' : JSON.stringify(t.type)})`);
+            }
+            else if (t.type === 'pull_request') {
+                if (!isAbsoluteHttpUrl(t.url)) {
+                    errors.push(`evidence.reviewHandoff.reviewTarget.url must be an absolute http or https URL for a pull_request target (got ${t.url === undefined ? 'missing' : JSON.stringify(t.url)})`);
+                }
+                if (Array.isArray(obj.artifacts) && obj.artifacts.length > 0) {
+                    errors.push('evidence.reviewHandoff.artifacts must be empty for a pull_request target — the PR is the complete review surface; set artifacts: []');
+                }
+            }
+            else if (t.type === 'artifact_set') {
+                if (Array.isArray(obj.artifacts)) {
+                    obj.artifacts.forEach((art, i) => {
+                        errors.push(...validateReviewArtifactEntry(art, i));
+                    });
+                }
+            }
+        }
         if (!Array.isArray(obj.reviewActions) || obj.reviewActions.length === 0) {
             errors.push('evidence.reviewHandoff.reviewActions must be a non-empty array when reviewRequired is true');
         }
@@ -135,6 +213,12 @@ function validateReviewHandoff(value) {
             }
         }
     }
+    else if (obj.reviewRequired === false && Array.isArray(obj.artifacts)) {
+        // For reviewRequired:false, validate any supplied artifact entries (no approval semantics required)
+        obj.artifacts.forEach((art, i) => {
+            errors.push(...validateReviewArtifactEntry(art, i));
+        });
+    }
     return errors.length > 0 ? errors : null;
 }
 /**
@@ -303,8 +387,12 @@ const REVIEW_HANDOFF_SCHEMA = `\`\`\`javascript
 evidence: {
   reviewHandoff: {
     reviewRequired: true,
-    reviewTarget: { kind: "pull_request", url: "<PR URL>" } | { kind: "artifact_set", files: ["<path>"] } | null,
-    artifacts: [{ label: "<label>", path: "<path>", kind: "<kind>" }],
+    // Pull request review (PR is the complete review surface -- set artifacts: []):
+    reviewTarget: { type: "pull_request", label: "Pull request", url: "https://github.com/org/repo/pull/N" },
+    artifacts: [],
+    // -- OR -- artifact set review (local generated files):
+    // reviewTarget: { type: "artifact_set", label: "Review bundle" },
+    // artifacts: [{ type: "markdown", label: "<label>", path: "<local-path>" }],
     summary: "<optional summary>",
     reviewActions: [
       { kind: "approve", label: "Approve" },
@@ -312,7 +400,8 @@ evidence: {
     ]
   }
 }
-\`\`\``;
+\`\`\`
+Note: reviewTarget uses "type" (not "kind"). Action entries use "kind" -- these are different fields.`;
 const NEXT_JOB_RECOMMENDATIONS_SCHEMA = `\`\`\`javascript
 evidence: {
   nextJobRecommendations: [

package/dist/src/core/resolve-phase-edge.js

@@ -15,13 +15,15 @@
  * change inert for every job that authors no map.
  */
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.FEEDBACK_PHASE_ID = void 0;
+exports.FEEDBACK_PHASE_ID = exports.WAITING_FOR_NEXT_INVOCATION = void 0;
 exports.resolvePhaseEdge = resolvePhaseEdge;
 exports.resolveDiscriminant = resolveDiscriminant;
 exports.discriminantKeys = discriminantKeys;
 exports.derivePredecessorPhase = derivePredecessorPhase;
 /** The default discriminant, and the mandatory key on every authored map. */
 const DEFAULT_DISCRIMINANT = 'default';
+/** Reserved transition target that parks a recurring job until the scheduler invokes it again. */
+exports.WAITING_FOR_NEXT_INVOCATION = 'waiting-for-next-invocation';
 /**
  * Resolve an edge to the next phase id.
  *

package/dist/src/local-mcp-server/learning-context-builder.js

@@ -1131,11 +1131,15 @@ function resolveTeamContextFile(workspaceRoot, key) {
     if (key === 'org' || key === 'orgRules') {
         const cachePath = (0, path_1.join)((0, pack_home_1.resolvePackHome)('org').contentRoot, relativePath);
         if ((0, fs_1.existsSync)(cachePath)) {
+            const fraimDir = (0, project_fraim_paths_1.getUserFraimDirPath)();
+            const orgDisplayPath = cachePath.startsWith(fraimDir)
+                ? (0, project_fraim_paths_1.getUserFraimDisplayPath)(cachePath.slice(fraimDir.length).replace(/\\/g, '/').replace(/^\//, ''))
+                : cachePath.replace(/\\/g, '/');
             return {
                 present: true,
                 readPath: cachePath,
                 writePath: '',
-                displayPath: (0, project_fraim_paths_1.getUserFraimDisplayPath)(`org/${relativePath}`),
+                displayPath: orgDisplayPath,
                 scope,
                 managedByOrgSync: true
             };
@@ -1146,16 +1150,16 @@ function resolveTeamContextFile(workspaceRoot, key) {
         const managerCachePath = (0, path_1.join)(managerHome.contentRoot, relativePath);
         if ((0, fs_1.existsSync)(managerCachePath)) {
             const fraimDir = (0, project_fraim_paths_1.getUserFraimDirPath)();
-            const relToFraim = managerCachePath.startsWith(fraimDir)
-                ? managerCachePath.slice(fraimDir.length).replace(/\\/g, '/').replace(/^\//, '')
-                : `personalized-employee/${relativePath}`;
+            const mgrDisplayPath = managerCachePath.startsWith(fraimDir)
+                ? (0, project_fraim_paths_1.getUserFraimDisplayPath)(managerCachePath.slice(fraimDir.length).replace(/\\/g, '/').replace(/^\//, ''))
+                : managerCachePath.replace(/\\/g, '/');
             return {
                 present: true,
                 readPath: managerCachePath,
-                writePath: '',
-                displayPath: (0, project_fraim_paths_1.getUserFraimDisplayPath)(relToFraim),
+                writePath: managerHome.requiresPublish ? '' : managerCachePath,
+                displayPath: mgrDisplayPath,
                 scope,
-                managedByManagerSync: true
+                ...(managerHome.requiresPublish ? { managedByManagerSync: true } : {})
             };
         }
     }

package/dist/src/local-mcp-server/learning-usage-attestation.js

@@ -25,15 +25,22 @@ const learning_context_builder_1 = require("./learning-context-builder");
 var learning_firing_parser_2 = require("./learning-firing-parser");
 Object.defineProperty(exports, "parseFiringSection", { enumerable: true, get: function () { return learning_firing_parser_2.parseFiringSection; } });
 Object.defineProperty(exports, "extractLegacyTitle", { enumerable: true, get: function () { return learning_firing_parser_2.extractLegacyTitle; } });
+const ENTRY_INDEX_READS = [
+    { scope: 'manager', level: 'machine' },
+    { scope: 'manager', level: 'project' },
+    { scope: 'org', level: 'machine' },
+    { scope: 'reverse', level: 'machine' },
+    { scope: 'reverse', level: 'project' },
+];
 function buildEntryIndex(workspaceRoot, userId) {
     const byId = new Map();
     const byTitle = new Map();
-    // Every scope a firing could name: the manager's own entries, the org entries
-    // the agent also reads, and the manager-coaching family.
-    for (const scope of ['manager', 'org', 'reverse']) {
+    // Keep this list in parity with the preserved-entry levels that the offer
+    // path can surface. Storage resolution stays inside readPreservedLearnings.
+    for (const { scope, level } of ENTRY_INDEX_READS) {
         let entries = [];
         try {
-            entries = (0, learning_context_builder_1.readPreservedLearnings)(workspaceRoot, userId, scope);
+            entries = (0, learning_context_builder_1.readPreservedLearnings)(workspaceRoot, userId, scope, level);
         }
         catch {
             continue;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fraim",
-  "version": "2.0.298",
+  "version": "2.0.299",
   "description": "FRAIM core CLI and MCP package.",
   "main": "index.js",
   "bin": {