fraim-hub 2.0.339 → 2.0.341

package/dist/src/ai-hub/server.js

@@ -37,6 +37,8 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.findAvailablePortExcluding = exports.findAvailablePort = exports.AiHubServer = exports.HubConnectorStatusStore = exports.HostConfigStore = exports.DeploymentStore = void 0;
+exports.normalizeProposalDecisions = normalizeProposalDecisions;
+exports.applyProposalSetToRun = applyProposalSetToRun;
 exports.selfHealBrokenManagedAgents = selfHealBrokenManagedAgents;
 exports.configureFraimForHubAgent = configureFraimForHubAgent;
 exports.installAgentAndRefreshDetection = installAgentAndRefreshDetection;
@@ -45,6 +47,9 @@ exports.__setCatalogSyncSpawnForTests = __setCatalogSyncSpawnForTests;
 exports.__setAgentInstallTimeoutMsForTests = __setAgentInstallTimeoutMsForTests;
 exports.hubRunProcess = hubRunProcess;
 exports.buildOpenFileInvocation = buildOpenFileInvocation;
+exports.buildHubRecoveryContinueMessage = buildHubRecoveryContinueMessage;
+exports.buildHubCompactionRecoveryContinueMessage = buildHubCompactionRecoveryContinueMessage;
+const handoff_contracts_1 = require("../core/handoff-contracts");
 const express_1 = __importDefault(require("express"));
 const path_1 = __importDefault(require("path"));
 const fs_1 = __importDefault(require("fs"));
@@ -53,8 +58,10 @@ const crypto_1 = require("crypto");
 const child_process_1 = require("child_process");
 const https_1 = __importDefault(require("https"));
 const native_voice_input_1 = require("./native-voice-input");
+const proposal_set_contract_1 = require("../core/proposal-set-contract");
 const types_1 = require("../first-run/types");
 const local_provider_registry_1 = require("../cli/providers/local-provider-registry");
+const learning_domains_1 = require("../config/learning-domains");
 const learning_context_builder_1 = require("../local-mcp-server/learning-context-builder");
 const brand_store_1 = require("../core/brand-store");
 const project_fraim_paths_1 = require("../core/utils/project-fraim-paths");
@@ -976,12 +983,64 @@ function normalizeDeliveryActionResult(raw) {
         ...(typeof value.domainActionCompleted === 'boolean' ? { domainActionCompleted: value.domainActionCompleted } : {}),
     };
 }
+/**
+ * Issue #1857. The proxy already rejects a malformed set and tells the agent which
+ * field to fix, so this is the second gate rather than the first: it protects the
+ * render from a payload that reached the Hub by some other path. Same fail-closed
+ * rule as normalizeReviewHandoff, because the failure this design exists to remove
+ * was a card rendering with its body missing rather than throwing.
+ */
+/**
+ * Issue #1857 R18. A relayed decision is only useful if it names the proposal it
+ * decided; a title cannot, because `move-artifact-between-levels` states that
+ * titles never select updates. Anything without a usable proposalId and a known
+ * action is dropped here rather than forwarded, so the job never records a
+ * decision against a proposal the manager did not actually resolve.
+ */
+function normalizeProposalDecisions(raw) {
+    if (!Array.isArray(raw))
+        return [];
+    const out = [];
+    for (const entry of raw) {
+        if (!entry || typeof entry !== 'object')
+            continue;
+        const value = entry;
+        const proposalId = typeof value.proposalId === 'string' ? value.proposalId.trim() : '';
+        const action = value.action === 'approve' || value.action === 'reject' ? value.action : null;
+        if (!proposalId || !action)
+            continue;
+        out.push({
+            proposalId,
+            action,
+            ...(Number.isInteger(value.revision) ? { revision: value.revision } : {}),
+            ...(typeof value.level === 'string' && value.level.trim() ? { level: value.level.trim() } : {}),
+            ...(typeof value.reason === 'string' && value.reason.trim() ? { reason: value.reason.trim() } : {}),
+        });
+    }
+    return out;
+}
+function normalizeProposalSet(raw) {
+    if ((0, proposal_set_contract_1.validateProposalSet)(raw))
+        return null;
+    if (!raw || typeof raw !== 'object')
+        return null;
+    const value = raw;
+    return {
+        runScope: value.runScope,
+        // Issue #1857 R3: strongest evidence first, decided here rather than trusted
+        // from the agent, so the order the manager reads does not depend on how a
+        // model happened to sort its output.
+        proposals: (0, proposal_set_contract_1.rankProposals)(value.proposals),
+        ...(value.suppressed?.length ? { suppressed: value.suppressed } : {}),
+    };
+}
 function normalizeReviewHandoff(raw) {
     if (!raw || typeof raw !== 'object')
         return null;
     const value = raw;
     if (typeof value.reviewRequired !== 'boolean')
         return null;
+    const producingJobName = typeof value.producingJobName === 'string' ? value.producingJobName.trim() : '';
     const artifacts = Array.isArray(value.artifacts)
         ? value.artifacts.map((artifact, index) => normalizeReviewArtifact(artifact, index)).filter((artifact) => Boolean(artifact))
         : [];
@@ -995,6 +1054,7 @@ function normalizeReviewHandoff(raw) {
         : '';
     if (!value.reviewRequired) {
         return {
+            ...(producingJobName ? { producingJobName } : {}),
             reviewRequired: false,
             reviewTarget: rawTarget ? { type: targetType || 'none', label: targetLabel || 'Completed work' } : null,
             artifacts,
@@ -1010,6 +1070,7 @@ function normalizeReviewHandoff(raw) {
         if (artifacts.length > 0)
             return null;
         return {
+            ...(producingJobName ? { producingJobName } : {}),
             reviewRequired: true,
             reviewTarget: { type: 'pull_request', label: targetLabel || 'Pull request', url },
             artifacts: [],
@@ -1027,6 +1088,7 @@ function normalizeReviewHandoff(raw) {
     const fileArtifacts = artifacts.filter((artifact) => artifact.path && !artifact.url);
     if (targetType === 'artifact_set' && fileArtifacts.length === artifacts.length) {
         return {
+            ...(producingJobName ? { producingJobName } : {}),
             reviewRequired: true,
             reviewTarget: { type: 'artifact_set', label: targetLabel || `${artifacts.length} artifact${artifacts.length === 1 ? '' : 's'}` },
             artifacts: fileArtifacts,
@@ -1392,6 +1454,7 @@ function buildAgentSwitchHandoffSummary(conversation) {
         recentEvents: events,
         artifacts,
         reviewHandoff: conversation.reviewHandoff || null,
+        proposalSet: conversation.proposalSet || null,
         pendingDeliveryActionId: conversation.pendingDeliveryActionId ?? null,
         selectedReviewAction: normalizeReviewAction(conversation.selectedReviewAction) || null,
         completedDeliveryActionId: conversation.completedDeliveryActionId ?? null,
@@ -1615,31 +1678,35 @@ function isCodexMissingReasoningResumeText(value) {
     return text.includes("provided without its required 'reasoning' item") ||
         text.includes('provided without its required "reasoning" item');
 }
-// Issue #1447: a dropped or non-persisted review handoff must not look
-// successful to the agent. Records the failure on the existing non-droppable
-// hostError channel (the same `run.lastHostError`/`run.events` pattern the
-// #1264/#1265 `detectUnrecognizedReviewHandoffCall` diagnostic uses) AND
-// appends a system message directly to `run.messages` — the agent- and
-// manager-visible thread — so the failure is visible immediately rather than
-// only after a terminal non-zero exit (`pushTerminalFailureToThread` only
-// fires then). The message names the reason and this run's identity so the
-// agent can recover by resubmitting.
-function failLoudlyOnDroppedReviewHandoff(run, reason) {
-    const message = `FRAIM review handoff was not applied to run ${run.id} (job "${run.jobId || 'unknown'}"): ${reason}. The Hub review surface does not reflect this submission — resubmit seekMentoring from this run's active job/phase.`;
-    run.lastHostError = message;
-    run.events.push((0, hosts_1.createHubEvent)('stderr', boundedEventText(message)));
-    // This runs outside recordHostEvent's own end-of-call cap, so cap here too —
-    // an agent stuck retrying a mismatched-job submission must not grow this
-    // array past the same bound every other event source respects.
-    capProjectedEvents(run);
-    run.messages.push((0, hosts_1.createHubMessage)('system', message));
-}
-// Issue #1447: applies a reviewHandoff carried on a same-job seekMentoring
-// signal. Pure apply/normalize — it records no diagnostics itself. Fidelity
-// to the submission is checked once, generically, by
-// verifyReviewHandoffReflectsSubmission below, regardless of which of this
-// function's branches (or the caller's cross-job guard) is why the stored
-// result might not match.
+// Review ownership follows the submitted deliverable, independently of tracker identity.
+/**
+ * Issue #1857. Mirrors applyReviewHandoffToRun's rule: an unnormalized payload
+ * leaves prior run state untouched rather than replacing a good batch with a bad
+ * one. Does not set pauseReason; that transition belongs to classifyExit at turn
+ * exit, for the same reason it does for reviewHandoff.
+ */
+function applyProposalSetToRun(run, proposalSet, onFailure) {
+    const normalized = normalizeProposalSet(proposalSet);
+    if (!normalized) {
+        // Issue #1857. Prior state is left untouched, matching applyReviewHandoffToRun:
+        // a batch the Hub cannot trust must not replace one it can.
+        //
+        // But silence here would be the very failure this issue exists to remove. The
+        // proxy contract rejects a malformed set before it ever gets this far and tells
+        // the agent which field to fix, so reaching this line means the payload arrived
+        // by some path that check does not cover: an older client, a replay, a direct
+        // post. In that case the manager would otherwise open an empty review surface
+        // with nothing anywhere saying a batch was dropped, which is exactly how the
+        // `## Pending Review` parser failed for a year.
+        //
+        // Report it on the same channel a rejected reviewHandoff uses (#1900), naming
+        // the fields, so the run carries a recoverable error the agent can act on.
+        const errors = (0, proposal_set_contract_1.validateProposalSet)(proposalSet) || ['the payload could not be normalized'];
+        onFailure(`the learning review batch was not applied: ${errors.join('; ')}`);
+        return;
+    }
+    run.proposalSet = normalized;
+}
 function applyReviewHandoffToRun(run, reviewHandoff) {
     const normalizedReviewHandoff = normalizeReviewHandoff(reviewHandoff);
     if (!normalizedReviewHandoff) {
@@ -1663,7 +1730,7 @@ function applyReviewHandoffToRun(run, reviewHandoff) {
 }
 // Issue #1447: a mismatched `pull_request` target, isolated for readability.
 function pullRequestTargetMismatch(stored, submittedTarget) {
-    const submittedUrl = typeof submittedTarget?.url === 'string' ? submittedTarget.url : undefined;
+    const submittedUrl = (0, url_safety_1.safeHttpUrl)(submittedTarget?.url) || undefined;
     if (stored.reviewTarget?.type !== 'pull_request' || stored.reviewTarget.url !== submittedUrl) {
         return `stored reviewTarget (${JSON.stringify(stored.reviewTarget)}) does not match the submitted pull_request target (url: "${submittedUrl}")`;
     }
@@ -1680,7 +1747,7 @@ function artifactSetMismatch(stored, submitted) {
     const rawArtifacts = submitted.artifacts;
     const rawArtifactList = Array.isArray(rawArtifacts) ? rawArtifacts : [];
     const submittedPaths = rawArtifactList
-        .map((artifact) => (artifact && typeof artifact.path === 'string' ? artifact.path : null))
+        .map((artifact) => (artifact && typeof artifact.path === 'string' ? artifact.path.trim() : null))
         .filter((path) => Boolean(path))
         .sort();
     const storedPaths = (stored.artifacts || [])
@@ -1693,8 +1760,7 @@ function artifactSetMismatch(stored, submitted) {
     return null;
 }
 // Issue #1447: one generic post-condition instead of enumerating each way a
-// review handoff can fail to land. Whatever the reason — cross-job
-// filtering, normalization rejecting the whole payload, or a per-artifact
+// review handoff can fail to land. Whether normalization rejects the whole payload or a per-artifact
 // normalization failure silently dropping one item while the handoff as a
 // whole still normalizes — this compares what was actually submitted against
 // what the run now holds and fails loudly on any structural mismatch. Only
@@ -1702,33 +1768,29 @@ function artifactSetMismatch(stored, submitted) {
 // issue's incident describes (a stale or absent handoff masquerading as a
 // successful submission); a `reviewRequired: false` payload carries no such
 // promise.
-function verifyReviewHandoffReflectsSubmission(run, submitted, crossJobName) {
+function verifyReviewHandoffReflectsSubmission(run, submitted, onFailure) {
     if (!submitted || typeof submitted !== 'object' || submitted.reviewRequired !== true)
         return;
-    if (crossJobName) {
-        failLoudlyOnDroppedReviewHandoff(run, `a review handoff was submitted under job "${crossJobName}", but this run is tracking job "${run.jobId}" — the cross-job guard did not apply it`);
-        return;
-    }
     const stored = run.reviewHandoff;
     const submittedTarget = submitted.reviewTarget;
     if (!stored || stored.reviewRequired !== true) {
-        failLoudlyOnDroppedReviewHandoff(run, `evidence.reviewHandoff failed validation and was rejected (submitted reviewTarget: ${JSON.stringify(submittedTarget) || 'none'})`);
+        onFailure(`evidence.reviewHandoff failed validation and was rejected (submitted reviewTarget: ${JSON.stringify(submittedTarget) || 'none'})`);
         return;
     }
-    const submittedType = submittedTarget && typeof submittedTarget.type === 'string' ? submittedTarget.type : undefined;
+    const submittedType = submittedTarget && typeof submittedTarget.type === 'string' ? submittedTarget.type.trim() : undefined;
     const mismatch = submittedType === 'pull_request'
         ? pullRequestTargetMismatch(stored, submittedTarget)
         : artifactSetMismatch(stored, submitted);
     if (mismatch)
-        failLoudlyOnDroppedReviewHandoff(run, mismatch);
+        onFailure(mismatch);
 }
 // Apply a parsed seekMentoring tool-use signal from the host stream to
 // the run state. Returns the updated currentPhase.
-function applySeekMentoringSignal(run, signal) {
+function applySeekMentoringSignal(run, signal, onReviewFailure) {
     // Issue #347: filter cross-job pollution. The agent may call
     // seekMentoring for jobs OTHER than the one this run is tracking
     // (e.g., consulting `organizational-learning-synthesis` mid-run).
-    // Only apply signals whose job identity matches this run's.
+    // Only tracker metadata requires matching job identity.
     // Issue #732: match on `jobName` — the stable job-name slug that equals
     // run.jobId — NOT `jobId`. get_fraim_job mints a fresh randomUUID as the
     // job id on every call and the agent echoes that UUID into
@@ -1739,33 +1801,30 @@ function applySeekMentoringSignal(run, signal) {
     const targetJobId = run.jobId;
     const callJobName = signal.jobName;
     const isCrossJob = Boolean(callJobName && targetJobId && callJobName !== targetJobId);
-    // Issue #1447: a genuine reviewHandoff must not vanish without a trace,
-    // whether the cross-job guard just below is why it was never applied, or
-    // applyReviewHandoffToRun rejected/truncated it. Apply first (skipped
-    // entirely for a foreign job, since that guard is still correct — a
-    // foreign job's data must never overwrite this run's tracked state), then
-    // verify unconditionally that the result actually reflects the submission.
-    if (signal.reviewHandoff) {
-        if (!isCrossJob)
-            applyReviewHandoffToRun(run, signal.reviewHandoff);
-        verifyReviewHandoffReflectsSubmission(run, signal.reviewHandoff, isCrossJob ? callJobName : null);
-    }
-    else if (!isCrossJob) {
-        // Issue #1501: No reviewHandoff in this same-job call. Clear any prior reviewHandoff so
-        // run.reviewHandoff always reflects the most recent seekMentoring intent,
-        // not a stale flag from an earlier submit phase.
-        run.reviewHandoff = null;
-    }
-    if (isCrossJob)
+    // Issue #1857: the learning review batch, applied on the same terms as the
+    // handoff above it. Placed before the early returns, because a review-pending
+    // call that also reports a handoff failure still emitted a real batch, and a
+    // dropped set is invisible: the surface renders nothing and says nothing.
+    if (signal.proposalSet)
+        applyProposalSetToRun(run, signal.proposalSet, onReviewFailure);
+    if (signal.reviewHandoffError) {
+        onReviewFailure(signal.reviewHandoffError);
         return;
-    // Issue #848: capture the issue number the call carries so a launched follow-on
-    // run can reference the originating issue, and persist any next-job recommendations.
-    if (signal.issueNumber)
-        run.issueNumber = signal.issueNumber;
-    if (signal.nextJobRecommendations) {
-        const normalized = normalizeNextJobRecommendations(signal.nextJobRecommendations);
-        if (normalized)
-            run.nextJobRecommendations = normalized;
+    }
+    else if (signal.reviewHandoff) {
+        const error = (0, handoff_contracts_1.reviewHandoffNormalizationError)(signal.reviewHandoff);
+        if (error) {
+            onReviewFailure(error);
+            return;
+        }
+        else {
+            applyReviewHandoffToRun(run, { ...signal.reviewHandoff, producingJobName: callJobName });
+            verifyReviewHandoffReflectsSubmission(run, signal.reviewHandoff, onReviewFailure);
+        }
+    }
+    else {
+        // The most recent mentoring intent owns review lifetime across all jobs.
+        run.reviewHandoff = null;
     }
     if (signal.deliveryActionId !== undefined) {
         run.pendingDeliveryActionId = signal.deliveryActionId;
@@ -1785,6 +1844,17 @@ function applySeekMentoringSignal(run, signal) {
             run.pendingDeliveryActionId = null;
         }
     }
+    // Delivery actions belong to the review, while tracker and issue metadata
+    // remain scoped to the run's original job (including colliding phase names).
+    if (isCrossJob)
+        return;
+    if (signal.issueNumber)
+        run.issueNumber = signal.issueNumber;
+    if (signal.nextJobRecommendations) {
+        const normalized = normalizeNextJobRecommendations(signal.nextJobRecommendations);
+        if (normalized)
+            run.nextJobRecommendations = normalized;
+    }
     if (signal.delegationLedger &&
         run.jobId === 'fully-delegate' &&
         signal.phaseStatus === 'complete' &&
@@ -2468,10 +2538,11 @@ function buildHubRecoveryContinueMessage(run, exitCode, attempt) {
         'The FRAIM Hub is automatically recovering this interrupted run.',
         'This is not a manager-authored instruction. Do not say the manager asked you to continue.',
         `Run id: ${run.id}`,
-        `Session id: ${run.sessionId || 'unknown'}`,
+        `CLI host session id: ${run.sessionId || 'unknown'}`,
         `Recovery attempt: ${attempt}/${MAX_RECOVERY_ATTEMPTS}`,
         `Prior exit code: ${exitCode ?? 'unknown'}`,
         'Resume only if the tracked FRAIM phase is non-terminal and not waiting for human review or approval.',
+        (0, manager_turns_1.buildHubPhaseRecoveryInstructions)(run.id),
     ].join('\n');
 }
 // Issue #1221: the terminal exit/recovery system events previously said only
@@ -2515,10 +2586,11 @@ function buildHubCompactionRecoveryContinueMessage(run, exitCode, attempt) {
         'The host compacted context or restarted its internal runtime while this run was still active.',
         'This is not a manager-authored instruction. Do not say the manager asked you to continue.',
         `Run id: ${run.id}`,
-        `Session id: ${run.sessionId || 'unknown'}`,
+        `CLI host session id: ${run.sessionId || 'unknown'}`,
         `Compaction recovery attempt: ${attempt}/${MAX_RECOVERY_ATTEMPTS}`,
         `Prior exit code: ${exitCode ?? 'unknown'}`,
         'Resume only if the tracked FRAIM phase is non-terminal and not waiting for human review or approval.',
+        (0, manager_turns_1.buildHubPhaseRecoveryInstructions)(run.id),
     ].join('\n');
 }
 function createHubCompactionRecoveryEvent(run, exitCode, attempt) {
@@ -3515,6 +3587,10 @@ class AiHubServer {
             project.droppedRecordedReason = this.droppedRecordedReason;
         }
         const rawJobs = (0, catalog_1.discoverEmployeeJobs)(normalizedProjectPath, FULL_JOB_CATALOG_OPTIONS);
+        // Issue #1891: build the custom-employee index once (O(1) per job, one disk walk total)
+        // so custom ownership wins over catalog assignment. Follows the same pattern as
+        // buildCustomJobOwnerIndex documented in the Issue #1090 comment above.
+        const customJobOwners = buildCustomJobOwnerIndex(normalizedProjectPath ?? '');
         // Issue #566 (R7): jobs already carry `personalized` from catalog discovery
         // (true for the fraim/personalized-employee layer). The Hub renders a plain
         // "Personalized" marking from that flag — no author/attribution is tracked.
@@ -3522,7 +3598,7 @@ class AiHubServer {
             .filter((job) => !FRAIM_INTERNAL_JOB_IDS.has(job.id))
             .map((job) => ({
             ...job,
-            requiredPersonaKey: getProtectedPersonaForHubJob(job.id),
+            requiredPersonaKey: customJobOwners.get(job.id) ?? getProtectedPersonaForHubJob(job.id),
         }));
         // Issue #1247: expose internal jobs in a separate bootstrap field so next-job
         // recommendation chips can resolve and launch them. They are intentionally
@@ -3711,6 +3787,9 @@ class AiHubServer {
             env: {
                 ...(launchContext.env || {}),
                 FRAIM_HUB_RUN_ID: runId,
+                // Each host turn is a new phase-arrival scope; MCP restarts within
+                // that host inherit the same token and retain their valid starts.
+                FRAIM_PHASE_RESUME_ID: (0, crypto_1.randomUUID)(),
                 FRAIM_BROWSER_CONVERSATION_ID: conversationId,
                 ...(page ? {
                     FRAIM_BROWSER_PAGE_TARGET_ID: page.targetId,
@@ -4059,6 +4138,7 @@ class AiHubServer {
             eventLogRefs: run.eventLogRefs || [],
             artifacts: run.artifacts || [],
             reviewHandoff: run.reviewHandoff || null,
+            proposalSet: run.proposalSet || null,
             pendingDeliveryActionId: run.pendingDeliveryActionId ?? null,
             selectedReviewAction: run.selectedReviewAction || null,
             completedDeliveryActionId: run.completedDeliveryActionId ?? null,
@@ -4444,6 +4524,7 @@ class AiHubServer {
             runDiscriminant: persistedRun?.runDiscriminant || undefined,
             artifacts: Array.isArray(conversation.artifacts) ? conversation.artifacts : [],
             reviewHandoff: conversation.reviewHandoff || null,
+            proposalSet: conversation.proposalSet || null,
             pendingDeliveryActionId: conversation.pendingDeliveryActionId ?? null,
             selectedReviewAction: normalizeReviewAction(conversation.selectedReviewAction) || null,
             completedDeliveryActionId: conversation.completedDeliveryActionId ?? null,
@@ -5128,7 +5209,9 @@ class AiHubServer {
         // jobId (resolveHubJob would never match a UUID, leaving a freeform run
         // unpromoted and then dropping its phase signals).
         this.maybePromoteFreeformRunToJob(run, signal.jobName || signal.jobId);
-        applySeekMentoringSignal(run, signal);
+        applySeekMentoringSignal(run, signal, (reason) => {
+            this.recordHostEvent(run, run.hostId, { hostError: 'Review handoff was not applied: ' + reason }, 'stderr');
+        });
         if (signal.phaseId === 'retrospective' && signal.phaseStatus === 'complete') {
             void this.releaseBrowserConversationPage(run.conversationId || run.id);
         }
@@ -5645,12 +5728,39 @@ class AiHubServer {
                 const projectPath = resolveProjectPath(req);
                 const entries = (0, learning_context_builder_1.readPreservedLearnings)(projectPath, userEmail, scope, level);
                 const threshold = (0, learning_context_builder_1.getScoreThreshold)(projectPath);
-                return res.json({ scope, level, entries, threshold });
+                // Issue #1755 R9: the domain catalogue travels with the corpus so the library's
+                // domain filter and the re-scope selector offer every valid domain, not only the
+                // ones that happen to have an entry already.
+                return res.json({ scope, level, entries, threshold, domains: ['global', ...learning_domains_1.LEARNING_DOMAINS] });
             }
             catch (error) {
                 return res.status(500).json({ error: error instanceof Error ? error.message : 'Could not read learnings.' });
             }
         });
+        // Issue #1857 R19: what the manager said no to, and why.
+        //
+        // A rejection is one of the three lifecycle states, and until now it was the
+        // only one with no way to see it short of opening a markdown file by hand:
+        // `readPreservedLearnings` reads family files, and a rejected claim is
+        // deliberately not in one. A manager who cannot review their own refusals
+        // cannot tell a claim that keeps coming back from one they already settled.
+        //
+        // Manager-only by construction. This is an HTTP read the Hub makes; nothing
+        // in the employee's learning context calls `readRejectedProposals`, and
+        // `test-1857-context-boundary.ts` pins that it never will. Feeding refused
+        // claims back to a job is the influence R10 exists to prevent.
+        this.app.get('/api/ai-hub/rejections', async (req, res) => {
+            try {
+                const userEmail = await this.resolveLearningIdentity('manager');
+                if (!userEmail)
+                    return res.json({ entries: [] });
+                const projectPath = resolveProjectPath(req);
+                return res.json({ entries: (0, learning_context_builder_1.readRejectedProposals)(projectPath, userEmail) });
+            }
+            catch (error) {
+                return res.status(500).json({ error: error instanceof Error ? error.message : 'Could not read rejections.' });
+            }
+        });
         // #533 §3: add / edit / delete a single learning entry — writes the real file
         // at the section's level (machine for the Manager/Company tabs, project for the
         // project workspace). The action targets exactly the card's file.
@@ -5664,7 +5774,16 @@ class AiHubServer {
             if (!b.category || !VALID_CATEGORIES.includes(b.category))
                 return res.status(400).json({ error: `category must be one of: ${VALID_CATEGORIES.join(', ')}` });
             const level = (b.level && VALID_LEVELS.includes(b.level)) ? b.level : 'machine';
-            const ref = { scope: b.scope, level, category: b.category };
+            // Issue #1755: `domain` names the file the entry lives in today, `targetDomain`
+            // the file it should live in after the write. Without the first, every write
+            // resolved to the undecorated global file and a domain-scoped entry could not be
+            // edited or deleted at all.
+            const ref = {
+                scope: b.scope,
+                level,
+                category: b.category,
+                domain: (0, learning_context_builder_1.normalizeLearningDomain)(b.domain),
+            };
             // Issue #750: writes to a personal-scope file need a resolved identity —
             // fail explicitly rather than writing to a guessed or empty-string file.
             const userEmail = await this.resolveLearningIdentity(b.scope);
@@ -5677,6 +5796,7 @@ class AiHubServer {
                     severity: b.severity,
                     title: b.title,
                     body: b.body,
+                    targetDomain: b.targetDomain === undefined ? undefined : (0, learning_context_builder_1.normalizeLearningDomain)(b.targetDomain),
                 });
                 return res.json({ ok: true, path: result.path });
             }
@@ -6018,6 +6138,7 @@ class AiHubServer {
                         personaKey: resolveConversationPersonaKey(conversation, bucketKey),
                         artifacts: Array.isArray(conversation.artifacts) ? conversation.artifacts : [],
                         reviewHandoff: conversation.reviewHandoff || null,
+                        proposalSet: conversation.proposalSet || null,
                         delegation: conversation.delegation || null,
                         delegationTaskId: conversation.delegationTaskId || null,
                         nextJobRecommendations: null,
@@ -7218,6 +7339,25 @@ class AiHubServer {
                 // Issue #1651 R7/R12: resolve staged attachments into persisted metadata
                 // (attached to the manager's message) and a host-bound reference suffix.
                 const { attachments, referenceSuffix: attachmentSuffix } = this.resolveMessageAttachments((0, conversation_store_1.conversationScopeKey)(run.scope, run.projectPath), run.conversationId || run.id, req.body.attachmentIds);
+                // Issue #1857 R18. The manager's prose names each proposal by title, and
+                // `move-artifact-between-levels` states that titles never select updates,
+                // so the job would have to guess which revision a sentence referred to.
+                // This carries the decisions as data alongside that prose, appended the
+                // same way an attachment reference is: the manager still reads their own
+                // words in the thread, and the job records against the id and revision.
+                const proposalDecisions = normalizeProposalDecisions(req.body.proposalDecisions);
+                const FENCE = '\u0060'.repeat(3);
+                // The reason is the manager's own words, so it can contain anything a
+                // person types, including a code fence. JSON escapes quotes and newlines
+                // but not backticks, and a stray fence here would close the block early
+                // and leave the rest of the decisions reading as prose. Escaping them
+                // keeps the block one parseable unit; the agent unescapes nothing, because
+                // a backtick inside a reason carries no meaning it needs.
+                const decisionJson = JSON.stringify(proposalDecisions).split('\u0060').join('\\u0060');
+                const decisionSuffix = proposalDecisions.length
+                    ? '\n\n<!-- fraim-proposal-decisions -->\n' + FENCE + 'json\n'
+                        + decisionJson + '\n' + FENCE
+                    : '';
                 // No resumable session — start fresh using a handoff prompt so the agent
                 // picks up from the preserved conversation state + manager coaching.
                 const reviewApprovalSystemEventText = buildReviewApprovalSystemEventText(prepared.display || message);
@@ -7266,8 +7406,8 @@ class AiHubServer {
                         this.persistRunConversation(startedFresh, startedFresh.conversationId || startedFresh.id);
                     this.runRegistry.create(run, {});
                     const freshLaunch = this.resolveLaunchAgent(run.configuredAgentId, run.hostId);
-                    this.recordHubGeneratedEvent(run, 'agent_input', freshPayload.message + attachmentSuffix);
-                    const freshChild = this.hostRuntime.startRun(run.hostId, run.projectPath, freshPayload.message + attachmentSuffix, {
+                    this.recordHubGeneratedEvent(run, 'agent_input', freshPayload.message + attachmentSuffix + decisionSuffix);
+                    const freshChild = this.hostRuntime.startRun(run.hostId, run.projectPath, freshPayload.message + attachmentSuffix + decisionSuffix, {
                         onEvent: (event, channel) => {
                             this.runRegistry.update(run.id, (current) => {
                                 if (event.sessionId) {
@@ -7353,8 +7493,8 @@ class AiHubServer {
                 // them, so any other continueRun call site delivering the turn (or a
                 // turn that exits before its first event) left the badge stuck
                 // forever. See clearStaleDeliveryStatuses and handleRunExit.
-                this.recordHubGeneratedEvent(run, 'agent_input', message + attachmentSuffix);
-                const child = this.hostRuntime.continueRun(run.hostId, run.projectPath, run.sessionId, message + attachmentSuffix, {
+                this.recordHubGeneratedEvent(run, 'agent_input', message + attachmentSuffix + decisionSuffix);
+                const child = this.hostRuntime.continueRun(run.hostId, run.projectPath, run.sessionId, message + attachmentSuffix + decisionSuffix, {
                     onEvent: (event, channel) => {
                         if (run.hostId === 'codex' && reviewApprovalSystemEventText) {
                             codexMissingReasoningResumeError = codexMissingReasoningResumeError ||