fraim-hub 2.0.323 → 2.0.325

package/dist/src/ai-hub/server.js

@@ -7189,9 +7189,10 @@ class AiHubServer {
                         // job that just received coaching has not reached retrospective
                         // again yet. Clear it at send-time so a coached Done job stops
                         // offering next-job recommendations immediately, not only once the
-                        // resumed session's next seekMentoring signal arrives.
+                        // resumed session's next seekMentoring signal arrives. The active
+                        // reviewHandoff deliberately survives conversational coaching; its
+                        // lifecycle is owned by applySeekMentoringSignal (issue #1763).
                         current.nextJobRecommendations = null;
-                        current.reviewHandoff = null;
                     });
                     const startedFresh = this.runRegistry.get(run.id);
                     if (startedFresh)
@@ -7260,9 +7261,10 @@ class AiHubServer {
                         current.pendingDeliveryActionId = selectedReviewAction.deliveryActionId || null;
                     }
                     // Issue #1373 (Defect 2): see the no-session branch above for why
-                    // this can only be stale at coaching-send time.
+                    // next-job recommendations can only be stale at coaching-send time.
+                    // applySeekMentoringSignal remains the sole reviewHandoff lifecycle
+                    // owner so a conversational coaching turn does not decide the review.
                     current.nextJobRecommendations = null;
-                    current.reviewHandoff = null;
                 });
                 const started = this.runRegistry.get(run.id);
                 if (started)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fraim-hub",
-  "version": "2.0.323",
+  "version": "2.0.325",
   "description": "FRAIM Hub local companion package.",
   "author": "Sid Mathur <sid.mathur@gmail.com>",
   "homepage": "https://github.com/mathursrus/FRAIM#readme",
@@ -213,7 +213,7 @@
     "electron-updater": "^6.8.9",
     "express": "^5.2.1",
     "extract-zip": "^2.0.1",
-    "fraim": "2.0.323",
+    "fraim": "2.0.325",
     "mongodb": "^7.0.0",
     "node-cron": "4.2.1",
     "node-edge-tts": "^1.2.10",

package/public/ai-hub/index.html

@@ -439,9 +439,10 @@
           <details class="panel-details panel-details--thread" id="thread-panel" open>
             <summary>
               <span class="panel-summary-copy">
-                <span class="panel-kicker" id="thread-panel-kicker">Updates</span>
+                <span class="panel-kicker" id="thread-panel-kicker">Manage</span>
               </span>
               <button class="conversation-focus-btn" id="conversation-focus-btn" type="button" aria-label="Expand conversation" title="Expand conversation" onclick="event.preventDefault(); event.stopPropagation();">&#8599;</button>
+              <button class="micro-manage-toggle" id="micro-manage-toggle" type="button" role="switch" aria-checked="false" aria-controls="manage-body"><span>Micro-Manage</span><span class="micro-switch-track" aria-hidden="true"></span></button>
             </summary>
             <!-- Issue #1065: find a passage inside the open conversation (R44-R46). A result that
                  promises "+6 more matches" is an unkept promise without this: the manager lands in
@@ -458,7 +459,21 @@
             <!-- Issue #512 R7: completion card + format-derived artifact strip
                  render INSIDE #messages (as the employee's review turn) so the
                  thread panel keeps its existing flex/scroll geometry. -->
-            <div class="messages" id="messages"></div>
+            <div class="manage-body" id="manage-body">
+              <div class="messages" id="messages"></div>
+              <div class="manage-activity" id="micro-manage" hidden>
+                <button class="micro-return" id="micro-return" type="button" hidden>Return to conversation</button>
+                <div class="micro-activity-state" id="micro-activity-state" role="status" hidden></div>
+                <pre class="micro-log" id="micro-log" tabindex="0" aria-label="Detailed activity"></pre>
+                <div class="resume-command" id="resume-command" hidden>
+                  <span class="resume-command-label">Resume in terminal</span>
+                  <div class="resume-command-row">
+                    <pre class="resume-command-code" id="resume-command-code"></pre>
+                    <button class="resume-command-copy" id="resume-command-copy" type="button" title="Copy command">Copy</button>
+                  </div>
+                </div>
+              </div>
+            </div>
           </details>
 
           <div class="support-stack">
@@ -480,22 +495,6 @@
                  active coaching actions cannot hide it. -->
             <div class="agent-unavailable-note" id="active-agent-unavailable-note" data-testid="active-agent-unavailable-note" role="status" hidden></div>
 
-            <details class="micro panel-details" id="micro-manage">
-              <summary>
-                <span class="panel-summary-copy">
-                  <span class="panel-kicker">Micro-manage</span>
-                  <span class="panel-summary-text">Raw host events and tool calls</span>
-                </span>
-              </summary>
-              <pre class="micro-log" id="micro-log"></pre>
-              <div class="resume-command" id="resume-command" hidden>
-                <span class="resume-command-label">Resume in terminal</span>
-                <div class="resume-command-row">
-                  <pre class="resume-command-code" id="resume-command-code"></pre>
-                  <button class="resume-command-copy" id="resume-command-copy" type="button" title="Copy command">Copy</button>
-                </div>
-              </div>
-            </details>
           </div>
         </div>
 

package/public/ai-hub/review.css

@@ -140,6 +140,10 @@
   color: var(--muted, #888);
   filter: none;
 }
+:root[data-theme="dark"] .review-actions .rb-approve:not(:disabled):not(.managed-disabled),
+:root[data-theme="dark"] .review-actions .rb-secondary:not(:disabled):not(.managed-disabled) {
+  color: var(--bg, #1e1e1e);
+}
 .review-actions .rb-handoff {
   font-size: 12px;
   color: var(--muted);

package/public/ai-hub/script.js

@@ -134,7 +134,7 @@ function gatherElements() {
     'status-line', 'coach-note',
     // Issue #1651: composer attachments.
     'coach', 'composer-dropzone', 'staged-attachments', 'attach-btn', 'attach-file-input',
-    'thread-panel', 'thread-panel-kicker',
+    'thread-panel', 'thread-panel-kicker', 'micro-manage-toggle', 'micro-return', 'micro-activity-state',
     'quick-coach-btns',
     'positive-reinforcement-btn', 'positive-reinforcement-dropdown',
     'negative-reinforcement-btn', 'negative-reinforcement-dropdown',
@@ -1417,7 +1417,8 @@ async function hydrateConversationBody(projectPath, id, options = {}) {
     try {
       const payload = await requestJson(`/api/ai-hub/conversations?${params.toString()}`);
       const body = payload && payload.conversation;
-      if (!body) return null;
+      if (!body) throw new Error('Conversation activity is unavailable');
+      activityLoadErrors.delete(manageKey(body));
       normalizeGeminiConversationMessages(body);
       const current = findConversation(body.id);
       // A body hydrate can be in flight while a live run poll or continue POST
@@ -1439,6 +1440,7 @@ async function hydrateConversationBody(projectPath, id, options = {}) {
         return current;
       }
       const merged = mergeConversationBody(current, body);
+      activityLoadErrors.delete(manageKey(merged));
       const bucket = convBucketKey(merged);
       const list = (state.conversations[bucket] || []).slice();
       const idx = list.findIndex((conv) => conv.id === merged.id);
@@ -1453,6 +1455,11 @@ async function hydrateConversationBody(projectPath, id, options = {}) {
       return merged;
     } catch (error) {
       console.warn('Could not hydrate conversation body:', error);
+      const failed = findConversation(id);
+      if (failed) {
+        activityLoadErrors.add(manageKey(failed));
+        if (state.activeId === failed.id) syncManageActivityState(failed, failed.microEvents || failed.events || []);
+      }
       return null;
     } finally {
       conversationBodyFetches.delete(key);
@@ -2069,12 +2076,11 @@ function managerLabel() {
   return id.name.split(' ')[0];
 }
 
-// R2: update the thread panel kicker with "[Employee] updates".
+// Manage is stable across agents and both levels of detail.
 function syncThreadPanelKicker(conv) {
   const el = els['thread-panel-kicker'] || document.getElementById('thread-panel-kicker');
   if (!el) return;
-  const name = conv ? coachEmployeeLabel(conv) : null;
-  el.textContent = name ? `${name} updates` : 'Updates';
+  el.textContent = 'Manage';
 }
 
 // Returns the FRAIM invocation prefix for the currently active employee:
@@ -2276,6 +2282,60 @@ function formatEmployeeText(text) {
   return out.join('\n');
 }
 
+// Presentation state is session-only and belongs to the record's own scope.
+const manageViews = new Map();
+const activityLoadErrors = new Set();
+let displayedManageKey = null;
+function manageKey(conv) { return conv ? `${convBucketKey(conv)}:${conv.id}` : null; }
+function manageViewFor(conv) {
+  const key = manageKey(conv);
+  if (!manageViews.has(key)) manageViews.set(key, { micro: false, messages: { top: 0, follow: true }, activity: { top: 0, follow: true } });
+  return manageViews.get(key);
+}
+function captureManagePosition() {
+  const view = manageViews.get(displayedManageKey);
+  if (!view || !els['thread-panel'].open) return;
+  const node = view.micro ? els['micro-log'] : els['messages'];
+  if (!node || !node.clientHeight) return;
+  view[view.micro ? 'activity' : 'messages'] = {
+    top: node.scrollTop,
+    follow: node.scrollHeight - node.scrollTop - node.clientHeight < 80,
+  };
+}
+function restoreManagePosition(conv) {
+  if (displayedManageKey !== manageKey(conv)) return;
+  const view = manageViewFor(conv);
+  const position = view[view.micro ? 'activity' : 'messages'];
+  const node = view.micro ? els['micro-log'] : els['messages'];
+  node.scrollTo({ top: position.follow ? node.scrollHeight : position.top, behavior: 'instant' });
+}
+function applyManageView(conv) {
+  const micro = !!conv && conv.compareMode !== 'ab' && manageViewFor(conv).micro;
+  els['micro-manage-toggle'].hidden = !conv || conv.compareMode === 'ab';
+  els['micro-manage-toggle'].setAttribute('aria-checked', String(micro));
+  els['micro-manage'].hidden = !micro;
+  els['messages'].hidden = micro;
+  if (els['conv-find']) els['conv-find'].hidden = micro || !convFind.open;
+}
+function setManageMicroMode(enabled) {
+  const conv = activeConversation();
+  if (!conv || conv.compareMode === 'ab') return;
+  captureManagePosition();
+  manageViewFor(conv).micro = enabled;
+  els['thread-panel'].open = true;
+  applyManageView(conv);
+  restoreManagePosition(conv);
+}
+function syncManageActivityState(conv, events) {
+  const error = activityLoadErrors.has(manageKey(conv));
+  const message = error ? 'Activity is unavailable. You can return to the conversation.'
+    : !conversationHasBody(conv) ? 'Loading activity…' : !events.length ? 'No activity yet' : '';
+  els['micro-activity-state'].textContent = message;
+  els['micro-activity-state'].hidden = !message;
+  // Keep an explicit way back to prompts even when the detailed view owns the body.
+  els['micro-return'].hidden = !(error || conversationUiState(conv) === 'waiting' || convAwaitingReview(conv));
+}
+
 function syncConversationPanels(conv, switchedConv) {
   if (!conv) return;
   const panelState = panelStateFor(conv.id);
@@ -2326,6 +2386,8 @@ async function deleteConversation(id) {
     if (next.length !== list.length) { state.conversations[key] = next; removed = true; }
   }
   if (!removed) return false;
+  manageViews.delete(manageKey(target));
+  activityLoadErrors.delete(manageKey(target));
   if (state.activeId === id) {
     state.activeId = null;
     // Deleting the active run: stop its poll so no zombie interval keeps ticking
@@ -3768,6 +3830,7 @@ function restoreFocusedConversationNodes() {
 
 function closeConversationFocus() {
   if (!conversationFocusState.open) return;
+  captureManagePosition();
   if (els['messages']) conversationFocusState.messageScrollTop = els['messages'].scrollTop;
   restoreFocusedConversationNodes();
   conversationFocusState.open = false;
@@ -3779,6 +3842,8 @@ function closeConversationFocus() {
   requestAnimationFrame(() => {
     if (els['messages']) els['messages'].scrollTop = conversationFocusState.messageScrollTop || 0;
     if (typeof syncThreadMessageViewport === 'function') syncThreadMessageViewport();
+    const conv = activeConversation();
+    if (conv) restoreManagePosition(conv);
     const target = conversationFocusState.previousFocus && document.contains(conversationFocusState.previousFocus)
       ? conversationFocusState.previousFocus
       : els['conversation-focus-btn'];
@@ -3788,6 +3853,7 @@ function closeConversationFocus() {
 
 function openConversationFocus() {
   const conv = activeConversation();
+  captureManagePosition();
   const overlay = els['conversation-focus-overlay'];
   const panels = els['conversation-focus-panels'];
   const thread = els['thread-panel'];
@@ -3815,6 +3881,7 @@ function openConversationFocus() {
   requestAnimationFrame(() => {
     if (els['messages']) els['messages'].scrollTop = conversationFocusState.messageScrollTop || 0;
     if (typeof syncThreadMessageViewport === 'function') syncThreadMessageViewport();
+    restoreManagePosition(conv);
     if (els['conversation-focus-close']) els['conversation-focus-close'].focus();
   });
 }
@@ -3881,6 +3948,11 @@ function renderActive() {
   // If we switched conversations (or this is the first render), wipe and
   // start fresh. Otherwise we're going to do an incremental update below.
   const switchedConv = renderedConvId !== conv.id;
+  if (displayedManageKey !== manageKey(conv)) {
+    captureManagePosition();
+    displayedManageKey = manageKey(conv);
+  }
+  applyManageView(conv);
   if (switchedConv) {
     els['messages'].innerHTML = '';
     els['messages'].className = 'messages';
@@ -4055,8 +4127,11 @@ function renderActive() {
   // <pre> wipes the entire log every tick which is wasteful.
   const microEvents = Array.isArray(conv.microEvents) && conv.microEvents.length > 0 ? conv.microEvents : null;
   const events = microEvents || conv.events || [];
+  if (!switchedConv && !els['micro-manage'].hidden) captureManagePosition();
   renderMicroLogEvents(events, { mode: microEvents ? 'microEvents' : 'events' });
   renderResumeCommand(conv);
+  syncManageActivityState(conv, events);
+  if (!els['micro-manage'].hidden || switchedConv) requestAnimationFrame(() => restoreManagePosition(conv));
 
   // Coaching state — only enable Send when there's text and the run is resumable.
   syncSendButton();
@@ -4075,7 +4150,7 @@ function renderActive() {
   // marks a manager is stepping through. Re-emit them from find state instead of injecting once.
   if (typeof convFindRefresh === 'function') convFindRefresh();
   const shouldScrollForUpdate = switchedConv || statusChanged || appendedMessages > 0 || messagesMutated;
-  const reviewFollow = switchedConv || statusChanged || threadWasNearBottom;
+  const reviewFollow = (switchedConv || statusChanged || threadWasNearBottom) && (!switchedConv || manageViewFor(conv).messages.follow);
   scrollThreadAfterViewportSync(conv, shouldScrollForUpdate, hasNewPendingDeliveryMessage, reviewFollow, clearedPendingDeliveryMessages);
   requestAnimationFrame(() => {
     syncThreadMessageViewport();
@@ -5709,6 +5784,7 @@ function ensurePendingAnchorScrollListener(host) {
 }
 
 function setThreadScrollTop(host, top) {
+  if (host.hidden) return;
   pendingAnchorProgrammaticScrollUntil = Date.now() + 200;
   host.scrollTop = top;
 }
@@ -5721,7 +5797,7 @@ function scrollThreadAfterViewportSync(conv, shouldScrollForUpdate, forceBottom,
   const latest = activeConversation();
   if (!latest || latest.id !== conv.id) return;
   const host = els['messages'];
-  if (!host) return;
+  if (!host || host.hidden) return;
   if (latest.status === 'running') {
     ensurePendingAnchorScrollListener(host);
     if (!forceBottom && pendingAnchorUserScrolled(host)) {
@@ -7637,15 +7713,17 @@ async function approveReview(options) {
   const opts = options || {};
   const conv = activeConversation();
   if (!conv) return;
+  const shouldResume = !!opts.resumeAfterApproval
+    && !!conv.runId
+    && convAwaitingReview(conv);
+  if (opts.resumeAfterApproval && !shouldResume) {
+    showStatus('Approve could not resume this run. The review gate is no longer active. Use Mark complete if you intend to close it manually.', true);
+    return;
+  }
   if (state.pollHandle) {
     window.clearInterval(state.pollHandle);
     state.pollHandle = null;
   }
-  const shouldResume = !!opts.resumeAfterApproval
-    && !!conv.runId
-    && !!conv.sessionId
-    && !!reviewHandoffForConversation(conv)
-    && convAwaitingReview(conv);
   if (shouldResume) {
     const selectedReviewAction = opts.reviewAction && typeof opts.reviewAction === 'object'
       ? opts.reviewAction
@@ -10234,6 +10312,16 @@ function wireEvents() {
   }
 
   // R6: thread panel toggle — persist open/close state per conversation.
+  els['micro-manage-toggle'].addEventListener('click', (event) => {
+    event.preventDefault();
+    event.stopPropagation();
+    setManageMicroMode(els['micro-manage-toggle'].getAttribute('aria-checked') !== 'true');
+  });
+  els['micro-return'].addEventListener('click', () => {
+    setManageMicroMode(false);
+    els['micro-manage-toggle'].focus();
+    scrollThreadForReview(activeConversation());
+  });
   if (els['thread-panel']) {
     els['thread-panel'].addEventListener('toggle', () => {
       const conv = activeConversation();
@@ -11325,6 +11413,7 @@ function convFindOpen(term) {
   if (!bar || !input) return;
   const cleaned = convFindTextFromQuery(term);
   if (!cleaned) return;
+  setManageMicroMode(false);
   bar.hidden = false;
   convFind.open = true;
   input.value = cleaned;

package/public/ai-hub/styles.css

@@ -4246,7 +4246,66 @@ body.hub-shell { display: flex; flex-direction: column; height: 100vh; overflow:
 }
 .workspace-conv #thread-panel:not([open]) #messages { display: none; }
 
-/* Support stack: Coach (input) + Micro-manage (log). It sizes to its content and
+/* Both Manage views use the same flex slot; switching does not resize the pane. */
+#thread-panel .manage-body {
+  display: flex;
+  flex-direction: column;
+  flex: 1 1 0;
+  min-height: 0;
+  min-width: 0;
+  overflow: hidden;
+}
+#thread-panel:not([open]) .manage-body { display: none; }
+#thread-panel .manage-activity {
+  display: flex;
+  flex-direction: column;
+  flex: 1 1 0;
+  min-height: 0;
+  min-width: 0;
+  overflow: hidden;
+}
+#thread-panel .manage-activity[hidden],
+#thread-panel #messages[hidden] { display: none; }
+#thread-panel .manage-activity .micro-log {
+  flex: 1 1 0;
+  min-height: 0;
+  max-height: 100%;
+  overflow: auto;
+  white-space: pre;
+}
+#thread-panel .resume-command { flex: 0 0 auto; }
+#thread-panel > summary { gap: 10px; }
+#thread-panel > summary .panel-summary-copy { margin-right: auto; }
+.micro-manage-toggle {
+  display: inline-flex;
+  align-items: center;
+  justify-content: center;
+  gap: 8px;
+  flex-shrink: 0;
+  min-height: 36px;
+  border: 0;
+  background: transparent;
+  color: var(--text);
+  font: inherit;
+  font-size: 12px;
+  cursor: pointer;
+  white-space: nowrap;
+}
+.micro-manage-toggle[hidden] { display: none; }
+.micro-switch-track { width: 30px; height: 18px; border: 1px solid var(--muted); border-radius: 12px; background: var(--line); }
+.micro-switch-track::after { content: ''; display: block; width: 12px; height: 12px; margin: 2px; border-radius: 50%; background: var(--muted); }
+.micro-manage-toggle[aria-checked="true"] .micro-switch-track { background: var(--accent); border-color: var(--accent); }
+.micro-manage-toggle[aria-checked="true"] .micro-switch-track::after { transform: translateX(12px); background: white; }
+.micro-manage-toggle:focus-visible, .micro-return:focus-visible { outline: 2px solid var(--accent); outline-offset: 2px; }
+.micro-activity-state, .micro-return { margin: 0 16px 12px; color: var(--text); }
+.micro-return { align-self: flex-start; padding: 6px 10px; border: 1px solid var(--line); border-radius: 6px; background: var(--panel); cursor: pointer; }
+@media (max-width: 480px) {
+  #thread-panel > summary { flex-wrap: wrap; }
+  #thread-panel > summary .conversation-focus-btn { order: 1; margin-left: auto; }
+  #thread-panel > summary .micro-manage-toggle { margin-left: auto; }
+}
+
+/* Support stack: coaching controls. It sizes to its content and
    never grows past it, so the thread keeps the spare real estate. Each open body
    has a viewport-relative cap and scrolls internally, so it shows more on bigger
    screens (and far more than the old 1-line peek) without crowding the thread. */
@@ -4537,6 +4596,12 @@ body.hub-shell { display: flex; flex-direction: column; height: 100vh; overflow:
   }
 }
 
+@media (max-width: 820px) {
+  .workspace-conv #thread-panel[open] { max-height: none; }
+  .workspace-conv #thread-panel[open] .manage-body { height: clamp(180px, 36vh, 320px); flex: none; }
+  .workspace-conv #thread-panel[open] .manage-body #messages { flex: 1 1 0; height: auto; max-height: none; }
+}
+
 /* Review surfaces */
 .completion-card { background: var(--surface); border: 1px solid var(--line); border-radius: 12px; padding: 14px 16px; margin-bottom: 8px; }
 .completion-card .cc-title { font-weight: 700; margin-bottom: 6px; font-size: 14px; }