fraim-hub 2.0.305 → 2.0.307

package/dist/src/ai-hub/cert-store.js

@@ -3,6 +3,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
+exports._internal = void 0;
 exports.certPaths = certPaths;
 exports.loadOrCreateCert = loadOrCreateCert;
 exports.trustCert = trustCert;
@@ -49,6 +50,15 @@ async function loadOrCreateCert() {
     // HTTPS loopback certificate to be trusted before it can render the task pane.
     return { key: pem.private, cert: pem.cert };
 }
+/**
+ * Test seam (issue #1589): the real OS command invocation goes through this mutable,
+ * module-owned indirection point instead of a bare `spawnSync` call, so a test can swap in
+ * a fake implementation and assert on the exact command/arguments `trustCert()`/`untrustCert()`
+ * would invoke, without spawning a process, touching PATH, or mutating the real trust store.
+ * Swapping the export on Node's built-in `child_process` module itself is not reliable for
+ * this (confirmed empirically while fixing this issue) - this repo-owned seam is.
+ */
+exports._internal = { spawnSync: child_process_1.spawnSync };
 /**
  * Installs the cert as a trusted root CA in the user's OS certificate store.
  * ONLY call this for explicit Word-Online support — it prompts a Windows security
@@ -59,7 +69,7 @@ async function loadOrCreateCert() {
  */
 function trustCert(certPath) {
     if (process.platform === 'win32') {
-        const result = (0, child_process_1.spawnSync)('certutil', ['-addstore', '-user', 'Root', certPath], { encoding: 'utf8' });
+        const result = exports._internal.spawnSync('certutil', ['-addstore', '-user', 'Root', certPath], { encoding: 'utf8' });
         if (result.status !== 0) {
             console.warn('[fraim] could not trust localhost certificate:', result.stderr || result.stdout);
         }
@@ -67,17 +77,17 @@ function trustCert(certPath) {
     }
     if (process.platform === 'darwin') {
         const keychain = path_1.default.join(os_1.default.homedir(), 'Library', 'Keychains', 'login.keychain-db');
-        (0, child_process_1.spawnSync)('security', ['add-trusted-cert', '-r', 'trustRoot', '-k', keychain, certPath], { stdio: 'ignore' });
+        exports._internal.spawnSync('security', ['add-trusted-cert', '-r', 'trustRoot', '-k', keychain, certPath], { stdio: 'ignore' });
     }
 }
 /** Removes a specific cert from the trust store, by fingerprint. Test-only helper. */
 function untrustCert(fingerprint) {
     if (process.platform === 'win32') {
-        (0, child_process_1.spawnSync)('certutil', ['-delstore', '-user', 'Root', fingerprint], { encoding: 'utf8' });
+        exports._internal.spawnSync('certutil', ['-delstore', '-user', 'Root', fingerprint], { encoding: 'utf8' });
         return;
     }
     if (process.platform === 'darwin') {
-        (0, child_process_1.spawnSync)('security', ['delete-certificate', '-Z', fingerprint], { stdio: 'ignore' });
+        exports._internal.spawnSync('security', ['delete-certificate', '-Z', fingerprint], { stdio: 'ignore' });
     }
 }
 /**

package/dist/src/ai-hub/hosts.js

@@ -495,6 +495,8 @@ function readAgentFromArgs(args) {
 function readToolName(candidate) {
     if (typeof candidate.name === 'string')
         return candidate.name;
+    if (typeof candidate.mcpToolName === 'string')
+        return candidate.mcpToolName;
     if (typeof candidate.tool_name === 'string')
         return candidate.tool_name;
     if (typeof candidate.tool === 'string')
@@ -591,6 +593,118 @@ function normalizeToolArgs(rawArgs) {
     }
     return null;
 }
+function stringifyMentorCallArgs(rawArgs) {
+    const args = normalizeToolArgs(rawArgs);
+    if (!args)
+        return null;
+    return JSON.stringify(args, null, 2);
+}
+function resultTextFromValue(value) {
+    if (typeof value === 'string')
+        return value.trim() || null;
+    if (Array.isArray(value)) {
+        const parts = value
+            .map((entry) => resultTextFromValue(entry))
+            .filter((entry) => Boolean(entry));
+        return parts.length > 0 ? parts.join('\n') : null;
+    }
+    if (!value || typeof value !== 'object')
+        return null;
+    const record = value;
+    for (const key of ['text', 'message', 'output', 'result', 'content']) {
+        const text = resultTextFromValue(record[key]);
+        if (text)
+            return text;
+    }
+    return null;
+}
+function microEventFromToolCall(candidate) {
+    if (!isFraimTool(readToolName(candidate), 'seekMentoring'))
+        return undefined;
+    const text = stringifyMentorCallArgs(candidate.input || candidate.arguments || candidate.parameters);
+    return text ? [{ kind: 'mentor_call', text }] : undefined;
+}
+function microEventFromToolResult(candidate) {
+    if (!isFraimTool(readToolName(candidate), 'seekMentoring'))
+        return undefined;
+    const text = resultTextFromValue(candidate.result ?? candidate.output ?? candidate.content ?? candidate.message);
+    return text ? [{ kind: 'mentor_reply', text }] : undefined;
+}
+function readToolUseId(candidate) {
+    return stringValue(candidate.id) || stringValue(candidate.tool_use_id) || stringValue(candidate.toolUseId);
+}
+function parseMicroEventsSignal(line) {
+    let parsed;
+    try {
+        parsed = JSON.parse(line);
+    }
+    catch {
+        return {};
+    }
+    if (!parsed || typeof parsed !== 'object')
+        return {};
+    const root = parsed;
+    const events = [];
+    const mentorToolUseIds = [];
+    const mentorToolResults = [];
+    const item = root.item && typeof root.item === 'object' ? root.item : null;
+    if (item && item.type === 'mcp_tool_call' && isFraimTool(readToolName(item), 'seekMentoring')) {
+        const rootType = typeof root.type === 'string' ? root.type : '';
+        const argsText = stringifyMentorCallArgs(item.arguments);
+        if (argsText && rootType !== 'item.completed')
+            events.push({ kind: 'mentor_call', text: argsText });
+        const replyText = resultTextFromValue(item.result);
+        if (replyText)
+            events.push({ kind: 'mentor_reply', text: replyText });
+    }
+    const data = root.data && typeof root.data === 'object' ? root.data : null;
+    if (data && isFraimTool(readToolName(data), 'seekMentoring')) {
+        if (root.type === 'tool.execution_start') {
+            const argsText = stringifyMentorCallArgs(data.arguments ?? data.input ?? data.parameters);
+            if (argsText)
+                events.push({ kind: 'mentor_call', text: argsText });
+        }
+        if (root.type === 'tool.execution_complete' || root.type === 'model.tool_execution') {
+            const replyText = resultTextFromValue(data.result ?? data.output ?? data.content);
+            if (replyText)
+                events.push({ kind: 'mentor_reply', text: replyText });
+        }
+    }
+    const contents = [];
+    if (Array.isArray(root.content))
+        contents.push(...root.content.filter((entry) => !!entry && typeof entry === 'object' && !Array.isArray(entry)));
+    const message = root.message && typeof root.message === 'object' ? root.message : null;
+    if (message && Array.isArray(message.content))
+        contents.push(...message.content.filter((entry) => !!entry && typeof entry === 'object' && !Array.isArray(entry)));
+    for (const content of contents) {
+        if (content.type === 'tool_use' || content.type === 'function_call') {
+            const call = microEventFromToolCall(content);
+            if (call) {
+                events.push(...call);
+                const id = readToolUseId(content);
+                if (id)
+                    mentorToolUseIds.push(id);
+            }
+        }
+        if (content.type === 'tool_result') {
+            const reply = microEventFromToolResult(content);
+            if (reply) {
+                events.push(...reply);
+            }
+            else {
+                const toolUseId = readToolUseId(content);
+                const text = resultTextFromValue(content.result ?? content.output ?? content.content ?? content.message);
+                if (toolUseId && text)
+                    mentorToolResults.push({ toolUseId, text });
+            }
+        }
+    }
+    return {
+        ...(events.length > 0 ? { microEvents: events } : {}),
+        ...(mentorToolUseIds.length > 0 ? { mentorToolUseIds } : {}),
+        ...(mentorToolResults.length > 0 ? { mentorToolResults } : {}),
+    };
+}
 function numberOrNull(v) {
     return typeof v === 'number' && Number.isFinite(v) ? v : null;
 }
@@ -627,6 +741,10 @@ function extractSignalFromArgs(args) {
     const reviewHandoff = extractReviewHandoffFromArgs(args);
     const delegationLedger = extractDelegationLedgerFromArgs(args);
     const nextJobRecommendations = extractNextJobRecommendationsFromArgs(args);
+    const deliveryActionId = readNullableString(evidenceArgs?.deliveryActionId);
+    const completedDeliveryActionId = readNullableString(evidenceArgs?.completedDeliveryActionId);
+    const selectedReviewAction = readReviewActionCandidate(evidenceArgs?.selectedReviewAction);
+    const deliveryActionResult = readDeliveryActionResultCandidate(evidenceArgs?.deliveryActionResult);
     return {
         phaseId,
         phaseStatus,
@@ -638,6 +756,64 @@ function extractSignalFromArgs(args) {
         ...(reviewHandoff ? { reviewHandoff } : {}),
         ...(delegationLedger ? { delegationLedger } : {}),
         ...(nextJobRecommendations ? { nextJobRecommendations } : {}),
+        ...(deliveryActionId !== undefined ? { deliveryActionId } : {}),
+        ...(selectedReviewAction !== undefined ? { selectedReviewAction } : {}),
+        ...(completedDeliveryActionId !== undefined ? { completedDeliveryActionId } : {}),
+        ...(deliveryActionResult ? { deliveryActionResult } : {}),
+    };
+}
+function readNullableString(value) {
+    if (value === null)
+        return null;
+    if (typeof value !== 'string')
+        return undefined;
+    const trimmed = value.trim();
+    return trimmed.length > 0 ? trimmed : null;
+}
+function readReviewActionCandidate(value) {
+    if (value === null)
+        return null;
+    if (!value || typeof value !== 'object' || Array.isArray(value))
+        return undefined;
+    const action = value;
+    const id = typeof action.id === 'string' && action.id.trim().length > 0 ? action.id.trim() : '';
+    const label = typeof action.label === 'string' && action.label.trim().length > 0 ? action.label.trim() : '';
+    const kind = typeof action.kind === 'string' && action.kind.trim().length > 0 ? action.kind.trim() : '';
+    if (!id || !label || !kind)
+        return undefined;
+    const target = action.target && typeof action.target === 'object' && !Array.isArray(action.target)
+        ? action.target
+        : undefined;
+    return {
+        id,
+        label,
+        kind,
+        ...(typeof action.style === 'string' ? { style: action.style } : {}),
+        ...(typeof action.deliveryActionId === 'string' && action.deliveryActionId.trim().length > 0 ? { deliveryActionId: action.deliveryActionId.trim() } : {}),
+        ...(typeof action.description === 'string' ? { description: action.description } : {}),
+        ...(target ? { target } : {}),
+    };
+}
+function readDeliveryActionResultCandidate(value) {
+    if (!value || typeof value !== 'object' || Array.isArray(value))
+        return null;
+    const result = value;
+    const actionId = typeof result.actionId === 'string' && result.actionId.trim().length > 0
+        ? result.actionId.trim()
+        : typeof result.deliveryActionId === 'string' && result.deliveryActionId.trim().length > 0
+            ? result.deliveryActionId.trim()
+            : '';
+    if (!actionId)
+        return null;
+    return {
+        actionId,
+        ...(typeof result.prNumber === 'number' && Number.isFinite(result.prNumber) ? { prNumber: result.prNumber } : {}),
+        ...(typeof result.pushed === 'boolean' ? { pushed: result.pushed } : {}),
+        ...(typeof result.merged === 'boolean' ? { merged: result.merged } : {}),
+        ...(typeof result.defaultBranchVerified === 'boolean' ? { defaultBranchVerified: result.defaultBranchVerified } : {}),
+        ...(typeof result.issueClosed === 'boolean' ? { issueClosed: result.issueClosed } : {}),
+        ...(typeof result.branchCleaned === 'boolean' ? { branchCleaned: result.branchCleaned } : {}),
+        ...(typeof result.domainActionCompleted === 'boolean' ? { domainActionCompleted: result.domainActionCompleted } : {}),
     };
 }
 function extractDelegationLedgerFromArgs(args) {
@@ -1808,11 +1984,15 @@ function parseHostLine(hostId, line) {
     const usage = parseUsageSignal(trimmed);
     const agentIdentity = parseAgentIdentitySignal(trimmed);
     const recurringPark = parseRecurringParkSignal(trimmed);
+    const microSignals = parseMicroEventsSignal(trimmed);
+    const microEvents = microSignals.microEvents;
+    const mentorToolUseIds = microSignals.mentorToolUseIds;
+    const mentorToolResults = microSignals.mentorToolResults;
     // Issue #1264 (R3): only worth checking when seekMentoring itself did not
     // already resolve — a recognized call has nothing to diagnose.
     const unrecognizedReviewHandoffError = seekMentoring ? null : detectUnrecognizedReviewHandoffCall(trimmed);
     const withSignal = (event) => {
-        if (!seekMentoring && !fraimJob && !executionMode && !usage && !agentIdentity && !recurringPark && !unrecognizedReviewHandoffError)
+        if (!seekMentoring && !fraimJob && !executionMode && !usage && !agentIdentity && !recurringPark && !microEvents && !mentorToolUseIds && !mentorToolResults && !unrecognizedReviewHandoffError)
             return event;
         return {
             ...event,
@@ -1822,6 +2002,9 @@ function parseHostLine(hostId, line) {
             ...(usage ? { usage } : {}),
             ...(agentIdentity ? { agentIdentity } : {}),
             ...(recurringPark ? { recurringPark: true } : {}),
+            ...(microEvents ? { microEvents } : {}),
+            ...(mentorToolUseIds ? { mentorToolUseIds } : {}),
+            ...(mentorToolResults ? { mentorToolResults } : {}),
             ...(unrecognizedReviewHandoffError && !event.hostError ? { hostError: unrecognizedReviewHandoffError } : {}),
         };
     };

package/dist/src/ai-hub/office-sideload.js

@@ -22,6 +22,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
+exports._internal = exports.WEF_DEVELOPER_KEY = void 0;
 exports.manifestXmlForPort = manifestXmlForPort;
 exports.shouldSkipSideloadForFlag = shouldSkipSideloadForFlag;
 exports.winDeveloperManifestSubkey = winDeveloperManifestSubkey;
@@ -32,7 +33,7 @@ const fs_1 = __importDefault(require("fs"));
 const path_1 = __importDefault(require("path"));
 const os_1 = __importDefault(require("os"));
 const child_process_1 = require("child_process");
-const WEF_DEVELOPER_KEY = 'HKCU\\SOFTWARE\\Microsoft\\Office\\16.0\\WEF\\Developer';
+exports.WEF_DEVELOPER_KEY = 'HKCU\\SOFTWARE\\Microsoft\\Office\\16.0\\WEF\\Developer';
 const MANIFESTS = [
     {
         guid: 'd1090951-50cf-4cf2-9d12-b0f8541d265c',
@@ -93,7 +94,7 @@ function prepareManifestForSideload(entry, sourcePath, options) {
 // Windows registry helpers
 // ---------------------------------------------------------------------------
 function winDeveloperManifestSubkey(guid) {
-    return `${WEF_DEVELOPER_KEY}\\{${guid}}`;
+    return `${exports.WEF_DEVELOPER_KEY}\\{${guid}}`;
 }
 function parseRegSzValue(stdout) {
     const line = stdout.split(/\r?\n/).find(l => l.includes('REG_SZ'));
@@ -103,7 +104,7 @@ function parseRegSzValue(stdout) {
     return line.slice(idx + 'REG_SZ'.length).trim() || null;
 }
 function winRegisteredRootValue(guid) {
-    const r = (0, child_process_1.spawnSync)('reg', ['query', WEF_DEVELOPER_KEY, '/v', guid], { encoding: 'utf8' });
+    const r = (0, child_process_1.spawnSync)('reg', ['query', exports.WEF_DEVELOPER_KEY, '/v', guid], { encoding: 'utf8' });
     if (r.status !== 0 || !r.stdout.includes('REG_SZ'))
         return null;
     // Output line looks like: "    <guid>    REG_SZ    C:\path\to\manifest.xml"
@@ -122,14 +123,21 @@ function winRegisteredValue(guid) {
     // but treat the root value as the effective discovery registration.
     return winRegisteredRootValue(guid) ?? winRegisteredDefaultValue(guid);
 }
+/**
+ * Test seam (issue #1589): the registry-write invocations go through this mutable,
+ * module-owned indirection point instead of a bare `spawnSync` call, so a test can swap in a
+ * fake implementation and assert on the exact `reg` command/arguments `sideloadManifest()`
+ * would invoke, without spawning a process, touching PATH, or mutating the real registry.
+ */
+exports._internal = { spawnSync: child_process_1.spawnSync };
 function winWriteRegisteredValue(guid, manifestPath) {
-    const root = (0, child_process_1.spawnSync)('reg', [
-        'add', WEF_DEVELOPER_KEY,
+    const root = exports._internal.spawnSync('reg', [
+        'add', exports.WEF_DEVELOPER_KEY,
         '/v', guid, '/t', 'REG_SZ', '/d', manifestPath, '/f',
     ], { encoding: 'utf8' });
     if (root.status !== 0)
         return { ok: false, reason: root.stderr || `reg add failed for ${guid}` };
-    const r = (0, child_process_1.spawnSync)('reg', [
+    const r = exports._internal.spawnSync('reg', [
         'add', winDeveloperManifestSubkey(guid),
         '/ve', '/t', 'REG_SZ', '/d', manifestPath, '/f',
     ], { encoding: 'utf8' });
@@ -137,7 +145,7 @@ function winWriteRegisteredValue(guid, manifestPath) {
         return { ok: false, reason: r.stderr || `reg add failed for ${guid}` };
     // Remove an accidental unbraced subkey left by older debugger settings. This
     // is different from the root named value above, which Word needs.
-    (0, child_process_1.spawnSync)('reg', ['delete', `${WEF_DEVELOPER_KEY}\\${guid}`, '/f'], { encoding: 'utf8' });
+    exports._internal.spawnSync('reg', ['delete', `${exports.WEF_DEVELOPER_KEY}\\${guid}`, '/f'], { encoding: 'utf8' });
     return { ok: true };
 }
 // ---------------------------------------------------------------------------
@@ -195,8 +203,8 @@ function sideloadManifest(projectPath, options = {}) {
 function removeSideload() {
     for (const entry of MANIFESTS) {
         if (process.platform === 'win32') {
-            (0, child_process_1.spawnSync)('reg', ['delete', WEF_DEVELOPER_KEY, '/v', entry.guid, '/f'], { encoding: 'utf8' });
-            (0, child_process_1.spawnSync)('reg', ['delete', `${WEF_DEVELOPER_KEY}\\${entry.guid}`, '/f'], { encoding: 'utf8' });
+            (0, child_process_1.spawnSync)('reg', ['delete', exports.WEF_DEVELOPER_KEY, '/v', entry.guid, '/f'], { encoding: 'utf8' });
+            (0, child_process_1.spawnSync)('reg', ['delete', `${exports.WEF_DEVELOPER_KEY}\\${entry.guid}`, '/f'], { encoding: 'utf8' });
             (0, child_process_1.spawnSync)('reg', ['delete', winDeveloperManifestSubkey(entry.guid), '/f'], { encoding: 'utf8' });
         }
         else if (process.platform === 'darwin') {