fraim-framework 2.0.67 → 2.0.69

package/dist/registry/ai-manager-rules/shared-phases/address-pr-feedback.md

@@ -1,188 +0,0 @@
-# Phase: address-pr-feedback
-
-## INTENT
-To systematically address all PR feedback items by making targeted changes, replying to comments, and preparing for re-validation.
-
-## OUTCOME
-All PR feedback addressed with:
-- Targeted changes made for each feedback item
-- Feedback file updated with resolutions
-- PR comments replied to with explanations
-- Changes validated and ready for re-review
-
-## RULES FOR THIS PHASE
-
-### Success Criteria
-Read `registry/rules/agent-success-criteria.md` via `get_fraim_file` for the complete framework. Focus especially on:
-- **Integrity** (document all changes made)
-- **Correctness** (address feedback accurately)
-- **Completeness** (address every UNADDRESSED item)
-
-### Simplicity Principles
-Read `registry/rules/simplicity.md` via `get_fraim_file` for complete guidelines. Critical for feedback phase:
-- **Targeted Changes**: Make minimal changes to address specific feedback
-- **Manual Validation**: Test changes manually before updating PR
-- **Clear Communication**: Reply to each comment with clear explanations
-
-## PRINCIPLES
-- **Feedback-Driven**: Address only the specific issues raised in PR comments
-- **Minimal Changes**: Avoid scope creep or unnecessary refactoring
-- **Clear Communication**: Explain resolutions clearly to reviewers
-- **Validation**: Ensure changes work before updating PR
-
-## 📋 WORKFLOW
-
-### Step 1: Read PR Feedback File
-
-**MANDATORY**: Read the feedback file created by `wait-for-pr-review`:
-- File location: `docs/evidence/{issue_number}-{workflow_type}-feedback.md`
-- Identify all UNADDRESSED feedback items
-- Understand the context and requirements for each item
-
-### Step 2: Address Each Feedback Item
-
-**For each UNADDRESSED item:**
-
-1. **Understand the Feedback**:
-   - Read the comment carefully
-   - Identify what specific change is requested
-   - Determine the scope of the change needed
-
-2. **Make Targeted Changes**:
-   - Make minimal, focused changes to address the specific feedback
-   - Avoid unrelated changes or improvements
-   - Keep changes as small as possible while fully addressing the feedback
-
-3. **Update Feedback File**:
-   - Change status from UNADDRESSED to ADDRESSED
-   - Document your resolution approach
-   - Include details of what you changed
-
-**Feedback File Update Format**:
-```markdown
-### Comment X - ADDRESSED
-- **Author**: reviewer_name
-- **Type**: pr_comment|review_comment|review
-- **File**: file_path (if applicable)
-- **Line**: line_number (if applicable)
-- **Comment**: Original feedback text
-- **Status**: ADDRESSED
-- **Resolution**: Detailed explanation of how you addressed this feedback
-- **Changes Made**: Specific files/lines modified
-```
-
-### Step 3: Validate Changes
-
-**Test your changes:**
-- Run compilation check: `npx tsc --noEmit --skipLibCheck`
-- Run relevant tests to ensure no regressions
-- Test manually if the feedback involves UI/API behavior
-- Verify the specific issue mentioned in feedback is resolved
-
-### Step 4: Reply to PR Comments
-
-**For each addressed comment:**
-- Reply to the original PR comment
-- Explain what you changed and how it addresses their concern
-- Reference specific files/lines if helpful
-- Be clear and professional in your communication
-
-**Example reply format**:
-```
-✅ **Addressed**: [Brief description of what you changed]
-
-**Changes made**:
-- [Specific change 1]
-- [Specific change 2]
-
-**Files modified**: `path/to/file.ts`, `path/to/test.ts`
-
-This should resolve the [specific issue mentioned]. Please let me know if you need any clarification!
-```
-
-### Step 5: Commit and Push Changes
-
-**Commit your changes:**
-- Use clear commit messages that reference the feedback
-- Example: `Address PR feedback: Fix error handling in auth service`
-- Push changes to the PR branch
-
-## 📸 EVIDENCE REQUIREMENTS
-
-You MUST provide concrete evidence for all claims:
-
-1. **All Feedback Addressed**: Every UNADDRESSED item in feedback file is now ADDRESSED
-2. **Changes Made**: Specific code changes made for each feedback item
-3. **Validation Complete**: Tests pass and changes work as expected
-4. **PR Updated**: Changes committed, pushed, and comments replied to
-
-## VALIDATION
-
-### Phase Complete When:
-- ✅ All UNADDRESSED items in feedback file are now ADDRESSED
-- ✅ Feedback file updated with resolution details for each item
-- ✅ Targeted changes made to address each specific feedback
-- ✅ Changes validated (compilation, tests, manual testing)
-- ✅ PR comments replied to with clear explanations
-- ✅ Changes committed and pushed to PR branch
-
-### Phase Incomplete If:
-- ❌ Any UNADDRESSED items remain in feedback file
-- ❌ Changes don't actually address the feedback given
-- ❌ Tests failing after changes
-- ❌ Compilation errors introduced
-- ❌ PR comments not replied to
-- ❌ Changes not committed/pushed
-
-### Report Back:
-When you complete this phase, call:
-
-```javascript
-seekMentoring({
-  workflowType: "{workflow_type}",
-  issueNumber: "{issue_number}",
-  currentPhase: "address-pr-feedback",
-  status: "complete",
-  findings: {
-    feedbackItemsAddressed: {total_items_addressed},
-    changesValidated: true
-  },
-  evidence: {
-    feedbackFileUpdated: "All UNADDRESSED items now ADDRESSED with resolutions",
-    changesMade: "Brief summary of changes made",
-    validationResults: "Compilation and tests pass",
-    prCommentsReplied: "Replied to all PR comments with explanations"
-  }
-})
-```
-
-If feedback addressing incomplete, iterate:
-```javascript
-seekMentoring({
-  workflowType: "{workflow_type}",
-  issueNumber: "{issue_number}",
-  currentPhase: "address-pr-feedback",
-  status: "incomplete",
-  findings: {
-    uncertainties: ["Issues encountered", "What needs to be fixed"]
-  }
-})
-```
-
-## SCRIPTS
-
-**Compile TypeScript:**
-```bash
-npx tsc --noEmit --skipLibCheck
-```
-
-**Run tests:**
-```bash
-npm test
-```
-
-**Check git status:**
-```bash
-git status
-git diff
-```

package/dist/registry/ai-manager-rules/shared-phases/finalize.md

@@ -1,169 +0,0 @@
-# Phase: Finalize
-
-## INTENT
-To prepare completed work for human review by setting proper labels, creating/updating PR, and documenting evidence.
-
-## OUTCOME
-Work is ready for human review with:
-- Proper issue labels applied
-- PR created/updated with work
-- Evidence documented
-- Clean handoff to next phase or review
-
-## PRINCIPLES
-- **Complete Documentation**: Evidence shows all work done
-- **Proper Labels**: Issue status reflects readiness
-- **Clear Communication**: PR and evidence are clear
-- **Ready for Review**: No blockers for human reviewer
-
-## RULES FOR THIS PHASE
-
-### Success Criteria
-Read `registry/rules/agent-success-criteria.md` via `get_fraim_file` for the complete framework. Focus on:
-- **Integrity** (honest documentation of all work completed)
-- **Completeness** (all finalization steps completed)
-
-### Simplicity Principles
-Read `registry/rules/simplicity.md` via `get_fraim_file` for complete guidelines. Key for finalization:
-- **Focus on the assigned issue only** - document only relevant work
-- **Clear communication** - evidence should be easy to understand
-
-### Git Operations (if needed)
-When using git commands directly (if MCP tools unavailable), read `registry/rules/git-safe-commands.md` via `get_fraim_file` to avoid interactive commands that hang agents.
-
-## WORKFLOW
-
-### Step 1: Update Issue Labels
-
-**Remove:**
-- `status:wip`
-- Any phase-specific labels (e.g., `phase:spec`, `phase:design`, `phase:impl`)
-
-**Add:**
-- `status:needs-review`
-
-**GitHub Repository Context:**
-Read `.fraim/config.json` for:
-- `git.repoOwner` - GitHub repository owner
-- `git.repoName` - GitHub repository name
-
-Use GitHub MCP tools to update labels.
-
-### Step 2: Create Evidence Document
-
-**File location:**
-```
-docs/evidence/{issue_number}-{workflow_type}-evidence.md
-```
-
-**Evidence document should include:**
-
-#### Summary
-- Issue number and title
-- Workflow type (spec, design, implement, test)
-- Brief description of work completed
-
-#### Work Completed
-**For Spec Workflow:**
-- Specification document created
-- High-fidelity HTML mocks (if UI changes)
-- Requirements coverage
-
-**For Design Workflow:**
-- Technical design document
-- Architecture decisions
-- API specifications
-- Database schema (if applicable)
-
-**For Implement Workflow:**
-- Implementation details
-- Key files changed
-- Approach taken
-- Testing completed
-
-**For Test Workflow:**
-- Test suite created/enhanced
-- Coverage metrics
-- Test results
-
-#### Validation
-- How work was validated
-- Validation results
-- Screenshots/output (if applicable)
-
-#### Quality Checks
-- All deliverables complete
-- Documentation clear and professional
-- Work ready for next phase or review
-
-#### Phase Completion
-- All phases completed for this workflow
-- Evidence from each phase
-- Any iterations or challenges
-
-### Step 3: Verify PR Exists
-
-**Verify PR:**
-- PR exists for the feature branch
-- PR title reflects the issue and workflow
-- PR description includes context and links to deliverables
-
-**If PR doesn't exist:**
-- Create PR manually
-- Link to issue
-- Add evidence document link
-
-### Step 4: Add PR Comment
-
-Add comment to PR with link to evidence:
-```
-{Workflow_type} workflow complete. Evidence document: docs/evidence/{issue_number}-{workflow_type}-evidence.md
-
-All phases completed:
-{workflow_specific_phases_checklist}
-
-Ready for human review.
-```
-
-### Step 5: Final Verification
-
-**Checklist:**
-- ✅ Issue labels updated
-- ✅ Evidence document created and complete
-- ✅ PR exists and is ready
-- ✅ PR comment added with evidence link
-- ✅ All deliverables complete
-- ✅ Git status clean
-
-## VALIDATION
-
-### Phase Complete When:
-- ✅ Issue has `status:needs-review` label
-- ✅ Issue does not have workflow phase labels
-- ✅ Evidence document exists and is complete
-- ✅ PR exists and is ready for review
-- ✅ PR has comment linking to evidence
-- ✅ All previous phases complete
-
-### Phase Incomplete If:
-- ❌ Labels not updated
-- ❌ Evidence document missing or incomplete
-- ❌ PR not ready
-- ❌ Previous phases not complete
-
-### Report Back:
-```javascript
-seekCoachingOnNextStep({
-  workflowType: "{workflow_type}",
-  issueNumber: "{issue_number}",
-  currentPhase: "finalize", 
-  status: "complete",
-  evidence: {
-    labelsUpdated: "Issue has status:needs-review label",
-    evidenceDocument: "docs/evidence/{issue_number}-{workflow_type}-evidence.md created",
-    prStatus: "PR ready for review",
-    prComment: "PR comment added with evidence link",
-    allPhasesComplete: "All {workflow_type} phases completed successfully"
-  }
-})
-```

package/dist/registry/ai-manager-rules/shared-phases/submit-pr.md

@@ -1,202 +0,0 @@
-# Phase: submit-pr
-
-## INTENT
-To submit completed work for review by creating/updating PR, setting proper labels, and documenting evidence.
-
-## OUTCOME
-Work is submitted for review with:
-- PR created/updated with work
-- Proper issue labels applied
-- Evidence documented
-- Ready to enter PR review phase
-
-## PRINCIPLES
-- **Complete Documentation**: Evidence shows all work done
-- **Proper Labels**: Issue status reflects PR submission
-- **Clear Communication**: PR and evidence are clear
-- **Ready for Review**: No blockers for PR review process
-
-## RULES FOR THIS PHASE
-
-### Success Criteria
-Read `registry/rules/agent-success-criteria.md` via `get_fraim_file` for the complete framework. Focus on:
-- **Integrity** (honest documentation of all work completed)
-- **Completeness** (all finalization steps completed)
-
-### Simplicity Principles
-Read `registry/rules/simplicity.md` via `get_fraim_file` for complete guidelines. Key for finalization:
-- **Focus on the assigned issue only** - document only relevant work
-- **Clear communication** - evidence should be easy to understand
-
-### Git Operations (if needed)
-When using git commands directly (if MCP tools unavailable), read `rules/git-safe-commands.md` via `get_fraim_file` to avoid interactive commands that hang agents.
-
-## WORKFLOW
-
-### Step 1: Create Evidence Document
-
-**File location:**
-```
-docs/evidence/{issue_number}-{workflow_type}-evidence.md
-```
-
-**Evidence document should include:**
-
-#### Summary
-- Issue number and title
-- Workflow type (spec, design, implement, test)
-- Brief description of work completed
-
-#### Work Completed
-**For Spec Workflow:**
-- Specification document created
-- High-fidelity HTML mocks (if UI changes)
-- Requirements coverage
-
-**For Design Workflow:**
-- Technical design document
-- Architecture decisions
-- API specifications
-- Database schema (if applicable)
-
-**For Implement Workflow:**
-- Implementation details
-- Key files changed
-- Approach taken
-- Testing completed
-
-**For Test Workflow:**
-- Test suite created/enhanced
-- Coverage metrics
-- Test results
-
-#### PR Feedback History (if applicable)
-**CRITICAL**: If PR feedback file exists (`docs/evidence/{issue_number}-{workflow_type}-feedback.md`), include its complete contents in the evidence document under this section.
-
-This shows reviewers:
-- All previous feedback received
-- How each item was addressed
-- Complete audit trail of review iterations
-
-#### Validation
-- How work was validated
-- Validation results
-- Screenshots/output (if applicable)
-
-#### Quality Checks
-- All deliverables complete
-- Documentation clear and professional
-- Work ready for next phase or review
-
-#### Phase Completion
-- All phases completed for this workflow
-- Evidence from each phase
-- Any iterations or challenges
-
-### Step 2: Commit and Sync Work
-
-**Commit all changes:**
-- Stage all modified files
-- Create commit with descriptive message
-- Push to feature branch
-
-**Commit message format:**
-```
-{workflow_type}({issue_number}): complete {phase_name} phase
-
-- Evidence document created
-- All deliverables complete
-- Ready for review
-```
-
-### Step 3: Verify PR Exists
-
-**Verify PR:**
-- PR exists for the feature branch
-- PR title reflects the issue and workflow
-- PR description includes context and links to deliverables
-
-**If PR doesn't exist:**
-- Create PR manually
-- Link to issue
-- Add evidence document link
-
-### Step 4: Add PR Comment
-
-Add comment to PR with link to evidence:
-```
-{Workflow_type} workflow complete. Evidence document: docs/evidence/{issue_number}-{workflow_type}-evidence.md
-
-All phases completed:
-{workflow_specific_phases_checklist}
-
-**PR Feedback History**: 
-{If feedback file exists, include: "This submission addresses all feedback from previous review rounds. See evidence document for complete feedback history and resolutions."}
-
-Ready for human review.
-```
-
-### Step 5: Update Issue Labels
-
-**Remove:**
-- `status:wip`
-
-**Add:**
-- `status:needs-review`
-
-**Keep:**
-- Current phase label (e.g., `phase:spec`, `phase:design`, `phase:impl`) to indicate which phase is in PR
-
-**GitHub Repository Context:**
-Read `.fraim/config.json` for:
-- `git.repoOwner` - GitHub repository owner
-- `git.repoName` - GitHub repository name
-
-Use GitHub MCP tools to update labels.
-
-### Step 6: Final Verification
-
-**Checklist:**
-- ✅ Issue labels updated (kept phase label, added needs-review)
-- ✅ Evidence document created and complete
-- ✅ All work committed and pushed to feature branch
-- ✅ PR exists and is ready
-- ✅ PR comment added with evidence link
-- ✅ All deliverables complete
-- ✅ Git status clean
-
-## VALIDATION
-
-### Phase Complete When:
-- ✅ Issue has `status:needs-review` label
-- ✅ Issue keeps current phase label to indicate what needs review
-- ✅ Evidence document exists and is complete
-- ✅ All work committed and synced to remote
-- ✅ PR exists and is ready for review
-- ✅ PR has comment linking to evidence
-- ✅ All previous phases complete
-
-### Phase Incomplete If:
-- ❌ Labels not updated correctly
-- ❌ Evidence document missing or incomplete
-- ❌ Work not committed and synced
-- ❌ PR not ready
-- ❌ Previous phases not complete
-
-### Report Back:
-```javascript
-seekMentoring({
-  workflowType: "{workflow_type}",
-  issueNumber: "{issue_number}",
-  currentPhase: "submit-pr", 
-  status: "complete",
-  evidence: {
-    labelsUpdated: "Issue has status:needs-review and keeps phase label",
-    evidenceDocument: "docs/evidence/{issue_number}-{workflow_type}-evidence.md created",
-    workCommitted: "All changes committed and pushed to feature branch",
-    prStatus: "PR ready for review",
-    prComment: "PR comment added with evidence link",
-    allPhasesComplete: "All {workflow_type} phases completed successfully"
-  }
-})
-```