fraim-framework 2.0.36 → 2.0.38

package/registry/scripts/detect-tautological-tests.sh

@@ -1,38 +1,38 @@
-#!/bin/bash
-
-# Detect Tautological Tests
-# This script scans test files for patterns that suggest tests are validating code structure 
-# (interfaces, enums) rather than runtime behavior.
-
-echo "🔍 Scanning for Tautological Test Patterns..."
-ERROR_FOUND=0
-
-# Pattern 1: Asserting an array literal equals another array literal (common in enum testing)
-# Looks for: assert.deepEqual(['a', 'b'], ['a', 'b'])
-if grep -rE "assert\.(deep)?(Strict)?Equal\(\[.*\], \[.*\]\)" test*.ts; then
-    echo "❌ ERROR: Found potential tautological array comparison. Tests should verify app logic, not hardcoded arrays."
-    echo "   Rationale: Testing that ['A'] equals ['A'] validates nothing about the application."
-    ERROR_FOUND=1
-fi
-
-# Pattern 2: Asserting properties on an object literal defined in the test (Type/Interface testing)
-# Simplified: Look for defining a typed object and immediately asserting on it in the same file
-# This is hard to do robustly with just grep, so we'll rely on the Naming Convention check for now.
-
-# Pattern 3: Test names that explicitly say "Validate Enums", "Validate Fields", etc.
-# We match "Validate TaskStatus Enums" or similar phrases
-if grep -riE "['\"]Unit: Validate (Enum|Constant|Interface|Type|Field|Object|TaskStatus|Task Object)" test*.ts; then
-    echo "❌ ERROR: Found test descriptions explicitly claiming to validate Enums/Types/Fields."
-    echo "   Rationale: Unit tests should validate BEHAVIOR (e.g., 'persists correct status'), not definitions."
-    ERROR_FOUND=1
-fi
-
-if [ $ERROR_FOUND -eq 1 ]; then
-    echo ""
-    echo "⚠️  Potential Anti-Patterns Detected."
-    echo "   Please review the identified tests against rules/integrity-and-test-ethics.md"
-    exit 1
-else
-    echo "✅ No obvious tautological patterns found."
-    exit 0
-fi
+#!/bin/bash
+
+# Detect Tautological Tests
+# This script scans test files for patterns that suggest tests are validating code structure 
+# (interfaces, enums) rather than runtime behavior.
+
+echo "🔍 Scanning for Tautological Test Patterns..."
+ERROR_FOUND=0
+
+# Pattern 1: Asserting an array literal equals another array literal (common in enum testing)
+# Looks for: assert.deepEqual(['a', 'b'], ['a', 'b'])
+if grep -rE "assert\.(deep)?(Strict)?Equal\(\[.*\], \[.*\]\)" test*.ts; then
+    echo "❌ ERROR: Found potential tautological array comparison. Tests should verify app logic, not hardcoded arrays."
+    echo "   Rationale: Testing that ['A'] equals ['A'] validates nothing about the application."
+    ERROR_FOUND=1
+fi
+
+# Pattern 2: Asserting properties on an object literal defined in the test (Type/Interface testing)
+# Simplified: Look for defining a typed object and immediately asserting on it in the same file
+# This is hard to do robustly with just grep, so we'll rely on the Naming Convention check for now.
+
+# Pattern 3: Test names that explicitly say "Validate Enums", "Validate Fields", etc.
+# We match "Validate TaskStatus Enums" or similar phrases
+if grep -riE "['\"]Unit: Validate (Enum|Constant|Interface|Type|Field|Object|TaskStatus|Task Object)" test*.ts; then
+    echo "❌ ERROR: Found test descriptions explicitly claiming to validate Enums/Types/Fields."
+    echo "   Rationale: Unit tests should validate BEHAVIOR (e.g., 'persists correct status'), not definitions."
+    ERROR_FOUND=1
+fi
+
+if [ $ERROR_FOUND -eq 1 ]; then
+    echo ""
+    echo "⚠️  Potential Anti-Patterns Detected."
+    echo "   Please review the identified tests against rules/integrity-and-test-ethics.md"
+    exit 1
+else
+    echo "✅ No obvious tautological patterns found."
+    exit 0
+fi

package/registry/scripts/prep-issue.sh

@@ -134,6 +134,7 @@ try {
     
     // Support both 'repository' (new) and 'git' (legacy/current) schemas
     let repo = config.repository;
+    let defaultBranch = 'master'; // Default fallback
     
     if (!repo) {
         if (config.git) {
@@ -142,13 +143,18 @@ try {
                 name: config.git.repoName,
                 url: config.git.repoUrl || \`https://github.com/\${config.git.repoOwner}/\${config.git.repoName}.git\`
             };
+            // Extract defaultBranch from git config
+            defaultBranch = config.git.defaultBranch || 'master';
         }
+    } else {
+        // Extract defaultBranch from repository config
+        defaultBranch = repo.defaultBranch || 'master';
     }
 
     if (!repo || !repo.owner || !repo.name || !repo.url) {
         process.exit(1);
     }
-    console.log(\`\${repo.owner}:\${repo.name}:\${repo.url}\`);
+    console.log(\`\${repo.owner}|\${repo.name}|\${repo.url}|\${defaultBranch}\`);
 } catch (e) {
     process.exit(1);
 }
@@ -161,13 +167,14 @@ if [ $? -ne 0 ]; then
     exit 1
 fi
 
-# Split the result into variables
-IFS=':' read -r REPO_OWNER REPO_NAME REPO_URL <<< "$REPO_INFO"
+# Split the result into variables using pipe delimiter
+IFS='|' read -r REPO_OWNER REPO_NAME REPO_URL CONFIG_DEFAULT_BRANCH <<< "$REPO_INFO"
 
 echo "Repository Configuration:"
 echo "  Owner: $REPO_OWNER"
 echo "  Name:  $REPO_NAME"
 echo "  URL:   $REPO_URL"
+echo "  Default Branch: $CONFIG_DEFAULT_BRANCH"
 echo
 
 echo "=== $REPO_NAME - Issue Preparation ==="
@@ -195,45 +202,69 @@ echo "Step 1: Determining base branch from current repository..."
 
 # Determine base branch from the ORIGINAL repository (before cloning)
 if [ "$USE_DEFAULT_BRANCH" = true ]; then
-    # Detect the default branch
-    DEFAULT_BRANCH=""
-    for candidate in main master develop; do
-        if git ls-remote --exit-code --heads "$REPO_URL" "$candidate" >/dev/null 2>&1; then
-            DEFAULT_BRANCH="$candidate"
-            echo "✓ Detected default branch: $DEFAULT_BRANCH"
-            break
-        fi
-    done
-    
-    # Fallback to master if nothing else worked
-    if [ -z "$DEFAULT_BRANCH" ]; then
-        DEFAULT_BRANCH="master"
-        echo "⚠️  Could not detect default branch, defaulting to: $DEFAULT_BRANCH"
-    fi
-    
-    BASE_BRANCH="$DEFAULT_BRANCH"
-    echo "Using detected default branch as base: $BASE_BRANCH (--use-default flag)"
-else
-    # Get current branch from the original repo
-    ORIGINAL_BRANCH=$(git branch --show-current 2>/dev/null || echo "")
+    # Use the default branch from FRAIM config
+    DEFAULT_BRANCH="$CONFIG_DEFAULT_BRANCH"
+    echo "✓ Using default branch from FRAIM config: $DEFAULT_BRANCH"
     
-    if [ -z "$ORIGINAL_BRANCH" ]; then
-        echo "Warning: Detached HEAD detected in original repo, falling back to default branch detection"
+    # Verify the branch exists on remote
+    if git ls-remote --exit-code --heads "$REPO_URL" "$DEFAULT_BRANCH" >/dev/null 2>&1; then
+        echo "✓ Confirmed branch '$DEFAULT_BRANCH' exists on remote"
+    else
+        echo "⚠️  Warning: Configured default branch '$DEFAULT_BRANCH' not found on remote"
+        echo "   Falling back to branch detection..."
         
-        # Detect the default branch
+        # Fallback to detection if configured branch doesn't exist
         DEFAULT_BRANCH=""
         for candidate in main master develop; do
             if git ls-remote --exit-code --heads "$REPO_URL" "$candidate" >/dev/null 2>&1; then
                 DEFAULT_BRANCH="$candidate"
-                echo "✓ Detected default branch: $DEFAULT_BRANCH"
+                echo "✓ Detected fallback branch: $DEFAULT_BRANCH"
                 break
             fi
         done
         
-        # Fallback to master if nothing else worked
+        # Final fallback to master
         if [ -z "$DEFAULT_BRANCH" ]; then
             DEFAULT_BRANCH="master"
-            echo "⚠️  Could not detect default branch, defaulting to: $DEFAULT_BRANCH"
+            echo "⚠️  Could not detect any branch, defaulting to: $DEFAULT_BRANCH"
+        fi
+    fi
+    
+    BASE_BRANCH="$DEFAULT_BRANCH"
+    echo "Using default branch as base: $BASE_BRANCH (--use-default flag)"
+else
+    # Get current branch from the original repo
+    ORIGINAL_BRANCH=$(git branch --show-current 2>/dev/null || echo "")
+    
+    if [ -z "$ORIGINAL_BRANCH" ]; then
+        echo "Warning: Detached HEAD detected in original repo, falling back to configured default branch"
+        
+        # Use the default branch from FRAIM config
+        DEFAULT_BRANCH="$CONFIG_DEFAULT_BRANCH"
+        echo "✓ Using default branch from FRAIM config: $DEFAULT_BRANCH"
+        
+        # Verify the branch exists on remote
+        if git ls-remote --exit-code --heads "$REPO_URL" "$DEFAULT_BRANCH" >/dev/null 2>&1; then
+            echo "✓ Confirmed branch '$DEFAULT_BRANCH' exists on remote"
+        else
+            echo "⚠️  Warning: Configured default branch '$DEFAULT_BRANCH' not found on remote"
+            echo "   Falling back to branch detection..."
+            
+            # Fallback to detection if configured branch doesn't exist
+            DEFAULT_BRANCH=""
+            for candidate in main master develop; do
+                if git ls-remote --exit-code --heads "$REPO_URL" "$candidate" >/dev/null 2>&1; then
+                    DEFAULT_BRANCH="$candidate"
+                    echo "✓ Detected fallback branch: $DEFAULT_BRANCH"
+                    break
+                fi
+            done
+            
+            # Final fallback to master
+            if [ -z "$DEFAULT_BRANCH" ]; then
+                DEFAULT_BRANCH="master"
+                echo "⚠️  Could not detect any branch, defaulting to: $DEFAULT_BRANCH"
+            fi
         fi
         
         BASE_BRANCH="$DEFAULT_BRANCH"