fraim-framework 2.0.35 → 2.0.36

package/registry/scripts/detect-tautological-tests.sh

@@ -1,38 +1,38 @@
-#!/bin/bash
-
-# Detect Tautological Tests
-# This script scans test files for patterns that suggest tests are validating code structure 
-# (interfaces, enums) rather than runtime behavior.
-
-echo "🔍 Scanning for Tautological Test Patterns..."
-ERROR_FOUND=0
-
-# Pattern 1: Asserting an array literal equals another array literal (common in enum testing)
-# Looks for: assert.deepEqual(['a', 'b'], ['a', 'b'])
-if grep -rE "assert\.(deep)?(Strict)?Equal\(\[.*\], \[.*\]\)" test*.ts; then
-    echo "❌ ERROR: Found potential tautological array comparison. Tests should verify app logic, not hardcoded arrays."
-    echo "   Rationale: Testing that ['A'] equals ['A'] validates nothing about the application."
-    ERROR_FOUND=1
-fi
-
-# Pattern 2: Asserting properties on an object literal defined in the test (Type/Interface testing)
-# Simplified: Look for defining a typed object and immediately asserting on it in the same file
-# This is hard to do robustly with just grep, so we'll rely on the Naming Convention check for now.
-
-# Pattern 3: Test names that explicitly say "Validate Enums", "Validate Fields", etc.
-# We match "Validate TaskStatus Enums" or similar phrases
-if grep -riE "['\"]Unit: Validate (Enum|Constant|Interface|Type|Field|Object|TaskStatus|Task Object)" test*.ts; then
-    echo "❌ ERROR: Found test descriptions explicitly claiming to validate Enums/Types/Fields."
-    echo "   Rationale: Unit tests should validate BEHAVIOR (e.g., 'persists correct status'), not definitions."
-    ERROR_FOUND=1
-fi
-
-if [ $ERROR_FOUND -eq 1 ]; then
-    echo ""
-    echo "⚠️  Potential Anti-Patterns Detected."
-    echo "   Please review the identified tests against rules/integrity-and-test-ethics.md"
-    exit 1
-else
-    echo "✅ No obvious tautological patterns found."
-    exit 0
-fi
+#!/bin/bash
+
+# Detect Tautological Tests
+# This script scans test files for patterns that suggest tests are validating code structure 
+# (interfaces, enums) rather than runtime behavior.
+
+echo "🔍 Scanning for Tautological Test Patterns..."
+ERROR_FOUND=0
+
+# Pattern 1: Asserting an array literal equals another array literal (common in enum testing)
+# Looks for: assert.deepEqual(['a', 'b'], ['a', 'b'])
+if grep -rE "assert\.(deep)?(Strict)?Equal\(\[.*\], \[.*\]\)" test*.ts; then
+    echo "❌ ERROR: Found potential tautological array comparison. Tests should verify app logic, not hardcoded arrays."
+    echo "   Rationale: Testing that ['A'] equals ['A'] validates nothing about the application."
+    ERROR_FOUND=1
+fi
+
+# Pattern 2: Asserting properties on an object literal defined in the test (Type/Interface testing)
+# Simplified: Look for defining a typed object and immediately asserting on it in the same file
+# This is hard to do robustly with just grep, so we'll rely on the Naming Convention check for now.
+
+# Pattern 3: Test names that explicitly say "Validate Enums", "Validate Fields", etc.
+# We match "Validate TaskStatus Enums" or similar phrases
+if grep -riE "['\"]Unit: Validate (Enum|Constant|Interface|Type|Field|Object|TaskStatus|Task Object)" test*.ts; then
+    echo "❌ ERROR: Found test descriptions explicitly claiming to validate Enums/Types/Fields."
+    echo "   Rationale: Unit tests should validate BEHAVIOR (e.g., 'persists correct status'), not definitions."
+    ERROR_FOUND=1
+fi
+
+if [ $ERROR_FOUND -eq 1 ]; then
+    echo ""
+    echo "⚠️  Potential Anti-Patterns Detected."
+    echo "   Please review the identified tests against rules/integrity-and-test-ethics.md"
+    exit 1
+else
+    echo "✅ No obvious tautological patterns found."
+    exit 0
+fi