fraim-framework 2.0.193 → 2.0.194

package/dist/src/ai-hub/hosts.js

@@ -23,6 +23,7 @@ const child_process_1 = require("child_process");
 const fs_1 = __importDefault(require("fs"));
 const os_1 = __importDefault(require("os"));
 const path_1 = __importDefault(require("path"));
+const manager_turns_1 = require("./manager-turns");
 const managed_agent_paths_1 = require("../cli/utils/managed-agent-paths");
 const mcp_config_generator_1 = require("../cli/setup/mcp-config-generator");
 const agent_token_prices_1 = require("../local-mcp-server/agent-token-prices");
@@ -702,11 +703,11 @@ function transformHeadlessFraimMessage(message, kind) {
     if (!parsed)
         return message;
     if (!parsed.jobId) {
+        // Issue #732: single-source the same-job continue wording via
+        // buildSameJobContinueMessage so the server (prepareContinueMessage) and
+        // this headless transform stay in lock-step.
         if (kind === 'continue') {
-            if (parsed.remainder) {
-                return `Continue the active FRAIM job with this manager coaching:\n\n${parsed.remainder}`;
-            }
-            return 'Continue the active FRAIM job using the current session context.';
+            return (0, manager_turns_1.buildSameJobContinueMessage)(parsed.remainder);
         }
         return message;
     }
@@ -1351,6 +1352,10 @@ class FakeHostRuntime {
             { id: 'gemini', label: 'Gemini CLI', available: true, detail: 'Test double employee.', supportsRaw: true },
             { id: 'copilot', label: 'GitHub Copilot CLI', available: true, detail: 'Test double agent tool.', supportsRaw: true },
         ];
+        // Remembered across turns like a resumed agent session: the job label from the
+        // start turn. Issue #732 — a same-job continue no longer carries a /fraim <job>
+        // invocation, so the fake falls back to this to stay job-aware on continue.
+        this.lastJobLabel = null;
     }
     detectEmployees() {
         return this.employees;
@@ -1407,9 +1412,12 @@ class FakeHostRuntime {
     }
     fakeEmployeeReply(kind, message) {
         const parsed = parseFraimInvocation(message);
-        const label = parsed?.jobId
+        const parsedLabel = parsed?.jobId
             ? parsed.jobId.split('-').map((part) => part.charAt(0).toUpperCase() + part.slice(1)).join(' ')
             : null;
+        if (parsedLabel)
+            this.lastJobLabel = parsedLabel;
+        const label = parsedLabel || (kind === 'continue' ? this.lastJobLabel : null);
         if (kind === 'continue') {
             return label
                 ? `Understood. I'm taking another pass with ${label}.`
@@ -1442,6 +1450,9 @@ class ScriptedHostRuntime {
         // Tracks runDiscriminant per sessionId so consecutive emitPhase calls
         // can resolve onSuccess routing without each test having to repeat it.
         this.discriminantBySession = new Map();
+        // Issue #732: capture the exact message the Hub sent on the most recent
+        // continue turn so tests can assert whether it would re-trigger get_fraim_job.
+        this.lastContinueMessage = null;
     }
     detectEmployees() {
         return this.employees;
@@ -1452,7 +1463,8 @@ class ScriptedHostRuntime {
         handlers.onEvent({ sessionId, raw: 'scripted-session-start' }, 'system');
         return this.spawnDouble();
     }
-    continueRun(_hostId, _projectPath, sessionId, _message, handlers) {
+    continueRun(_hostId, _projectPath, sessionId, message, handlers) {
+        this.lastContinueMessage = message;
         this.handlersBySession.set(sessionId, handlers);
         handlers.onEvent({ sessionId, raw: 'scripted-session-resume' }, 'system');
         return this.spawnDouble();
@@ -1517,6 +1529,20 @@ class ScriptedHostRuntime {
             },
         }, 'stdout');
     }
+    // Test API — emit a same-job seekMentoring signal that carries BOTH the
+    // stable jobName slug and a per-invocation UUID jobId, exactly as a real
+    // agent does after get_fraim_job (which mints a fresh randomUUID each call).
+    // Issue #732: the tracker must key off jobName, not the UUID jobId.
+    emitPhaseWithJobIds(runId, phaseId, status, jobName, jobId, findingsText) {
+        const target = this.resolveSession(runId);
+        if (!target)
+            return;
+        target.handlers.onEvent({
+            sessionId: target.sessionId,
+            raw: `scripted-seekMentoring-ids:${phaseId}:${status}`,
+            seekMentoring: { phaseId, phaseStatus: status, jobName, jobId, findingsText },
+        }, 'stdout');
+    }
     // Test API — emit the structured job-load signal that get_fraim_job
     // produces before the first seekMentoring phase call.
     emitFraimJobLoad(runId, jobId) {

package/dist/src/ai-hub/manager-turns.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.extractExplicitFraimInvocation = extractExplicitFraimInvocation;
 exports.fraimInvocationFor = fraimInvocationFor;
 exports.buildCommunicationStyleNote = buildCommunicationStyleNote;
+exports.buildSameJobContinueMessage = buildSameJobContinueMessage;
 exports.buildManagerMessage = buildManagerMessage;
 function extractExplicitFraimInvocation(text) {
     const raw = String(text || '');
@@ -36,6 +37,18 @@ function buildCommunicationStyleNote() {
         '[How to talk to me] In your messages to me, report ONLY on the job and its outcome — what you found, what you changed, the decisions you made, blockers, and what you need from me. Do NOT narrate the FRAIM machinery: don\'t announce that you are talking to FRAIM, asking your mentor, following the process, moving between phases, or calling tools (git, playwright, etc.). I can see the raw tool activity separately if I want it. Keep your updates short and about the work, not the process.',
     ].join('\n');
 }
+// Issue #732: a plain continue of the SAME active job must not re-load the job.
+// Continue turns resume the existing agent session, which already has the job
+// loaded, so this message carries NO `/fraim <job>` invocation — the headless
+// transform therefore does not re-instruct get_fraim_job (which is slow and
+// mints a fresh UUID job id every call). The manager coaching still reaches the
+// agent, which advances the workflow via seekMentoring using its resumed context.
+function buildSameJobContinueMessage(coaching) {
+    const remainder = String(coaching || '').trim();
+    return remainder
+        ? `Continue the active FRAIM job with this manager coaching:\n\n${remainder}`
+        : 'Continue the active FRAIM job using the current session context.';
+}
 function buildManagerMessage(employeeId, jobId, kind, instructions, stubPath) {
     const trimmed = String(instructions || '').trim();
     const explicit = extractExplicitFraimInvocation(trimmed);

package/dist/src/ai-hub/server.js

@@ -726,12 +726,17 @@ function applySeekMentoringSignal(run, signal) {
     // Issue #347: filter cross-job pollution. The agent may call
     // seekMentoring for jobs OTHER than the one this run is tracking
     // (e.g., consulting `organizational-learning-synthesis` mid-run).
-    // Only apply signals whose jobId/jobName matches this run's jobId.
-    // Match against either field because the agent passes both and they
-    // typically agree, but defenses are cheap.
+    // Only apply signals whose job identity matches this run's.
+    // Issue #732: match on `jobName` — the stable job-name slug that equals
+    // run.jobId — NOT `jobId`. get_fraim_job mints a fresh randomUUID as the
+    // job id on every call and the agent echoes that UUID into
+    // seekMentoring.jobId, so a UUID never equals run.jobId. Comparing the UUID
+    // discarded every real phase signal as if it were foreign-job pollution and
+    // froze the tracker at "no phases done". The UUID cannot positively identify
+    // this run's job, so it must not participate in the match.
     const targetJobId = run.jobId;
-    const callJobId = signal.jobId || signal.jobName;
-    if (callJobId && targetJobId && callJobId !== targetJobId)
+    const callJobName = signal.jobName;
+    if (callJobName && targetJobId && callJobName !== targetJobId)
         return;
     if (signal.reviewHandoff) {
         const normalizedReviewHandoff = normalizeReviewHandoff(signal.reviewHandoff);
@@ -1862,7 +1867,10 @@ class AiHubServer {
         return null;
     }
     applySeekMentoringSignalToRun(run, signal) {
-        this.maybePromoteFreeformRunToJob(run, signal.jobId || signal.jobName);
+        // Issue #732: promote using the stable jobName slug, not the per-call UUID
+        // jobId (resolveHubJob would never match a UUID, leaving a freeform run
+        // unpromoted and then dropping its phase signals).
+        this.maybePromoteFreeformRunToJob(run, signal.jobName || signal.jobId);
         applySeekMentoringSignal(run, signal);
     }
     applyFraimJobSignalToRun(run, signal) {
@@ -1890,15 +1898,17 @@ class AiHubServer {
         if (!resolvedJobId) {
             throw new Error('Choose a FRAIM job before starting a run, or start with /fraim <job-id>.');
         }
-        // #696: `display` is the manager conversation bubble. Keep the full generated
-        // turn in `message`, but show only the host-specific FRAIM invocation.
-        const display = (0, manager_turns_1.fraimInvocationFor)(hostId, resolvedJobId) || (explicit?.remainder || instructions || '').trim();
+        // `display` is the manager conversation bubble. It keeps the user's full
+        // coaching text with the host-specific FRAIM invocation. The agent payload
+        // still receives Hub-only helper blocks such as `[FRAIM shared browser]`
+        // and `[How to talk to me]`; those are omitted from the visible bubble.
         // #521: the shared-browser guidance is injected HERE, at the Hub layer — never
         // baked into the registry job/skill. It only appears when a shared browser is
         // available (env published at boot).
         const browserNote = (0, managed_browser_1.buildBrowserContextNote)(process.env.FRAIM_BROWSER_CDP_ENDPOINT, process.env.FRAIM_HUB_BASE_URL);
         const styleNote = (0, manager_turns_1.buildCommunicationStyleNote)();
         if (resolvedJobId === '__freeform__') {
+            const display = (0, manager_turns_1.buildManagerMessage)(hostId, resolvedJobId, 'start', instructions);
             return {
                 jobId: resolvedJobId,
                 message: (0, manager_turns_1.buildManagerMessage)(hostId, resolvedJobId, 'start', instructions) + browserNote + styleNote,
@@ -1909,6 +1919,7 @@ class AiHubServer {
         const absoluteStubPath = resolvedJob?.stubPath
             ? [projectPath, resolvedJob.stubPath].join('/').replace(/\\/g, '/').replace(/\/+/g, '/')
             : undefined;
+        const display = (0, manager_turns_1.buildManagerMessage)(hostId, resolvedJobId, 'start', instructions);
         return {
             jobId: resolvedJobId,
             message: (0, manager_turns_1.buildManagerMessage)(hostId, resolvedJobId, 'start', instructions, absoluteStubPath) + browserNote + styleNote,
@@ -1923,14 +1934,27 @@ class AiHubServer {
         // passes raw invocation syntax.
         const explicit = (0, manager_turns_1.extractExplicitFraimInvocation)(instructions);
         const effectiveJobId = explicit?.jobId || coachingJobId || run.jobId;
-        // #696: the thread shows the invocation that the Hub sent, while the employee
-        // still receives the full manager turn plus the style note.
+        // #730: the manager thread shows the coaching turn with high fidelity — the
+        // correct FRAIM command in front plus what the manager actually said — built
+        // from the shared normalizer, exactly like the start path. With no
+        // instructions (e.g. a plain coaching-template click) buildManagerMessage
+        // collapses to just the invocation. The employee additionally receives the
+        // communication-style note (and, per #732 below, a lighter same-job payload);
+        // those operational details stay out of the visible bubble.
         const userText = (explicit?.remainder || instructions || '').trim();
-        const display = (0, manager_turns_1.fraimInvocationFor)(run.hostId, effectiveJobId) || userText || (0, manager_turns_1.buildManagerMessage)(run.hostId, effectiveJobId, 'continue', '');
-        return {
-            message: (0, manager_turns_1.buildManagerMessage)(run.hostId, effectiveJobId, 'continue', instructions) + (0, manager_turns_1.buildCommunicationStyleNote)(),
-            display,
-        };
+        const display = (0, manager_turns_1.buildManagerMessage)(run.hostId, effectiveJobId, 'continue', instructions);
+        // Issue #732: a plain continue of the SAME active real job must not re-load
+        // the job via get_fraim_job on every coaching turn — the host session is
+        // resumed with the job already in context, so re-fetching is wasted latency
+        // and tokens (the reported hub slowness) and mints a fresh UUID job id each
+        // time. Only load the job when the continue SWITCHES jobs (a coaching
+        // template or an explicit /fraim <other>). Freeform/adhoc runs keep the
+        // existing buildManagerMessage path (which already emits no invocation).
+        const switchesJob = effectiveJobId !== run.jobId;
+        const message = (switchesJob || run.jobId === '__freeform__')
+            ? (0, manager_turns_1.buildManagerMessage)(run.hostId, effectiveJobId, 'continue', instructions) + (0, manager_turns_1.buildCommunicationStyleNote)()
+            : (0, manager_turns_1.buildSameJobContinueMessage)(userText) + (0, manager_turns_1.buildCommunicationStyleNote)();
+        return { message, display };
     }
     async computePersonas(apiKey) {
         const allBundles = listHubPersonaBundles();

package/dist/src/local-mcp-server/stdio-server.js

@@ -1052,6 +1052,27 @@ class FraimLocalMCPServer {
         this.collectStrings(response.result, strings);
         return strings.some(s => /\{\{proxy\.delivery\.[^}]+\}\}/.test(s));
     }
+    getDeliveryPlaceholderKeys(response) {
+        const keys = new Set();
+        if (!response.result)
+            return keys;
+        const strings = [];
+        this.collectStrings(response.result, strings);
+        for (const text of strings) {
+            for (const match of text.matchAll(/\{\{proxy\.delivery\.([^}]+)\}\}/g)) {
+                keys.add(`proxy.delivery.${match[1].trim()}`);
+            }
+        }
+        return keys;
+    }
+    deliveryTemplatesCoverPlaceholders(templates, response) {
+        const requiredKeys = this.getDeliveryPlaceholderKeys(response);
+        for (const key of requiredKeys) {
+            if (!(key in templates))
+                return false;
+        }
+        return true;
+    }
     responseHasPotentialProviderPlaceholders(response) {
         if (!response.result)
             return false;
@@ -1123,15 +1144,17 @@ class FraimLocalMCPServer {
         if (!this.responseContainsDeliveryPlaceholders(response))
             return;
         const engine = this.ensureEngine();
-        if (engine.hasDeliveryTemplates())
-            return;
-        if (engine.loadDeliveryTemplates())
+        const currentTemplates = engine.loadDeliveryTemplates();
+        // Normal proxy.delivery substitution is correct once the provider contains the
+        // key. Older local registry caches can predate newly added delivery keys, so
+        // treat missing required keys as stale cache and refresh from the server.
+        if (currentTemplates && this.deliveryTemplatesCoverPlaceholders(currentTemplates, response))
             return;
         const filename = this.getWorkingStyle() === 'Conversation'
             ? 'delivery-conversation.json'
             : 'delivery-pr.json';
         const cached = this.readCachedTemplateFile(filename);
-        if (cached) {
+        if (cached && this.deliveryTemplatesCoverPlaceholders(cached, response)) {
             engine.setDeliveryTemplates(cached);
             return;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fraim-framework",
-  "version": "2.0.193",
+  "version": "2.0.194",
   "description": "FRAIM: AI Workforce Infrastructure — the organizational capability that turns AI agents into an accountable workforce, their operators into capable AI managers, and executives into leaders with clear optics on AI proficiency.",
   "main": "index.js",
   "bin": {

package/public/ai-hub/script.js

@@ -2937,11 +2937,19 @@ function humanizeSlug(slug) {
     .join(' ');
 }
 
-function stripStubReference(text) {
-  return String(text || '')
+function stripStubReference(text, options = {}) {
+  const cleaned = String(text || '')
     .replace(/\n?\[Job stub:[^\]]+\]/gi, '')
-    .replace(/\[Thought:\s*true\]\s*/gi, '')
-    .replace(/\s+/g, ' ')
+    .replace(/\[Thought:\s*true\]\s*/gi, '');
+  if (options.preserveWhitespace) {
+    return cleaned.replace(/\n{3,}/g, '\n\n').trim();
+  }
+  return cleaned.replace(/\s+/g, ' ').trim();
+}
+
+function managerBubbleText(text) {
+  return stripHubInjectedNotes(stripStubReference(text, { preserveWhitespace: true }))
+    .replace(/\n{3,}/g, '\n\n')
     .trim();
 }
 
@@ -3048,8 +3056,7 @@ function appendMessageDom(role, text, conv) {
     const content = useSurfaced ? surfaced : raw;
     bubble.innerHTML = formatEmployeeText(content || (conv.status === 'completed' ? 'Done — please review.' : 'Working on it…'));
   } else {
-    const surfaced = surfaceText(role, text, conv);
-    bubble.textContent = surfaced || text;
+    bubble.textContent = role === 'manager' ? managerBubbleText(text) : (surfaceText(role, text, conv) || text);
   }
   if (role === 'manager') {
     const raw = document.createElement('span');

package/public/ai-hub/styles.css

@@ -1503,6 +1503,7 @@ img.coach-employee-avatar { object-fit: cover; border-radius: 4px; }
 .message.manager .bubble {
   background: var(--accent);
   color: #fff;
+  white-space: pre-wrap;
 }
 .message.employee .bubble {
   background: var(--surface);
@@ -2752,7 +2753,7 @@ body.hub-shell { display: flex; flex-direction: column; height: 100vh; overflow:
 .am-av { width: 32px; height: 32px; border-radius: 50%; background: var(--accent); color: #fff; display: flex; align-items: center; justify-content: center; font-size: 11px; font-weight: 700; flex-shrink: 0; }
 .am-name { font-size: 13px; font-weight: 700; }
 .am-email { font-size: 11px; color: var(--muted); }
-.am-item { display: flex; align-items: flex-start; gap: 10px; width: 100%; padding: 9px 16px; cursor: pointer; font-size: 13px; color: var(--text); text-align: left; text-decoration: none; border: 0; background: none; }
+.am-item { display: flex; align-items: flex-start; gap: 10px; width: 100%; padding: 9px 16px; cursor: pointer; font-size: 13px; color: var(--text); text-align: left; text-decoration: none; border: 0; background: none; }
 .am-item:hover { background: var(--bg); }
 .am-ico { font-size: 14px; width: 18px; text-align: center; flex-shrink: 0; margin-top: 1px; }
 .am-label { font-weight: 600; }
@@ -2768,75 +2769,75 @@ body.hub-shell { display: flex; flex-direction: column; height: 100vh; overflow:
 .am-theme[aria-checked="true"] .am-switch-knob { transform: translateX(16px); }
 
 /* Hub areas */
-.hub-area { display: none; flex: 1; overflow: hidden; }
-.hub-area.on { display: flex; flex-direction: column; }
-.hub-area-page { max-width: 860px; margin: 0 auto; padding: 28px 24px 48px; overflow-y: auto; flex: 1; /* authoritative rule — see also Round-2 override below which is now removed */ }
-
-.connected-shell {
-  display: flex;
-  flex: 1;
-  min-height: 0;
-  flex-direction: column;
-  background: var(--bg);
-}
-.connected-toolbar {
-  display: flex;
-  align-items: center;
-  gap: 14px;
-  min-height: 52px;
-  padding: 8px 16px;
-  background: var(--surface);
-  border-bottom: 1px solid var(--line);
-  flex-shrink: 0;
-}
-.connected-title-block {
-  min-width: 0;
-  display: flex;
-  flex-direction: column;
-  gap: 1px;
-}
-.connected-kicker {
-  font-size: 10px;
-  font-weight: 700;
-  letter-spacing: .04em;
-  text-transform: uppercase;
-  color: var(--muted);
-}
-.connected-title {
-  font-size: 14px;
-  font-weight: 700;
-  color: var(--text);
-}
-.connected-origin {
-  min-width: 0;
-  flex: 1;
-  color: var(--muted);
-  font-size: 12px;
-  overflow: hidden;
-  text-overflow: ellipsis;
-  white-space: nowrap;
-}
-.connected-close {
-  border: 1px solid var(--line);
-  background: var(--surface);
-  color: var(--text);
-  border-radius: 8px;
-  padding: 6px 12px;
-  font-size: 13px;
-  font-weight: 600;
-  flex-shrink: 0;
-}
-.connected-close:hover { background: var(--bg); }
-.connected-frame {
-  flex: 1;
-  min-height: 0;
-  width: 100%;
-  border: 0;
-  background: var(--surface);
-}
-
-/* #521 R6: Company/Manager use the same rail + main shell as the project workspace. */
-.area-shell { display: flex; flex: 1; min-height: 0; }
+.hub-area { display: none; flex: 1; overflow: hidden; }
+.hub-area.on { display: flex; flex-direction: column; }
+.hub-area-page { max-width: 860px; margin: 0 auto; padding: 28px 24px 48px; overflow-y: auto; flex: 1; /* authoritative rule — see also Round-2 override below which is now removed */ }
+
+.connected-shell {
+  display: flex;
+  flex: 1;
+  min-height: 0;
+  flex-direction: column;
+  background: var(--bg);
+}
+.connected-toolbar {
+  display: flex;
+  align-items: center;
+  gap: 14px;
+  min-height: 52px;
+  padding: 8px 16px;
+  background: var(--surface);
+  border-bottom: 1px solid var(--line);
+  flex-shrink: 0;
+}
+.connected-title-block {
+  min-width: 0;
+  display: flex;
+  flex-direction: column;
+  gap: 1px;
+}
+.connected-kicker {
+  font-size: 10px;
+  font-weight: 700;
+  letter-spacing: .04em;
+  text-transform: uppercase;
+  color: var(--muted);
+}
+.connected-title {
+  font-size: 14px;
+  font-weight: 700;
+  color: var(--text);
+}
+.connected-origin {
+  min-width: 0;
+  flex: 1;
+  color: var(--muted);
+  font-size: 12px;
+  overflow: hidden;
+  text-overflow: ellipsis;
+  white-space: nowrap;
+}
+.connected-close {
+  border: 1px solid var(--line);
+  background: var(--surface);
+  color: var(--text);
+  border-radius: 8px;
+  padding: 6px 12px;
+  font-size: 13px;
+  font-weight: 600;
+  flex-shrink: 0;
+}
+.connected-close:hover { background: var(--bg); }
+.connected-frame {
+  flex: 1;
+  min-height: 0;
+  width: 100%;
+  border: 0;
+  background: var(--surface);
+}
+
+/* #521 R6: Company/Manager use the same rail + main shell as the project workspace. */
+.area-shell { display: flex; flex: 1; min-height: 0; }
 .area-rail { width: 244px; flex-shrink: 0; background: var(--surface); border-right: 1px solid var(--line); overflow-y: auto; padding: 6px 0; }
 .area-main { flex: 1; min-width: 0; display: flex; flex-direction: column; overflow: hidden; }
 .area-rail-head { font-size: 11px; font-weight: 700; letter-spacing: .04em; text-transform: uppercase; color: var(--muted); padding: 14px 16px 6px; }