fr.jeanf.questsystem 0.0.41 → 0.0.43

package/Runtime/Scripts/Core/QuestItem.cs

@@ -99,16 +99,11 @@ namespace jeanf.questsystem
         #region Instantiations & Loading
         public void InstantiateQuestStep(string id)
         {
-            if (activeSteps.ContainsKey(id))
-            {
-                Debug.Log($"Step with id:[{id}] is already in the list of active steps");
-                return;
-            }
-
-            if (stepMap.ContainsKey(id))
-            {
-                activeSteps.Add(id,Instantiate(stepMap[id], this.transform, true));
-            }
+            if (stepMap[id].stepStatus != QuestStepStatus.Inactive) return;
+            if (activeSteps.ContainsKey(id)) return;
+            if (!stepMap.ContainsKey(id)) return;
+            
+            if(!activeSteps.ContainsKey(id)) activeSteps.Add(id,Instantiate(stepMap[id], this.transform, true));
         }
 
         public void DestroyQuestStep(string id)

package/Runtime/Scripts/Core/QuestStep.cs

@@ -56,7 +56,7 @@ namespace jeanf.questsystem
         public void InitializeQuestStep()
         {
             // failsafe to avoid lauching the same step more than once at a time.
-            //if (stepStatus != QuestStepStatus.Active) return;
+            if (stepStatus == QuestStepStatus.Active) return;
             Debug.Log($"Initializing quest with questId: {questId}");
 
             stepStatus = QuestStepStatus.Active;
@@ -84,22 +84,17 @@ namespace jeanf.questsystem
             {
                 sendQuestStepTooltip.RaiseEvent(string.Empty);
             }
-
-            Debug.LogWarning("Implement prefab destruction");
-            Debug.LogWarning("Implement next trigger calls.");
-
-            
+;
 
             foreach(QuestStep questStep in questStepsToTrigger)
             {
                 sendNextStepId?.Invoke(questStep.stepId);
             }
             stepCompleted?.Invoke(stepId);
-            stepActive?.Invoke(stepId, stepStatus); 
-            
-            // stops the timeline in case it were playing
-            // this may cause issue of timing so disabled it to test.
-            // _timelineTriggerEventChannelSo.RaiseEvent(timeline, false);
+            stepActive?.Invoke(stepId, stepStatus);
+
+            if (isDebug) Debug.Log($"Step with id: {stepId} finished. Destroying the gameobject with name {this.name}", this);
+            Destroy(this);
         }
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name":"fr.jeanf.questsystem",
-  "version":"0.0.41",
+  "version":"0.0.43",
   "displayName":"Quest system",
   "description":"This package uses Scriptable Objects to define quests.",
   "unity": "2021.3",