foxclaw 0.1.2 → 0.1.4

package/python/foxclaw/skills/pipeline.py

@@ -18,22 +18,20 @@ import re
 from dataclasses import dataclass, field
 from typing import Optional
 
-from ..planning import planner as P   # 统一规划原语(P1-2:否定/拆分/打分单一真源)
+from ..planning import planner as P
 
 
-# ============ skill-router:委托统一引擎,候选空间=skill ============
-
 @dataclass
 class RouteResult:
-    primary: Optional[str] = None        # 选中的主 skill id
+    primary: Optional[str] = None
     confidence: float = 0.0
-    candidates: list = field(default_factory=list)   # [(skill_id, score)]
+    candidates: list = field(default_factory=list)
     fallback: Optional[str] = None
     needs_composition: bool = False
     reason: str = ""
 
 
-def route(task: str, registry, fallback_id: str = None) -> RouteResult:
+def route(task: str, registry, fallback_id: str | None = None) -> RouteResult:
     """skill-router:把 skill 适配成通用候选,交统一引擎 trigger_route 打分选择。
     算法(否定过滤触发命中 0.8 + 描述领域匹配 0.2)现由 foxclaw.planning 单一真源提供。"""
     skills = registry.all()
@@ -50,8 +48,6 @@ def route(task: str, registry, fallback_id: str = None) -> RouteResult:
                        needs_composition=r.needs_composition, reason=r.reason)
 
 
-# ============ planner:任务拆解 ============
-
 @dataclass
 class PlanTask:
     id: str
@@ -63,9 +59,9 @@ class PlanTask:
 @dataclass
 class Plan:
     intent: str
-    tasks: list = field(default_factory=list)        # [PlanTask]
-    flow_type: str = "sequential"                    # sequential/parallel/hybrid
-    steps: list = field(default_factory=list)        # 执行顺序 [task_id]
+    tasks: list = field(default_factory=list)
+    flow_type: str = "sequential"
+    steps: list = field(default_factory=list)
     needs_input: bool = False
     missing: list = field(default_factory=list)
 
@@ -95,7 +91,6 @@ def plan(task: str, registry) -> Plan:
     for i, p in enumerate(parts, 1):
         r = route(p, registry)
         tid = f"T{i}"
-        # 顺序:依赖前一步;并行:无依赖(可同时 fork)
         deps = [f"T{i-1}"] if (i > 1 and flow == "sequential") else []
         tasks.append(PlanTask(id=tid, name=p, suggested_skill=r.primary,
                               dependencies=deps))
@@ -104,8 +99,6 @@ def plan(task: str, registry) -> Plan:
     return Plan(intent=task, tasks=tasks, flow_type=flow, steps=steps)
 
 
-# ============ composition:多 skill 编排执行 ============
-
 @dataclass
 class StageResult:
     stage: int
@@ -116,16 +109,14 @@ class StageResult:
 @dataclass
 class CompositionResult:
     mode: str
-    stages: list = field(default_factory=list)       # [StageResult]
+    stages: list = field(default_factory=list)
     final_output: dict = field(default_factory=dict)
     failed: list = field(default_factory=list)
     rolled_back: bool = False
-    rollback_clean: bool = True                       # 回滚是否干净完成(无补偿失败/无需人工)
-    rollback_log: list = field(default_factory=list)  # 回滚记录 [{skill,status,detail}]
-    needs_manual: list = field(default_factory=list)  # 需人工处理的 skill(无补偿/补偿失败)
-    # 【P2-2】待确认状态:遇到 needs_confirmation 时填充(不回滚),供调用方展示+断点续跑
-    pending_confirmation: dict = None                 # {task_id,skill_id,stage,message,args,completed_steps,resume_at}
-    # 【P2-2】已完成步骤(断点续跑所需的现场): [(task_id, skill_id, output)]
+    rollback_clean: bool = True
+    rollback_log: list = field(default_factory=list)
+    needs_manual: list = field(default_factory=list)
+    pending_confirmation: Optional[dict] = None
     completed_steps: list = field(default_factory=list)
 
     @property
@@ -148,16 +139,13 @@ def _build_args(skill, task_text: str, upstream: dict) -> dict:
     params = skill.params or {}
     if not params:
         return {}
-    # 计算器类:从文本提取数学表达式
     if "expression" in params:
         m = re.search(r"[-+*/().\d\s]+", task_text)
         expr = (m.group(0).strip() if m else task_text)
         return {"expression": expr or task_text}
-    # 单参数 skill:把整段任务文本作为该参数
     if len(params) == 1:
         only = next(iter(params))
         return {only: task_text}
-    # 多参数:传 task,让下游(或 LLM)解析;附带上游
     return {"task": task_text, "upstream_outputs": dict(upstream)}
 
 
@@ -174,7 +162,7 @@ def _rollback(executed, registry, res: CompositionResult):
             continue
         side_effect = getattr(skill, "side_effect", "read")
         if side_effect == "read":
-            continue   # 只读操作无副作用,无需回滚
+            continue
         comp = getattr(skill, "compensate", None)
         if comp is not None:
             try:
@@ -184,12 +172,12 @@ def _rollback(executed, registry, res: CompositionResult):
             except Exception as e:
                 res.rollback_log.append({"skill": sid, "status": "compensate_failed",
                                          "detail": f"补偿失败: {e}"})
-                res.rollback_clean = False          # 补偿失败 → 回滚不干净
+                res.rollback_clean = False
                 res.needs_manual.append(sid)
         else:
             res.rollback_log.append({"skill": sid, "status": "manual_required",
                                      "detail": f"{side_effect} 操作无补偿动作,需人工处理"})
-            res.rollback_clean = False              # 有副作用却无法补偿 → 不干净
+            res.rollback_clean = False
             res.needs_manual.append(sid)
 
 
@@ -212,7 +200,7 @@ def _invoke(adapter, skill, args: dict, confirmed: bool, confirm_nonce: str):
 
 
 def compose(plan_obj: Plan, registry, adapter, confirmed: bool = False,
-            resume_state: dict = None) -> CompositionResult:
+            resume_state: dict | None = None) -> CompositionResult:
     """skill-composition:按计划顺序执行各 skill。
 
     结束态三种:
@@ -226,10 +214,9 @@ def compose(plan_obj: Plan, registry, adapter, confirmed: bool = False,
     恢复已完成步骤的 upstream/executed 现场,跳过 resume_at 之前的步骤。
     """
     res = CompositionResult(mode=plan_obj.flow_type)
-    upstream = {}     # skill_id -> output(供下游读取)
-    executed = []     # [(skill_id, output)] 按执行顺序,供回滚
+    upstream = {}
+    executed = []
 
-    # 【P2-2】恢复已完成步骤(断点续跑)
     resume_at = None
     if resume_state:
         for tid, sid, output in resume_state.get("completed_steps", []):
@@ -239,9 +226,6 @@ def compose(plan_obj: Plan, registry, adapter, confirmed: bool = False,
         resume_at = resume_state.get("resume_at")
 
     for i, t in enumerate(plan_obj.tasks, 1):
-        # 【P2-2】跳过已完成的步骤(断点续跑):resume_at 之前的步骤不重跑;
-        # 命中断点后清空 resume_at,让断点及其之后的步骤正常执行。
-        # (若照抄"!= resume_at 就 continue",断点之后的步骤会被一并跳过)
         if resume_at:
             if t.id != resume_at:
                 continue
@@ -251,7 +235,6 @@ def compose(plan_obj: Plan, registry, adapter, confirmed: bool = False,
             res.failed.append(t.id); continue
         skill = registry.get(sid)
         call_args = _build_args(skill, t.name, upstream)
-        # 关键操作二次确认码随 resume_state 回灌:同一 nonce 只能在原动作+原参数上用一次
         _nonce = (resume_state or {}).get("confirm_nonce", "") or ""
         out = _invoke(adapter, skill, call_args, confirmed, _nonce)
         res.stages.append(StageResult(stage=i, skill_id=sid, result=out.to_dict()))
@@ -260,7 +243,6 @@ def compose(plan_obj: Plan, registry, adapter, confirmed: bool = False,
             executed.append((sid, out.output))
             res.completed_steps.append((t.id, sid, out.output))
         elif out.status == "needs_confirmation":
-            # 【P2-2】待确认 → 暂停,不回滚;把断点现场打包给调用方
             res.pending_confirmation = {
                 "task_id": t.id,
                 "skill_id": sid,
@@ -269,8 +251,6 @@ def compose(plan_obj: Plan, registry, adapter, confirmed: bool = False,
                 "args": call_args,
                 "completed_steps": list(res.completed_steps),
                 "resume_at": t.id,
-                # 关键操作:一次性确认码(绑定 skill + 本次 args,过期即废)。
-                # 续跑时把它塞回 resume_state 一起传,才能通过 adapter 的二次确认校验。
                 "confirm_nonce": getattr(out, "confirm_nonce", "") or "",
                 "confirm_expires_at": getattr(out, "confirm_expires_at", 0.0) or 0.0,
             }
@@ -281,7 +261,6 @@ def compose(plan_obj: Plan, registry, adapter, confirmed: bool = False,
             }
             return res
         else:
-            # blocked/circuit_open/error/timeout → 关键路径失败 → 逆序回滚
             res.failed.append(t.id)
             res.final_output = {"error": out.message, "failed_at": t.id}
             _rollback(executed, registry, res)
@@ -290,8 +269,6 @@ def compose(plan_obj: Plan, registry, adapter, confirmed: bool = False,
     return res
 
 
-# ============ 编排器:把 6 个元 skill 串起来 ============
-
 @dataclass
 class PipelineResult:
     task: str
@@ -302,7 +279,7 @@ class PipelineResult:
     summary: str
 
     @property
-    def pending_confirmation(self) -> dict:
+    def pending_confirmation(self) -> dict | None:
         """【P2-2】待确认状态(若无则 None)。结构见 compose 的 pending_confirmation。"""
         return self.composition.get("pending_confirmation")
 
@@ -320,7 +297,7 @@ class AHSPipeline:
         self.adapter = adapter
 
     def run(self, task: str, confirmed: bool = False,
-            resume_state: dict = None, confirm_nonce: str = "") -> PipelineResult:
+            resume_state: dict | None = None, confirm_nonce: str = "") -> PipelineResult:
         """同步执行。【P2-2】resume_state 用于从待确认状态断点续跑
         (传上次返回的 pending_confirmation;确认后调 run(task, confirmed=True, resume_state=...))。
 
@@ -329,25 +306,17 @@ class AHSPipeline:
         """
         if confirm_nonce:
             resume_state = {**(resume_state or {}), "confirm_nonce": confirm_nonce}
-        # session_start 钩子
         self.adapter.hooks.fire("session_start", "", {"task": task})
 
-        # 1. router 选主 skill
         r = route(task, self.registry)
 
-        # 2. planner 拆解(总是出计划;简单任务=单步)
         p = plan(task, self.registry)
 
-        # 3. composition 编排执行(每步内部过 guard+breaker+hooks)
         c = compose(p, self.registry, self.adapter,
                     confirmed=confirmed, resume_state=resume_state)
 
-        # session_end 钩子
         self.adapter.hooks.fire("session_end", "", {"task": task})
 
-        # 【P2-2】success 判定区分 pending:待确认不是失败,但也不是成功
-        # (旧语义:pending 会进 failed → success=False;新语义:pending 非空 → success=False。
-        #  外向结果一致,语义不同——pending 的步骤没有被回滚,可以续跑)
         success = not c.failed and bool(c.stages) and not c.pending_confirmation
         if c.pending_confirmation:
             summary = (f"执行 {len(c.stages)} 步,待确认:"
@@ -367,13 +336,12 @@ class AHSPipeline:
                          "failed": c.failed, "final": c.final_output,
                          "rolled_back": c.rolled_back, "rollback_clean": c.rollback_clean,
                          "rollback_log": c.rollback_log, "needs_manual": c.needs_manual,
-                         # 【P2-2】待确认 + 已完成步骤(供前端识别/续跑)
                          "pending_confirmation": c.pending_confirmation,
                          "completed_steps": [s[0] for s in c.completed_steps]},
             success=success, summary=summary)
 
     async def run_async(self, task: str, confirmed: bool = False,
-                        resume_state: dict = None,
+                        resume_state: dict | None = None,
                         confirm_nonce: str = "") -> PipelineResult:
         """【P2-1】异步入口:把同步 run 放到线程池,避免阻塞事件循环。
 

package/python/foxclaw/skills/policy.py

@@ -12,19 +12,15 @@ class SkillPolicy:
     def __init__(self, data_dir):
         self._path = Path(data_dir) / "skill_policy.json"
         self._lock = threading.RLock()
-        self._deny: set = set()    # user 层:运行时可 deny/undeny,持久化到 skill_policy.json
-        self._allow: set = set()   # 空 = 全放行
-        # E1 分层:policy 层 deny(管理员锁定,env FOXCLAW_POLICY_DENY + <data_dir>/policy.json)。
-        # 与 user 层物理分开、不写回 skill_policy.json;**不可被 undeny 撤销**。默认空 = 现状。
+        self._deny: set = set()
+        self._allow: set = set()
         from ..core.config import LayeredConfig, load_policy_layer
         policy_layer = load_policy_layer(data_dir)
-        # user 层传 self._deny(set 引用)→ 运行时增删被 merged_set 实时反映,无需重建 LayeredConfig
         self._layers = LayeredConfig(policy=policy_layer, user={"deny": self._deny})
         self._load()
 
     def is_blocked(self, skill_id: str) -> bool:
         with self._lock:
-            # deny = policy 层 ∪ user 层(只增不减);deny 压倒 allow
             if skill_id in self._layers.merged_set("deny"):
                 return True
             if self._allow and skill_id not in self._allow:
@@ -39,7 +35,7 @@ class SkillPolicy:
     def undeny(self, skill_id: str) -> bool:
         with self._lock:
             if skill_id in self._layers.policy_locked("deny"):
-                return False       # E1:policy 层为管理员锁定,用户 undeny 无效(deny 铁律)
+                return False
             existed = skill_id in self._deny
             self._deny.discard(skill_id)
         self._save()
@@ -53,15 +49,13 @@ class SkillPolicy:
     def snapshot(self) -> dict:
         with self._lock:
             return {"deny": sorted(self._deny), "allow": sorted(self._allow),
-                    "policy_deny": sorted(self._layers.policy_locked("deny"))}  # E1:管理员锁定项(只读)
+                    "policy_deny": sorted(self._layers.policy_locked("deny"))}
 
     def _load(self):
         if not self._path.exists():
             return
         try:
             d = json.loads(self._path.read_text(encoding="utf-8"))
-            # 就地更新 self._deny(不重新赋值!)——LayeredConfig.user 持有本 set 的引用,
-            # 重新赋值会断开引用,导致从盘加载的 user deny 不被 merged_set 反映(E1 集成的坑)。
             self._deny.clear()
             self._deny.update(d.get("deny") or [])
             self._allow = set(d.get("allow") or [])

package/python/foxclaw/skills/review.py

@@ -20,7 +20,7 @@ def _is_internal_host(host: str) -> bool:
     try:
         infos = socket.getaddrinfo(host, None)
     except Exception:
-        return False   # 解析不了 → 不在安装期硬挡,交运行时 SSRF 兜底
+        return False
     for info in infos:
         try:
             addr = ipaddress.ip_address(info[4][0])
@@ -28,7 +28,7 @@ def _is_internal_host(host: str) -> bool:
             continue
         if addr.is_private or addr.is_loopback or addr.is_link_local or addr.is_reserved:
             return True
-        if str(addr) == "169.254.169.254":   # 云元数据
+        if str(addr) == "169.254.169.254":
             return True
     return False
 
@@ -69,4 +69,4 @@ def review_mcp_server(url: str) -> dict:
     warnings.append("接入外部 MCP server,其返回内容为外部不可信数据,不应被当作指令执行")
     if reasons:
         return {"verdict": "deny", "reasons": reasons, "warnings": warnings}
-    return {"verdict": "warn", "reasons": [], "warnings": warnings}   # 外部低信任恒 warn
+    return {"verdict": "warn", "reasons": [], "warnings": warnings}

package/python/frontend/deck/auth.js

@@ -1,7 +1,3 @@
-/* 鉴权注入:后端若设了 FOXCLAW_API_KEY,同源 /api、/knowledge 请求需带 X-API-Key。
-   从 localStorage.foxclawApiKey 读取并包一层 fetch 自动注入。
-   必须最先加载(在 settings.js 等业务模块之前),否则模块顶层提前发出的请求
-   (如 settings.js 的 loadModel → /api/model)会漏带 key 被 401。 */
 (function(){
   if(window.__foxclawFetchPatched) return;
   const _fetch=window.fetch.bind(window);
@@ -10,14 +6,11 @@
     try{
       const key=localStorage.getItem('foxclawApiKey');
       const u=String(url||'');
-      // /knowledge/* 与 /api/* 一样受后端可选鉴权守护,两者都要注入 key
-      // /stats 是 HKC 统计数据面,后端已纳入守护,同样需要注入
       if(key && (u.indexOf('/api')>=0 || u.indexOf('/knowledge')>=0 || u.indexOf('/stats')>=0)){
         opts=opts||{}; opts.headers=Object.assign({}, opts.headers, {'X-API-Key':key});
       }
     }catch(e){}
     const p=_fetch(url,opts);
-    // 401 检测:后端开了鉴权但本机浏览器没配 key(或 key 错)→ 弹提示条引导(只弹一次)
     try{
       p.then(r=>{
         if(r && r.status===401 && !_authHinted){

package/python/frontend/deck/chat_model_picker.js

@@ -1,11 +1,3 @@
-// chat_model_picker.js — chat 输入框旁的「下拉式模型选择器」
-//
-// 视觉:参考图1 (CodeBuddy 模型列表) + 图2 (「添加自定义」对话框)。
-// 数据:全部走 foxclaw/api/routes/llm_admin.py 的 REST 端点(GET/POST/DELETE)。
-// 状态:切换写入 FOXCLAW_DATA_DIR/.current_model,model_router 用 mtime 缓存 lazy reload,
-//     用户改完**无需重启 foxclaw**,下次 chat 自动走新模型。
-//
-// 不会外泄:GET /api/llm/models 只返 has_key 布尔;POST /api/llm/custom/add 只在服务端保存。
 
 const API_BASE = (typeof window !== 'undefined' && window.API_BASE) || '';
 const _api = (p) => `${API_BASE}/api/llm${p}`;
@@ -13,18 +5,12 @@ const _api = (p) => `${API_BASE}/api/llm${p}`;
 let _models = { providers: [], custom: [], current: null };
 let _menuOpen = false;
 
-// ── 工具 ─────────────────────────────────────────────
-
 function _esc(s) {
   return String(s == null ? '' : s)
     .replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;')
     .replace(/"/g, '&quot;').replace(/'/g, '&#39;');
 }
 
-// BASE URL 规范化(与后端 core/model_router.normalize_base_url 同规则):
-// 无 scheme → 补 https://;path 为空 → 补 /v1;已有 path(/v1、/compatible-mode/v1…)原样保留。
-// 病根:用户照厂商文档填 https://api.deepseek.com,SDK 拼出 /chat/completions → 多数网关 404/401,
-// 用户以为是"模型填不上"。前端先收拾干净,后端再兜一层(旧记录 / 直接调 API 的场景)。
 function _normalizeBaseUrl(u) {
   let s = String(u || '').trim();
   if (!s) return s;
@@ -37,7 +23,6 @@ function _normalizeBaseUrl(u) {
   return `${parsed.protocol}//${parsed.host}${path}${parsed.search || ''}`;
 }
 
-// 常见厂商的模型 ID 提示(只做 placeholder 引导,不阻断保存 —— 自建网关可能有自定义名)
 const _MODEL_HINTS = [
   { re: /api\.deepseek\.com/i,  hint: 'deepseek-chat',   note: 'DeepSeek 官方 ID:deepseek-chat / deepseek-reasoner' },
   { re: /api\.openai\.com/i,    hint: 'gpt-4o-mini',     note: 'OpenAI 官方 ID:gpt-4o-mini / gpt-4o' },
@@ -61,7 +46,6 @@ function _autoCurrent() {
   return !_models.current;
 }
 
-// 当前显示在 pill 上的名称 + 颜色
 function _currentLabel() {
   if (_isCustomCurrent()) {
     const m = _models.custom.find(m => m.name === _models.current.name);
@@ -76,15 +60,12 @@ function _currentLabel() {
   return { name: 'Auto', color: '#7e93b8', isCustom: false };
 }
 
-// ── 渲染:菜单内容 ─────────────────────────────────────
-
 function renderMenu() {
   const menu = document.getElementById('chatModelMenu');
   if (!menu) return;
   const cur = _currentLabel();
   let h = '';
 
-  // Auto(让用户能清掉选择,退回 .env 默认)
   h += `<div class="mp-item ${_autoCurrent() ? 'active' : ''}" data-act="auto">
     <span class="mp-dot" style="background:#7e93b8"></span>
     <span class="mp-name"><b>Auto</b><span>跟随 .env 默认</span></span>
@@ -107,9 +88,6 @@ function renderMenu() {
     h += '<div class="mp-sep">自定义</div>';
     _models.custom.forEach(m => {
       const isCur = _isCustomCurrent() && _models.current.name === m.name;
-      // 三个 tag 都常驻:当前(按需显隐)+ ✎ 编辑 + ✕ 删除
-      // 即使是当前选中的,用户也应该能直接编辑它(改 key / 加 group_id),不能强制切走
-      // 删除当前选中的也安全 —— 后端 DELETE 已处理清 .current_model
       h += `<div class="mp-item ${isCur ? 'active' : ''}" data-act="custom" data-name="${_esc(m.name)}">
         <span class="mp-dot" style="background:#a78bfa;box-shadow:0 0 6px #a78bfa"></span>
         <span class="mp-name"><b>${_esc(m.name)}</b><span>${_esc(m.model)}</span></span>
@@ -127,7 +105,6 @@ function renderMenu() {
 
   menu.innerHTML = h;
 
-  // 事件
   menu.querySelectorAll('.mp-item').forEach(el => {
     el.addEventListener('click', (e) => {
       if (e.target.classList.contains('mp-del')) {
@@ -164,8 +141,6 @@ function renderPill() {
   if (name) name.textContent = cur.name;
 }
 
-// ── API ─────────────────────────────────────────────
-
 async function loadModels() {
   try {
     const r = await fetch(_api('/models'));
@@ -230,14 +205,12 @@ async function addCustom(payload) {
 }
 
 async function getCustom(name) {
-  // 取单个自定义模型详情(后端不返回 api_key 明文,只返 has_key)
   const r = await fetch(_api(`/custom/${encodeURIComponent(name)}`));
   if (!r.ok) throw new Error(`HTTP ${r.status}`);
   return r.json();
 }
 
 async function updateCustom(name, payload) {
-  // payload 字段语义:填了非空 = 用新值;没传(或不传该字段)= 不变;api_key 留空=保留原值
   const r = await fetch(_api(`/custom/${encodeURIComponent(name)}`), {
     method: 'PUT',
     headers: { 'Content-Type': 'application/json' },
@@ -252,7 +225,6 @@ async function updateCustom(name, payload) {
 }
 
 async function editCustom(name) {
-  // 加载详情 → 复用 openAddDialog 切到 edit 模式预填表单
   try {
     const m = await getCustom(name);
     openAddDialog('edit', { ...m, _editingName: name });
@@ -274,9 +246,6 @@ async function testModel(source, provider, name) {
   return r.json();
 }
 
-// ── 添加对话框(图2 风格)────────────────────────────
-
-// 对话框全局状态:add / edit 模式共用同一表单
 let _cmMode = 'add';          // 'add' | 'edit'
 let _cmEditingName = null;    // edit 模式下的原名(PUT URL 用);改名后仍指向磁盘上那条记录
 
@@ -289,7 +258,6 @@ function openAddDialog(mode = 'add', preset = null) {
   const mask = document.getElementById('cmAddMask');
   if (!mask) return;
 
-  // 标题 + 副标题
   const title = document.getElementById('cmAddTitle');
   if (title) {
     title.textContent = mode === 'edit' && preset?.name
@@ -297,7 +265,6 @@ function openAddDialog(mode = 'add', preset = null) {
       : '添加自定义模型';
   }
 
-  // 填表单 — api_key 永远不清空回填(安全考虑)
   const set = (id, v) => { const el = document.getElementById(id); if (el) el.value = v || ''; };
   set('cm_name',          preset?.name);
   set('cm_base_url',      preset?.base_url);
@@ -309,7 +276,6 @@ function openAddDialog(mode = 'add', preset = null) {
   set('cm_note',          preset?.note);
   _applyModelHint(preset?.base_url);
 
-  // API KEY 字段 placeholder 区分 add / edit
   const keyInp = document.getElementById('cm_api_key');
   if (keyInp) {
     keyInp.placeholder = (mode === 'edit' && preset?.has_key)
@@ -323,7 +289,6 @@ function openAddDialog(mode = 'add', preset = null) {
   setTimeout(() => document.getElementById('cm_name')?.focus(), 50);
 }
 
-// 已知厂商的"模型 ID 写错"软提示(只警告不阻断 —— 自建网关可以有自定义别名)
 function _modelWarning(baseUrl, modelId) {
   const s = String(baseUrl || ''), m = String(modelId || '').trim();
   if (!m) return '';
@@ -332,7 +297,6 @@ function _modelWarning(baseUrl, modelId) {
   return '';
 }
 
-// 按 BASE URL 域名更新「模型 ID」的 placeholder + 副标题提示(不阻断保存)
 function _applyModelHint(baseUrl) {
   const hint = _hintForBaseUrl(baseUrl);
   const inp = document.getElementById('cm_model');
@@ -360,7 +324,6 @@ function _readForm() {
   const v = (id) => (document.getElementById(id)?.value || '').trim();
   const out = {
     name:         v('cm_name'),
-    // 保存前再规范化一次(用户可能没触发 blur 直接点保存);后端也会兜一层
     base_url:     _normalizeBaseUrl(v('cm_base_url')),
     api_key:      v('cm_api_key'),
     model:        v('cm_model'),
@@ -384,7 +347,6 @@ function _readForm() {
 async function _onSave() {
   try {
     const payload = _readForm();
-    // name / base_url / model 必填;api_key 在 edit 模式下留空 = 保留(后端校验)
     if (!payload.name || !payload.base_url || !payload.model) {
       _setMsg('请填全 * 号必填项', 'err');
       return;
@@ -401,13 +363,9 @@ async function _onSave() {
     } else {
       const r = await updateCustom(_cmEditingName, payload);
       savedName = r.name;
-      // 改名后,_cmEditingName 失效 → 下次 _onTest 会失败 → 清掉,避免误测
       _cmEditingName = r.name;
     }
     await loadModels();
-    // 保存即生效 —— 用户点「保存」的诉求就是「用它」。
-    // 病根:此前只写盘不切换,聊天仍走 .env 的旧 provider,用户看到 AuthenticationError/stub,
-    // 以为是"模型填不上";实际上是要再回菜单点一次这个条目。现在省掉这一步。
     _setMsg('已保存,正在切换…', 'info');
     const ok = await selectModel('custom', null, savedName);
     _setMsg(ok ? `已保存并切换到 ${savedName}` : `已保存 ${savedName},但切换失败(见弹窗)`,
@@ -426,8 +384,6 @@ async function _onTest() {
       return;
     }
     if (_cmMode === 'edit') {
-      // edit 模式:测磁盘上**已保存**的配置(避免被 form 里未保存的改动误导)
-      // 若想测表单里的新值,先点「保存」再点「测试连通性」
       _setMsg(`测试已保存配置(${_cmEditingName})…`, 'info');
       const r = await testModel('custom', null, _cmEditingName);
       if (r.ok) {
@@ -437,7 +393,6 @@ async function _onTest() {
       }
       return;
     }
-    // add 模式:必须 name + api_key,临时 add 一个 tmp 名测,失败保留
     if (!payload.name || !payload.api_key) {
       _setMsg('add 模式请先填「模型名称」+「API KEY」再测试', 'err');
       return;
@@ -446,7 +401,6 @@ async function _onTest() {
     await addCustom(payload);
     const r = await testModel('custom', null, payload.name);
     if (r.ok) {
-      // 测试通过 = 这份配置真的能用 → 直接切过去,不用用户再回菜单点一次
       await loadModels();
       await selectModel('custom', null, payload.name);
       _setMsg(`✓ 连通 (${r.latency_ms} ms, model=${r.model}) — 已切换`, 'ok');
@@ -459,8 +413,6 @@ async function _onTest() {
   }
 }
 
-// ── 事件绑定 ─────────────────────────────────────
-
 function bindEvents() {
   const pill = document.getElementById('chatModelPill');
   const menu = document.getElementById('chatModelMenu');
@@ -470,7 +422,6 @@ function bindEvents() {
       _menuOpen = !_menuOpen;
       menu.classList.toggle('show', _menuOpen);
     });
-    // 点外面收起
     document.addEventListener('click', (e) => {
       if (!_menuOpen) return;
       if (e.target.closest('#chatModelPick')) return;
@@ -500,7 +451,6 @@ function bindEvents() {
       if (e.target === mask) closeAddDialog();
     });
   }
-  // BASE URL 失焦即规范化(补 https:// / 补 /v1),并联动模型 ID 提示
   const baseInp = document.getElementById('cm_base_url');
   if (baseInp) {
     baseInp.addEventListener('blur', () => {
@@ -521,16 +471,12 @@ function bindEvents() {
   });
 }
 
-// ── 启动 ─────────────────────────────────────────
-
 (function init() {
   bindEvents();
   loadModels();
-  // 多 tab 同步:监听 storage 事件
   window.addEventListener('storage', (e) => {
     if (e.key === '__foxclaw_model_changed__') loadModels();
   });
-  // 切完模型后,广播给其它 tab(简版:周期性 reload)
   setInterval(() => {
     if (_menuOpen) loadModels();
   }, 5000);