formstand 0.7.0 → 0.8.0

package/dist/index.js

@@ -57,7 +57,7 @@ var valuesEqual = (a, b) => {
   if (isPlainObject(a) && isPlainObject(b)) {
     const aKeys = Object.keys(a);
     const bKeys = Object.keys(b);
-    return aKeys.length === bKeys.length && aKeys.every((k) => valuesEqual(a[k], b[k]));
+    return aKeys.length === bKeys.length && aKeys.every((k) => Object.hasOwn(b, k) && valuesEqual(a[k], b[k]));
   }
   return false;
 };
@@ -92,7 +92,7 @@ var readSegment = (obj, segment) => {
   if (Array.isArray(obj)) {
     return typeof segment === "number" ? obj[segment] : void 0;
   }
-  return isPlainRecord(obj) ? obj[String(segment)] : void 0;
+  return isPlainRecord(obj) && Object.hasOwn(obj, String(segment)) ? obj[String(segment)] : void 0;
 };
 var getAtPath = (obj, path) => parsePath(path).reduce(readSegment, obj);
 var slotAtPath = (obj, path) => {
@@ -135,6 +135,12 @@ var writeSegments = (obj, segments, value) => {
     return writeIntoArray(obj, head, rest, value);
   }
   if (isPlainRecord(obj)) {
+    if (!isPlainObject(obj)) {
+      console.warn(
+        `[formstand] cannot write key "${String(head)}" through a non-plain object (Date/Map/Set/class instance); value left unchanged.`
+      );
+      return obj;
+    }
     const key = String(head);
     return { ...obj, [key]: writeSegments(obj[key], rest, value) };
   }
@@ -668,7 +674,11 @@ var createForm = (schema, options) => {
           });
         }
         const merged = stale ? result.errors : store.getState().errors;
-        onInvalid?.(merged);
+        try {
+          onInvalid?.(merged);
+        } catch (error) {
+          return { kind: "error", error };
+        }
         return { kind: "invalid", errors: merged };
       }
       if (!stale) {
@@ -928,9 +938,13 @@ var createForm = (schema, options) => {
         // In-flight state is owned by live passes, never by snapshots: a
         // snapshotted flag has no pass left to clear it (the pass that set
         // it cleared its ORIGINAL entry when it settled), so restoring one
-        // would stick it forever.
+        // would stick it forever. isSubmitting follows the same rule — a
+        // mid-submit snapshot restored later must not disable submit
+        // buttons forever, so it reflects the LIVE submit count instead of
+        // the snapshotted flag (a live pass's finally still resets it).
         isValidating: emptyBools,
-        isValidatingForm: false
+        isValidatingForm: false,
+        isSubmitting: inFlight.count > 0
       };
     })
   });
@@ -958,15 +972,17 @@ var useForm = (schema, options) => {
     formRef.current = createForm(schema, options);
   }
   const form = formRef.current;
+  const mountInitialsRef = useRef(options.initialValues);
   const warnedRef = useRef(false);
   useEffect(() => {
-    if (!warnedRef.current && form.schema !== schema) {
+    const changedInitials = !Object.is(options.initialValues, mountInitialsRef.current) && !valuesEqual(options.initialValues, mountInitialsRef.current);
+    if (!warnedRef.current && (form.schema !== schema || changedInitials)) {
       warnedRef.current = true;
       console.warn(
-        "[formstand] useForm received a different schema reference after the first render; schema and options changes are ignored for the life of the component. If the schema is defined inline this is harmless (but consider hoisting it to module scope). For initial values that arrive later (e.g. from a fetch), call form.adoptValues(values) or form.reset(values) instead."
+        "[formstand] useForm received a different schema or initial values after the first render; schema and options changes are ignored for the life of the component. If the schema is defined inline this is harmless (but consider hoisting it to module scope). For initial values that arrive later (e.g. from a fetch), call form.adoptValues(values) or form.reset(values) instead."
       );
     }
-  }, [form, schema]);
+  }, [form, schema, options.initialValues]);
   return form;
 };
 var createFormContext = () => {
@@ -1132,23 +1148,22 @@ var reconcileIds = (prev, nextItems) => {
     const prevIndex = buckets.get(item)?.shift();
     return prevIndex === void 0 ? null : prev.ids[prevIndex] ?? null;
   });
-  const leftover = [...buckets.values()].flat().sort((a, b) => a - b).map((i) => prev.ids[i]).filter((id) => id !== void 0);
-  const ordinals = matchedIds.reduce((acc, id) => {
-    const count = acc.length === 0 ? 0 : acc[acc.length - 1] ?? 0;
-    acc.push(id === null ? count + 1 : count);
-    return acc;
+  const leftoverAt = new Map(
+    [...buckets.values()].flat().flatMap((i) => {
+      const id = prev.ids[i];
+      return id === void 0 ? [] : [[i, id]];
+    })
+  );
+  const reused = matchedIds.map((id, i) => id ?? leftoverAt.get(i) ?? null);
+  const mintCounts = reused.reduce((acc, id) => {
+    const count = acc[acc.length - 1] ?? 0;
+    return [...acc, id === null ? count + 1 : count];
   }, []);
-  const unmatched = ordinals.length === 0 ? 0 : ordinals[ordinals.length - 1] ?? 0;
-  const ids = matchedIds.map((id, i) => {
-    if (id !== null) return id;
-    const ordinal = ordinals[i] ?? 0;
-    return leftover[ordinal - 1] ?? `__zfa_${prev.counter + (ordinal - leftover.length)}`;
-  });
-  return {
-    items: nextItems,
-    ids,
-    counter: prev.counter + Math.max(0, unmatched - leftover.length)
-  };
+  const minted = mintCounts[mintCounts.length - 1] ?? 0;
+  const ids = reused.map(
+    (id, i) => id ?? `__zfa_${prev.counter + (mintCounts[i] ?? 0)}`
+  );
+  return { items: nextItems, ids, counter: prev.counter + minted };
 };
 function useFieldArray(form, pathArg) {
   const path = useStore(
@@ -1465,7 +1480,8 @@ var SelectField = ({
   const id = useId();
   const errorId = `${id}-error`;
   const field = useField(form, path);
-  const showEmptyOption = field.value === void 0 || field.value === null || placeholder !== void 0;
+  const clearable = field.emptyValue === null;
+  const showEmptyOption = clearable || field.value === void 0 || field.value === null || placeholder !== void 0;
   return /* @__PURE__ */ jsxs("div", { className: "zf-field", children: [
     label !== void 0 ? /* @__PURE__ */ jsx("label", { htmlFor: id, className: "zf-label", children: label }) : null,
     /* @__PURE__ */ jsxs(
@@ -1476,7 +1492,7 @@ var SelectField = ({
         ...selectProps(field),
         "aria-describedby": hasError(field.error) ? errorId : void 0,
         children: [
-          showEmptyOption ? /* @__PURE__ */ jsx("option", { value: "", disabled: true, children: placeholder ?? "" }) : null,
+          showEmptyOption ? /* @__PURE__ */ jsx("option", { value: "", disabled: !clearable, children: placeholder ?? "" }) : null,
           options.map((opt, index) => (
             // Index-qualified: option lists may legitimately repeat a value
             // (e.g. differently-labelled aliases), and bare value keys would