form-tester 0.8.2 → 0.8.3

package/.claude/skills/form-tester/INSTRUCTIONS.md

@@ -78,27 +78,33 @@ Dokumenter verification (only when modal confirms storage):
 1. Navigate to `/dokumenter?pnr={PNR}` and select the same person used during form fill.
 2. The document list loads sorted newest first. The first entry should match the form title.
 3. Click "Se detaljer" on the first document, then click "Åpne dokumentet".
-4. After clicking "Åpne dokumentet", the document may open in a dialog, a new tab, or inline. FIRST determine the format before capturing:
-
-   Step A — Detect format:
-   Run `form-tester exec snapshot` and examine the result.
-   - If you see an iframe/embed/object with a src containing `.pdf`, `blob:`, or a PDF viewer → it's a PDF.
-   - If you see rendered HTML content (headings, paragraphs, form data) → it's HTML.
-   - If `--full-page` screenshot times out → it's almost certainly a PDF viewer. Do NOT retry the screenshot. Switch to PDF download.
-
-   Step B — PDF documents (viewer in dialog/modal/iframe/new tab):
-   Do NOT screenshot PDFs — it will timeout or produce garbage. Download the file:
-   1. Extract PDF URL from the iframe/embed/object:
-      `form-tester exec eval "document.querySelector('iframe')?.src || document.querySelector('embed')?.src || document.querySelector('object')?.data"`
-   2. If the result is a URL, download it with run-code:
-      `form-tester exec run-code "async page => { const url = await page.evaluate(() => document.querySelector('iframe')?.src || document.querySelector('embed')?.src || document.querySelector('object')?.data); if (url) { const resp = await page.request.get(url); require('fs').writeFileSync('$OUTPUT_DIR/document.pdf', await resp.body()); } }"`
-   3. Or if the PDF viewer has a download button, click it.
-   4. Record in test_results.txt: document type PDF, downloaded to document.pdf.
-
-   Step C — HTML documents:
-   Take a FULL-PAGE screenshot (`form-tester exec screenshot --filename "$OUTPUT_DIR/document_screenshot.png" --full-page`).
+4. After clicking "Åpne dokumentet", determine the document format:
+
+   How to detect format:
+   - Take a snapshot: `form-tester exec snapshot`
+   - If snapshot shows a link with href containing `/pdf/` or `blob:` → PDF
+   - If `--full-page` screenshot times out → PDF (do NOT retry, switch to download)
+   - If snapshot shows rendered HTML content (headings, paragraphs, form data) → HTML
+
+   PDF documents — DOWNLOAD, do NOT screenshot:
+   IMPORTANT: `run-code` does NOT have access to `require` or `fs`. Do NOT use `require('fs')`. Use Playwright's download API instead.
+
+   Find the PDF download link in the snapshot (look for `a[href*="/pdf/"]` or "Last ned" link), then download using the Playwright download event:
+   ```
+   form-tester exec run-code "async page => { const link = page.locator('a[href*=\"/pdf/\"]').first(); const [download] = await Promise.all([ page.waitForEvent('download'), link.click() ]); await download.saveAs('$OUTPUT_DIR/document.pdf'); }"
+   ```
+   If there is no direct PDF link but a "Last ned" button:
+   ```
+   form-tester exec run-code "async page => { const [download] = await Promise.all([ page.waitForEvent('download'), page.getByRole('link', { name: 'Last ned' }).click() ]); await download.saveAs('$OUTPUT_DIR/document.pdf'); }"
+   ```
+   Verify the download: check that document.pdf exists in the output folder.
+
+   HTML documents — SCREENSHOT full page:
+   ```
+   form-tester exec screenshot --filename "$OUTPUT_DIR/document_screenshot.png" --full-page
+   ```
    Also save raw HTML: `form-tester exec eval "document.documentElement.outerHTML"` → save to document.html.
 
-   Step D — XML/other: Note type in test_results.txt, skip capture.
+   XML/other: Note type in test_results.txt, skip capture.
 
 5. Include the document verification results in test_results.txt (document title, whether it matched the form h1, document type: HTML/PDF/XML).

package/.github/copilot-instructions.md

@@ -87,13 +87,18 @@ After submission, read the modal text:
 - If it mentions Dokumenter storage -> navigate to `/dokumenter?pnr={PNR}`, verify the document appears.
 - If it does NOT mention Dokumenter -> skip verification, note in test_results.txt.
 
-Document capture — FIRST detect the format by running `form-tester exec snapshot`:
+Document capture — detect format via `form-tester exec snapshot`:
 
-**PDF documents** (iframe/embed with .pdf or blob: URL, or screenshot times out): Do NOT screenshot PDFs. Download instead:
-1. Extract URL: `form-tester exec eval "document.querySelector('iframe')?.src || document.querySelector('embed')?.src || document.querySelector('object')?.data"`
-2. Download: `form-tester exec run-code "async page => { const url = await page.evaluate(() => document.querySelector('iframe')?.src || document.querySelector('embed')?.src || document.querySelector('object')?.data); if (url) { const resp = await page.request.get(url); require('fs').writeFileSync('OUTPUT_DIR/document.pdf', await resp.body()); } }"`
-3. Or click the download button in the PDF viewer if available.
-4. If `--full-page` screenshot times out, it's a PDF — switch to download, don't retry screenshot.
+**PDF documents** (link with href containing `/pdf/`, or screenshot times out):
+Do NOT screenshot PDFs. Do NOT use `require('fs')` in run-code (it doesn't exist there).
+Download using Playwright's download event:
+```
+form-tester exec run-code "async page => { const link = page.locator('a[href*=\"/pdf/\"]').first(); const [download] = await Promise.all([ page.waitForEvent('download'), link.click() ]); await download.saveAs('$OUTPUT_DIR/document.pdf'); }"
+```
+Or if there's a "Last ned" button:
+```
+form-tester exec run-code "async page => { const [download] = await Promise.all([ page.waitForEvent('download'), page.getByRole('link', { name: 'Last ned' }).click() ]); await download.saveAs('$OUTPUT_DIR/document.pdf'); }"
+```
 
 **HTML documents**: `form-tester exec screenshot --filename "..." --full-page`. Also save raw HTML.
 

package/form-tester.js

@@ -6,7 +6,7 @@ const { spawn, execSync } = require("child_process");
 
 const CONFIG_PATH = path.join(process.cwd(), "form-tester.config.json");
 const OUTPUT_BASE = path.resolve(process.cwd(), "output");
-const LOCAL_VERSION = "0.8.2";
+const LOCAL_VERSION = "0.8.3";
 const RECOMMENDED_PERSON = "Uromantisk Direktør";
 
 // Recording — persisted to disk so `form-tester exec` can append across processes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "form-tester",
-  "version": "0.8.2",
+  "version": "0.8.3",
   "description": "AI-powered form testing skill for /skjemautfyller forms using Playwright CLI. Works with Claude Code and GitHub Copilot.",
   "main": "form-tester.js",
   "bin": {