form-tester 0.7.3 → 0.8.0

package/.claude/skills/form-tester/INSTRUCTIONS.md

@@ -69,22 +69,27 @@ Dokumenter verification (only when modal confirms storage):
 1. Navigate to `/dokumenter?pnr={PNR}` and select the same person used during form fill.
 2. The document list loads sorted newest first. The first entry should match the form title.
 3. Click "Se detaljer" on the first document, then click "Åpne dokumentet".
-4. IMPORTANT - document capture depends on format:
-
-   PDF documents (shown in a PDF viewer/modal/iframe):
-   Do NOT screenshot PDFs. Instead, download the actual PDF file:
-   a. Take a snapshot to find the PDF viewer element: `form-tester exec snapshot`
-   b. Find the iframe or embed/object element that displays the PDF. Look for src attributes containing .pdf or blob: URLs.
-   c. Extract the PDF URL: `form-tester exec eval "document.querySelector('iframe')?.src || document.querySelector('embed')?.src || document.querySelector('object')?.data"`
-   d. If the URL is a blob: URL or direct PDF link, download it: `form-tester exec eval "async () => { const r = await fetch(document.querySelector('iframe')?.src); const b = await r.blob(); return URL.createObjectURL(b); }"`
-   e. Or use the download button if the PDF viewer has one — look for a download icon/button in the snapshot and click it.
-   f. Save the PDF: `form-tester exec pdf --filename "$OUTPUT_DIR/document.pdf"`
-   g. If all else fails, right-click save or use: `form-tester exec run-code "async page => { const frame = page.frameLocator('iframe').first(); /* extract content */ }"`
-
-   HTML documents (opens in a new tab or renders in page):
-   Take a FULL-PAGE screenshot of the ENTIRE document (`form-tester exec screenshot --filename "$OUTPUT_DIR/document_screenshot.png" --full-page`). HTML documents cannot be downloaded as files, so the full-page screenshot is the primary artifact. Also save the snapshot and raw HTML with:
-   `form-tester exec eval "document.documentElement.outerHTML"` and save to document.html.
-
-   XML/other formats: Note the document type in test_results.txt and skip capture.
+4. After clicking "Åpne dokumentet", the document may open in a dialog, a new tab, or inline. FIRST determine the format before capturing:
+
+   Step A — Detect format:
+   Run `form-tester exec snapshot` and examine the result.
+   - If you see an iframe/embed/object with a src containing `.pdf`, `blob:`, or a PDF viewer → it's a PDF.
+   - If you see rendered HTML content (headings, paragraphs, form data) → it's HTML.
+   - If `--full-page` screenshot times out → it's almost certainly a PDF viewer. Do NOT retry the screenshot. Switch to PDF download.
+
+   Step B — PDF documents (viewer in dialog/modal/iframe/new tab):
+   Do NOT screenshot PDFs — it will timeout or produce garbage. Download the file:
+   1. Extract PDF URL from the iframe/embed/object:
+      `form-tester exec eval "document.querySelector('iframe')?.src || document.querySelector('embed')?.src || document.querySelector('object')?.data"`
+   2. If the result is a URL, download it with run-code:
+      `form-tester exec run-code "async page => { const url = await page.evaluate(() => document.querySelector('iframe')?.src || document.querySelector('embed')?.src || document.querySelector('object')?.data); if (url) { const resp = await page.request.get(url); require('fs').writeFileSync('$OUTPUT_DIR/document.pdf', await resp.body()); } }"`
+   3. Or if the PDF viewer has a download button, click it.
+   4. Record in test_results.txt: document type PDF, downloaded to document.pdf.
+
+   Step C — HTML documents:
+   Take a FULL-PAGE screenshot (`form-tester exec screenshot --filename "$OUTPUT_DIR/document_screenshot.png" --full-page`).
+   Also save raw HTML: `form-tester exec eval "document.documentElement.outerHTML"` → save to document.html.
+
+   Step D — XML/other: Note type in test_results.txt, skip capture.
 
 5. Include the document verification results in test_results.txt (document title, whether it matched the form h1, document type: HTML/PDF/XML).

package/.github/copilot-instructions.md

@@ -82,13 +82,14 @@ After submission, read the modal text:
 - If it mentions Dokumenter storage -> navigate to `/dokumenter?pnr={PNR}`, verify the document appears.
 - If it does NOT mention Dokumenter -> skip verification, note in test_results.txt.
 
-Document capture depends on format:
+Document capture — FIRST detect the format by running `form-tester exec snapshot`:
 
-**PDF documents** (shown in PDF viewer/modal/iframe): Do NOT screenshot PDFs. Download the file instead:
-1. Take a snapshot to find the PDF viewer: `form-tester exec snapshot`
-2. Extract the PDF URL from the iframe/embed: `form-tester exec eval "document.querySelector('iframe')?.src || document.querySelector('embed')?.src || document.querySelector('object')?.data"`
-3. Download via: `form-tester exec pdf --filename "$OUTPUT_DIR/document.pdf"` or click the download button in the PDF viewer if available.
+**PDF documents** (iframe/embed with .pdf or blob: URL, or screenshot times out): Do NOT screenshot PDFs. Download instead:
+1. Extract URL: `form-tester exec eval "document.querySelector('iframe')?.src || document.querySelector('embed')?.src || document.querySelector('object')?.data"`
+2. Download: `form-tester exec run-code "async page => { const url = await page.evaluate(() => document.querySelector('iframe')?.src || document.querySelector('embed')?.src || document.querySelector('object')?.data); if (url) { const resp = await page.request.get(url); require('fs').writeFileSync('OUTPUT_DIR/document.pdf', await resp.body()); } }"`
+3. Or click the download button in the PDF viewer if available.
+4. If `--full-page` screenshot times out, it's a PDF — switch to download, don't retry screenshot.
 
-**HTML documents**: take a full-page screenshot of the ENTIRE document (`form-tester exec screenshot --filename "..." --full-page`). Also save raw HTML with `form-tester exec eval "document.documentElement.outerHTML"`.
+**HTML documents**: `form-tester exec screenshot --filename "..." --full-page`. Also save raw HTML.
 
 **XML/other**: note the type in test_results.txt and skip capture.

package/form-tester.js

@@ -6,7 +6,7 @@ const { spawn, execSync } = require("child_process");
 
 const CONFIG_PATH = path.join(process.cwd(), "form-tester.config.json");
 const OUTPUT_BASE = path.resolve(process.cwd(), "output");
-const LOCAL_VERSION = "0.7.3";
+const LOCAL_VERSION = "0.8.0";
 const RECOMMENDED_PERSON = "Uromantisk Direktør";
 
 // Recording — persisted to disk so `form-tester exec` can append across processes
@@ -955,12 +955,10 @@ async function handleTest(url, config) {
       "/dokumenter?pnr={PNR}",
   );
 
-  // Save recording
-  const recordingPath = saveRecording();
-  if (recordingPath) {
-    console.log(`Recording saved: ${recordingPath}`);
-    console.log(`Replay with: form-tester replay "${recordingPath}"`);
-  }
+  // Don't finalize recording — exec commands will keep appending.
+  console.log(`Recording active: ${config.activeRecording}`);
+  console.log(`Use 'form-tester exec' for all playwright-cli commands to record them.`);
+  console.log(`Recording finalizes on 'form-tester exec close'.`);
 }
 
 async function handleTestAuto(url, config, flags) {
@@ -1073,12 +1071,11 @@ async function handleTestAuto(url, config, flags) {
     printNextSteps(outputDir, dokumenterUrl || "/dokumenter?pnr={PNR}");
   }
 
-  // Save recording
-  const recordingPath = saveRecording();
-  if (recordingPath) {
-    log(`Recording saved: ${recordingPath}`);
-    log(`Replay with: form-tester replay "${recordingPath}"`);
-  }
+  // Don't finalize recording here — `form-tester exec` commands will keep appending.
+  // Recording is finalized when `form-tester exec close` is called.
+  log(`Recording active: ${config.activeRecording}`);
+  log(`Use 'form-tester exec' for all playwright-cli commands to record them.`);
+  log(`Recording finalizes on 'form-tester exec close'.`);
 }
 
 async function handleReplay(filePath) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "form-tester",
-  "version": "0.7.3",
+  "version": "0.8.0",
   "description": "AI-powered form testing skill for /skjemautfyller forms using Playwright CLI. Works with Claude Code and GitHub Copilot.",
   "main": "form-tester.js",
   "bin": {