form-tester 0.5.0 → 0.5.1

package/.claude/skills/form-tester/INSTRUCTIONS.md

@@ -45,6 +45,7 @@ Notes:
 - Use `--help` or `-h` to print the command list without starting the prompt.
 - Playwright CLI commands are available from this skill when needed.
 - IMPORTANT: All screenshots taken during a test run MUST use `--full-page` to capture the entire page, not just the viewport. This applies to every screenshot command: `playwright-cli screenshot --filename "..." --full-page`
+- IMPORTANT: Take a full-page screenshot EVERY TIME the page changes. This includes: after clicking any action button (Neste, Forrige, Send inn, etc.), after a step/page transition, after form validation errors appear, after modals open, and after submission. Name screenshots descriptively (e.g., step1_filled.png, step2_before_submit.png, submit_result.png).
 
 Test flow (when /test is triggered):
 IMPORTANT: Each prompt below MUST be asked as a separate message to the user. Wait for the user's response before proceeding to the next step. Do NOT combine multiple prompts into one message.
@@ -63,7 +64,8 @@ Dokumenter verification (only when modal confirms storage):
 1. Navigate to `/dokumenter?pnr={PNR}` and select the same person used during form fill.
 2. The document list loads sorted newest first. The first entry should match the form title.
 3. Click "Se detaljer" on the first document, then click "Åpne dokumentet".
-4. If the document opens in a new tab as HTML: switch to that tab, take a full-page screenshot (`--full-page`), save snapshot and raw HTML.
-5. If the document opens as a PDF viewer: download the PDF instead of screenshotting. Use `playwright-cli pdf --filename "$OUTPUT_DIR/document.pdf"` or save it via the download.
-6. If the document does NOT open (XML format, no new tab, or other): note the document type in test_results.txt and skip the screenshot/download.
-7. Include the document verification results in test_results.txt (document title, whether it matched the form h1, document type: HTML/PDF/XML).
+4. IMPORTANT - document capture depends on format:
+   - PDF documents: DOWNLOAD the file. Use `playwright-cli pdf --filename "$OUTPUT_DIR/document.pdf"` or save via browser download. Do NOT screenshot PDFs.
+   - HTML documents: Take a FULL-PAGE screenshot of the ENTIRE document (`playwright-cli screenshot --filename "$OUTPUT_DIR/document_screenshot.png" --full-page`). HTML documents cannot be downloaded as files, so the full-page screenshot is the primary artifact. Also save the snapshot and raw HTML.
+   - XML/other formats: Note the document type in test_results.txt and skip capture.
+5. Include the document verification results in test_results.txt (document title, whether it matched the form h1, document type: HTML/PDF/XML).

package/.github/copilot-instructions.md

@@ -62,11 +62,17 @@ When `/test` is triggered:
 
 - Provide a full /skjemautfyller URL. If `pnr` is missing, the CLI will prompt.
 - All screenshots MUST use `--full-page` to capture the entire page.
+- Take a full-page screenshot EVERY TIME the page changes: after clicking action buttons (Neste, Forrige, Send inn), after step/page transitions, after validation errors, after modals, and after submission.
 - Use `/save {label}` to capture additional snapshots into the output folder.
 - If an error modal appears on submit, open DevTools -> Network, retry once, and capture the Correlation ID header.
 
 ## Post-Submit Verification
 
 After submission, read the modal text:
-- If it mentions Dokumenter storage -> navigate to `/dokumenter?pnr={PNR}`, verify the document appears, and capture it (screenshot for HTML, download for PDF).
+- If it mentions Dokumenter storage -> navigate to `/dokumenter?pnr={PNR}`, verify the document appears.
 - If it does NOT mention Dokumenter -> skip verification, note in test_results.txt.
+
+Document capture depends on format:
+- **PDF documents**: download the file (`playwright-cli pdf --filename "..." `). Do NOT screenshot PDFs.
+- **HTML documents**: take a full-page screenshot of the ENTIRE document (`playwright-cli screenshot --filename "..." --full-page`). HTML documents cannot be downloaded, so the screenshot is the primary artifact.
+- **XML/other**: note the type in test_results.txt and skip capture.

package/README.md

@@ -112,6 +112,13 @@ Test runs are saved to `output/{form-id}/{timestamp}/` with:
 - Screenshots (PNG, full-page)
 - `test_results.txt`
 
+### Dokumenter verification
+
+After form submission, some forms store a copy in Dokumenter. The document type determines how to capture it:
+
+- **PDF documents** — download the file directly (`playwright-cli pdf` or via browser download)
+- **HTML documents** — take a full-page screenshot of the entire document (`playwright-cli screenshot --filename "..." --full-page`). HTML documents cannot be downloaded as-is, so the screenshot is the primary artifact.
+
 ## Update
 
 ```bash

package/form-tester.js

@@ -6,7 +6,7 @@ const { spawn, execSync } = require("child_process");
 
 const CONFIG_PATH = path.join(process.cwd(), "form-tester.config.json");
 const OUTPUT_BASE = path.resolve(process.cwd(), "output");
-const LOCAL_VERSION = "0.5.0";
+const LOCAL_VERSION = "0.5.1";
 const RECOMMENDED_PERSON = "Uromantisk Direktør";
 
 const PERSONAS = [
@@ -884,10 +884,10 @@ async function handleTestAuto(url, config, flags) {
   const log = (msg) => { if (v !== "silent") console.log(msg); };
   const verbose = (msg) => { if (v === "verbose") console.log(msg); };
 
-  // Resolve PNR
-  const pnr = flags.pnr || config.pnr;
+  // Resolve PNR — check URL first, then flag, then config
+  const pnr = extractPnrFromUrl(url) || flags.pnr || config.pnr;
   if (!pnr) {
-    console.error("No PNR available. Pass --pnr <value> or set it in form-tester.config.json");
+    console.error("No PNR available. Pass --pnr <value>, include pnr= in the URL, or set it in form-tester.config.json");
     process.exit(1);
   }
   const fullUrl = extractPnrFromUrl(url) ? url : setPnrOnUrl(url, pnr);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "form-tester",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "AI-powered form testing skill for /skjemautfyller forms using Playwright CLI. Works with Claude Code and GitHub Copilot.",
   "main": "form-tester.js",
   "bin": {