form-tester 0.11.3 → 0.11.5

package/form-tester.js

@@ -7,7 +7,7 @@ const { spawn, execSync } = require("child_process");
 const CONFIG_PATH = path.join(process.cwd(), "form-tester.config.json");
 const OUTPUT_BASE = path.resolve(process.cwd(), "output");
 const ISSUES_PATH = path.join(OUTPUT_BASE, "issues.jsonl");
-const LOCAL_VERSION = "0.11.3";
+const LOCAL_VERSION = "0.11.5";
 const RECOMMENDED_PERSON = "Uromantisk Direktør";
 
 // Recording — persisted to disk so `form-tester exec` can append across processes
@@ -167,36 +167,99 @@ async function handleDocuments(config, flags = {}) {
   }
   await sleep(2000);
 
-  // Step 2: Check if person selection is needed
+  // Step 2: Check if person selection is needed — parse snapshot for person buttons
   const checkSnapshot = path.join(outputDir, "dokumenter_check.yml");
   await runPlaywrightCli(["snapshot", "--filename", checkSnapshot]);
   if (fs.existsSync(checkSnapshot)) {
     const checkText = fs.readFileSync(checkSnapshot, "utf8");
     if (checkText.includes("Hvem vil du bruke Helsenorge") || checkText.includes("personliste")) {
-      log("Person selection detected on Dokumenter page. Selecting person...");
-      // Use direct click approach — the person page has simple buttons with person names
+      log("Person selection detected on Dokumenter page.");
       const personName = config.lastPerson || config.person || RECOMMENDED_PERSON;
-      const clickScript = `() => {
-        const buttons = Array.from(document.querySelectorAll('button'));
-        const target = ${JSON.stringify(personName)};
-        for (const btn of buttons) {
-          const text = (btn.textContent || "").replace(/\\s+/g, " ").trim();
-          if (text.includes(target)) { btn.click(); return "clicked: " + text.substring(0, 60); }
+      // Find the button ref INSIDE the person list region (not the nav header)
+      let clickRef = null;
+      const lines = checkText.split(/\r?\n/);
+      let inRegion = false;
+      for (const line of lines) {
+        if (line.includes('region "Hvem vil du bruke Helsenorge')) inRegion = true;
+        if (!inRegion) continue;
+        const btnMatch = line.match(/button "([^"]*)" \[ref=(e\d+)\]/);
+        if (btnMatch) {
+          // First try to match person name
+          if (btnMatch[1].includes(personName)) {
+            clickRef = btnMatch[2];
+            log(`Found person button: "${btnMatch[1]}" (ref=${clickRef})`);
+            break;
+          }
+          // Or take first button in region as fallback
+          if (!clickRef) {
+            clickRef = btnMatch[2];
+          }
+        }
+      }
+      if (clickRef && !lines.some((l) => l.includes(personName) && l.includes(clickRef))) {
+        log(`Fallback: clicking first person button in region (ref=${clickRef})`);
+      }
+      if (clickRef) {
+        await runPlaywrightCli(["click", clickRef]);
+        log("Person clicked on Dokumenter page. Waiting for navigation...");
+        await sleep(3000);
+        // Verify we left the person picker — take a new snapshot
+        const verifySnapshot = path.join(outputDir, "dokumenter_verify.yml");
+        await runPlaywrightCli(["snapshot", "--filename", verifySnapshot]);
+        if (fs.existsSync(verifySnapshot)) {
+          const verifyText = fs.readFileSync(verifySnapshot, "utf8");
+          if (verifyText.includes("Hvem vil du bruke Helsenorge")) {
+            // Still on person picker — the click might have opened the nav dropdown instead
+            // Try clicking the person button inside the full-page list (region), not the nav
+            log("Still on person picker. Looking for person in full-page list...");
+            const regionLines = verifyText.split(/\r?\n/);
+            let inFullPageRegion = false;
+            let retryRef = null;
+            for (const line of regionLines) {
+              if (line.includes('region "Hvem vil du bruke Helsenorge')) inFullPageRegion = true;
+              if (line.includes('listitem') && inFullPageRegion) {
+                const btnMatch = line.match(/button "[^"]*" \[ref=(e\d+)\]/);
+                // Also check next lines for button
+                if (btnMatch) {
+                  retryRef = btnMatch[1];
+                  break;
+                }
+              }
+              if (inFullPageRegion) {
+                const btnMatch = line.match(/button "([^"]*)" \[ref=(e\d+)\]/);
+                if (btnMatch && btnMatch[1].includes(personName)) {
+                  retryRef = btnMatch[2];
+                  break;
+                }
+              }
+            }
+            // If region-based search didn't find it, just click first listitem button in region
+            if (!retryRef && inFullPageRegion) {
+              let inList = false;
+              for (const line of regionLines) {
+                if (line.includes('region "Hvem vil du bruke Helsenorge')) inList = true;
+                if (inList) {
+                  const btnMatch = line.match(/button "[^"]*" \[ref=(e\d+)\].*\[cursor=pointer\]/);
+                  if (btnMatch) {
+                    retryRef = btnMatch[1];
+                    break;
+                  }
+                }
+              }
+            }
+            if (retryRef) {
+              log(`Retrying with ref=${retryRef}...`);
+              await runPlaywrightCli(["click", retryRef]);
+              await sleep(3000);
+            }
+          }
+          try { fs.unlinkSync(verifySnapshot); } catch (e) {}
         }
-        // Fallback: click first person button (usually has class personliste__person)
-        const first = document.querySelector('button[class*="personliste"], button[class*="person"]');
-        if (first) { first.click(); return "clicked-first: " + (first.textContent || "").trim().substring(0, 60); }
-        return "not-found";
-      }`;
-      const personResult = await runPlaywrightCliCapture(["eval", clickScript]);
-      const personOutput = personResult.stdout.replace(/^### Result\s*/i, "").trim();
-      if (personOutput.startsWith("clicked")) {
-        log(`Person selected: ${personOutput}`);
       } else {
-        log("Could not auto-select person. Trying select-person command...");
+        log("Could not find person button in snapshot. Trying select-person...");
         await handleSelectPerson(config, personName);
+        await sleep(3000);
       }
-      await sleep(2000);
     }
     try { fs.unlinkSync(checkSnapshot); } catch (e) {}
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "form-tester",
-  "version": "0.11.3",
+  "version": "0.11.5",
   "description": "AI-powered form testing skill for /skjemautfyller forms using Playwright CLI. Works with Claude Code and GitHub Copilot.",
   "main": "form-tester.js",
   "bin": {