forgedock 1.8.1 → 1.8.2

package/scripts/lint-dispatch-prompt.sh

@@ -0,0 +1,217 @@
+#!/usr/bin/env bash
+# SPDX-FileCopyrightText: Copyright (c) RapierCraft Studios
+# SPDX-License-Identifier: AGPL-3.0-or-later
+#
+# lint-dispatch-prompt.sh — Best-effort enforcement of /orchestrate Hard Rule 1
+# ("copy the Phase 4A template verbatim; no custom prompts").
+#
+# NOTE: this is a best-effort, self-run guard, not a tamper-proof gate: no hook gates
+# Agent(...), so the orchestrator must run it. Free-text slots (issue title, DISPATCH_CONTEXT)
+# are phrase-scanned only and can be bypassed by rephrasing.
+#
+# Lints a RENDERED dispatch prompt (the text handed to Agent(prompt=...)) so an
+# orchestrator cannot pre-solve an issue or pre-decide its verdict in a custom brief.
+#
+# Usage:
+#   lint-dispatch-prompt.sh [--expect KEY=VALUE]... <prompt-file>   (or "-" / no file to read stdin)
+#
+#   Every placeholder the orchestrator resolves itself (PROJECT_NAME, GH_REPO, REPO_PATH, LANE,
+#   PR_BASE, STAGING_BRANCH, SOURCE_BRANCH, NUMBER, FORGE_GIST_CAPABLE, SUBAGENT_MODEL,
+#   PROJECT_PREFIX, SATELLITE_PREFIX, FORGE_SKILL_PREFIX) must EXACTLY equal the value passed via
+#   --expect KEY=VALUE (repeatable; split on the first "="; an empty VALUE is legal). The value
+#   is never eval'd or re-interpreted, so spaces, parentheses, backslashes and non-ASCII are safe
+#   (pass it as one quoted argument). A resolvable slot present in the prompt with NO --expect is
+#   refused (fail closed); there is no charset/stopword fallback. Free-text slots (the issue
+#   title, the DISPATCH_CONTEXT block) cannot be pre-resolved and keep the directive-phrase scan.
+#
+# Structure expected (see commands/orchestrate/phase-4-execution.md Step 4A):
+#   <fixed 4A template text>
+#   **Issue title**: ...
+#   <!-- DISPATCH_CONTEXT:BEGIN -->   (allowed variable blocks only:
+#   ...                                       GIST_CONTEXT, SOURCE_PR_HINT_CONTEXT,
+#   <!-- DISPATCH_CONTEXT:END -->       claims board, same-file "what changed")
+#   (nothing else)
+#
+# Checks:
+#   1. Required template anchors are present (mission, loop contract, Skill invocation).
+#   2. Nothing but the context block follows the "**Issue title**" line.
+#   3. Outside the context block, no verdict/fix-prescribing or resume-shortcut language
+#      (the Issue title text is scanned too), and every line before the title must
+#      match a line of the real Step 4A template (allowlist); resolvable placeholders must
+#      equal their --expect value byte for byte.
+#   4. Inside the context block, the strongest directive phrases are rejected
+#      (context may legitimately quote investigations, so the list is narrower).
+#
+# Output: LINT: PASS | LINT: FAIL, then one "VIOLATION: <reason>" line per problem.
+# Exit codes: 0 pass, 1 violations, 2 unreadable input.
+
+set -uo pipefail
+
+# Max findings reported per check (also the awk template-mismatch cap).
+MAX_HITS=5
+
+# Expected values for orchestrator-resolved placeholders: one "KEY=VALUE" line per --expect in a
+# temp file that awk reads byte-exact (no shell/awk escape processing of the value).
+EXPECT_FILE="$(mktemp)"; trap 'rm -f "$EXPECT_FILE"' EXIT
+NL='
+'
+SRC="-"; SRC_SET=0
+while [ $# -gt 0 ]; do
+  case "$1" in
+    --expect)
+      if [ $# -lt 2 ] || [[ "$2" != [A-Z_]*=* ]]; then
+        echo "LINT: ERROR"; echo "VIOLATION: --expect needs KEY=VALUE (KEY is UPPER_CASE)"; exit 2
+      fi
+      case "$2" in *"$NL"*) echo "LINT: ERROR"; echo "VIOLATION: --expect value must not contain a newline"; exit 2;; esac
+      printf '%s\n' "$2" >> "$EXPECT_FILE"; shift 2 ;;
+    --expect=*)
+      echo "LINT: ERROR"; echo "VIOLATION: use '--expect KEY=VALUE' (separate arguments)"; exit 2 ;;
+    *) if [ "$SRC_SET" -eq 1 ]; then echo "LINT: ERROR"; echo "VIOLATION: unexpected argument: $1"; exit 2; fi
+       SRC="$1"; SRC_SET=1; shift ;;
+  esac
+done
+if [ "$SRC" = "-" ]; then
+  PROMPT="$(cat)"
+elif [ -r "$SRC" ]; then
+  PROMPT="$(cat "$SRC")"
+else
+  echo "LINT: ERROR"; echo "VIOLATION: cannot read prompt file: $SRC"; exit 2
+fi
+# Normalize CRLF -> LF so Windows-authored prompts are compared on content (forge#3078).
+# Strip only a TRAILING CR per line: a mid-line CR is content and must not be silently
+# erased (it could hide text from the line-oriented checks). printf-built CR keeps this
+# portable to BSD sed, which does not interpret \r (forge#3085).
+CR="$(printf '\r')"
+PROMPT="$(printf '%s' "$PROMPT" | sed "s/${CR}\$//")"
+[ -n "$PROMPT" ] || { echo "LINT: ERROR"; echo "VIOLATION: empty prompt"; exit 2; }
+
+BEGIN='<!-- DISPATCH_CONTEXT:BEGIN -->'
+END='<!-- DISPATCH_CONTEXT:END -->'
+FAILS=()
+fail() { FAILS+=("$1"); }
+
+# Phrases that pre-decide a verdict or fix, or turn a relaunch into "finish the leftovers".
+STRONG='(likely|probably|possibly) (already )?(resolved|fixed|moot|invalid|a duplicate)|already (resolved|fixed|implemented)[ ,.]*(—|-|,)? *(verify|close)|verify (it|this)?[ ,]*and close|\b(proposed|suggested|recommended|prescribed) (fix|solution)\b|make (the|this|that) [a-z_ -]{1,60}(terminal|return early|raise)|implement the following|(continue|resume|pick up) (from )?where (you|the previous (agent|run)) left off|finish (what|the work|the uncommitted)|uncommitted (work|changes) (from|left)|the (fix|solution) (is|was)([ ,]+(simply|just))?([ ,]+to\b|[ ,]*:)'
+# Outside the context block additionally reject generic fix-design language.
+WIDE="$STRONG|the (fix|root cause|diagnosis|solution) is\\b|\\broot cause( is|:)|\\bdiagnosis:|(just|simply) (read and edit|edit the file)"
+
+# --- 1. anchors -------------------------------------------------------------
+for anchor in '**YOUR MISSION**' 'LABEL-STATE LOOP CONTRACT' 'Skill(skill=' '--under-orchestration' '**LANE**' '**Issue title**:'; do
+  grep -qF -- "$anchor" <<< "$PROMPT" || fail "missing required template anchor: $anchor"
+done
+
+# --- 2. structure after the Issue title line ---------------------------------
+TITLE_LN=$(grep -nF -- '**Issue title**:' <<< "$PROMPT" | head -1 | cut -d: -f1)
+if [ -n "$TITLE_LN" ]; then
+  HEAD_PART=$(printf '%s\n' "$PROMPT" | sed -n "1,${TITLE_LN}p")
+  TAIL_PART=$(printf '%s\n' "$PROMPT" | sed -n "$((TITLE_LN+1)),\$p")
+else
+  HEAD_PART="$PROMPT"; TAIL_PART=""
+fi
+
+FIRST_NONBLANK=$(grep -v '^[[:space:]]*$' <<< "$TAIL_PART" | head -1)
+CTX=""; AFTER=""
+if grep -qF -- "$BEGIN" <<< "$TAIL_PART"; then
+  if [ "$FIRST_NONBLANK" != "$BEGIN" ]; then
+    fail "content between '**Issue title**' and the DISPATCH_CONTEXT block is not allowed"
+  fi
+  if grep -qF -- "$END" <<< "$TAIL_PART"; then
+    CTX=$(printf '%s\n' "$TAIL_PART" | sed -n "/$(printf '%s' "$BEGIN" | sed 's/[][\/.*^$]/\\&/g')/,/$(printf '%s' "$END" | sed 's/[][\/.*^$]/\\&/g')/p")
+    AFTER=$(printf '%s\n' "$TAIL_PART" | sed -n "/$(printf '%s' "$END" | sed 's/[][\/.*^$]/\\&/g')/,\$p" | tail -n +2)
+  else
+    fail "DISPATCH_CONTEXT block is not closed"
+  fi
+else
+  # No context block: nothing but whitespace/closing quote may follow the title line.
+  AFTER="$TAIL_PART"
+fi
+AFTER_STRIPPED=$(tr -d '[:space:]' <<< "$AFTER")
+if [ -n "$AFTER_STRIPPED" ] && [ "$AFTER_STRIPPED" != '"' ]; then
+  fail "unexpected content after the DISPATCH_CONTEXT block (custom prompt text is not allowed)"
+fi
+
+# --- 3. forbidden language outside the context block -------------------------
+# The title line is NOT exempt: its text is untrusted free text, so the strongest
+# directive phrases are scanned in it (forge#3072).
+TITLE_TEXT=$(printf '%s\n' "$HEAD_PART" | grep -F -- '**Issue title**:' | head -1)
+TITLE_TEXT="${TITLE_TEXT#*\*\*Issue title\*\*:}"
+HITS=$(grep -inE -- "$STRONG" <<< "$TITLE_TEXT" | head -n "$MAX_HITS")
+[ -z "$HITS" ] || while IFS= read -r l; do fail "directive language in the Issue title line: ${l:0:160}"; done <<< "$HITS"
+
+OUTSIDE=$(printf '%s\n' "$HEAD_PART" | grep -vF -- '**Issue title**:')
+OUTSIDE="$OUTSIDE
+$AFTER"
+HITS=$(grep -inE -- "$WIDE" <<< "$OUTSIDE" | head -n "$MAX_HITS")
+[ -z "$HITS" ] || while IFS= read -r l; do fail "verdict/fix-prescribing language outside context block: ${l:0:160}"; done <<< "$HITS"
+
+# --- 3b. allowlist: every head line must match a Step 4A template line --------
+# The denylist above is bypassable by rephrasing, so the head is also diffed
+# against the real template extracted from the spec (placeholders {UPPER_CASE}
+# match any text; pure-placeholder template lines match nothing). Fails closed
+# when the spec/template cannot be found. Resolved relative to THIS script.
+SPEC_FILE="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/../commands/orchestrate/phase-4-execution.md"
+TPL=""
+[ -r "$SPEC_FILE" ] && TPL=$(awk '/Copy this template. Fill in variables/{f=1} f&&/^Agent\($/{g=1} g{print} g&&/^\)$/{exit}' "$SPEC_FILE" \
+  | sed -e '/^Agent($/d' -e '/^  subagent_type/d;/^  model=/d;/^  description=/d;/^  run_in_background/d' \
+        -e 's/^  prompt="//' -e '/^)$/d' | sed -e '$ { /^"$/ d; }' \
+  | sed -e '/DISPATCH_CONTEXT:BEGIN/,$d')
+if [ -z "$TPL" ]; then
+  fail "cannot extract the Step 4A template from $SPEC_FILE (fail closed)"
+else
+  UNMATCHED=$(awk -v MAXU="$MAX_HITS" '
+    # Resolvable placeholders must EXACTLY equal the --expect value (EXP[], read from file 1).
+    # No expected value -> fail closed (MISSING[]). Only ISSUE_TITLE is free text (it is scanned
+    # for directive language separately); {AGENT_TOKEN} is literal template prose.
+    function expected(name) { return (name in EXP) }
+    function matches(line, pat,   rest, lit, name, nl, idx, val) {
+      rest = line
+      while (1) {
+        if (!match(pat, /\{[A-Z_]+\}/)) return rest == pat
+        lit = substr(pat, 1, RSTART - 1); name = substr(pat, RSTART + 1, RLENGTH - 2)
+        pat = substr(pat, RSTART + RLENGTH)
+        if (substr(rest, 1, length(lit)) != lit) return 0
+        rest = substr(rest, length(lit) + 1)
+        if (name == "AGENT_TOKEN") { val = "{AGENT_TOKEN}"; if (substr(rest, 1, length(val)) != val) return 0; rest = substr(rest, length(val) + 1); continue }
+        if (name == "ISSUE_TITLE") {
+          if (match(pat, /\{[A-Z_]+\}/)) nl = substr(pat, 1, RSTART - 1); else nl = pat
+          if (pat == "") { rest = "" }
+          else if (nl != "" && nl == pat) {
+            if (length(rest) < length(nl) || substr(rest, length(rest) - length(nl) + 1) != nl) return 0
+            rest = nl
+          } else if (nl != "") { idx = index(rest, nl); if (idx == 0) return 0; rest = substr(rest, idx) }
+          continue
+        }
+        if (!expected(name)) { TM[name] = 1; return 0 }
+        val = EXP[name]
+        if (substr(rest, 1, length(val)) != val) return 0
+        rest = substr(rest, length(val) + 1)
+      }
+    }
+    FILENAME == ARGV[1] { i = index($0, "="); if (i > 1) EXP[substr($0, 1, i - 1)] = substr($0, i + 1); next }
+    FILENAME == ARGV[2] {
+      if ($0 !~ /^[ \t]*(\{[A-Z_]+\}[ \t]*)+$/ && $0 != "") pats[++np] = $0; next }
+    $0 ~ /^[ \t]*$/ { next }
+    { ok = 0; delete TM; for (i = 1; i <= np; i++) if (matches($0, pats[i])) { ok = 1; break }
+      if (!ok) { for (n in TM) MISSING[n] = 1 }
+      if (!ok) { print "LINE:" substr($0, 1, 120); c++ } if (c >= MAXU) exit }
+    END { for (n in MISSING) print "MISSING:" n }
+  ' "$EXPECT_FILE" <(printf '%s\n' "$TPL") <(printf '%s\n' "$HEAD_PART"))
+  while IFS= read -r l; do
+    case "$l" in
+      LINE:*) fail "line does not match the Step 4A template: ${l#LINE:}" ;;
+      MISSING:*) fail "no expected value supplied for resolvable slot {${l#MISSING:}} (pass --expect ${l#MISSING:}=VALUE; fail closed)" ;;
+    esac
+  done <<< "$UNMATCHED"
+fi
+# --- 4. strongest directives inside the context block ------------------------
+if [ -n "$CTX" ]; then
+  HITS=$(grep -inE -- "$STRONG" <<< "$CTX" | head -n "$MAX_HITS")
+  [ -z "$HITS" ] || while IFS= read -r l; do fail "pre-solved/directive language inside context block: ${l:0:160}"; done <<< "$HITS"
+fi
+
+if [ "${#FAILS[@]}" -eq 0 ]; then
+  echo "LINT: PASS"; exit 0
+fi
+echo "LINT: FAIL"
+for f in "${FAILS[@]}"; do echo "VIOLATION: $f"; done
+exit 1

package/scripts/lint-dispatch-prompt.test.sh

@@ -0,0 +1,307 @@
+#!/usr/bin/env bash
+# SPDX-FileCopyrightText: Copyright (c) RapierCraft Studios
+# SPDX-License-Identifier: AGPL-3.0-or-later
+# Fixtures for lint-dispatch-prompt.sh (forge#3062). Run: bash scripts/lint-dispatch-prompt.test.sh
+set -uo pipefail
+HERE="$(cd "$(dirname "$0")" && pwd)"
+LINT="$HERE/lint-dispatch-prompt.sh"
+SPEC="$HERE/../commands/orchestrate/phase-4-execution.md"
+T="$(mktemp -d)"; trap 'rm -rf "$T"' EXIT
+PASS=0; FAILN=0
+# Expected values for orchestrator-resolved slots (the lint compares byte for byte).
+KEYS="PROJECT_NAME GH_REPO REPO_PATH FORGE_GIST_CAPABLE FORGE_SKILL_PREFIX PROJECT_PREFIX NUMBER STAGING_BRANCH LANE PR_BASE SUBAGENT_MODEL"
+reset_vals() {
+  PROJECT_NAME=ForgeDock; GH_REPO=Acme/Repo; REPO_PATH=/home/dev/repo; FORGE_GIST_CAPABLE=true
+  FORGE_SKILL_PREFIX=forgedock:; PROJECT_PREFIX=; NUMBER=42; SATELLITE_PREFIX=sat; STAGING_BRANCH=staging
+  SOURCE_BRANCH=staging; LANE=fast-lane; PR_BASE=staging; SUBAGENT_MODEL=sonnet
+}
+reset_vals
+OMIT=""   # a key to leave out of the --expect list (fail-closed fixtures)
+check() { # name expected_rc file [extra KEY=VALUE expectations that override the defaults]
+  local name="$1" want="$2" file="$3" k; shift 3
+  local args=()
+  for k in $KEYS; do [ "$k" = "$OMIT" ] || args+=(--expect "$k=${!k}"); done
+  for k in "$@"; do args+=(--expect "$k"); done
+  bash "$LINT" "${args[@]}" "$file" >"$T/out" 2>&1; rc=$?
+  if [ "$rc" -eq "$want" ]; then PASS=$((PASS+1)); else FAILN=$((FAILN+1)); echo "FAIL: $name (rc=$rc want $want)"; cat "$T/out"; fi
+}
+# Rendered fixtures must show the distinct fail-closed message (not just any failure).
+check_out() { # name pattern
+  if grep -q -- "$2" "$T/out"; then PASS=$((PASS+1)); else FAILN=$((FAILN+1)); echo "FAIL: $1 (output lacks '$2')"; cat "$T/out"; fi
+}
+
+# Portable in-place sed (BSD sed -i requires a suffix arg; GNU does not).
+sed_i() { local f="$1"; shift; sed "$@" "$f" > "$f.tmp" && mv "$f.tmp" "$f"; }
+# Portable "insert a line before the first **LANE** line" (GNU-only sed 0,/re/ and \n in replacement break on BSD sed).
+lane_before() { awk -v ins="$1" '/^\*\*LANE\*\*/ && !d { print ins; d = 1 } { print }' "$2"; }
+
+# Extract the real Step 4A template (stops at the first bare ")" line; inner ```bash fences are kept).
+awk '/Copy this template. Fill in variables/{f=1} f&&/^Agent\($/{g=1} g{print} g&&/^\)$/{exit}' "$SPEC" > "$T/tpl"
+[ -s "$T/tpl" ] || { echo "FAIL: could not extract 4A template"; exit 1; }
+sed -e '/^Agent($/d' -e '/^  subagent_type/d;/^  model=/d;/^  description=/d;/^  run_in_background/d' \
+    -e 's/^  prompt="//' -e '/^)$/d' "$T/tpl" > "$T/base"
+sed_i "$T/base" -e '$ { /^"$/ d; }'
+sed_i "$T/base" -e '/^{GIST_CONTEXT}$/d' -e '/^{SOURCE_PR_HINT_CONTEXT}$/d' -e '/DISPATCH_CONTEXT:END/d' 
+sed_i "$T/base" -e '/DISPATCH_CONTEXT:BEGIN/d'
+cp "$T/base" "$T/base_tpl"
+# Fill placeholders from the vars above with an exact (non-regex, non-escaping) replacement.
+build_base() {
+  for k in $KEYS; do export "E_$k=${!k}"; done
+  awk -v keys="$KEYS" 'BEGIN { n = split(keys, K, " ") }
+    { line = $0; out = ""
+      for (i = 1; i <= n; i++) { ph = "{" K[i] "}"; val = ENVIRON["E_" K[i]]; out = ""
+        while ((j = index(line, ph)) > 0) { out = out substr(line, 1, j - 1) val; line = substr(line, j + length(ph)) }
+        line = out line }
+      print line }' "$T/base_tpl" > "$T/base"
+}
+build_base
+
+render() { # context-body-file -> prompt
+  cat "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; cat "$1" 2>/dev/null; echo '<!-- DISPATCH_CONTEXT:END -->'
+}
+: > "$T/empty"
+
+# 1. Verbatim template, no context: PASS
+render "$T/empty" > "$T/p1"; check "verbatim template" 0 "$T/p1"
+
+# 2. Legitimate context: claims board, same-file brief (what changed), source-PR hint, gist context
+cat > "$T/ctx_ok" <<'X'
+**RECONCILED CONTEXT (orchestrate Phase 2.5 synthesis brief)**: use this as cross-investigation context.
+**SAME-FILE STATE BRIEF**: PR #34100 changed `app/billing.py` (renamed `refund()` to `refund_intent()`); it is merged to staging.
+Claims board issue URL: https://github.com/o/r/issues/1
+**SOURCE PR HINT**: source PR #5 merged; triage hint: likely-moot candidate, agent must verify itself.
+X
+render "$T/ctx_ok" > "$T/p2"; check "legit context blocks" 0 "$T/p2"
+
+# 3. The #34180-style brief: pre-written diagnosis and fix design inside context -> FAIL
+cat > "$T/ctx_bad" <<'X'
+The fix is to make the fraud branch terminal: refund, release promo, cancel intent, return.
+X
+render "$T/ctx_bad" > "$T/p3"; check "pre-written fix design in context" 1 "$T/p3"
+
+# 4. LIKELY ALREADY RESOLVED instruction -> FAIL
+printf 'LIKELY ALREADY RESOLVED — verify and close.\n' > "$T/ctx_moot"
+render "$T/ctx_moot" > "$T/p4"; check "likely already resolved" 1 "$T/p4"
+
+# 5. Custom brief appended after the context block -> FAIL
+{ render "$T/empty"; echo 'Diagnosis: the root cause is a missing return in handle_fraud().'; } > "$T/p5"; check "custom text after block" 1 "$T/p5"
+
+# 6. Free-text resume prompt -> FAIL (missing anchors)
+echo "Resume #3062 — continue from where you left off and finish the uncommitted work." > "$T/p6"; check "free-text resume prompt" 1 "$T/p6"
+
+# 7. Custom text injected into the template body -> FAIL
+{ lane_before 'Root cause: handle_fraud never returns.' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p7"; check "injected root-cause line in template" 1 "$T/p7"
+
+# 8. Text between title and context block -> FAIL
+{ cat "$T/base"; echo 'Just read and edit the file.'; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p8"; check "text between title and block" 1 "$T/p8"
+
+# 9. Unreadable / empty input -> rc 2
+bash "$LINT" "$T/does-not-exist" >/dev/null 2>&1; [ $? -eq 2 ] && PASS=$((PASS+1)) || { FAILN=$((FAILN+1)); echo "FAIL: missing file rc"; }
+
+# 11. Large prompt (>1MB) must not SIGPIPE-fail the anchor checks (forge#3071)
+{ cat "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; for _ in $(seq 1 30000); do echo 'Claims board entry: issue 1 holds file scripts/example.sh for the current batch run.'; done; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p11"; check "large prompt passes" 0 "$T/p11"
+
+# 12. Context quoting a prior investigation ("the root cause is ...") is legitimate -> PASS
+printf 'Prior investigation excerpt: "the root cause is a stale cache; the fix is described in #12".\n' > "$T/ctx_quote"
+render "$T/ctx_quote" > "$T/p12"; check "quoted investigation in context" 0 "$T/p12"
+
+# 13. Trailing quote/paren-only junk after the block is not silently ignored -> FAIL
+{ render "$T/empty"; echo '")'; } > "$T/p13"; check "trailing paren junk after block" 1 "$T/p13"
+
+# 14. Directive on the Issue title line must not be exempt (forge#3072) -> FAIL
+{ sed 's/^\*\*Issue title\*\*:.*/**Issue title**: fix X (likely already resolved - verify and close)/' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p14"; check "directive in title line" 1 "$T/p14"
+
+# 15. Rephrased custom line inside the template body evades the denylist but not the allowlist -> FAIL
+{ lane_before 'Please begin by editing handle_fraud to return early.' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p15"; check "rephrased line not in template" 1 "$T/p15"
+
+# 16. Placeholders substituted with real values still PASS
+{ sed -e 's/{NUMBER}/3072/g' -e 's/{PROJECT_NAME}/ForgeDock/g' -e 's/{ISSUE_TITLE}/fix(scripts): a normal title/' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p16"; check "substituted template" 0 "$T/p16"
+
+# 17. Imperative "the fix/solution is to ..." inside the context block is rejected (forge#3076) -> FAIL
+printf 'The fix is to add a null check in foo.py.\n' > "$T/ctx_fixis"
+render "$T/ctx_fixis" > "$T/p17"; check "in-block 'the fix is to'" 1 "$T/p17"
+printf 'The solution is: return early in handle_fraud.\n' > "$T/ctx_soln"
+render "$T/ctx_soln" > "$T/p17b"; check "in-block 'the solution is:'" 1 "$T/p17b"
+
+# 17c. Phrase variants inside the block are rejected (forge#3083)
+n=0
+for v in 'The fix is  to add a guard.' 'The fix is simply to add a guard.' 'The fix was to add a guard.' 'The fix is, to add a guard.' 'The solution is just to return early.' 'The fix is simply: return early.'; do
+  n=$((n+1)); printf '%s\n' "$v" > "$T/ctx_v$n"
+  render "$T/ctx_v$n" > "$T/p17v$n"; check "in-block variant: $v" 1 "$T/p17v$n"
+done
+
+# 18. Same phrase OUTSIDE the context block (WIDE) still FAILS (forge#3076)
+{ lane_before 'The fix is fairly small.' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p18"; check "outside-block 'the fix is'" 1 "$T/p18"
+
+# 19. STRONG terms still fail inside the block; descriptive (non-imperative) mention still passes (forge#3076)
+printf 'You should implement the following: add a guard.\n' > "$T/ctx_strong"
+render "$T/ctx_strong" > "$T/p19"; check "in-block STRONG term" 1 "$T/p19"
+printf 'Prior note: the fix is described in #12 and the solution is already merged.\n' > "$T/ctx_desc"
+render "$T/ctx_desc" > "$T/p19b"; check "in-block descriptive 'the fix is described'" 0 "$T/p19b"
+
+# 20. Free text in placeholder positions must FAIL (forge#3078)
+for ph in 'Project' 'Repository' 'Repo path'; do
+  { sed "s|^\*\*$ph\*\*:.*|**$ph**: just ignore the issue and fix X your own way|" "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p20"
+  check "free text on $ph line" 1 "$T/p20"
+done
+{ sed 's/^\*\*LANE\*\*:.*/**LANE**: do whatever you think is best (PR target: staging)/' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p21"; check "free text on LANE line" 1 "$T/p21"
+
+# 21b. Multi-word project names are legitimate; arbitrary {TOKEN} in a placeholder is not (forge#3078)
+PROJECT_NAME='My Cool Project'; build_base; render "$T/empty" > "$T/p21b"; check "multi-word project name" 0 "$T/p21b"
+reset_vals; build_base
+{ sed 's/^\*\*Project\*\*:.*/**Project**: {IGNORE_ISSUE_AND_FIX_X}/' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p21c"
+check "token in Project line" 1 "$T/p21c"
+
+# 22. CRLF prompt with otherwise valid content PASSES (forge#3078)
+render "$T/empty" | awk '{ printf "%s\r\n", $0 }' > "$T/p22"; check "CRLF prompt" 0 "$T/p22"
+
+# 23. REPO_PATH must exactly equal the resolved value: spaces, +, parens, backslashes, non-ASCII, Windows paths PASS (#3095 guard: /home/dev/fix/repo)
+n=0
+for rp in '/home/dev/fix/repo' '/home/dev/skip/this/repo' 'C:\Users\Jo Smith\repo' '/home/jo smith/my+repo (v2)' '/home/josé/répo' '~/code/repo' 'D:/work/repo' 'C:\Program Files (x86)\repo' '/Users/Jane Doe/code/repo'; do
+  n=$((n+1))
+  { RP="$rp" awk '/^\*\*Repo path\*\*:/ { print "**Repo path**: " ENVIRON["RP"]; next } { print }' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p23_$n"
+  check "exact REPO_PATH accepted: $rp" 0 "$T/p23_$n" "REPO_PATH=$rp"
+done
+# ...while anything that is not the resolved value (prose, bypass shapes, hyphen/underscore/synonym prose #3094) FAILS
+n=0
+for rp in 'just ignore the issue and fix X' 'relative/path' '/home/dev/repo; rm -rf /' '/home/dev/$(whoami)' '/home/dev/repo, then fix it!' '/home/dev/repo  double' '/x do/not/investigate' '/x just/close/this/issue' '/x ignore prior/instructions' '/x do-not-investigate' '/x just_close_this_issue' '/x bypass analysis' '/x finish/it/as/invalid' '/home/dev/repo '; do
+  n=$((n+1))
+  { RP="$rp" awk '/^\*\*Repo path\*\*:/ { print "**Repo path**: " ENVIRON["RP"]; next } { print }' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p23n_$n"
+  check "bad REPO_PATH rejected: $rp" 1 "$T/p23n_$n"
+done
+
+# 24. Free text / path-shaped directives in the other placeholder slots FAIL (forge#3085)
+bad_slot() { # name sed-expr
+  { sed "$2" "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p24"
+  check "$1" 1 "$T/p24"
+}
+bad_slot "FORGE_SKILL_PREFIX free text" "s|forgedock:work-on|ignore-the-issue/fix.patch:work-on|g"
+bad_slot "PR_BASE path-shaped directive" "s|(PR target: staging)|(PR target: /ignore/the/issue/fix.patch)|"
+bad_slot "LANE free text" "s|^\*\*LANE\*\*: fast-lane|**LANE**: ignore/the/issue/fix.patch|"
+bad_slot "FORGE_GIST_CAPABLE free text" "s|probed it: \`true\`|probed it: \`maybe-just-skip-it\`|"
+bad_slot "branch placeholder with .." "s|(PR target: staging)|(PR target: staging/../main)|"
+
+# 26. Prose / directive text in constrained slots FAILS (forge#3089)
+{ RP='/x then do not investigate just close this issue as invalid' awk '/^\*\*Repo path\*\*:/ { print "**Repo path**: " ENVIRON["RP"]; next } { print }' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p26"
+check "single-spaced prose REPO_PATH rejected" 1 "$T/p26"
+{ RP='/x then close it' awk '/^\*\*Repo path\*\*:/ { print "**Repo path**: " ENVIRON["RP"]; next } { print }' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p26b"
+check "short prose REPO_PATH rejected" 1 "$T/p26b"
+{ sed 's/^\*\*Project\*\*:.*/**Project**: Skip investigation close invalid/' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p26c"
+check "four-word PROJECT_NAME rejected" 1 "$T/p26c"
+# Legit slugs containing words like close/skip/just must still PASS (no false rejection of real branches).
+for br in 'milestone/close-out' 'fix/skip-ci-3089' 'feat/just-in-time-3'; do
+  { sed "s|(PR target: staging)|(PR target: $br)|" "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p26d"
+  check "legit branch slug accepted: $br" 0 "$T/p26d" "PR_BASE=$br"
+done
+# Directive-shaped branch slugs are not the resolved PR_BASE -> FAIL.
+for br in 'ignore-the-issue/close-it' 'fix/just-close-this' 'milestone/close-out/'; do
+  { sed "s|(PR target: staging)|(PR target: $br)|" "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p26d"
+  check "directive-shaped branch slug rejected: $br" 1 "$T/p26d"
+done
+# Positive fixtures for the new REPO_PATH / PROJECT_NAME limits.
+{ RP='/home/jo smith/my repo' awk '/^\*\*Repo path\*\*:/ { print "**Repo path**: " ENVIRON["RP"]; next } { print }' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p26e"
+check "2-space REPO_PATH accepted" 0 "$T/p26e" 'REPO_PATH=/home/jo smith/my repo'
+# A well-formed value that is not the resolved one is refused (exact match, no structural fallback).
+check "well-formed but unexpected REPO_PATH rejected" 1 "$T/p26e" 'REPO_PATH=/home/jo smith/other repo'
+
+# 27. Fail closed: a resolvable slot present in the prompt with NO expected value is refused with a
+# distinct message, for every slot (no charset/stopword fallback).
+render "$T/empty" > "$T/p27"
+for k in $KEYS; do
+  # SUBAGENT_MODEL fills Agent(model=...), which is outside the linted prompt text, so it has no slot to fail.
+  [ "$k" = "SUBAGENT_MODEL" ] && continue
+  OMIT="$k"; check "missing expected value for $k fails closed" 1 "$T/p27"
+  check_out "distinct fail-closed message for $k" "no expected value supplied for resolvable slot {$k}"
+done
+OMIT=""
+bash "$LINT" "$T/p27" >"$T/out" 2>&1; [ $? -eq 1 ] && PASS=$((PASS+1)) || { FAILN=$((FAILN+1)); echo "FAIL: no --expect at all must fail closed"; }
+check_out "no --expect at all names the slots" "no expected value supplied"
+# An empty expected value is a real value (PROJECT_PREFIX is empty for the default repo).
+check "empty expected value accepted when it equals the rendered value" 0 "$T/p27" "PROJECT_PREFIX="
+check "empty expected value rejects a non-empty rendered value" 1 "$T/p27" "PROJECT_NAME="
+# Malformed --expect usage is an input error (rc 2).
+bash "$LINT" --expect nokey "$T/p27" >/dev/null 2>&1; [ $? -eq 2 ] && PASS=$((PASS+1)) || { FAILN=$((FAILN+1)); echo "FAIL: malformed --expect rc"; }
+
+# 25. A MID-line CR is content, not a line ending: it must not be silently stripped (forge#3085) -> FAIL
+{ awk '/^\*\*Project\*\*:/ { printf "**Project**: Forge\rDock\n"; next } { print }' "$T/base"; echo '<!-- DISPATCH_CONTEXT:BEGIN -->'; echo '<!-- DISPATCH_CONTEXT:END -->'; } > "$T/p25"
+check "mid-line CR not stripped" 1 "$T/p25"
+
+# 10. Spec snippet enforcement (forge#3070): extract the lint gate from the spec and run it in a loop.
+# Gate = from the bootstrap marker to the end of its fenced code block (not a hard-coded count of
+# top-level fi lines, which breaks whenever the bootstrap gains or loses a conditional).
+awk '/^# FORGE_ROOT bootstrap/{f=1} f&&/^```/{exit} f{print}' "$SPEC" > "$T/gate"
+[ -s "$T/gate" ] || { FAILN=$((FAILN+1)); echo "FAIL: could not extract spec lint gate"; }
+gate_refused() { # prompt-file home -> prints refusal entries or LAUNCHED
+  ( LINT_REFUSED_ISSUES=(); RENDERED_PROMPT="$(cat "$1")"; FORGEDOCK_HOME="$2"; unset FORGE_HOME; reset_vals
+    for _i in 1; do
+      eval "$(sed 's/{NUMBER}/42/g' "$T/gate")"
+      echo LAUNCHED; exit 0
+    done
+    echo "REFUSED ${LINT_REFUSED_ISSUES[*]}" ) 2>"$T/gate_err" | tail -1
+}
+expect() { [ "$2" = "$3" ] && PASS=$((PASS+1)) || { FAILN=$((FAILN+1)); echo "FAIL: $1 (got '$3' want '$2')"; }; }
+expect "gate launches clean prompt" "LAUNCHED" "$(gate_refused "$T/p1" "$HERE/..")"
+expect "gate refuses lint failure" "REFUSED 42:lint-rc-1" "$(gate_refused "$T/p3" "$HERE/..")"
+expect "gate fails closed when script missing" "REFUSED 42:lint-script-not-found" "$(gate_refused "$T/p1" "$T/nowhere")"
+grep -q 'lint script not found' "$T/gate_err" && PASS=$((PASS+1)) || { FAILN=$((FAILN+1)); echo "FAIL: missing-script message not distinct"; }
+# Unbound inputs (forge#3149): an empty rendered prompt or any unset resolved value is refused with a distinct reason, never launched.
+: > "$T/empty_prompt"
+expect "gate refuses an empty rendered prompt" "REFUSED 42:lint-inputs-unbound" "$(gate_refused "$T/empty_prompt" "$HERE/..")"
+gate_unset() { # unset-var -> prints refusal entries or LAUNCHED
+  ( LINT_REFUSED_ISSUES=(); RENDERED_PROMPT="$(cat "$T/p1")"; FORGEDOCK_HOME="$HERE/.."; unset FORGE_HOME; reset_vals; eval "$1="
+    for _i in 1; do
+      eval "$(sed 's/{NUMBER}/42/g' "$T/gate")"
+      echo LAUNCHED; exit 0
+    done
+    echo "REFUSED ${LINT_REFUSED_ISSUES[*]}" ) 2>/dev/null | tail -1
+}
+for v in PROJECT_NAME GH_REPO REPO_PATH LANE PR_BASE STAGING_BRANCH FORGE_GIST_CAPABLE SUBAGENT_MODEL; do
+  expect "gate refuses empty $v" "REFUSED 42:lint-inputs-unbound" "$(gate_unset "$v")"
+done
+# The legitimately-empty slots must not be refused by the binding guard.
+for v in PROJECT_PREFIX; do
+  expect "gate accepts empty $v" "LAUNCHED" "$(gate_unset "$v")"
+done
+# The spec binds every lint input explicitly (the snippet used to read unassigned variables).
+for v in RENDERED_PROMPT SOURCE_BRANCH SUBAGENT_MODEL PROJECT_PREFIX SATELLITE_PREFIX FORGE_SKILL_PREFIX; do
+  grep -q "^[A-Z_]*=.*\b$v='{\|^$v='{\|; *$v='{\|^$v=\$(cat" "$SPEC" && PASS=$((PASS+1)) || { FAILN=$((FAILN+1)); echo "FAIL: spec does not bind $v"; }
+done
+# Exemption is stated in the spec so the scope matches the script.
+grep -q 'Exempt (not Step 4A-template prompts' "$SPEC" && PASS=$((PASS+1)) || { FAILN=$((FAILN+1)); echo "FAIL: spec exemption missing"; }
+
+# Template/slot clash guard: the Step 4A template must never contain a shell expansion of a
+# slot name (e.g. ${NUMBER}). Filling the {NUMBER} slot turns it into "$42" while leaving it
+# fails the exact-match lint, so an orchestrator cannot render it consistently (field test #3149).
+TPL4A=$(awk '/Copy this template. Fill in variables/{f=1} f&&/^Agent\($/{g=1} g{print} g&&/^\)$/{exit}' "$SPEC")
+[ -n "$TPL4A" ] && PASS=$((PASS+1)) || { FAILN=$((FAILN+1)); echo "FAIL: cannot extract Step 4A template"; }
+if printf '%s\n' "$TPL4A" | grep -qE '\$\{(PROJECT_NAME|GH_REPO|REPO_PATH|LANE|PR_BASE|STAGING_BRANCH|SOURCE_BRANCH|NUMBER|FORGE_GIST_CAPABLE|SUBAGENT_MODEL|PROJECT_PREFIX|SATELLITE_PREFIX|FORGE_SKILL_PREFIX|ISSUE_TITLE)\}'; then
+  FAILN=$((FAILN+1)); echo "FAIL: Step 4A template contains a shell expansion of a slot name"
+else PASS=$((PASS+1)); fi
+
+# Knowledge Gist probe fails closed (field test: an App installation token gets HTTP 403 on /user,
+# which the old "not Bot => capable" rule treated as capable). Run each copy against a fake gh.
+for probe_src in "$SPEC" "$HERE/../commands/work-on/investigate.md"; do
+  awk '/if \[ -z "\$\{FORGE_GIST_CAPABLE\+x\}" \]; then/{f=1} f{print} f&&/^fi$/{exit}' "$probe_src" > "$T/gistprobe"
+  [ -s "$T/gistprobe" ] && PASS=$((PASS+1)) || { FAILN=$((FAILN+1)); echo "FAIL: gist probe not found in $probe_src"; continue; }
+  for case_ in "User:true" "Bot:false" "403:false" "empty:false"; do
+    mode=${case_%%:*}; want=${case_#*:}
+    mkdir -p "$T/fakegh_$mode"
+    case "$mode" in
+      User)  printf '#!/bin/sh\necho User\n' ;;
+      Bot)   printf '#!/bin/sh\necho Bot\n' ;;
+      403)   printf '#!/bin/sh\necho "HTTP 403: Resource not accessible by integration" >&2\nexit 1\n' ;;
+      empty) printf '#!/bin/sh\nexit 0\n' ;;
+    esac > "$T/fakegh_$mode/gh"; chmod +x "$T/fakegh_$mode/gh"
+    got=$(env -u FORGE_GIST_CAPABLE PATH="$T/fakegh_$mode:$PATH" bash -c "$(cat "$T/gistprobe"); printf %s \"\$FORGE_GIST_CAPABLE\"")
+    expect "gist probe ($mode) in $(basename "$probe_src")" "$want" "$got"
+  done
+done
+
+# Worker-resolved values must not be orchestrator slots (field test: filling {SOURCE_BRANCH}/{SATELLITE_PREFIX}
+# with empty strings rendered "origin/:{filepath}" and "PR target is ``" into worker prompts).
+if printf '%s\n' "$TPL4A" | grep -qE '\{(SOURCE_BRANCH|SATELLITE_PREFIX)\}'; then
+  FAILN=$((FAILN+1)); echo "FAIL: Step 4A template exposes a worker-resolved value as an orchestrator slot"
+else PASS=$((PASS+1)); fi
+
+echo "lint-dispatch-prompt tests: pass=$PASS fail=$FAILN"
+[ "$FAILN" -eq 0 ]

package/scripts/validate-spec-graph.sh

@@ -287,7 +287,7 @@ check_dangling() {
   # Extract every Skill(skill="X") / Skill(skill='X') target with file+line.
   # grep -rn over the whole tree (no fixed -A/-m window that could truncate).
   local hits
-  hits="$(grep -rnoE "Skill\(\s*(skill\s*[:=]\s*)?[\"'][A-Za-z0-9][A-Za-z0-9:_/-]*[\"']" "$commands_dir" 2>/dev/null || true)"
+  hits="$(grep -rnoE "Skill\(\s*(skill\s*[:=]\s*)?[\"'](\{FORGE_SKILL_PREFIX\})?[A-Za-z0-9][A-Za-z0-9:_/-]*[\"']" "$commands_dir" 2>/dev/null || true)"
 
   [ -n "$hits" ] || return 0
 
@@ -301,7 +301,8 @@ check_dangling() {
     relpath="${line%%:*}"
     relpath="${relpath#"$REPO_ROOT"/}"
     # Pull the quoted target.
-    target="$(printf '%s' "$line" | grep -oE "[\"'][A-Za-z0-9][A-Za-z0-9:_/-]*[\"']" | head -1 | tr -d "\"'")"
+    target="$(printf '%s' "$line" | grep -oE "[\"'](\{FORGE_SKILL_PREFIX\})?[A-Za-z0-9][A-Za-z0-9:_/-]*[\"']" | head -1 | tr -d "\"'")"
+    target="${target#\{FORGE_SKILL_PREFIX\}}"
     [ -n "$target" ] || continue
     # Normalize the `/`-delimited sub-phase form (work-on/review) to the graph's
     # `:` form (work-on:review) before resolution — kept in sync with the builder.