forgedock 1.4.0 → 1.5.1

package/scripts/extract-affected-files.test.sh

@@ -0,0 +1,331 @@
+#!/usr/bin/env bash
+# extract-affected-files.test.sh — Unit-style tests for scripts/extract-affected-files.sh
+#
+# No network/GitHub API access required: `gh` is replaced with a mock that
+# returns fixture text via MOCK_GH_COMMENTS (FORGE:INVESTIGATOR comment body,
+# already pre-filtered the way `gh api ... --jq 'select(...)|.body'` would
+# return it) and MOCK_GH_BODY (raw issue body, as `gh issue view --json body
+# --jq '.body'` would return it) — same fixture-file-via-env-var mocking
+# convention as scripts/issue-dedup.test.sh.
+#
+# Usage: bash scripts/extract-affected-files.test.sh
+# Exit code: 0 if all assertions pass, 1 if any fail.
+#
+# SPDX-FileCopyrightText: Copyright (c) RapierCraft Studios
+# SPDX-License-Identifier: AGPL-3.0-or-later
+
+set -uo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+EXTRACT="$SCRIPT_DIR/extract-affected-files.sh"
+
+TMP_BIN=$(mktemp -d)
+TMP_FIXTURES=$(mktemp -d)
+cleanup() {
+  rm -rf "$TMP_BIN" "$TMP_FIXTURES"
+}
+trap cleanup EXIT
+
+# --------------------------------------------------------------------------- #
+# Mock `gh` — intercepts:
+#   gh api repos/<repo>/issues/<num>/comments --jq '...'   -> cat $MOCK_GH_COMMENTS (if set+exists, else empty)
+#   gh issue view <num> -R <repo> --json body --jq '...'   -> cat $MOCK_GH_BODY (if set+exists, else empty)
+# Any other invocation is a test setup error.
+#
+# forge#2504: MOCK_GH_COMMENTS_FAIL=1 / MOCK_GH_BODY_FAIL=1 force the respective
+# call site to simulate a genuine `gh` failure (non-zero exit, nothing on
+# stdout) instead of a "call succeeded, empty/no-match result" — this is the
+# distinction extract-affected-files.sh must now surface as PROVENANCE=error.
+# --------------------------------------------------------------------------- #
+cat > "$TMP_BIN/gh" <<'MOCK'
+#!/usr/bin/env bash
+if [[ "$1" == "api" ]]; then
+  if [[ "${MOCK_GH_COMMENTS_FAIL:-}" == "1" ]]; then
+    echo "mock gh api: simulated failure (network error / rate limit)" >&2
+    exit 1
+  fi
+  if [[ -n "${MOCK_GH_COMMENTS:-}" && -f "${MOCK_GH_COMMENTS:-}" ]]; then
+    cat "$MOCK_GH_COMMENTS"
+  fi
+  exit 0
+fi
+if [[ "$1" == "issue" && "$2" == "view" ]]; then
+  if [[ "${MOCK_GH_BODY_FAIL:-}" == "1" ]]; then
+    echo "mock gh issue view: simulated failure (network error / rate limit)" >&2
+    exit 1
+  fi
+  if [[ -n "${MOCK_GH_BODY:-}" && -f "${MOCK_GH_BODY:-}" ]]; then
+    cat "$MOCK_GH_BODY"
+  fi
+  exit 0
+fi
+echo "extract-affected-files.test.sh: unexpected gh mock invocation: $*" >&2
+exit 1
+MOCK
+chmod +x "$TMP_BIN/gh"
+
+export PATH="$TMP_BIN:$PATH"
+
+PASS=0
+FAIL=0
+
+# assert_output <description> <expected_provenance> <expected_files_csv_or_empty> <extract args...>
+#
+# forge#2504: stdout is captured separately from stderr (`2>/dev/null`, not
+# `2>&1`) because the script's PROVENANCE=/file-list contract lives entirely
+# on stdout — the new gh-failure paths intentionally also emit a stderr
+# WARNING (see extract-affected-files.sh), which must not be merged into the
+# line this helper parses as "line 1 == PROVENANCE=...".
+assert_output() {
+  local desc="$1" expected_prov="$2" expected_files="$3"
+  shift 3
+  OUT=$("$EXTRACT" "$@" 2>/dev/null)
+  ACTUAL_PROV=$(echo "$OUT" | head -1)
+  ACTUAL_FILES=$(echo "$OUT" | tail -n +2 | tr '\n' ',' | sed 's/,$//')
+  if [[ "$ACTUAL_PROV" == "PROVENANCE=$expected_prov" && "$ACTUAL_FILES" == "$expected_files" ]]; then
+    echo "PASS: $desc"
+    PASS=$((PASS + 1))
+  else
+    echo "FAIL: $desc"
+    echo "  expected: PROVENANCE=$expected_prov / files=[$expected_files]"
+    echo "  actual:   $ACTUAL_PROV / files=[$ACTUAL_FILES]"
+    FAIL=$((FAIL + 1))
+  fi
+}
+
+# assert_exit <description> <expected_exit> <extract args...>
+assert_exit() {
+  local desc="$1" expected="$2"
+  shift 2
+  set +e
+  OUT=$("$EXTRACT" "$@" 2>&1)
+  ACTUAL=$?
+  set -e
+  if [[ "$ACTUAL" -eq "$expected" ]]; then
+    echo "PASS: $desc"
+    PASS=$((PASS + 1))
+  else
+    echo "FAIL: $desc (expected exit $expected, got $ACTUAL)"
+    echo "  output: $OUT"
+    FAIL=$((FAIL + 1))
+  fi
+}
+
+# --------------------------------------------------------------------------- #
+# Scenario 1 (forge#2382 regression fixture): no FORGE:INVESTIGATOR comment.
+# Issue body lists three context-only paths under "## Context" and has NO
+# "## Affected Files" section. Must yield PROVENANCE=none and zero files —
+# NOT the pre-fix behavior of scraping the three context paths.
+# --------------------------------------------------------------------------- #
+BODY_2382="$TMP_FIXTURES/body_2382.txt"
+cat > "$BODY_2382" <<'EOF'
+## Problem
+
+Something is broken in the batching logic.
+
+## Context
+
+This follows the pattern of `bin/hooks/pre-tool-use.mjs`, already implements
+part of `scripts/transition-label.sh`, and is related to prior work in
+`scripts/worktree-lifecycle.sh`.
+
+## Root Cause
+
+Unknown — investigation needed.
+EOF
+
+unset MOCK_GH_COMMENTS
+MOCK_GH_BODY="$BODY_2382" assert_output \
+  "forge#2382 regression: context-only paths under ## Context, no ## Affected Files -> zero files, PROVENANCE=none" \
+  "none" "" 2382 -R test/repo
+
+# --------------------------------------------------------------------------- #
+# Scenario 2: body has a real "## Affected Files" section AND an unrelated
+# "## Context" section with different paths. Only the Affected Files paths
+# must be extracted; the Context paths must be ignored.
+# --------------------------------------------------------------------------- #
+BODY_SCOPED="$TMP_FIXTURES/body_scoped.txt"
+cat > "$BODY_SCOPED" <<'EOF'
+## Problem
+
+Bug description.
+
+## Affected Files
+
+1. `bin/engine.mjs` — fix the thing
+2. `bin/engine/phases.mjs` — related fix
+
+## Context
+
+Follows the pattern of `bin/unrelated-context-file.mjs`.
+
+## Expected Behavior
+
+It should work.
+EOF
+
+unset MOCK_GH_COMMENTS
+MOCK_GH_BODY="$BODY_SCOPED" assert_output \
+  "body-fallback scoped to ## Affected Files: extracts only the 2 listed files, ignores ## Context path" \
+  "body-fallback" "bin/engine.mjs,bin/engine/phases.mjs" 2383 -R test/repo
+
+# --------------------------------------------------------------------------- #
+# Scenario 3: extension regex must cover mjs/js/sh/md (previously missing).
+# ## Deliverables heading variant also exercised here.
+# --------------------------------------------------------------------------- #
+BODY_EXT="$TMP_FIXTURES/body_ext.txt"
+cat > "$BODY_EXT" <<'EOF'
+## Deliverables
+
+1. `bin/cli-spawn-shared.mjs`
+2. `scripts/danger-zones.mjs`
+3. `scripts/flaky-quarantine.sh`
+4. `devdocs/project/architecture.md`
+EOF
+
+unset MOCK_GH_COMMENTS
+MOCK_GH_BODY="$BODY_EXT" assert_output \
+  "extension regex covers mjs/sh/md under ## Deliverables heading" \
+  "body-fallback" "bin/cli-spawn-shared.mjs,devdocs/project/architecture.md,scripts/danger-zones.mjs,scripts/flaky-quarantine.sh" \
+  2384 -R test/repo
+
+# --------------------------------------------------------------------------- #
+# Scenario 4: "### Files to change" heading variant.
+# --------------------------------------------------------------------------- #
+BODY_FTC="$TMP_FIXTURES/body_ftc.txt"
+cat > "$BODY_FTC" <<'EOF'
+## Problem
+
+Doc-only change.
+
+### Files to change
+
+- `docs/site/troubleshooting.md`
+
+## Context
+
+References `bin/registry.mjs` for background.
+EOF
+
+unset MOCK_GH_COMMENTS
+MOCK_GH_BODY="$BODY_FTC" assert_output \
+  "### Files to change heading scoped correctly, ## Context path ignored" \
+  "body-fallback" "docs/site/troubleshooting.md" 2385 -R test/repo
+
+# --------------------------------------------------------------------------- #
+# Scenario 5: FORGE:INVESTIGATOR comment present -> primary path used,
+# scoped to its own "### Affected Files" section. Paths in "### Evidence"
+# and "### Root Cause" sections of the SAME comment must be ignored. The
+# raw issue body (which may itself contain misleading context paths) must
+# never be consulted when an INVESTIGATOR comment exists.
+# --------------------------------------------------------------------------- #
+INVESTIGATOR_COMMENT="$TMP_FIXTURES/investigator_comment.txt"
+cat > "$INVESTIGATOR_COMMENT" <<'EOF'
+<!-- FORGE:INVESTIGATOR -->
+## Investigation Report
+
+**Verdict**: CONFIRMED
+
+### Root Cause
+Traced through `bin/engine/reconcile.mjs` before landing on the real cause.
+
+### Affected Files
+1. `bin/engine/state.mjs`
+2. `bin/engine/projector.mjs`
+
+### Evidence
+See `bin/engine/invariants.mjs` for the assertion that fails.
+
+<!-- INVESTIGATION:COMPLETE -->
+EOF
+
+BODY_SHOULD_BE_IGNORED="$TMP_FIXTURES/body_should_be_ignored.txt"
+cat > "$BODY_SHOULD_BE_IGNORED" <<'EOF'
+## Context
+
+Totally different file: `bin/unrelated.mjs`
+EOF
+
+MOCK_GH_COMMENTS="$INVESTIGATOR_COMMENT" MOCK_GH_BODY="$BODY_SHOULD_BE_IGNORED" assert_output \
+  "INVESTIGATOR comment present: primary path scoped to its own ### Affected Files, Root Cause/Evidence ignored, raw body never consulted" \
+  "affected-files-section" "bin/engine/projector.mjs,bin/engine/state.mjs" 2386 -R test/repo
+
+# --------------------------------------------------------------------------- #
+# Scenario 6: no INVESTIGATOR comment AND no deliverables-shaped heading in
+# the body at all (not even "## Context") -> PROVENANCE=none.
+# --------------------------------------------------------------------------- #
+BODY_NO_HEADINGS="$TMP_FIXTURES/body_no_headings.txt"
+cat > "$BODY_NO_HEADINGS" <<'EOF'
+Just some prose mentioning `bin/foo.mjs` with no headings at all.
+EOF
+
+unset MOCK_GH_COMMENTS
+MOCK_GH_BODY="$BODY_NO_HEADINGS" assert_output \
+  "no INVESTIGATOR comment, no deliverables heading at all -> PROVENANCE=none" \
+  "none" "" 2387 -R test/repo
+
+# --------------------------------------------------------------------------- #
+# Scenario 7 (forge#2503 regression fixture): positive-path pre-joined
+# single-token -R form, e.g. "-R owner/repo" as ONE argv element instead of
+# two separate tokens. The script's usage comment and its `-R\ *` case arm
+# both document this form as supported, but until this fixture the only
+# assertion touching that arm was the malformed-value negative case in
+# Scenario 8 below — the success branch (REPO="$_rval"; shift) had zero
+# positive-path coverage. Reuses the BODY_SCOPED fixture from Scenario 2;
+# only the argv form differs.
+# --------------------------------------------------------------------------- #
+unset MOCK_GH_COMMENTS
+MOCK_GH_BODY="$BODY_SCOPED" assert_output \
+  "pre-joined single-token -R form (\"-R test/repo\" as one argv element): body-fallback scoped to ## Affected Files" \
+  "body-fallback" "bin/engine.mjs,bin/engine/phases.mjs" 2390 "-R test/repo"
+
+# --------------------------------------------------------------------------- #
+# Scenario 8: usage errors.
+# --------------------------------------------------------------------------- #
+assert_exit "missing issue number -> exit 2" 2 -R test/repo
+assert_exit "missing value for -R -> exit 2" 2 2388 -R
+assert_exit "malformed -R value (no slash, pre-joined token) -> exit 2" 2 2389 "-R notaslash"
+
+# --------------------------------------------------------------------------- #
+# Scenario 9 (forge#2504 regression fixture): primary `gh api` call fails
+# outright (simulated network error / rate limit) and there is no usable
+# fallback body either. Must yield PROVENANCE=error, NOT the pre-fix
+# behavior of silently falling through to PROVENANCE=none as if this were
+# a confirmed-empty result.
+# --------------------------------------------------------------------------- #
+unset MOCK_GH_COMMENTS MOCK_GH_BODY MOCK_GH_BODY_FAIL
+MOCK_GH_COMMENTS_FAIL=1 assert_output \
+  "forge#2504: primary gh api call fails, no usable fallback -> PROVENANCE=error, not none" \
+  "error" "" 2504 -R test/repo
+
+# --------------------------------------------------------------------------- #
+# Scenario 10 (forge#2504 regression fixture): no FORGE:INVESTIGATOR comment
+# (primary path legitimately empty, not failed) but the fallback `gh issue
+# view` call fails outright. Must yield PROVENANCE=error, NOT none.
+# --------------------------------------------------------------------------- #
+unset MOCK_GH_COMMENTS MOCK_GH_COMMENTS_FAIL
+MOCK_GH_BODY_FAIL=1 assert_output \
+  "forge#2504: no INVESTIGATOR comment (legitimately empty) + fallback gh issue view fails -> PROVENANCE=error, not none" \
+  "error" "" 2505 -R test/repo
+
+# --------------------------------------------------------------------------- #
+# Scenario 11 (forge#2504 regression fixture): primary `gh api` call fails,
+# but the fallback `gh issue view` call succeeds and yields real files. A
+# gh failure must never suppress or overwrite data actually recovered by a
+# subsequent successful call — this must still report body-fallback, not
+# error. Reuses the BODY_SCOPED fixture from Scenario 2.
+# --------------------------------------------------------------------------- #
+unset MOCK_GH_BODY_FAIL
+MOCK_GH_COMMENTS_FAIL=1 MOCK_GH_BODY="$BODY_SCOPED" assert_output \
+  "forge#2504: primary gh api call fails but fallback succeeds with real files -> body-fallback, not error" \
+  "body-fallback" "bin/engine.mjs,bin/engine/phases.mjs" 2506 -R test/repo
+
+# --------------------------------------------------------------------------- #
+# Summary
+# --------------------------------------------------------------------------- #
+echo ""
+echo "Results: $PASS passed, $FAIL failed"
+if [[ "$FAIL" -gt 0 ]]; then
+  exit 1
+fi
+exit 0

package/scripts/forge-run.sh

@@ -182,6 +182,8 @@ fi
 
 # Fetch issue: state, labels
 GH_STDERR_TMP=$(mktemp)
+chmod 600 "$GH_STDERR_TMP"
+trap 'rm -f "$GH_STDERR_TMP"' EXIT
 ISSUE_JSON=$(gh issue view "$ISSUE_NUMBER" "${GH_REPO_ARGS[@]}" \
   --json number,state,labels,title \
   2>"$GH_STDERR_TMP") || {
@@ -229,6 +231,8 @@ fi
 # via GH_REPO_ARGS and handles both default-repo and explicit-repo cases.
 # gh api repos/{owner}/{repo}/... would need GH_REPO env var for -R override — avoided here.
 GH_STDERR_TMP=$(mktemp)
+chmod 600 "$GH_STDERR_TMP"
+trap 'rm -f "$GH_STDERR_TMP"' EXIT
 COMMENTS_JSON=$(gh issue view "$ISSUE_NUMBER" "${GH_REPO_ARGS[@]}" \
   --json comments --jq '[.comments[] | {id: .id, body: .body}]' \
   2>"$GH_STDERR_TMP") || {

package/scripts/issue-dedup.sh

@@ -2,8 +2,8 @@
 # issue-dedup.sh — Deterministic near-duplicate check for GitHub issue creation
 #
 # Usage:
-#   issue-dedup.sh <title> [-R <owner/repo>] [--force]
-#   issue-dedup.sh <title> ["-R <owner/repo>"] [--force]   (single pre-joined token also accepted)
+#   issue-dedup.sh <title> [-R <owner/repo>] [--force] [--exclude <N,N,...>]
+#   issue-dedup.sh <title> ["-R <owner/repo>"] [--force] [--exclude <N,N,...>]   (single pre-joined -R token also accepted)
 #
 #   <title>           : Proposed issue title (required, must be quoted if it contains spaces)
 #   -R <owner/repo>   : GitHub repository, as two argv tokens (optional, defaults to
@@ -15,6 +15,19 @@
 #                       correctly detected by the parser and treated as a title, not a
 #                       repo flag. See the -R\ * case arm guard in the arg-parsing loop.
 #   --force           : Skip dedup check and always allow creation (explicit override)
+#   --exclude <N,N,...> : Comma-separated issue numbers to remove from the candidate
+#                       set BEFORE token matching runs. Accepts either "--exclude N,N"
+#                       (two argv tokens) or "--exclude=N,N" (one pre-joined token).
+#                       Intended for callers that are about to create an issue that is a
+#                       deliberate supersede of other, already-open issues (e.g. a P3
+#                       review-finding batch issue restating its own member findings) —
+#                       those members would otherwise always collide with the new title
+#                       by construction. This is NOT a --force equivalent: it narrows the
+#                       candidate set, it does not disable the check. Any OTHER open issue
+#                       (not in the exclusion list) is still matched normally, so a batch
+#                       title that happens to duplicate an unrelated existing issue is
+#                       still caught. See commands/issue.md Phase 2D for the integration
+#                       contract. <!-- Added: forge#2432 -->
 #
 # Exit codes:
 #   0 — No near-duplicate found. Creation is safe. Stdout is empty.
@@ -27,12 +40,13 @@
 #      of length ≥ 4 (short words are noise: "fix", "add", "the", etc.)
 #   2. Query open issues: search GitHub using the 2 most distinctive title tokens
 #      as the --search query (balances recall vs API cost)
-#   3. For each candidate open issue, count shared tokens (length ≥ 4) between
-#      the proposed title and the candidate title.
-#   4. MATCH threshold: ≥ 3 shared tokens OR shared token count ≥ 50% of
+#   3. Remove any --exclude'd issue numbers from the candidate set.
+#   4. For each remaining candidate open issue, count shared tokens (length ≥ 4)
+#      between the proposed title and the candidate title.
+#   5. MATCH threshold: ≥ 3 shared tokens OR shared token count ≥ 50% of
 #      the shorter title's token set — whichever fires first.
-#   5. On match: print "DUPLICATE: #<N> <title>" to stdout, exit 1.
-#   6. On no match: exit 0 (silent).
+#   6. On match: print "DUPLICATE: #<N> <title>" to stdout, exit 1.
+#   7. On no match: exit 0 (silent).
 #
 # Integration pattern (for command specs that call gh issue create):
 #
@@ -66,6 +80,10 @@
 #     "Regression of #N" reference; see issue.md Phase 2D).
 #   - The --force flag is the explicit override path. Human decision is required
 #     to use it — agents MUST NOT pass --force without user authorization.
+#   - The --exclude flag is NOT a --force equivalent and requires no human
+#     authorization: it narrows the candidate set to exclude specific already-
+#     known issue numbers (e.g. a batch's own declared members), it does not
+#     disable the check. Any other open issue is still matched normally.
 #   - Token matching is case-insensitive and punctuation-agnostic.
 #   - GitHub's --search flag performs a full-text search; the token query is a
 #     tiebreaker against the full candidate list, not the sole filter.
@@ -81,6 +99,7 @@ set -euo pipefail
 PROPOSED_TITLE=""
 GH_FLAG=""
 FORCE=0
+EXCLUDE_ARG=""
 
 while [[ $# -gt 0 ]]; do
   case "$1" in
@@ -121,6 +140,19 @@ while [[ $# -gt 0 ]]; do
       FORCE=1
       shift
       ;;
+    --exclude)
+      shift
+      if [[ $# -eq 0 ]]; then
+        echo "Missing value for --exclude" >&2
+        exit 2
+      fi
+      EXCLUDE_ARG="$1"
+      shift
+      ;;
+    --exclude=*)
+      EXCLUDE_ARG="${1#--exclude=}"
+      shift
+      ;;
     -*)
       echo "Unknown flag: $1" >&2
       exit 2
@@ -133,7 +165,7 @@ while [[ $# -gt 0 ]]; do
 done
 
 if [[ -z "$PROPOSED_TITLE" ]]; then
-  echo "Usage: issue-dedup.sh <title> [-R <owner/repo>] [--force]" >&2
+  echo "Usage: issue-dedup.sh <title> [-R <owner/repo>] [--force] [--exclude <N,N,...>]" >&2
   exit 2
 fi
 
@@ -142,6 +174,27 @@ if [[ "$FORCE" -eq 1 ]]; then
   exit 0
 fi
 
+# --------------------------------------------------------------------------- #
+# Exclusion set (--exclude N,N,N)
+# Narrows the candidate set BEFORE token matching — does NOT disable the gate.
+# Non-numeric/malformed tokens are silently dropped rather than treated as a
+# usage error, since callers typically build this list programmatically from
+# a bash array of issue numbers (e.g. a batch's own member issues) and should
+# not have to pre-validate it. Same "|| true" pattern as the grep -c hazard
+# documented below — a filter that legitimately matches nothing must not trip
+# `set -e`.
+# --------------------------------------------------------------------------- #
+EXCLUDE_SET=""
+if [[ -n "$EXCLUDE_ARG" ]]; then
+  EXCLUDE_SET=$(echo "$EXCLUDE_ARG" | tr ',' '\n' | sed 's/^[[:space:]]*//;s/[[:space:]]*$//' | grep -E '^[0-9]+$' || true)
+fi
+
+is_excluded() {
+  local num="$1"
+  [[ -z "$EXCLUDE_SET" ]] && return 1
+  grep -qxF "$num" <<< "$EXCLUDE_SET"
+}
+
 # --------------------------------------------------------------------------- #
 # Token normalization
 # Lowercase, strip non-alphanumeric chars except spaces, split on whitespace,
@@ -198,6 +251,14 @@ MATCH_TITLE=""
 while IFS=$'\t' read -r CAND_NUMBER CAND_TITLE; do
   [[ -z "$CAND_NUMBER" ]] && continue
 
+  # Excluded candidates (e.g. a batch issue's own declared members) are removed
+  # from the candidate set entirely — they never reach token matching, so they
+  # can never produce a false "DUPLICATE" against the very issue meant to
+  # supersede them. Any other open issue is still matched normally below.
+  if is_excluded "$CAND_NUMBER"; then
+    continue
+  fi
+
   CAND_TOKENS=$(normalize_tokens "$CAND_TITLE")
   # Same double-fallback hazard as PROPOSED_TOKEN_COUNT above — see comment there.
   CAND_TOKEN_COUNT=$(echo "$CAND_TOKENS" | grep -c . || true)

package/scripts/issue-dedup.test.sh

@@ -0,0 +1,142 @@
+#!/usr/bin/env bash
+# issue-dedup.test.sh — Unit-style tests for scripts/issue-dedup.sh's --exclude flag
+#
+# No network/GitHub API access required: `gh` is replaced with a mock that
+# returns fixture candidate lists via the MOCK_GH_CANDIDATES env var, mimicking
+# the "\(.number)\t\(.title)" projection issue-dedup.sh expects from
+# `gh issue list --json number,title --jq '...'`.
+#
+# Usage: bash scripts/issue-dedup.test.sh
+# Exit code: 0 if all assertions pass, 1 if any fail.
+#
+# SPDX-FileCopyrightText: Copyright (c) RapierCraft Studios
+# SPDX-License-Identifier: AGPL-3.0-or-later
+
+set -uo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+DEDUP="$SCRIPT_DIR/issue-dedup.sh"
+
+TMP_BIN=$(mktemp -d)
+TMP_FIXTURES=$(mktemp -d)
+cleanup() {
+  rm -rf "$TMP_BIN" "$TMP_FIXTURES"
+}
+trap cleanup EXIT
+
+# --------------------------------------------------------------------------- #
+# Mock `gh` — intercepts `gh issue list ...` and prints the fixture file named
+# by $MOCK_GH_CANDIDATES (tab-separated "number\ttitle" lines), ignoring all
+# other flags/subcommands issue-dedup.sh passes through. Any other `gh`
+# invocation is treated as an unexpected test setup error.
+# --------------------------------------------------------------------------- #
+cat > "$TMP_BIN/gh" <<'MOCK'
+#!/usr/bin/env bash
+if [[ "$1" == "issue" && "$2" == "list" ]]; then
+  if [[ -n "${MOCK_GH_CANDIDATES:-}" && -f "${MOCK_GH_CANDIDATES:-}" ]]; then
+    cat "$MOCK_GH_CANDIDATES"
+  fi
+  exit 0
+fi
+echo "issue-dedup.test.sh: unexpected gh mock invocation: $*" >&2
+exit 1
+MOCK
+chmod +x "$TMP_BIN/gh"
+
+export PATH="$TMP_BIN:$PATH"
+
+PASS=0
+FAIL=0
+
+# assert_exit <description> <expected_exit> <dedup args...>
+assert_exit() {
+  local desc="$1" expected="$2"
+  shift 2
+  set +e
+  OUT=$("$DEDUP" "$@" 2>&1)
+  ACTUAL=$?
+  set -e
+  if [[ "$ACTUAL" -eq "$expected" ]]; then
+    echo "PASS: $desc"
+    PASS=$((PASS + 1))
+  else
+    echo "FAIL: $desc (expected exit $expected, got $ACTUAL)"
+    echo "  output: $OUT"
+    FAIL=$((FAIL + 1))
+  fi
+}
+
+PROPOSED_TITLE="fix(batch): duplicate detection review findings"
+
+# --------------------------------------------------------------------------- #
+# Scenario A: candidate set contains ONLY the batch's own declared members.
+# Both titles are engineered to share >=3 normalized tokens (length >= 4) with
+# the proposed title: "duplicate", "detection", "review"/"findings".
+# --------------------------------------------------------------------------- #
+MEMBERS_ONLY="$TMP_FIXTURES/members_only.tsv"
+cat > "$MEMBERS_ONLY" <<'EOF'
+2422	fix: duplicate detection review token overlap
+2424	fix: duplicate detection findings batching logic
+EOF
+
+MOCK_GH_CANDIDATES="$MEMBERS_ONLY" assert_exit \
+  "baseline (no --exclude): batch title collides with its own members -> exit 1" \
+  1 "$PROPOSED_TITLE" -R test/repo
+
+MOCK_GH_CANDIDATES="$MEMBERS_ONLY" assert_exit \
+  "--exclude '2422,2424': batch title excludes its own members -> exit 0" \
+  0 "$PROPOSED_TITLE" -R test/repo --exclude "2422,2424"
+
+MOCK_GH_CANDIDATES="$MEMBERS_ONLY" assert_exit \
+  "--exclude=2422,2424 (pre-joined form) -> exit 0" \
+  0 "$PROPOSED_TITLE" -R test/repo --exclude=2422,2424
+
+# --------------------------------------------------------------------------- #
+# Scenario B: candidate set has the declared members PLUS an unrelated
+# non-member issue (#2600) that also collides on token overlap. Excluding the
+# members must NOT suppress the non-member match — protection is preserved.
+# --------------------------------------------------------------------------- #
+MEMBERS_PLUS_NONMEMBER="$TMP_FIXTURES/members_plus_nonmember.tsv"
+cat > "$MEMBERS_PLUS_NONMEMBER" <<'EOF'
+2422	fix: duplicate detection review token overlap
+2424	fix: duplicate detection findings batching logic
+2600	fix: duplicate detection review triage
+EOF
+
+MOCK_GH_CANDIDATES="$MEMBERS_PLUS_NONMEMBER" assert_exit \
+  "--exclude '2422,2424' with a real non-member duplicate present -> still exit 1" \
+  1 "$PROPOSED_TITLE" -R test/repo --exclude "2422,2424"
+
+# --------------------------------------------------------------------------- #
+# Scenario C: exclusion list has no bearing when there is no candidate overlap
+# at all — sanity check that --exclude doesn't accidentally suppress dedup.
+# --------------------------------------------------------------------------- #
+NO_OVERLAP="$TMP_FIXTURES/no_overlap.tsv"
+cat > "$NO_OVERLAP" <<'EOF'
+9001	feat: totally unrelated subsystem work
+EOF
+
+MOCK_GH_CANDIDATES="$NO_OVERLAP" assert_exit \
+  "no overlap at all, --exclude present but irrelevant -> exit 0" \
+  0 "$PROPOSED_TITLE" -R test/repo --exclude "2422,2424"
+
+# --------------------------------------------------------------------------- #
+# Scenario D: malformed / non-numeric exclusion tokens are silently dropped,
+# not a usage error.
+# --------------------------------------------------------------------------- #
+MOCK_GH_CANDIDATES="$MEMBERS_ONLY" assert_exit \
+  "malformed --exclude tokens (non-numeric) are dropped, real numeric ones still apply -> exit 0" \
+  0 "$PROPOSED_TITLE" -R test/repo --exclude "2422, 2424, abc, "
+
+# --------------------------------------------------------------------------- #
+# Scenario E: --exclude combined with existing -R parsing (two-token and
+# pre-joined forms) does not regress prior -R argument-parsing fixes (#1530,
+# #1625).
+# --------------------------------------------------------------------------- #
+MOCK_GH_CANDIDATES="$MEMBERS_ONLY" assert_exit \
+  "--exclude alongside pre-joined -R token -> exit 0" \
+  0 "$PROPOSED_TITLE" "-R test/repo" --exclude "2422,2424"
+
+echo ""
+echo "Results: $PASS passed, $FAIL failed"
+[[ "$FAIL" -eq 0 ]]