forgedock 1.1.11 → 1.3.0

package/commands/security-audit.md

@@ -1,6 +1,6 @@
 ---
 description: Periodic security posture audit — runs a scripted 4-phase checklist against repo files (not diffs), creates GitHub issues for confirmed findings
-argument-hint: [--repo <prefix>] [--phase 1|2|3|4|all] [--dry-run]
+argument-hint: "[--repo <prefix>] [--phase 1|2|3|4|all] [--dry-run]"
 install: extras
 ---
 <!-- SPDX-FileCopyrightText: Copyright (c) RapierCraft Studios -->
@@ -515,20 +515,18 @@ gh label create "priority:P3" --color "C2E0C6" --description "Low priority — m
 
 ### 5C: Create GitHub issues for CONFIRMED findings
 
-For each CONFIRMED finding (not REVIEW-only), create an issue:
+For each CONFIRMED finding (not REVIEW-only), create an issue — routed through the `/issue` create-hook's programmatic invocation contract (see `commands/issue.md` → Programmatic Invocation Contract) so dedup and mandatory-section validation run on every finding:
 
 ```bash
-gh issue create -R "{GH_REPO}" \
-  --title "{ISSUE_TITLE}" \
-  --label "security,audit-finding,{SEVERITY}" \
-  --body "$(cat <<'ISSUE_EOF'
+SECURITY_BODY_FILE=$(mktemp)
+cat > "$SECURITY_BODY_FILE" <<'ISSUE_EOF'
 ## Problem
 
 {2-3 sentences describing the finding, its location, and exploitation path.}
 
 ## Evidence
 
-**File**: \`{FILE}\`
+**File**: `{FILE}`
 **Line**: {LINE}
 **Finding**: {GREP_OUTPUT}
 
@@ -538,23 +536,28 @@ gh issue create -R "{GH_REPO}" \
 
 ## Affected Files
 
-1. \`{FILE}\` — {what needs to change}
+1. `{FILE}` — {what needs to change}
 
 ## Acceptance Criteria
 
 - [ ] {Specific remediation step}
-- [ ] Verified by re-running \`/security-audit\` after fix
+- [ ] Verified by re-running `/security-audit` after fix
 
 ## Context
 
 **Audited at**: {TIMESTAMP}
 **Audit phase**: {PHASE}
 **Severity**: {SEVERITY}
-**Source**: \`/security-audit\` run on \`{GH_REPO}\`
+**Source**: `/security-audit` run on `{GH_REPO}`
 ISSUE_EOF
-)"
 ```
 
+```
+Skill(skill="issue", args="--title \"{ISSUE_TITLE}\" --body-file \"$SECURITY_BODY_FILE\" --label \"security\" --label \"audit-finding\" --label \"{SEVERITY}\"")
+```
+
+`security`, `audit-finding`, and `{SEVERITY}` are each passed as their own `--label` flag — `/issue`'s programmatic mode does not comma-split a single `--label` value. Note: `/issue` resolves the target repo from `forge.yaml → project.owner/repo` (or the satellite-prefix table), not from a caller-supplied `-R`/`--repo` flag — this is correct for the common case where `{GH_REPO}` matches `forge.yaml`'s project repo.
+
 ### 5D: Post audit summary comment (if invoked from a GitHub issue context)
 
 If this command was invoked from within a `/work-on` context or with an issue reference:

package/commands/signal-planner.md

@@ -1,6 +1,6 @@
 ---
 description: Closed-loop autonomy — convert a production/analytics/incident signal into a dependency-ordered issue DAG, execute via /orchestrate, then verify the originating signal is resolved. Event-driven companion to /autopilot.
-argument-hint: [--signal '<json>' | --metric '<name> <threshold>' | --incident <issue#> | --geo | --dry-run | --max-issues N]
+argument-hint: "[--signal '<json>' | --metric '<name> <threshold>' | --incident <issue#> | --geo | --dry-run | --max-issues N]"
 install: extras
 ---
 <!-- SPDX-FileCopyrightText: Copyright (c) RapierCraft Studios -->
@@ -224,10 +224,10 @@ Detect cycles — if a cycle exists, break it by demoting the lower-priority uni
 Post the DAG to a tracker issue on GitHub. First, create the tracker issue:
 
 ```bash
-TRACKER_ISSUE=$(gh issue create -R {GH_REPO} \
-  --title "signal-planner: DAG tracker for {SIGNAL.name}" \
-  --label "signal-planner,priority:{SIGNAL.severity}" \
-  --body "$(cat <<'TRACKER_EOF'
+TRACKER_TITLE="signal-planner: DAG tracker for {SIGNAL.name}"
+TRACKER_BODY_TMPFILE=$(mktemp)
+trap 'rm -f "$TRACKER_BODY_TMPFILE"' EXIT
+cat > "$TRACKER_BODY_TMPFILE" <<'TRACKER_EOF'
 ## Signal
 
 **Type**: {SIGNAL.type}
@@ -247,7 +247,18 @@ This tracker was created by \`/signal-planner\`. The dependency DAG below repres
 - [ ] All DAG issues merged
 - [ ] Originating signal verified resolved (FORGE:SIGNAL_RESOLVED posted)
 TRACKER_EOF
-)" --json number --jq '.number')
+# Route through the /issue create-hook (canonical dedup + body validation) instead of a raw
+# `gh issue create`. This body uses "## Acceptance" rather than the mandatory "## Acceptance
+# Criteria"/"## Affected Files"/"## Problem" sections — /issue's Phase 3F will non-blockingly
+# append placeholder mandatory sections; this is expected for a coordination tracker issue.
+Skill(skill="issue", args="--title \"$TRACKER_TITLE\" --body-file \"$TRACKER_BODY_TMPFILE\" --label signal-planner --label \"priority:{SIGNAL.severity}\"")
+rm -f "$TRACKER_BODY_TMPFILE"
+trap - EXIT
+TRACKER_ISSUE=$(gh issue list -R {GH_REPO} \
+  --state open \
+  --search "$TRACKER_TITLE" \
+  --json number,title \
+  --jq --arg t "$TRACKER_TITLE" '.[] | select(.title == $t) | .number' 2>/dev/null | head -1)
 ```
 
 Then post the `FORGE:PLAN_DAG` comment:
@@ -312,10 +323,10 @@ If governor would be breached, **hard fail** — do not create any issues, do no
 For each work unit with `existing == null`, create a GitHub issue:
 
 ```bash
-ISSUE_NUM=$(gh issue create -R {GH_REPO} \
-  --title "{work_unit.title}" \
-  --label "priority:{work_unit.priority},{work_unit.type}" \
-  --body "$(cat <<'ISSUE_EOF'
+WORK_UNIT_TITLE="{work_unit.title}"
+WORK_UNIT_BODY_TMPFILE=$(mktemp)
+trap 'rm -f "$WORK_UNIT_BODY_TMPFILE"' EXIT
+cat > "$WORK_UNIT_BODY_TMPFILE" <<'ISSUE_EOF'
 ## Problem
 
 {work_unit.rationale — why this is needed to resolve the originating signal}
@@ -341,10 +352,19 @@ Signal context: {relevant subset of SIGNAL.context for this work unit}
 ---
 *Created by \`/signal-planner\` on $(date -u +%Y-%m-%dT%H:%M:%SZ). Will be investigated before any fix is applied.*
 ISSUE_EOF
-)" --json number --jq '.number')
+# Route through the /issue create-hook (canonical dedup + body validation) instead of a raw
+# `gh issue create`.
+Skill(skill="issue", args="--title \"$WORK_UNIT_TITLE\" --body-file \"$WORK_UNIT_BODY_TMPFILE\" --label \"priority:{work_unit.priority}\" --label \"{work_unit.type}\"")
+rm -f "$WORK_UNIT_BODY_TMPFILE"
+trap - EXIT
+ISSUE_NUM=$(gh issue list -R {GH_REPO} \
+  --state open \
+  --search "$WORK_UNIT_TITLE" \
+  --json number,title \
+  --jq --arg t "$WORK_UNIT_TITLE" '.[] | select(.title == $t) | .number' 2>/dev/null | head -1)
 ```
 
-Record each created issue number and update the DAG table in the tracker issue.
+Record each created issue number and update the DAG table in the tracker issue. If `/issue` deduped this work unit against an existing open issue, `ISSUE_NUM` will come back empty — fall back to `work_unit.existing` (if already resolved during Phase 2) or treat the work unit as already covered and skip re-creation.
 
 ### 3C: Compile final DAG issue list
 

package/commands/spec-doctor.md

@@ -1,6 +1,6 @@
 ---
 description: Evidence-backed spec evolution — reads finding concentration for a spec file, drafts a spec diff, opens a spec-evolution PR with per-change citations
-argument-hint: [spec file path | "auto"]
+argument-hint: "[spec file path | \"auto\"]"
 install: extras
 ---
 <!-- SPDX-FileCopyrightText: Copyright (c) RapierCraft Studios -->

package/commands/sync-ecosystem.md

@@ -1,6 +1,6 @@
 ---
 description: Detect API changes, sync satellite repos, and publish releases
-argument-hint: [check | auto | status | publish | PR-number]
+argument-hint: "[check | auto | status | publish | PR-number]"
 install: extras
 ---
 <!-- SPDX-FileCopyrightText: Copyright (c) RapierCraft Studios -->
@@ -218,10 +218,16 @@ Create issues in the affected repos:
 
 ```bash
 # For satellite repos (separate GitHub repos):
-gh issue create -R {TARGET_REPO} \
-  --title "feat(sync): {description of what API change needs to be reflected}" \
-  --label "feature,priority:P2" \
-  --body "$(cat <<'BODY_EOF'
+#
+# /issue resolves its target repo in Phase 1A from a `{prefix}:` token at the start of the
+# free-text input, not from an explicit -R override — its multi-repo prefix table is keyed
+# off forge.yaml → repos.satellites (the same registry this file already iterates). Prepend
+# the satellite's configured {COMPONENT} (= satellites[].prefix) to the title so /issue routes
+# to {TARGET_REPO} correctly instead of the default project repo.
+SYNC_TITLE="feat(sync): {description of what API change needs to be reflected}"
+SYNC_BODY_TMPFILE=$(mktemp)
+trap 'rm -f "$SYNC_BODY_TMPFILE"' EXIT
+cat > "$SYNC_BODY_TMPFILE" <<'BODY_EOF'
 ## Problem
 
 {1-3 sentences: what API or schema change in the upstream repo needs to be reflected in this satellite repo. What will break or be missing if this sync is not done.}
@@ -252,13 +258,41 @@ Files that need changes:
 
 {If applicable: describe the new API shape with an example}
 BODY_EOF
-)"
+# Route through the /issue create-hook (canonical dedup + body validation) instead of a raw
+# `gh issue create`. Prefixing the title with "{COMPONENT}: " lets /issue's Phase 1A resolve
+# the satellite repo ({TARGET_REPO}) from forge.yaml → repos.satellites, matching how a human
+# would invoke /issue for the same satellite (e.g. "mcp: add list_schemas tool"). The prefix
+# is stripped by /issue's own routing — it does not become part of the created issue title.
+Skill(skill="issue", args="\"{COMPONENT}: $SYNC_TITLE\" --title \"$SYNC_TITLE\" --body-file \"$SYNC_BODY_TMPFILE\" --label feature --label \"priority:P2\"")
+rm -f "$SYNC_BODY_TMPFILE"
+trap - EXIT
+SYNC_ISSUE_NUMBER=$(gh issue list -R {TARGET_REPO} \
+  --state open \
+  --search "$SYNC_TITLE" \
+  --json number,title \
+  --jq --arg t "$SYNC_TITLE" '.[] | select(.title == $t) | .number' 2>/dev/null | head -1)
+
+# Safety net: the "{COMPONENT}: " prefix trick above is not a documented part of the
+# Programmatic Invocation Contract (issue.md has no --repo/-R flag for programmatic mode) —
+# if /issue's Phase 1A did not honor the prefix and created the issue in the default project
+# repo instead of {TARGET_REPO}, the lookup above returns empty and this would otherwise be
+# silently treated as "deduped by /issue" further down. Distinguish the two cases explicitly.
+if [ -z "$SYNC_ISSUE_NUMBER" ]; then
+  MISROUTED_CHECK=$(gh issue list \
+    --state open \
+    --search "$SYNC_TITLE" \
+    --json number,title \
+    --jq --arg t "$SYNC_TITLE" '.[] | select(.title == $t) | .number' 2>/dev/null | head -1)
+  if [ -n "$MISROUTED_CHECK" ]; then
+    echo "WARNING: '/issue' created #$MISROUTED_CHECK in the default project repo instead of {TARGET_REPO} — the '{COMPONENT}:' prefix routing did not take effect. Move/re-file the issue in {TARGET_REPO} manually."
+  fi
+fi
 
 # For monorepo issues (SDKs, packages inside a single repo):
-gh issue create \
-  --title "feat(sync): {description of what API change needs to be reflected}" \
-  --label "feature,priority:P2" \
-  --body "$(cat <<'BODY_EOF'
+MONOREPO_SYNC_TITLE="feat(sync): {description of what API change needs to be reflected}"
+MONOREPO_SYNC_BODY_TMPFILE=$(mktemp)
+trap 'rm -f "$MONOREPO_SYNC_BODY_TMPFILE"' EXIT
+cat > "$MONOREPO_SYNC_BODY_TMPFILE" <<'BODY_EOF'
 ## Problem
 
 {1-3 sentences: what API or schema change needs to be reflected in this SDK or package. What will be out of sync if not updated.}
@@ -285,7 +319,16 @@ Files that need changes:
 **Change**: {description of upstream API change}
 **Detected by**: `/sync-ecosystem`
 BODY_EOF
-)"
+# Route through the /issue create-hook (canonical dedup + body validation) instead of a raw
+# `gh issue create`. No prefix needed — this targets the default/monorepo repo.
+Skill(skill="issue", args="--title \"$MONOREPO_SYNC_TITLE\" --body-file \"$MONOREPO_SYNC_BODY_TMPFILE\" --label feature --label \"priority:P2\"")
+rm -f "$MONOREPO_SYNC_BODY_TMPFILE"
+trap - EXIT
+MONOREPO_SYNC_ISSUE_NUMBER=$(gh issue list \
+  --state open \
+  --search "$MONOREPO_SYNC_TITLE" \
+  --json number,title \
+  --jq --arg t "$MONOREPO_SYNC_TITLE" '.[] | select(.title == $t) | .number' 2>/dev/null | head -1)
 ```
 
 ### Add sync issues to Project board

package/commands/test-gate.md

@@ -1,6 +1,6 @@
 ---
 description: Deterministic deploy-gate — verify a staging→main bundle's acceptance criteria against running code before deploy
-argument-hint: [--prs "<N1 N2 ...>"] [--base <branch>]
+argument-hint: "[--prs \"<N1 N2 ...>\"] [--base <branch>]"
 allowed-tools: Task, Bash, Read, Grep, Glob
 install: extras
 ---
@@ -520,10 +520,16 @@ else
       SOURCE_ISSUES_LIST="${SOURCE_ISSUES_LIST}\n- #${issue_num}"
     done
 
-    ISSUE_NUM=$(gh issue create ${GH_FLAG} \
-      --title "fix: test-gate FAIL — cluster '${cluster}' broken by staging→${DEFAULT_BRANCH} bundle" \
-      --label "test-failure,priority:P1" \
-      --body "$(cat <<ISSUE_EOF
+    TESTGATE_FAIL_TITLE="fix: test-gate FAIL — cluster '${cluster}' broken by staging→${DEFAULT_BRANCH} bundle"
+    # Defense-in-depth: /issue's arg tokenizer (commands/issue.md, forge#2094) uses
+    # an xargs-based tokenizer that never expands backtick/$(...) substitution, so
+    # this is no longer required for safety — but strip it anyway so the raw title
+    # stays readable if it round-trips through any other eval-based consumer.
+    # ${cluster} is config-controlled (forge.yaml verification.integration_tests), but sanitize
+    # unconditionally for defense-in-depth consistency with the other converted call sites.
+    TESTGATE_FAIL_TITLE=$(printf '%s' "$TESTGATE_FAIL_TITLE" | tr '`' "'" | sed 's/\$(/$ (/g')
+    TESTGATE_FAIL_BODY_FILE=$(mktemp)
+    cat <<ISSUE_EOF > "$TESTGATE_FAIL_BODY_FILE"
 ## Problem
 
 The \`/test-gate\` command detected a runtime failure in cluster \`${cluster}\` that was introduced by the staging→${DEFAULT_BRANCH} bundle. The failure did not exist on \`${BASE_BRANCH}\` (baseline PASS), confirming it is batch-introduced, not pre-existing.
@@ -570,7 +576,21 @@ $(echo -e "$SOURCE_ISSUES_LIST")
    $(yq ".verification.integration_tests[] | select(.cluster == \"${cluster}\") | .command" "$CONFIG_FILE")
    \`\`\`
 ISSUE_EOF
-)" --json number --jq '.number' 2>/dev/null || echo "FAILED")
+
+    # Route through the /issue create-hook's programmatic invocation contract (see
+    # commands/issue.md § "Programmatic Invocation Contract") instead of the raw issue-creation call.
+    Skill(skill="issue", args="--title \"$TESTGATE_FAIL_TITLE\" --body-file \"$TESTGATE_FAIL_BODY_FILE\" --label test-failure --label priority:P1")
+    rm -f "$TESTGATE_FAIL_BODY_FILE"
+
+    # /issue has no machine-readable return contract — resolve the created issue's number by
+    # exact-title search immediately after the call. Retry to absorb GitHub Search API indexing lag.
+    ISSUE_NUM=""
+    for _resolve_attempt in 1 2 3; do
+      ISSUE_NUM=$(gh issue list ${GH_FLAG} --search "in:title \"${TESTGATE_FAIL_TITLE}\"" --state open --limit 1 --json number --jq '.[0].number // empty' 2>/dev/null || echo "")
+      [ -n "$ISSUE_NUM" ] && break
+      sleep 2
+    done
+    [ -z "$ISSUE_NUM" ] && ISSUE_NUM="FAILED"
 
     if [ "$ISSUE_NUM" != "FAILED" ] && [ -n "$ISSUE_NUM" ]; then
       echo "Filed test-failure issue #${ISSUE_NUM} for cluster '${cluster}'"
@@ -786,10 +806,14 @@ if [ "${UNCOVERED_COUNT}" -gt 0 ]; then
       continue
     fi
 
-    GAP_ISSUE_NUM=$(gh issue create ${GH_FLAG} \
-      --title "fix: test-gap — uncovered criterion in issue #${GAP_ISSUE} (${GAP_TYPE})" \
-      --label "test-gap" \
-      --body "$(cat <<TGAP_EOF
+    TESTGAP_TITLE="fix: test-gap — uncovered criterion in issue #${GAP_ISSUE} (${GAP_TYPE})"
+    # Defense-in-depth: /issue's arg tokenizer (commands/issue.md, forge#2094) uses
+    # an xargs-based tokenizer that never expands backtick/$(...) substitution, so
+    # this is no longer required for safety — but strip it anyway so the raw title
+    # stays readable if it round-trips through any other eval-based consumer.
+    TESTGAP_TITLE=$(printf '%s' "$TESTGAP_TITLE" | tr '`' "'" | sed 's/\$(/$ (/g')
+    TESTGAP_BODY_FILE=$(mktemp)
+    cat <<TGAP_EOF > "$TESTGAP_BODY_FILE"
 ## Problem
 
 The \`/test-gate\` criteria-adequacy check (Phase 6) found a runtime-testable acceptance criterion in issue #${GAP_ISSUE} that is not covered by any configured test cluster. Coverage gaps cannot produce a clean PASS verdict — this criterion must be covered before the staging→${DEFAULT_BRANCH} bundle can pass the deploy gate.
@@ -822,7 +846,21 @@ Files to be identified during investigation. Start with the test suite for the \
 ${GAP_CRITERION}
 \`\`\`
 TGAP_EOF
-)" --json number --jq '.number' 2>/dev/null || echo "FAILED")
+
+    # Route through the /issue create-hook's programmatic invocation contract (see
+    # commands/issue.md § "Programmatic Invocation Contract") instead of the raw issue-creation call.
+    Skill(skill="issue", args="--title \"$TESTGAP_TITLE\" --body-file \"$TESTGAP_BODY_FILE\" --label test-gap")
+    rm -f "$TESTGAP_BODY_FILE"
+
+    # /issue has no machine-readable return contract — resolve the created issue's number by
+    # exact-title search immediately after the call. Retry to absorb GitHub Search API indexing lag.
+    GAP_ISSUE_NUM=""
+    for _resolve_attempt in 1 2 3; do
+      GAP_ISSUE_NUM=$(gh issue list ${GH_FLAG} --search "in:title \"${TESTGAP_TITLE}\"" --state open --limit 1 --json number --jq '.[0].number // empty' 2>/dev/null || echo "")
+      [ -n "$GAP_ISSUE_NUM" ] && break
+      sleep 2
+    done
+    [ -z "$GAP_ISSUE_NUM" ] && GAP_ISSUE_NUM="FAILED"
 
     if [ "$GAP_ISSUE_NUM" != "FAILED" ] && [ -n "$GAP_ISSUE_NUM" ]; then
       echo "Filed test-gap issue #${GAP_ISSUE_NUM} for uncovered criterion in #${GAP_ISSUE} (${GAP_TYPE})"