forgedock 1.0.9 → 1.0.10

package/bin/init-detect.mjs

@@ -186,7 +186,7 @@ function detectDefaultBranch(cwd) {
       );
     }
   } catch {
-    // git not available or detached HEAD
+    // git unavailable or not a git repo
   }
 
   // Strategy 3: fall back

package/bin/init-enrich-api.mjs

@@ -107,8 +107,16 @@ export function parseEnrichedDraft(output, draft) {
         // Found the closing brace of the top-level object — parse the candidate.
         try {
           const enriched = JSON.parse(output.slice(start, i + 1));
-          // Basic sanity check: must have the required top-level sections.
-          if (!enriched.project || !enriched.paths || !enriched.branches) {
+          // Basic sanity check: must have the required top-level sections and
+          // each section must be a plain non-null object. The typeof+null guard
+          // rejects null and primitives; Array.isArray() additionally rejects
+          // arrays since typeof [] === 'object' would otherwise pass them.
+          if (
+            typeof enriched.project !== "object" || enriched.project === null || Array.isArray(enriched.project) ||
+            typeof enriched.paths !== "object" || enriched.paths === null || Array.isArray(enriched.paths) ||
+            typeof enriched.branches !== "object" || enriched.branches === null || Array.isArray(enriched.branches) ||
+            typeof enriched.meta !== "object" || enriched.meta === null || Array.isArray(enriched.meta)
+          ) {
             return draft;
           }
           return enriched;

package/bin/tui.mjs

@@ -106,9 +106,6 @@ export function box(content, { title = "", padding = 1, width } = {}) {
   const lines = Array.isArray(content) ? content : String(content).split("\n");
   const pad = " ".repeat(padding);
 
-  // Strip ANSI codes to compute visual width
-  const stripAnsi = (s) => s.replace(/\x1b\[[0-9;]*[A-Za-z]/g, "");
-
   const contentWidth = lines.reduce(
     (max, l) => Math.max(max, stripAnsi(l).length),
     0,
@@ -659,8 +656,6 @@ export function table(
 ) {
   if (!rows || rows.length === 0) return "";
 
-  const stripAnsi = (s) => s.replace(/\x1b\[[0-9;]*[A-Za-z]/g, "");
-
   // Compute column widths
   const colCount = Math.max(...rows.map((r) => r.length));
   const widths = Array.from({ length: colCount }, (_, c) =>
@@ -701,6 +696,63 @@ export function table(
   return lines.join("\n") + "\n";
 }
 
+// ---------------------------------------------------------------------------
+// ANSI string utilities (exported for testing)
+// ---------------------------------------------------------------------------
+
+/** Strip all ANSI CSI sequences from a string, returning only visible text. */
+export function stripAnsi(s) {
+  return s.replace(/\x1b\[[0-9;]*[A-Za-z]/g, "");
+}
+
+/**
+ * Truncate an ANSI-decorated string to at most `maxWidth` visible characters,
+ * never bisecting an escape sequence.
+ *
+ * Tokens from the cut region are suppressed — only ANSI tokens encountered
+ * while the visible budget is still live are forwarded to the output.
+ * A trailing reset (\x1b[0m) is appended when truncation occurs and the
+ * result already contains ANSI sequences, preventing color bleed into
+ * adjacent columns.
+ */
+export function truncateVisible(str, maxWidth) {
+  const ansiRe = /\x1b\[[0-9;]*[A-Za-z]/g;
+  let visible = 0;
+  let result = "";
+  let lastIndex = 0;
+  let m;
+  ansiRe.lastIndex = 0;
+  while ((m = ansiRe.exec(str)) !== null) {
+    // Consume plain-text chars before this ANSI token
+    const plain = str.slice(lastIndex, m.index);
+    const remaining = maxWidth - visible;
+    if (remaining > 0) {
+      result += plain.slice(0, remaining);
+      visible += Math.min(plain.length, remaining);
+    }
+    // Only include the ANSI token while the visible budget is not yet exhausted.
+    // Once the cut point is reached, tokens from the removed region are suppressed;
+    // the post-loop reset guard below handles color-state cleanup.
+    if (visible < maxWidth) {
+      result += m[0];
+    }
+    lastIndex = ansiRe.lastIndex;
+  }
+  // Remaining plain text after last ANSI token
+  const remaining = maxWidth - visible;
+  if (remaining > 0) {
+    result += str.slice(lastIndex, lastIndex + remaining);
+  }
+  // If truncation occurred and the result contains any ANSI sequences,
+  // append a full reset to prevent color from bleeding into adjacent columns.
+  // Truncation is detected by checking whether the original string has more
+  // visible characters than maxWidth (i.e. stripAnsi(str).length > maxWidth).
+  if (stripAnsi(str).length > maxWidth && result.includes("\x1b[")) {
+    result += "\x1b[0m";
+  }
+  return result;
+}
+
 // ---------------------------------------------------------------------------
 // Annotated Review Screen
 // ---------------------------------------------------------------------------
@@ -821,50 +873,12 @@ export async function annotatedReviewScreen(
     };
   }
 
-  const stripAnsi = (s) => s.replace(/\x1b\[[0-9;]*[A-Za-z]/g, "");
-
   // Pad an ANSI-decorated string to `width` visible characters.
   function padVisible(str, width) {
     const visual = stripAnsi(str).length;
     return str + " ".repeat(Math.max(0, width - visual));
   }
 
-  // Truncate an ANSI-decorated string to at most `maxWidth` visible characters,
-  // never bisecting an escape sequence.
-  function truncateVisible(str, maxWidth) {
-    const ansiRe = /\x1b\[[0-9;]*[A-Za-z]/g;
-    let visible = 0;
-    let result = "";
-    let lastIndex = 0;
-    let m;
-    ansiRe.lastIndex = 0;
-    while ((m = ansiRe.exec(str)) !== null) {
-      // Consume plain-text chars before this ANSI token
-      const plain = str.slice(lastIndex, m.index);
-      const remaining = maxWidth - visible;
-      if (remaining > 0) {
-        result += plain.slice(0, remaining);
-        visible += Math.min(plain.length, remaining);
-      }
-      // Always include the ANSI token (zero visible width)
-      result += m[0];
-      lastIndex = ansiRe.lastIndex;
-    }
-    // Remaining plain text after last ANSI token
-    const remaining = maxWidth - visible;
-    if (remaining > 0) {
-      result += str.slice(lastIndex, lastIndex + remaining);
-    }
-    // If truncation occurred and the result contains any ANSI sequences,
-    // append a full reset to prevent color from bleeding into adjacent columns.
-    // Truncation is detected by checking whether the original string has more
-    // visible characters than maxWidth (i.e. stripAnsi(str).length > maxWidth).
-    if (stripAnsi(str).length > maxWidth && result.includes("\x1b[")) {
-      result += "\x1b[0m";
-    }
-    return result;
-  }
-
   // ── Render the annotated table ────────────────────────────────────────────
   function renderScreen() {
     process.stdout.write("\n");

package/commands/work-on.md

@@ -745,6 +745,8 @@ if iteration == max_iterations AND not PASS:
 
 **After quality gate completes (PASS or fixes applied): proceed immediately to sub-phase 3H below. Quality gate is an intermediate check — "PASS" means the code is clean, NOT that the build is done. Do NOT stop.**
 
+**After PASS: Do NOT re-read GitHub state, issue body, labels, or any file. Do NOT run any gh commands. Do NOT check PR status. Proceed directly to Phase 3H (Format and verify) below.** <!-- Added: forge#93 -->
+
 ### 3H: Format and verify
 
 All tool commands are read from `forge.yaml → verification.commands`. When a key is absent, the step logs `SKIPPED — not configured in verification.commands` and continues rather than silently passing.
@@ -999,10 +1001,24 @@ PR #${PR_NUMBER} created targeting \`{PR_BASE}\`. Invoking /review-pr with --aut
 ```
 
 ### 5C: Invoke /review-pr with --auto-merge
+
+**Context budget check** (run before invoking review-pr): <!-- Added: forge#93 -->
+
+Large-context sessions that accumulated significant build history cause review-pr to hit the token limit mid-review. Check the accumulated context before delegating:
+
+- If the build changed **≥6 files** OR this agent has made **≥20 Skill invocations** since it started: invoke `work-on/review` as a fresh sub-agent (via `Skill(skill="work-on/review", args="...")`) rather than calling review-pr directly. The sub-agent starts with a clean context window.
+- Otherwise (small build, few skill calls): invoke review-pr directly as below.
+
+**Direct invocation** (small builds — <6 changed files AND <20 Skill invocations):
 ```
 Skill(skill="review-pr", args="{PR_NUMBER} --auto-merge --issue {NUMBER} --base {PR_BASE} --gh-flag {GH_FLAG}")
 ```
 
+**Sub-agent invocation** (large builds — ≥6 changed files OR ≥20 Skill invocations):
+```
+Skill(skill="work-on/review", args="{NUMBER} --repo {GH_REPO} --gh-flag {GH_FLAG} --worktree {WORKTREE_PATH} --branch {BRANCH} --base {PR_BASE}")
+```
+
 Review-pr handles: full domain-agent review → post findings as separate issues → merge PR. It does NOT close the issue or clean up the worktree — those run in Phase 6.
 
 ### 5D: Verify merge and close (recovery)
@@ -1020,6 +1036,8 @@ gh issue view {NUMBER} {GH_FLAG} --json state --jq '.state'
 
 **After /review-pr returns and the PR is confirmed merged: immediately proceed to Phase 6 (Close & Cleanup). Do NOT stop here. `REVIEW_RESULT: status: COMPLETE` is an intermediate result — the pipeline is NOT done. Invoke Phase 6 now to close the issue, update labels, post the trajectory log, and clean up the worktree.**
 
+**Do NOT output any text describing this transition. Do NOT write phrases like "returning to work-on", "proceeding to close", "now invoking Phase 6", or any narrative summary of what comes next. Do NOT emit end_turn. Execute Phase 6 code immediately.** <!-- Added: forge#93 -->
+
 ---
 
 ## Phase 6: Close & Cleanup

package/docs/CONFIG.md

@@ -665,6 +665,24 @@ The `registry` module resolves one of three states for any directory:
 
 A missing or corrupt `registry.json` is treated as an empty opt-out set. The registry always fails open — it never throws and never blocks a Claude Code session.
 
+### Downgrade Behaviour
+
+Registry keys are the **real path** of a directory (resolved via `realpathSync`) rather than the raw `resolve()` path. This has been the case since v1.0.x (PR #467, which fixed symlinked-directory key mismatches).
+
+If you downgrade to a build older than PR #467 **and** your project is accessed via a symlinked directory path, the older build looks up registry entries using the pre-symlink `resolve()`-only key form. It will not find entries written by the newer build's real-path keys. The practical effect is benign:
+
+- Opt-outs set on the newer build briefly stop applying for one session.
+- The one-time "Enable ForgeDock here?" nudge may reappear once.
+- No data is lost. No crash. Fail-open behaviour holds throughout.
+
+**Recovery**: after downgrading, re-apply your opt-out with the older build:
+
+```bash
+npx forgedock disable [dir]
+```
+
+This re-writes the entry under the key form the older build expects.
+
 ### Managing Opt-Out State
 
 Use the `forgedock enable` and `forgedock disable` commands to add or remove a directory from the opt-out set:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "forgedock",
-  "version": "1.0.9",
+  "version": "1.0.10",
   "description": "GitHub as a knowledge graph for AI agents. Autonomous dev pipeline for Claude Code.",
   "bin": {
     "forgedock": "bin/forgedock.mjs"