forgecraft-mcp 1.3.2 → 1.6.1

package/templates/universal/hooks.yaml

@@ -90,6 +90,10 @@ hooks:
       echo "$STAGED" | grep '\.py$' | xargs -r isort --quiet 2>/dev/null
       # TypeScript/JavaScript
       echo "$STAGED" | grep '\.\(ts\|tsx\|js\|jsx\)$' | xargs -r npx prettier --write 2>/dev/null
+      # Rust
+      if echo "$STAGED" | grep -q '\.rs$' && [ -f "Cargo.toml" ]; then
+        cargo fmt 2>/dev/null
+      fi
       # Re-stage formatted files
       echo "$STAGED" | xargs -r git add
 
@@ -99,6 +103,20 @@ hooks:
     filename: pre-commit-secrets.sh
     script: |
       #!/bin/bash
+      _fc_write_violation() {
+        local hook_name="$1" severity="${2:-error}" message="$3"
+        local repo_root
+        repo_root="$(git rev-parse --show-toplevel 2>/dev/null)" || return 0
+        local dir="$repo_root/.forgecraft"
+        mkdir -p "$dir" 2>/dev/null || return 0
+        local ts
+        ts="$(date -u +"%Y-%m-%dT%H:%M:%SZ" 2>/dev/null || printf "unknown")"
+        local esc_msg
+        esc_msg="$(printf '%s' "$message" | sed 's/\\/\\\\/g; s/"/\\"/g')"
+        printf '{"hook":"%s","severity":"%s","message":"%s","timestamp":"%s"}\n' \
+          "$hook_name" "$severity" "$esc_msg" "$ts" \
+          >> "$dir/gate-violations.jsonl" 2>/dev/null || true
+      }
       PATTERNS=(
         'AKIA[0-9A-Z]{16}'
         'password\s*=\s*["\x27][^"\x27]+'
@@ -111,6 +129,7 @@ hooks:
         for pattern in "${PATTERNS[@]}"; do
           if grep -qE "$pattern" "$file" 2>/dev/null; then
             echo "❌ Potential secret found in $file matching pattern"
+            _fc_write_violation "pre-commit-secrets" "error" "Potential secrets detected in staged files — review output above"
             exit 1
           fi
         done
@@ -122,6 +141,20 @@ hooks:
     filename: pre-commit-compile.sh
     script: |
       #!/bin/bash
+      _fc_write_violation() {
+        local hook_name="$1" severity="${2:-error}" message="$3"
+        local repo_root
+        repo_root="$(git rev-parse --show-toplevel 2>/dev/null)" || return 0
+        local dir="$repo_root/.forgecraft"
+        mkdir -p "$dir" 2>/dev/null || return 0
+        local ts
+        ts="$(date -u +"%Y-%m-%dT%H:%M:%SZ" 2>/dev/null || printf "unknown")"
+        local esc_msg
+        esc_msg="$(printf '%s' "$message" | sed 's/\\/\\\\/g; s/"/\\"/g')"
+        printf '{"hook":"%s","severity":"%s","message":"%s","timestamp":"%s"}\n' \
+          "$hook_name" "$severity" "$esc_msg" "$ts" \
+          >> "$dir/gate-violations.jsonl" 2>/dev/null || true
+      }
       echo "🔨 Running build check..."
       if [ -f "pyproject.toml" ] || [ -f "setup.py" ] || [ -f "requirements.txt" ]; then
         STAGED_PY=$(git diff --cached --name-only --diff-filter=ACM | grep '\.py$')
@@ -130,6 +163,7 @@ hooks:
             python -m py_compile "$file" 2>&1
             if [ $? -ne 0 ]; then
               echo "❌ Syntax error in $file"
+              _fc_write_violation "pre-commit-compile" "error" "TypeScript compilation failed — run tsc --noEmit to see errors"
               exit 1
             fi
           done
@@ -140,12 +174,62 @@ hooks:
         npx tsc --noEmit 2>&1
         if [ $? -ne 0 ]; then
           echo "❌ TypeScript compilation failed."
+          _fc_write_violation "pre-commit-compile" "error" "TypeScript compilation failed — run tsc --noEmit to see errors"
           exit 1
         fi
         echo "  ✅ TypeScript compilation OK"
       fi
+      if [ -f "Cargo.toml" ]; then
+        STAGED_RS=$(git diff --cached --name-only --diff-filter=ACM | grep '\.rs$')
+        if [ -n "$STAGED_RS" ]; then
+          cargo check --quiet 2>&1
+          if [ $? -ne 0 ]; then
+            echo "❌ Rust cargo check failed."
+            _fc_write_violation "pre-commit-compile" "error" "Rust cargo check failed — run cargo check to see errors"
+            exit 1
+          fi
+          echo "  ✅ Rust cargo check OK"
+        fi
+      fi
       echo "🔨 Build check passed"
 
+  - name: cargo-clippy
+    trigger: pre-commit
+    description: "Run cargo clippy on Rust projects — catches bugs, style issues, and common mistakes beyond cargo check"
+    filename: pre-commit-clippy.sh
+    script: |
+      #!/bin/bash
+      _fc_write_violation() {
+        local hook_name="$1" severity="${2:-error}" message="$3"
+        local repo_root
+        repo_root="$(git rev-parse --show-toplevel 2>/dev/null)" || return 0
+        local dir="$repo_root/.forgecraft"
+        mkdir -p "$dir" 2>/dev/null || return 0
+        local ts
+        ts="$(date -u +"%Y-%m-%dT%H:%M:%SZ" 2>/dev/null || printf "unknown")"
+        local esc_msg
+        esc_msg="$(printf '%s' "$message" | sed 's/\\/\\\\/g; s/"/\\"/g')"
+        printf '{"hook":"%s","severity":"%s","message":"%s","timestamp":"%s"}\n' \
+          "$hook_name" "$severity" "$esc_msg" "$ts" \
+          >> "$dir/gate-violations.jsonl" 2>/dev/null || true
+      }
+      if [ ! -f "Cargo.toml" ]; then
+        exit 0
+      fi
+      STAGED_RS=$(git diff --cached --name-only --diff-filter=ACM | grep '\.rs$')
+      if [ -z "$STAGED_RS" ]; then
+        exit 0
+      fi
+      echo "🦀 Running cargo clippy..."
+      cargo clippy --all-targets --all-features 2>&1
+      if [ $? -ne 0 ]; then
+        echo "❌ cargo clippy failed — fix lint errors before committing."
+        echo "   Run: cargo clippy --all-targets --all-features"
+        _fc_write_violation "pre-commit-clippy" "error" "Cargo clippy violations found — run cargo clippy to see details"
+        exit 1
+      fi
+      echo "  ✅ cargo clippy passed"
+
   - name: tdd-phase-gate
     trigger: pre-commit
     description: "RED gate: test-only commits must have failing tests; warn on implementation without tests"
@@ -180,6 +264,8 @@ hooks:
           elif grep -q '"jest"' package.json 2>/dev/null; then
             RUN_CMD="npx jest --passWithNoTests"
           fi
+        elif [ -f "Cargo.toml" ]; then
+          RUN_CMD="cargo test"
         elif [ -f "pytest.ini" ] || [ -f "pyproject.toml" ] || [ -f "setup.py" ]; then
           RUN_CMD="python -m pytest"
         fi
@@ -270,6 +356,14 @@ hooks:
           echo "  ✅ Python tests passed"
         fi
       fi
+      if [ -f "Cargo.toml" ]; then
+        cargo test --quiet 2>&1
+        if [ $? -ne 0 ]; then
+          echo "❌ Rust tests failed."
+          exit 1
+        fi
+        echo "  ✅ Rust tests passed"
+      fi
       echo "🧪 All tests passed"
 
   - name: coverage-gate
@@ -278,6 +372,20 @@ hooks:
     filename: pre-commit-coverage.sh
     script: |
       #!/bin/bash
+      _fc_write_violation() {
+        local hook_name="$1" severity="${2:-error}" message="$3"
+        local repo_root
+        repo_root="$(git rev-parse --show-toplevel 2>/dev/null)" || return 0
+        local dir="$repo_root/.forgecraft"
+        mkdir -p "$dir" 2>/dev/null || return 0
+        local ts
+        ts="$(date -u +"%Y-%m-%dT%H:%M:%SZ" 2>/dev/null || printf "unknown")"
+        local esc_msg
+        esc_msg="$(printf '%s' "$message" | sed 's/\\/\\\\/g; s/"/\\"/g')"
+        printf '{"hook":"%s","severity":"%s","message":"%s","timestamp":"%s"}\n' \
+          "$hook_name" "$severity" "$esc_msg" "$ts" \
+          >> "$dir/gate-violations.jsonl" 2>/dev/null || true
+      }
       # ──────────────────────────────────────────────────────────────────────
       # Pre-Commit Hook: Coverage Gate
       #
@@ -317,8 +425,30 @@ hooks:
       # ── Run coverage ───────────────────────────────────────────────────────
       echo "📊 Running coverage gate (src/ files staged)..."
 
-      if [ ! -f "package.json" ]; then
-        echo "  ⚠️  No package.json found — skipping coverage check."
+      if [ ! -f "package.json" ] && [ ! -f "pyproject.toml" ] && [ ! -f "setup.py" ]; then
+        if [ -f "Cargo.toml" ]; then
+          # Rust: run tests; use cargo-tarpaulin for coverage if available
+          if command -v cargo-tarpaulin &> /dev/null; then
+            cargo tarpaulin --out Stdout --fail-under {{coverage_minimum | default: 80}} 2>&1
+            if [ $? -ne 0 ]; then
+              echo "❌ Coverage gate failed — below {{coverage_minimum | default: 80}}%."
+              echo "   Run: cargo tarpaulin --out Html"
+              _fc_write_violation "pre-commit-coverage" "error" "Coverage gate failed — run npm test --coverage to see report"
+              exit 1
+            fi
+            echo "  ✅ Rust coverage gate passed"
+          else
+            cargo test --quiet 2>&1
+            if [ $? -ne 0 ]; then
+              echo "❌ Rust tests failed."
+              _fc_write_violation "pre-commit-coverage" "error" "Coverage gate failed — run npm test --coverage to see report"
+              exit 1
+            fi
+            echo "  ✅ Rust tests passed (install cargo-tarpaulin for coverage enforcement)"
+          fi
+        else
+          echo "  ⚠️  No supported build system found — skipping coverage check."
+        fi
         exit 0
       fi
 
@@ -332,6 +462,7 @@ hooks:
           echo "❌ Coverage gate failed — thresholds not met."
           echo "   Run 'npx vitest run --coverage' locally to see the full report."
           echo "   Add tests until coverage meets the configured minimums."
+          _fc_write_violation "pre-commit-coverage" "error" "Coverage gate failed — run npm test --coverage to see report"
           exit 1
         fi
         echo "  ✅ Coverage gate passed"
@@ -345,17 +476,19 @@ hooks:
           --silent 2>&1
         if [ $? -ne 0 ]; then
           echo "❌ Coverage gate failed — thresholds not met."
+          _fc_write_violation "pre-commit-coverage" "error" "Coverage gate failed — run npm test --coverage to see report"
           exit 1
         fi
         echo "  ✅ Coverage gate passed"
         exit 0
       fi
 
-      if [ -f "pyproject.toml" ] || [ -f "setup.py" ]; then
+      if [ -f "pyproject.toml" ]|| [ -f "setup.py" ]; then
         if command -v pytest &> /dev/null; then
           pytest --tb=no --quiet --cov=src --cov-fail-under={{coverage_minimum | default: 80}} 2>&1
           if [ $? -ne 0 ]; then
             echo "❌ Coverage gate failed — below {{coverage_minimum | default: 80}}%."
+            _fc_write_violation "pre-commit-coverage" "error" "Coverage gate failed — run npm test --coverage to see report"
             exit 1
           fi
           echo "  ✅ Coverage gate passed"
@@ -376,8 +509,22 @@ hooks:
       - .env vs .env.example drift (warns on missing variables)
     script: |
       #!/bin/bash
+      _fc_write_violation() {
+        local hook_name="$1" severity="${2:-error}" message="$3"
+        local repo_root
+        repo_root="$(git rev-parse --show-toplevel 2>/dev/null)" || return 0
+        local dir="$repo_root/.forgecraft"
+        mkdir -p "$dir" 2>/dev/null || return 0
+        local ts
+        ts="$(date -u +"%Y-%m-%dT%H:%M:%SZ" 2>/dev/null || printf "unknown")"
+        local esc_msg
+        esc_msg="$(printf '%s' "$message" | sed 's/\\/\\\\/g; s/"/\\"/g')"
+        printf '{"hook":"%s","severity":"%s","message":"%s","timestamp":"%s"}\n' \
+          "$hook_name" "$severity" "$esc_msg" "$ts" \
+          >> "$dir/gate-violations.jsonl" 2>/dev/null || true
+      }
       STAGED=$(git diff --cached --name-only --diff-filter=ACM)
-      SOURCE_FILES=$(echo "$STAGED" | grep -E '\.(py|ts|tsx|js|jsx)$' | grep -vE '(test_|\.test\.|\.spec\.|__tests__|tests/|fixtures/|mock|conftest)')
+      SOURCE_FILES=$(echo "$STAGED" | grep -E '\.(py|ts|tsx|js|jsx|rs)$' | grep -vE '(test_|\.test\.|\.spec\.|__tests__|tests/|fixtures/|mock|conftest|_test\.rs)')
       if [ -z "$SOURCE_FILES" ]; then exit 0; fi
       VIOLATIONS=0
       WARNINGS=0
@@ -443,10 +590,39 @@ hooks:
           echo "  ⚠️  $file — $LINE_COUNT lines (max {{max_file_length | default: 300}})"
           WARNINGS=$((WARNINGS + 1))
         fi
-      done
+        # Rust-specific anti-patterns
+        if echo "$file" | grep -q '\.rs$'; then
+          if ! is_excepted "rust/unwrap" "$file"; then
+            if grep -nE '\.unwrap\(\)' "$file" > /tmp/violations 2>/dev/null; then
+              if [ -s /tmp/violations ]; then
+                echo "  ⚠️  $file — .unwrap() in production code — use ? or explicit error handling"
+                WARNINGS=$((WARNINGS + 1))
+              fi
+            fi
+          fi
+          if grep -nE '\btodo!\(|\bunimplemented!\(' "$file" > /tmp/violations 2>/dev/null; then
+            if [ -s /tmp/violations ]; then
+              echo "  ❌ $file — todo!/unimplemented! in production code"
+              VIOLATIONS=$((VIOLATIONS + 1))
+            fi
+          fi
+          if grep -nE '^[[:space:]]*#\[allow\(dead_code\)\]' "$file" > /tmp/violations 2>/dev/null; then
+            if [ -s /tmp/violations ]; then
+              echo "  ⚠️  $file — #[allow(dead_code)] suppression — delete orphaned code instead"
+              WARNINGS=$((WARNINGS + 1))
+            fi
+          fi
+          if grep -nE '^[[:space:]]*unsafe[[:space:]]*\{' "$file" > /tmp/violations 2>/dev/null; then
+            if [ -s /tmp/violations ]; then
+              echo "  ⚠️  $file — unsafe block present — requires explicit justification comment"
+              WARNINGS=$((WARNINGS + 1))
+            fi
+          fi
+        fi
       rm -f /tmp/violations
       if [ $VIOLATIONS -gt 0 ]; then
         echo "❌ $VIOLATIONS violation(s) found — commit blocked."
+        _fc_write_violation "pre-commit-anti-patterns" "error" "Anti-patterns detected in staged files — see output above"
         exit 1
       fi
       if [ $WARNINGS -gt 0 ]; then
@@ -462,26 +638,42 @@ hooks:
       #!/bin/bash
       MAX_LENGTH={{max_function_length | default: 50}}
       STAGED=$(git diff --cached --name-only --diff-filter=ACM)
-      SOURCE_FILES=$(echo "$STAGED" | grep -E '\.(ts|tsx|js|jsx)$' | grep -vE '(\.test\.|\.spec\.|__tests__|tests/)')
+      SOURCE_FILES=$(echo "$STAGED" | grep -E '\.(ts|tsx|js|jsx|rs)$' | grep -vE '(\.test\.|\.spec\.|__tests__|tests/|_test\.rs)')
       if [ -z "$SOURCE_FILES" ]; then exit 0; fi
       WARNINGS=0
       for file in $SOURCE_FILES; do
-        # Heuristic: find function/method declarations and count lines to next declaration or closing brace
-        awk -v max="$MAX_LENGTH" -v fname="$file" '
-          /^[[:space:]]*(export )?(async )?(function |const [a-zA-Z]+ = (async )?\(|[a-zA-Z]+\(.*\) \{|[a-zA-Z]+\(.*\): )/ {
-            if (start > 0 && NR - start > max) {
-              printf "  ⚠️  %s:%d — function starting here is %d lines (max %d)\n", fname, start, NR - start, max
-              warnings++
+        # Heuristic: find function/method declarations and count lines to next declaration
+        if echo "$file" | grep -q '\.rs$'; then
+          awk -v max="$MAX_LENGTH" -v fname="$file" '
+            /^[[:space:]]*(pub )?(async )?fn [a-zA-Z_]/ {
+              if (start > 0 && NR - start > max) {
+                printf "  ⚠️  %s:%d — fn starting here is %d lines (max %d)\n", fname, start, NR - start, max
+              }
+              start = NR
             }
-            start = NR
-          }
-          END {
-            if (start > 0 && NR - start > max) {
-              printf "  ⚠️  %s:%d — function starting here is %d lines (max %d)\n", fname, start, NR - start, max
-              warnings++
+            END {
+              if (start > 0 && NR - start > max) {
+                printf "  ⚠️  %s:%d — fn starting here is %d lines (max %d)\n", fname, start, NR - start, max
+              }
             }
-          }
-        ' "$file"
+          ' "$file"
+        else
+          awk -v max="$MAX_LENGTH" -v fname="$file" '
+            /^[[:space:]]*(export )?(async )?(function |const [a-zA-Z]+ = (async )?\(|[a-zA-Z]+\(.*\) \{|[a-zA-Z]+\(.*\): )/ {
+              if (start > 0 && NR - start > max) {
+                printf "  ⚠️  %s:%d — function starting here is %d lines (max %d)\n", fname, start, NR - start, max
+                warnings++
+              }
+              start = NR
+            }
+            END {
+              if (start > 0 && NR - start > max) {
+                printf "  ⚠️  %s:%d — function starting here is %d lines (max %d)\n", fname, start, NR - start, max
+                warnings++
+              }
+            }
+          ' "$file"
+        fi
         WARNINGS=$((WARNINGS + $?))
       done
       # Warning only — does not block commit since bash heuristics aren't perfect

package/templates/web-react/harness/uc-template.spec.ts

@@ -0,0 +1,35 @@
+import { test, expect } from "@playwright/test";
+
+/**
+ * L2 Harness: {{uc_id}} — {{uc_title}}
+ *
+ * Actor: {{actor}}
+ * Precondition: {{precondition}}
+ * Postcondition: {{postcondition}}
+ *
+ * Behavioral harness probe — verifies use case postconditions in the running UI.
+ * Failure = specification violation. Regenerate from spec; don't patch the code.
+ */
+test.describe("{{uc_id}}: {{uc_title}}", () => {
+  test.beforeEach(async ({ page }) => {
+    // Set up precondition: {{precondition}}
+    await page.goto("http://localhost:3000");
+  });
+
+  test("postcondition: {{postcondition}}", async ({ page }) => {
+    // TODO: implement UC main flow
+    // {{step_1}}
+    // {{step_2}}
+
+    // Assert postcondition
+    // await expect(page.locator('...')).toBeVisible();
+    throw new Error(
+      "Not implemented: add UI interactions following {{uc_id}} main flow",
+    );
+  });
+
+  test("error case: [fill in error case]", async ({ page }) => {
+    // TODO: test error paths from use case
+    throw new Error("Not implemented: add error path for {{uc_id}}");
+  });
+});