forge-workflow 0.1.0-beta.6 → 0.1.0-beta.8

package/lib/commands/validate.js

@@ -12,6 +12,7 @@ const { execFileSync } = require('node:child_process');
 const fs = require('node:fs');
 const path = require('node:path');
 const { secureExecFileSync } = require('../shell-utils');
+const validationReceipt = require('../validation-receipt');
 
 // Constants
 const CHECK_TYPES = {
@@ -94,7 +95,6 @@ function getExecOptions(rootDir = process.cwd(), fullSuite = false) {
 }
 
 const ERROR_PATTERNS = {
-	COMMAND_NOT_FOUND: ['ENOENT', 'not found'],
 	NO_LOCK_FILE: ['requires an existing', 'package-lock'],
 	GIT_LISTING_UNAVAILABLE: [
 		'not a git repository',
@@ -112,9 +112,7 @@ const ERROR_PATTERNS = {
  * @private
  */
 function isCommandNotFound(error) {
-	return ERROR_PATTERNS.COMMAND_NOT_FOUND.some(pattern =>
-		error.message.includes(pattern),
-	);
+	return error?.code === 'ENOENT';
 }
 
 function isGitListingUnavailableError(error) {
@@ -299,6 +297,7 @@ async function runTypeCheck() {
 		return {
 			success: true,
 			skipped: true,
+			notConfigured: true,
 			duration: Date.now() - startTime,
 			message: 'TypeScript not configured (no tsconfig.json)',
 		};
@@ -358,7 +357,7 @@ async function runTypeCheck() {
  * const result = await runLint();
  * console.log(`Warnings: ${result.warnings}, Errors: ${result.errors}`);
  */
-async function runLint(exec = execFileSync) {
+async function runLint(exec = secureExecFileSync) {
 	const startTime = Date.now();
 
 	try {
@@ -575,6 +574,21 @@ async function runSecurityScan() { // NOSONAR S3776
  */
 function parseTestCounts(output) {
 	const text = String(output || '');
+	const effectiveBudgetMatch = /Full suite resource budget: requested=(default|\d+) effective=(\d+)/.exec(text);
+	const rejectedBudgetMatch = /Full suite resource budget: requested=(\d+) minimum=(\d+) outcome=rejected/.exec(text);
+	let resourceBudget;
+	if (effectiveBudgetMatch) {
+		resourceBudget = {
+			requested: effectiveBudgetMatch[1] === 'default' ? null : Number(effectiveBudgetMatch[1]),
+			effective: Number(effectiveBudgetMatch[2]),
+		};
+	} else if (rejectedBudgetMatch) {
+		resourceBudget = {
+			requested: Number(rejectedBudgetMatch[1]),
+			minimum: Number(rejectedBudgetMatch[2]),
+			outcome: 'rejected',
+		};
+	}
 	const aggregateMatches = [...text.matchAll(
 		/Full suite aggregate: status=(PASS|FAIL|INCOMPLETE) tests=(\d+) assertions=\d+ passed=(\d+) failed=(\d+) errors=(\d+) skipped=(\d+)/g,
 	)]; // NOSONAR S5852 - fixed tokens and bounded numeric fields
@@ -583,6 +597,7 @@ function parseTestCounts(output) {
 		const total = parseNumber(aggregate, 2);
 		return {
 			status: aggregate[1],
+			resourceBudget,
 			passed: parseNumber(aggregate, 3),
 			failed: parseNumber(aggregate, 4),
 			errors: parseNumber(aggregate, 5),
@@ -596,7 +611,24 @@ function parseTestCounts(output) {
 	const skipped = parseNumber(/(\d+) skip/.exec(text));  // NOSONAR S5852 - bounded \d+ pattern
 	const ranMatch = /Ran (\d+) tests/.exec(text);  // NOSONAR S5852 - bounded \d+ pattern
 	const total = ranMatch ? parseNumber(ranMatch, 1) : passed + failed + skipped;
-	return { passed, failed, skipped, total, testsFound: total > 0 };
+	return { passed, failed, skipped, total, testsFound: total > 0, resourceBudget };
+}
+
+function parseResourceBudget(args = []) {
+	let budget = null;
+	for (let index = 0; index < args.length; index += 1) {
+		if (args[index] !== '--shards') continue;
+		const value = args[index + 1];
+		if (!/^[1-9]\d*$/.test(String(value ?? ''))) {
+			throw new TypeError('--shards must be a positive integer resource budget');
+		}
+		budget = Number(value);
+		if (!Number.isSafeInteger(budget)) {
+			throw new TypeError('--shards must be a positive integer resource budget');
+		}
+		index += 1;
+	}
+	return budget;
 }
 
 function isForgeCheckout(rootDir) {
@@ -612,17 +644,142 @@ function isForgeCheckout(rootDir) {
 	}
 }
 
-async function runAllTests(exec = execFileSync, rootDir = process.cwd()) {
+function isValidationRootAvailable(rootDir) {
+	try {
+		return fs.statSync(rootDir).isDirectory();
+	} catch {
+		return false;
+	}
+}
+
+function unavailableValidationRootResult(startTime) {
+	return {
+		success: false,
+		testsFound: false,
+		fullSuite: false,
+		duration: Date.now() - startTime,
+		passed: 0,
+		failed: 0,
+		total: 0,
+		message: 'Test execution failed: validation root directory is unavailable',
+	};
+}
+
+function testExecutionErrorResult(error, startTime, rootDir, useFullSuite, timeout) {
+	const output = error.stdout || error.message;
+	const counts = parseTestCounts(output);
+	const budgetEvidence = counts.resourceBudget ? { resourceBudget: counts.resourceBudget } : {};
+	if (error.code === 'ETIMEDOUT' || (error.killed && error.signal === 'SIGTERM')) {
+		return {
+			success: false,
+			fullSuite: useFullSuite,
+			...budgetEvidence,
+			duration: Date.now() - startTime,
+			passed: 0,
+			failed: 0,
+			total: 0,
+			message: validationTimeoutMessage('Test execution', timeout),
+		};
+	}
+
+	if (isCommandNotFound(error)) {
+		if (!isValidationRootAvailable(rootDir)) {
+			return { ...unavailableValidationRootResult(startTime), ...budgetEvidence };
+		}
+		return {
+			success: true,
+			skipped: true,
+			testsFound: false,
+			fullSuite: useFullSuite,
+			...budgetEvidence,
+			duration: Date.now() - startTime,
+			passed: 0,
+			failed: 0,
+			total: 0,
+			message: 'Tests skipped: test runner not found. Install Node.js and Bun to run tests.',
+		};
+	}
+
+	if (counts.resourceBudget?.outcome === 'rejected') {
+		return {
+			success: false,
+			testsFound: false,
+			fullSuite: useFullSuite,
+			resourceBudget: counts.resourceBudget,
+			duration: Date.now() - startTime,
+			passed: 0,
+			failed: 0,
+			total: 0,
+			message: `Full suite resource budget rejected: requested=${counts.resourceBudget.requested} minimum=${counts.resourceBudget.minimum}`,
+			output,
+		};
+	}
+	const passed = counts.passed;
+	const failed = counts.failed > 0 ? counts.failed : Math.max(1, counts.errors || 0);
+	const total = counts.total > 0 ? counts.total : passed + failed + counts.skipped;
+
+	return {
+		success: false,
+		testsFound: counts.testsFound,
+		fullSuite: useFullSuite,
+		resourceBudget: counts.resourceBudget,
+		duration: Date.now() - startTime,
+		passed,
+		failed,
+		total,
+		message: `${failed}/${total} tests failed`,
+		output,
+	};
+}
+
+async function runAllTests(exec = execFileSync, rootDir = process.cwd(), resourceBudget = null) {
 	const startTime = Date.now();
+	if (!isValidationRootAvailable(rootDir)) return unavailableValidationRootResult(startTime);
 	const useFullSuite = isForgeCheckout(rootDir);
+	if (resourceBudget !== null && !useFullSuite) {
+		return {
+			success: false,
+			testsFound: false,
+			fullSuite: false,
+			duration: Date.now() - startTime,
+			passed: 0,
+			failed: 0,
+			total: 0,
+			message: '--shards requires the canonical Forge full-suite runner',
+		};
+	}
 	const command = useFullSuite ? 'node' : 'bun';
 	const args = useFullSuite ? ['scripts/test-full-suite.js'] : ['test', '--timeout', '30000'];
+	if (useFullSuite && resourceBudget !== null) args.push('--shards', String(resourceBudget));
 	const execOptions = getExecOptions(rootDir, useFullSuite);
 
 	try {
 		const result = exec(command, args, execOptions);  // NOSONAR S4036 - fixed CLI commands, no user input, developer tool context
 
-		const { status, passed, failed, errors = 0, skipped, total, testsFound } = parseTestCounts(result);
+		const {
+			status,
+			passed,
+			failed,
+			errors = 0,
+			skipped,
+			total,
+			testsFound,
+			resourceBudget: budgetEvidence,
+		} = parseTestCounts(result);
+		if (useFullSuite && status !== 'PASS') {
+			return {
+				success: false,
+				testsFound,
+				fullSuite: true,
+				resourceBudget: budgetEvidence,
+				duration: Date.now() - startTime,
+				passed,
+				failed,
+				skipped,
+				total,
+				message: 'Full suite did not report a passing terminal aggregate',
+			};
+		}
 		const success = failed === 0 && errors === 0 && (status === undefined || status === 'PASS');
 
 		// B2 (N1): a bun run that executes 0 tests must NEVER report PASS — that
@@ -632,6 +789,7 @@ async function runAllTests(exec = execFileSync, rootDir = process.cwd()) {
 				success: true,
 				skipped: true,
 				testsFound: false,
+				fullSuite: useFullSuite,
 				duration: Date.now() - startTime,
 				passed,
 				failed,
@@ -643,61 +801,17 @@ async function runAllTests(exec = execFileSync, rootDir = process.cwd()) {
 		return {
 			success,
 			testsFound: true,
+			fullSuite: useFullSuite,
+			resourceBudget: budgetEvidence,
 			duration: Date.now() - startTime,
 			passed,
 			failed,
 			skipped,
 			total,
-			message: success
-				? `All ${total} tests passed`
-				: `${failed + errors}/${total} tests failed`,
+			message: success ? `All ${total} tests passed` : `${failed + errors}/${total} tests failed`,
 		};
 	} catch (error) {
-		// Check for timeout
-		if (error.code === 'ETIMEDOUT' || (error.killed && error.signal === 'SIGTERM')) {
-			return {
-				success: false,
-				duration: Date.now() - startTime,
-				passed: 0,
-				failed: 0,
-				total: 0,
-				message: validationTimeoutMessage('Test execution', execOptions.timeout),
-			};
-		}
-
-		// Test runner absent — say so explicitly (do NOT silently pass).
-		if (isCommandNotFound(error)) {
-			return {
-				success: true,
-				skipped: true,
-				testsFound: false,
-				duration: Date.now() - startTime,
-				passed: 0,
-				failed: 0,
-				total: 0,
-				message: 'Tests skipped: test runner not found. Install Node.js and Bun to run tests.',
-			};
-		}
-
-		// Parse test failures from output
-		const output = error.stdout || error.message;
-		const counts = parseTestCounts(output);
-		const passed = counts.passed;
-		// bun exited non-zero: if the output shows no explicit failure count, treat
-		// it as at least one failure rather than swallowing the non-zero exit.
-		const failed = counts.failed > 0 ? counts.failed : Math.max(1, counts.errors || 0);
-		const total = counts.total > 0 ? counts.total : passed + failed + counts.skipped;
-
-		return {
-			success: false,
-			testsFound: counts.testsFound,
-			duration: Date.now() - startTime,
-			passed,
-			failed,
-			total,
-			message: `${failed}/${total} tests failed`,
-			output,
-		};
+		return testExecutionErrorResult(error, startTime, rootDir, useFullSuite, execOptions.timeout);
 	}
 }
 
@@ -723,13 +837,27 @@ async function runAllTests(exec = execFileSync, rootDir = process.cwd()) {
  * console.log(result.summary);
  */
 async function executeValidate(options = {}) { // NOSONAR S3776
-	const { skip = [], continueOnError = true, rootDir = process.cwd() } = options || {};
+	const {
+		skip = [],
+		continueOnError = true,
+		rootDir = process.cwd(),
+		resourceBudget = null,
+	} = options || {};
+	const startTime = Date.now();
+	if (!isValidationRootAvailable(rootDir)) {
+		const checks = { tests: unavailableValidationRootResult(startTime) };
+		const result = buildResult(checks, [CHECK_TYPES.TESTS], [], startTime);
+		result.validationReceipt = false;
+		return result;
+	}
+	const receiptApi = options?.validationReceipt || validationReceipt;
+	const testRunner = options?.runAllTests || runAllTests;
+	const validationSnapshot = receiptApi.beginValidation(rootDir);
+	const receiptSnapshot = skip.length === 0 ? validationSnapshot : null;
 
 	const checks = {};
 	const failedChecks = [];
 	const errors = [];
-	const startTime = Date.now();
-
 	// 0. Conflict markers
 	if (!skip.includes(CHECK_TYPES.CONFLICT_MARKERS)) {
 		try {
@@ -797,7 +925,7 @@ async function executeValidate(options = {}) { // NOSONAR S3776
 	// 4. Tests
 	if (!skip.includes(CHECK_TYPES.TESTS)) {
 		try {
-			checks.tests = await runAllTests(execFileSync, rootDir);
+			checks.tests = await testRunner(execFileSync, rootDir, resourceBudget);
 			if (!checks.tests.success && checks.tests.skipped !== true) {
 				failedChecks.push(CHECK_TYPES.TESTS);
 				if (!continueOnError) {
@@ -810,7 +938,9 @@ async function executeValidate(options = {}) { // NOSONAR S3776
 		}
 	}
 
-	return buildResult(checks, failedChecks, errors, startTime);
+	const result = buildResult(checks, failedChecks, errors, startTime);
+	result.validationReceipt = receiptApi.completeValidation(rootDir, receiptSnapshot, result);
+	return result;
 }
 
 /**
@@ -885,21 +1015,43 @@ function executeDebugMode({ fixAttempts = 0, claim } = {}) {
 module.exports = {
 	name: 'validate',
 	description: 'Run validation checks across type, lint, security, and tests',
-	handler: async () => {
-		const result = await executeValidate();
-		if (!result.success) {
-			return result;
+	usage: 'forge validate [--shards N]',
+	flags: {
+		'--shards N': 'Set the full-suite resource budget',
+	},
+	handler: async (args = [], _flags = {}, projectRoot = process.cwd(), deps = {}) => {
+		let resourceBudget;
+		try {
+			resourceBudget = parseResourceBudget(args);
+		} catch (error) {
+			return { success: false, error: error.message };
 		}
-
+		const result = await (deps.executeValidate || executeValidate)({
+			rootDir: projectRoot,
+			resourceBudget,
+		});
+		const errorParts = Array.isArray(result.errors) ? result.errors.filter(Boolean) : [];
+		for (const check of Object.values(result.checks || {})) {
+			if (check?.success !== false || check.skipped === true || !check.message) continue;
+			if (!errorParts.some(error => error.endsWith(check.message))) errorParts.push(check.message);
+		}
+		const budget = result.checks?.tests?.resourceBudget;
+		const budgetOutput = Number.isInteger(budget?.effective)
+			? `Full suite resource budget: requested=${budget.requested ?? 'default'} effective=${budget.effective}`
+			: null;
+		const output = [result.success ? result.summary : null, budgetOutput].filter(Boolean).join('\n');
+		const error = result.error || result.message || errorParts.join('; ') || result.summary;
 		return {
 			...result,
-			output: result.summary,
+			...(output ? { output } : {}),
+			...(!result.success && error ? { error } : {}),
 		};
 	},
 	runTypeCheck,
 	runLint,
 	runSecurityScan,
 	runAllTests,
+	parseResourceBudget,
 	parseTestCounts,
 	scanForConflictMarkers,
 	executeValidate,