forge-workflow 0.1.0-beta.3 → 0.1.0-beta.5

package/lib/commands/status.js

@@ -18,7 +18,7 @@ const {
 const {
 	loadState,
 	extractWorkflowStateFromComments,
-	readWorkflowStateFromBeads,
+	readWorkflowStateFromIssue,
 } = require('../workflow/state-manager');
 const { secureExecFileSync } = require('../shell-utils.js');
 
@@ -140,12 +140,12 @@ function analyzeChecks(context) {
 }
 
 /**
- * Analyze Beads issue state
- * @param {object} beadsIssue - Beads issue object
- * @returns {object} Beads analysis
+ * Analyze kernel issue state
+ * @param {object} issueRecord - kernel issue record
+ * @returns {object} issue analysis
  */
-function analyzeBeads(beadsIssue) {
-	if (!beadsIssue) {
+function analyzeIssue(issueRecord) {
+	if (!issueRecord) {
 		return {
 			hasActiveIssue: false,
 			issueStatus: null,
@@ -155,10 +155,10 @@ function analyzeBeads(beadsIssue) {
 
 	return {
 		hasActiveIssue: true,
-		issueStatus: beadsIssue.status,
-		issueType: beadsIssue.type,
-		isInProgress: beadsIssue.status === 'in_progress',
-		isClosed: beadsIssue.status === 'closed',
+		issueStatus: issueRecord.status,
+		issueType: issueRecord.type,
+		isInProgress: issueRecord.status === 'in_progress',
+		isClosed: issueRecord.status === 'closed',
 	};
 }
 
@@ -178,7 +178,7 @@ function calculateConfidence(factors, stage) {
 		files: 30,
 		pr: 25,
 		checks: 15,
-		beads: 10,
+		issue: 10,
 	};
 
 	// Branch state
@@ -235,16 +235,16 @@ function calculateConfidence(factors, stage) {
 		score += weights.checks / 2; // Partial match
 	}
 
-	// Beads issue
-	maxScore += weights.beads;
-	if (factors.beads.isInProgress && stage >= 2 && stage <= 7) {
-		score += weights.beads; // Active work
-	} else if (factors.beads.isClosed && stage >= 8) {
-		score += weights.beads; // Closed for late stages
-	} else if (!factors.beads.hasActiveIssue && stage === 1) {
-		score += weights.beads; // No issue for fresh start
+	// Issue state
+	maxScore += weights.issue;
+	if (factors.issue.isInProgress && stage >= 2 && stage <= 7) {
+		score += weights.issue; // Active work
+	} else if (factors.issue.isClosed && stage >= 8) {
+		score += weights.issue; // Closed for late stages
+	} else if (!factors.issue.hasActiveIssue && stage === 1) {
+		score += weights.issue; // No issue for fresh start
 	} else {
-		score += weights.beads / 2; // Partial match
+		score += weights.issue / 2; // Partial match
 	}
 
 	const percentage = Math.round((score / maxScore) * 100);
@@ -275,21 +275,21 @@ function detectStage(context) {
 	const fileFactors = analyzeFiles(context);
 	const prFactors = analyzePR(context.pr);
 	const checkFactors = analyzeChecks(context);
-	const beadsFactors = analyzeBeads(context.beadsIssue);
+	const issueFactors = analyzeIssue(context.issueRecord);
 
 	const factors = {
 		branch: branchFactors,
 		files: fileFactors,
 		pr: prFactors,
 		checks: checkFactors,
-		beads: beadsFactors,
+		issue: issueFactors,
 	};
 
 	// Stage detection logic
 	let stage;
 
 	// Stage 9: PR merged, verify docs
-	if (prFactors.prMerged && beadsFactors.isClosed) {
+	if (prFactors.prMerged && issueFactors.isClosed) {
 		stage = 9;
 	}
 	// Stage 8: PR approved, ready to merge
@@ -317,7 +317,7 @@ function detectStage(context) {
 		stage = 3;
 	}
 	// Stage 2: Research in progress
-	else if (beadsFactors.issueType === 'research' && beadsFactors.isInProgress) {
+	else if (issueFactors.issueType === 'research' && issueFactors.isInProgress) {
 		stage = 2;
 	}
 	// Stage 1: Fresh project (default)
@@ -612,7 +612,7 @@ function resolveWorkflowState(inputs) {
 			issueId: inputs.issueId,
 			issue: inputs.issue,
 			comments: inputs.bdComments,
-			preferBeads: inputs.preferBeads,
+			preferIssueLookup: inputs.preferIssueLookup,
 		});
 
 		return { workflowState: state, fallbackReason: null };
@@ -649,7 +649,7 @@ function buildAuthoritativeStatus(workflowState) {
 			branch: {},
 			pr: {},
 			checks: { allChecksPass: workflowState.completedStages.includes('validate') },
-			beads: { hasActiveIssue: true },
+			issue: { hasActiveIssue: true },
 		},
 	};
 }
@@ -751,15 +751,36 @@ function formatStatus(result) {
 module.exports = {
 	name: 'status',
 	description: 'One-glance orientation: where you are, what to run next, and your work',
-	usage: 'forge status [--full] [--json]',
+	usage: 'forge status [-v|--verbose] [--full] [--json]',
 	flags: {
+		'-v, --verbose': 'Print the full session-entry briefing (replaces the deprecated `forge prime`)',
 		'--full': 'Also show blocked, stale, and recently completed issues',
 		'--json': 'Emit the machine-readable status envelope',
 	},
 	handler: async (args, flags, projectRoot) => {
+		// git-status-v semantics: bare status is the short pulse, -v is the long form.
+		// `--verbose` also arrives as flags.verbose from the global CLI flag parser.
+		const statusArgs = Array.isArray(args) ? args : [];
+		if (flags?.verbose === true || statusArgs.includes('-v') || statusArgs.includes('--verbose')) {
+			// Required lazily so the short pulse never loads the briefing's module graph.
+			const { renderBriefing } = require('./prime');
+			// The briefing reads --json from args (same as prime), so fold in the flag
+			// forms the short pulse accepts or `-v` would silently drop them.
+			const wantsJson = flags?.json === true || flags?.['--json'] === true;
+			const briefingArgs = wantsJson && !statusArgs.includes('--json')
+				? [...statusArgs, '--json']
+				: statusArgs;
+			return renderBriefing(briefingArgs, projectRoot || process.cwd());
+		}
+
+		// Injectable snapshot read, same convention as setup.js's `options.commandRunner`
+		// (lib/commands/setup.js:223): a real default with a test-supplied override. Tests
+		// need a snapshot with controlled ids and orderings, which a seeded kernel cannot
+		// give them — the kernel stamps its own updated_at.
+		const readSnapshot = flags?.readStatusSnapshot || readStatusSnapshot;
 		const inputs = parseStatusInputs(args, flags);
 		const isZeroArgStatus = !inputs.issueId && !inputs.workflowState && !inputs.bdComments;
-		inputs.preferBeads = !isZeroArgStatus && Boolean(inputs.issueId || inputs.bdComments);
+		inputs.preferIssueLookup = !isZeroArgStatus && Boolean(inputs.issueId || inputs.bdComments);
 		if (!inputs.projectRoot && projectRoot) {
 			inputs.projectRoot = projectRoot;
 		}
@@ -769,11 +790,11 @@ module.exports = {
 
 		if (isZeroArgStatus) {
 			context = detectRepoContext(effectiveProjectRoot);
-			// Read from the active issue backend (Kernel by default; Beads only when
-			// explicitly selected). Previously hard-wired to the retired Beads
+			// Read from the Kernel, the only issue backend. Previously hard-wired to
+			// the retired Beads
 			// issues.jsonl, which is empty on a kernel-default repo — so the flagship
 			// view showed "Ready: none" despite a populated kernel (bug 40f35797).
-			snapshot = await readStatusSnapshot(effectiveProjectRoot, {
+			snapshot = await readSnapshot(effectiveProjectRoot, {
 				now: inputs.now,
 				staleAfterDays: inputs.staleAfterDays,
 				issueBackend: inputs.issueBackend,
@@ -834,7 +855,7 @@ module.exports = {
 	extractWorkflowStateFromComments,
 	resolveWorkflowState,
 	parseStatusInputs,
-	readWorkflowStateFromBeads,
+	readWorkflowStateFromIssue,
 	detectStage,
 	detectRepoContext,
 	discoverCurrentIssue,
@@ -842,7 +863,7 @@ module.exports = {
 	analyzeFiles,
 	analyzePR,
 	analyzeChecks,
-	analyzeBeads,
+	analyzeIssue,
 	calculateConfidence,
 	formatStatus,
 	extractDesignSlugs,

package/lib/commands/test.js

@@ -5,7 +5,6 @@
  *
  * Wraps test execution with smart defaults:
  * - Auto-detects package manager from lockfiles
- * - Checks Beads (Dolt) connectivity, sets BEADS_SKIP_TESTS if unavailable
  * - Supports --affected flag to run only tests for changed files
  *
  * Security: Uses execFileSync for subprocess calls (OWASP A03)
@@ -17,6 +16,8 @@ const { execFileSync: defaultExecFileSync, spawnSync: defaultSpawnSync } = requi
 const defaultFs = require('node:fs');
 const path = require('node:path');
 
+const { selectDocAssertingTests } = require('../doc-assertions');
+
 /** @type {Array<[string, string]>} Lockfile → package manager mapping (order matters) */
 const LOCKFILE_MAP = [
 	['bun.lockb', 'bun'],
@@ -26,20 +27,53 @@ const LOCKFILE_MAP = [
 ];
 
 const DEFAULT_TIMEOUT = 120000;
-const BEADS_CHECK_TIMEOUT = 3000;
 const DIRECT_TEST_CANDIDATES = Object.freeze({
 	'bin/forge.js': [
 		'test/cli-flags.test.js',
 		'test/forge-cli-registry.test.js',
-		'test/setup-github-sync.test.js',
 		'test/setup-runtime-flags.test.js',
 	],
+	// The second CLI surface (command descriptions + shepherd wiring). Without an
+	// entry here it resolves to zero tests and pushes fall back to the full suite.
+	'bin/forge-cmd.js': [
+		'test/cli/forge-cmd.test.js',
+		'test/forge-cmd-shepherd.test.js',
+	],
+	'bin/forge-preflight.js': ['test/bin/forge-preflight.test.js'],
+	// The CI entry point is covered by the doc-assertion regression suite; without
+	// this entry it resolves to zero tests and forces the full suite.
+	// (lib/doc-assertions.js resolves via the lib/ -> test/ convention below.)
+	'scripts/doc-asserting-tests.js': [
+		'test/doc-assertions.test.js',
+		'test/scripts/doc-asserting-tests.test.js',
+	],
 	'lib/lefthook-check.js': ['test/lefthook-check.test.js', 'test/runtime-health.test.js'],
 	'lib/runtime-health.js': ['test/runtime-health.test.js'],
+	// skill-eval hosts the accuracy-lint detectors (auditCommandDocumentation /
+	// auditRouterPrecision), so edits there must also run their detector suite.
+	'lib/skill-eval.js': ['test/skill-eval.test.js', 'test/skill-accuracy.test.js'],
 	'lib/upgrade-safety.js': ['test/commands/upgrade.test.js'],
 	'scripts/test.js': ['test/scripts/test-runner.test.js'],
 });
 
+// Skill sources (canonical `skills/**` and the committed `.agents/skills/**` mirror)
+// map to the fast skill suite. This is what keeps a skills-only PR on the targeted
+// lane instead of the full ~1500-test suite. `skills-sync-drift` guards the mirror.
+const SKILL_TEST_TARGETS = Object.freeze([
+	'test/skills-structure.test.js',
+	'test/skill-coverage.test.js',
+	'test/skill-eval.test.js',
+	'test/skill-accuracy.test.js',
+	'test/skill-dispatch-parity.test.js',
+	'test/using-forge.test.js',
+	'test/structural/skills-sync-drift.test.js',
+	'test/skills/chain-integrity.test.js',
+	'test/skills/skills-sync.test.js',
+	'test/skills/stage-skills.test.js',
+	'test/skills/using-forge-skill.test.js',
+	'test/skills/context-cost.test.js',
+]);
+
 /**
  * Detect the package manager by checking which lockfile exists.
  *
@@ -56,22 +90,6 @@ function detectPackageManager(projectRoot, fs) {
 	return 'npm';
 }
 
-/**
- * Check if Beads (bd CLI) is reachable.
- *
- * @param {Function} execFileSync - Injected execFileSync
- * @returns {boolean} true if bd is available
- */
-function checkBeadsConnectivity(execFileSync) {
-	try {
-		execFileSync('bd', ['list', '--limit=1'], { timeout: BEADS_CHECK_TIMEOUT });
-		return true;
-	} catch (_e) { // NOSONAR S2486
-		/* intentional: bd not installed or unreachable */
-		return false;
-	}
-}
-
 function resolveBaseBranch(execFileSync) {
 	let baseBranch = 'main';
 	try {
@@ -168,6 +186,16 @@ function getAffectedTestFiles(projectRoot, execFileSync, fs = defaultFs, options
 		}
 	}
 
+	// Markdown changes must also run the suites that assert on that markdown's
+	// CONTENT (README size badge, AGENTS.md convention, docs consistency). The
+	// static mapping above only knows the docs-consistency suite, so a docs PR
+	// used to merge green and break master for the next code PR (issue 63556816).
+	// The set is derived from the test sources, so new markdown-reading suites are
+	// picked up without editing a list here.
+	for (const candidate of selectDocAssertingTests(changedFiles, projectRoot, fs)) {
+		testFiles.add(candidate);
+	}
+
 	return Array.from(testFiles).sort((left, right) => left.localeCompare(right));
 }
 
@@ -183,6 +211,10 @@ function getTestCandidatesForChangedFile(file) {
 		return [file];
 	}
 
+	if (file.startsWith('skills/') || file.startsWith('.agents/skills/')) {
+		return [...SKILL_TEST_TARGETS];
+	}
+
 	if (file === 'README.md'
 		|| file === 'QUICKSTART.md'
 		|| file === 'CHANGELOG.md'
@@ -259,7 +291,7 @@ module.exports = {
 	 * @param {Object} [deps.fs] - fs module
 	 * @param {Function} [deps.execFileSync] - child_process.execFileSync
 	 * @param {Function} [deps.spawnSync] - child_process.spawnSync
-	 * @returns {Promise<{ success: boolean, exitCode: number, beadsSkipped: boolean }>}
+	 * @returns {Promise<{ success: boolean, exitCode: number }>}
 	 */
 	async handler(_args, flags, projectRoot, deps = {}) {
 		const fs = deps.fs || defaultFs;
@@ -281,19 +313,10 @@ module.exports = {
 			}
 		} catch (_e) { /* intentional: package.json missing or unreadable, use default timeout */ } // NOSONAR S2486
 
-		// 3. Check Beads connectivity
-		const beadsAvailable = checkBeadsConnectivity(execFileSync);
-		const beadsSkipped = !beadsAvailable;
-
-		const extraEnv = {};
-		if (beadsSkipped) {
-			extraEnv.BEADS_SKIP_TESTS = '1';
-		}
-
-		// 4. Build test command args
+		// 3. Build test command args
 		let testArgs = ['run', 'test'];
 
-		// 5. --affected flag: find changed test files
+		// 4. --affected flag: find changed test files
 		if (flags['--affected'] || flags.affected) {
 			const affectedTests = getAffectedTestFiles(projectRoot, execFileSync, fs, {
 				sinceUpstream: flags.sinceUpstream || flags['--since-upstream'],
@@ -304,9 +327,9 @@ module.exports = {
 			// If no affected tests found, fall back to running all tests
 		}
 
-		// 6. Run tests
+		// 5. Run tests
 		const result = spawnSync(pkgManager, testArgs, {
-			env: { ...process.env, ...extraEnv },
+			env: { ...process.env },
 			timeout,
 			stdio: 'inherit',
 			shell: process.platform === 'win32',
@@ -317,7 +340,6 @@ module.exports = {
 		return {
 			success: exitCode === 0,
 			exitCode,
-			beadsSkipped,
 		};
 	},
 };